| *** yamamoto has quit IRC | 00:10 | |
| *** yamamoto has joined #openstack-fwaas | 00:11 | |
| *** vishwanathj has quit IRC | 00:18 | |
| *** vishwanathj has joined #openstack-fwaas | 00:18 | |
| *** deep-book-gk_ has joined #openstack-fwaas | 00:36 | |
| *** deep-book-gk_ has left #openstack-fwaas | 00:37 | |
| *** hoangcx has joined #openstack-fwaas | 02:04 | |
| *** mestery_ has joined #openstack-fwaas | 02:19 | |
| *** mestery has quit IRC | 02:19 | |
| *** mestery_ is now known as mestery | 02:20 | |
| *** vishwanathj has quit IRC | 03:06 | |
| *** vishwanathj has joined #openstack-fwaas | 03:07 | |
| *** vishwanathj has quit IRC | 03:09 | |
| *** vishwanathj has joined #openstack-fwaas | 03:09 | |
| reedip | amotoki : looking at it | 04:14 |
|---|---|---|
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from neutron-lib https://review.openstack.org/478883 | 04:58 |
| *** vishwana_ has joined #openstack-fwaas | 05:08 | |
| *** vishwana_ has quit IRC | 05:09 | |
| *** vishwanathj has quit IRC | 05:09 | |
| *** vishwanathj has joined #openstack-fwaas | 05:10 | |
| *** yushiro has joined #openstack-fwaas | 05:19 | |
| amotoki | yushiro: could you check https://review.openstack.org/#/c/487157/ ? this is neutron-fwaas-dashboard doc cleanup. | 05:28 |
| amotoki | yushiro: I would like to merge this before releasing the initial version of the dashboard. | 05:29 |
| yushiro | amotoki, sure | 05:29 |
| amotoki | yushiro: thianks | 05:29 |
| yushiro | amotoki, also, thanks for your update for cliff minor bug. | 05:29 |
| amotoki | yushiro: np | 05:30 |
| yushiro | amotoki, I'm checking here http://docs-draft.openstack.org/57/487157/1/check/gate-neutron-fwaas-dashboard-releasenotes/a1b76a9//releasenotes/build/html/unreleased.html | 05:32 |
| yushiro | amotoki, Just a question. What is difference ``foo`` and "foo" ? | 05:33 |
| yushiro | I always confuse in writing reno about that. You wrote "Add Router" / "Remove Router" in Bug Fixes section. Is ``foo`` one of parameter/attribute ? | 05:35 |
| amotoki | yushiro: the difference is how they are rendered | 05:36 |
| amotoki | yushiro: for example, http://docs-draft.openstack.org/57/487157/1/check/gate-neutron-fwaas-dashboard-releasenotes/a1b76a9//releasenotes/build/html/unreleased.html | 05:36 |
| yushiro | amotoki, Yes, I'm watching same place :) | 05:36 |
| amotoki | yushiro: I use ``foo`` for literal strings. in this case, "update_router" is a rule name in policy.json | 05:37 |
| amotoki | so I use ``xxx`` for "update_router" | 05:37 |
| amotoki | "Add Router" is just a quoted string from the dashboard, so I use "xxx" for this. | 05:37 |
| yushiro | amotoki, OK, I understood. | 05:37 |
| yushiro | Thank you | 05:37 |
| yushiro | LGTM. Done. | 05:39 |
| yushiro | amotoki, If you don't have any problem about your patch, can I put +A or assign other cores? | 05:43 |
| amotoki | yushiro: I am fine with a single approve. | 05:50 |
| yushiro | amotoki, OK, will do it | 05:50 |
| amotoki | yushiro: actually horizon use a single +2/A model unless an author belongs to a same company. | 05:51 |
| yushiro | amotoki, aha, I see. Thanks for your guide. | 05:51 |
| amotoki | it is under neutron project, so i usually wait two +2, but I think it is okay dependin on a case or content. | 05:52 |
| amotoki | + depending on review attention :) | 05:52 |
| yushiro | +1 | 05:52 |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Document cleanup and release notes for a new release https://review.openstack.org/487157 | 05:59 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from neutron-lib https://review.openstack.org/478883 | 06:10 |
| reedip | yushiro : you are fast now .. I was making this change :( | 06:12 |
| yushiro | reedip, ah, sorry ~~~ | 06:12 |
| yushiro | reedip, please review it again :) | 06:13 |
| yushiro | after jenkins +1 | 06:13 |
| reedip | yushiro : sure :) | 06:14 |
| *** yamamoto has quit IRC | 06:54 | |
| *** yamamoto has joined #openstack-fwaas | 07:55 | |
| *** vishwanathj has quit IRC | 07:58 | |
| *** vishwanathj has joined #openstack-fwaas | 07:58 | |
| *** yamamoto has quit IRC | 08:02 | |
| *** yushiro has quit IRC | 08:42 | |
| *** vishwanathj has quit IRC | 09:01 | |
| *** vishwanathj has joined #openstack-fwaas | 09:01 | |
| *** yamamoto has joined #openstack-fwaas | 09:24 | |
| *** yamamoto has quit IRC | 09:35 | |
| *** vishwanathj has quit IRC | 09:43 | |
| *** vishwanathj has joined #openstack-fwaas | 09:43 | |
| *** yamamoto has joined #openstack-fwaas | 09:45 | |
| *** vishwanathj has quit IRC | 11:45 | |
| *** vishwanathj has joined #openstack-fwaas | 11:45 | |
| *** yamamoto has quit IRC | 11:57 | |
| *** yamamoto has joined #openstack-fwaas | 12:13 | |
| *** yamamoto has quit IRC | 12:54 | |
| *** yamamoto has joined #openstack-fwaas | 13:09 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 13:55 | |
| *** yushiro has joined #openstack-fwaas | 13:55 | |
| *** SarathMekala has joined #openstack-fwaas | 13:58 | |
| yushiro | hi | 14:00 |
| *** chandanc has joined #openstack-fwaas | 14:00 | |
| yushiro | hi chandanc and SarathMekala | 14:01 |
| chandanc | I am still bringing p my devstack | 14:01 |
| chandanc | Hello yushiro | 14:01 |
| yushiro | chandanc, me too. Here is my progress now.(not so fast ...) https://etherpad.openstack.org/p/fwaas-v2-l2-agent | 14:02 |
| yushiro | You can see 'Error trace' section for pastestack. | 14:02 |
| SarathMekala | hi yushiro | 14:03 |
| yushiro | I just editted to get local vlan tag from port dict. As a result, a minor error occurred. | 14:03 |
| yushiro | Hi SarathMekala | 14:03 |
| chandanc | so you are getting the Traceback ? | 14:04 |
| yushiro | Yes, could you see https://etherpad.openstack.org/p/fwaas-v2-l2-agent in 'Error trace' section? | 14:04 |
| chandanc | ok looks like some constant definition is missing | 14:05 |
| yushiro | chandanc, minor error was ICMPV&_ALLOWED_TYPES | 14:05 |
| yushiro | yes, I didn't know this value has been removed from neutron-lib. | 14:05 |
| yushiro | It's minor bug. | 14:07 |
| chandanc | ok ok | 14:07 |
| yushiro | we can refer constants from neutron.agent.linux.openvswitch_firewall | 14:07 |
| yushiro | chandanc, I'd like to discuss about race condition for handle_port() with you | 14:08 |
| chandanc | Sure | 14:08 |
| chandanc | let me open the patch | 14:09 |
| yushiro | OK | 14:09 |
| chandanc | Yes | 14:11 |
| chandanc | in def _apply_fwg_rules(self, context, fwg, fwg_ports, host, event=UPDATE): | 14:13 |
| chandanc | fwg_ports are list of port_id or port dict ? | 14:14 |
| chandanc | https://review.openstack.org/#/c/323971/37/neutron_fwaas/services/firewall/agents/l2/fwaas_v2.py | 14:14 |
| chandanc | L164 | 14:14 |
| chandanc | @ yushiro | 14:15 |
| yushiro | now, this is a list of port_dict | 14:15 |
| chandanc | oh ok ok | 14:15 |
| yushiro | please refer https://etherpad.openstack.org/p/fwaas-v2-l2-agent | 14:15 |
| yushiro | in handle_port() section or some method name | 14:16 |
| chandanc | sure , in that case i agree with your suggestion to update the port dict with lvlan key | 14:16 |
| yushiro | ovs driver handles port['device'] like that. Therefore, I think it should be kept a list of port_dict. | 14:16 |
| yushiro | OK, | 14:17 |
| chandanc | this means the previous patch should do the job | 14:17 |
| chandanc | I will test it. | 14:17 |
| chandanc | Could you please chare the diff to fix the lates Traceback | 14:17 |
| chandanc | share* | 14:18 |
| yushiro | OK, currently, I editted fwaas_v2.py and openvswitch_firewall/firewall.py. | 14:18 |
| chandanc | can you paste the diff | 14:19 |
| chandanc | i will apply locally to my devstack | 14:19 |
| *** SarathMekala has quit IRC | 14:23 | |
| *** yamamoto has quit IRC | 14:24 | |
| yushiro | sorry chandanc , here : http://paste.openstack.org/show/616588/ | 14:25 |
| chandanc | Thanks yushiro | 14:26 |
| yushiro | Maybe handle_port() has passed but failed in update_firewall_group(). Because in this case, there is no 'network_id' in port dict. | 14:26 |
| *** SridarK has joined #openstack-fwaas | 14:27 | |
| chandanc | oh | 14:27 |
| SridarK | yushiro: hi | 14:27 |
| yushiro | SridarK, Hi :) | 14:28 |
| SridarK | sorry got late | 14:28 |
| yushiro | No problem, SridarK I and chandanc just sync with latest patch file. | 14:28 |
| SridarK | ok | 14:28 |
| yushiro | Latest patch is here : http://paste.openstack.org/show/616588/ | 14:28 |
| SridarK | ok | 14:29 |
| yushiro | Now, I added local vlan manager in l2-agent side and stored in port dict as 'lvlan' key. | 14:30 |
| yushiro | In addition, in driver layer, I also editted to get local vlan id from port dict not from ovsdb. | 14:31 |
| yushiro | It seems handle_port() passed but failed in update_firewall_group(). This is current status. | 14:32 |
| SridarK | i am bringing up my env - will pull this change in | 14:33 |
| yushiro | chandanc, I'd like to ask you to check OVS flow rule is configured or not when you execute 'openstack server create' | 14:33 |
| chandanc | ok sure | 14:34 |
| SridarK | chandanc: i will be around - if there is something specific u would like me to look at | 14:35 |
| chandanc | Sure SridarK | 14:35 |
| chandanc | yushiro: can you please help me understand , why ‘network_id’ is not part of the port dict ? | 14:37 |
| yushiro | because, port dict in update_firewall_group() is not generated from core_plugin.get_port() but from update_firewall_group in services/firewall/fwaas_plugin_v2.py | 14:39 |
| yushiro | Please refer https://etherpad.openstack.org/p/fwaas-v2-l2-agent LINE#153 | 14:39 |
| yushiro | Therefore, in order to refer 'network_id' at any case(handle_port, delete_port, create/update/delete_firewall_group) in l2-agent side, we have to do following ways: | 14:42 |
| yushiro | 1. Call _core_plugin.get_port() at each case except delete_port() | 14:43 |
| yushiro | 2. Store 'lvlan' infor into PortFirewallGroupMap dict | 14:43 |
| chandanc | ok got it | 14:50 |
| *** vishwanathj has quit IRC | 14:51 | |
| *** vishwanathj has joined #openstack-fwaas | 14:52 | |
| yushiro | hmm, otherwise, we can insert 'network_id' in fwaas_plugin_v2 layer. | 15:00 |
| yushiro | I'll try it. | 15:00 |
| yushiro | I mean that I'll customize _get_fwg_port_details() to add 'network_id'. | 15:03 |
| chandanc | yushiro: +1 | 15:10 |
| chandanc | i think that is the right way | 15:10 |
| yushiro | OK. but it is a little confuse :) | 15:12 |
| amotoki | FYI: neutron-fwaas-dashboard 0.1.0 has been relased https://releases.openstack.org/pike/index.html#horizon-plugins | 15:15 |
| yushiro | wow !! | 15:19 |
| yushiro | amotoki, Sarath thanks for your great work :) | 15:20 |
| amotoki | it was shipped with FWaaS v1 support only (with several bug fixes) | 15:20 |
| yushiro | OK | 15:21 |
| amotoki | the next release will include v2 support. the release model is cycle-with-intermediary, so I think we can release a next version soon after Pike is released. | 15:22 |
| yushiro | amotoki, yes, sure. | 15:22 |
| yushiro | Ah, amotoki I updated https://review.openstack.org/#/c/453204/ | 15:23 |
| yushiro | amotoki, I just fixed releasenote section. | 15:23 |
| yushiro | Could you please review it again? | 15:24 |
| *** yamamoto has joined #openstack-fwaas | 15:24 | |
| amotoki | yushiro: thanks. Looking at the relnote, I wonder regular level users asscoiate 'attribute' with 'option' name.. options like --public/--private looks easier to understand to me. | 15:26 |
| amotoki | this is really a release note developer tend to write. | 15:27 |
| yushiro | amotoki, indeed. will update. | 15:27 |
| yushiro | Thank you | 15:27 |
| yushiro | for your quick review :) | 15:27 |
| amotoki | i can tweak it a bit if necessary | 15:27 |
| amotoki | np | 15:27 |
| *** yamamoto has quit IRC | 15:36 | |
| yushiro | chandanc, SridarK I updated patch file http://paste.openstack.org/show/616596/ | 15:39 |
| yushiro | It seems be passed VM creation and update_firewall_group() | 15:39 |
| chandanc | Thanks yushiro | 15:39 |
| chandanc | cool :) | 15:40 |
| yushiro | not tested delete VM/firewall_group | 15:40 |
| yushiro | It seems no race condition but need to check of rule layer | 15:40 |
| yushiro | Please kindly check it :) | 15:41 |
| chandanc | Will do | 15:41 |
| chandanc | So we need a 1 line change in the plugin side too | 15:41 |
| chandanc | yushiro: will you pull the plugin side change into your patch. I will update my driver patch with the cahnges needed fron the pastebin you shared | 15:44 |
| yushiro | You mean update l2-agent patch set? | 15:45 |
| yushiro | in plugin side? | 15:45 |
| yushiro | OK, but please wait to fix minor bug ... | 15:51 |
| yushiro | chandanc, "/opt/stack/neutron-fwaas/neutron_fwaas/services/firewall/drivers/linux/l2/openvswitch_firewall/firewall.py", line 355, in initialize_port_flows | 16:02 |
| yushiro | I got an error from 'ovsfw_consts.FW_BASE_EGRESS_TABLE)' -> 'ValueError: Unknown format code 'd' for object of type 'str'' | 16:03 |
| yushiro | chandanc, have you already updated in your latest driver patch? | 16:04 |
| chandanc | not yet | 16:04 |
| chandanc | i will do once my destack is up, it is still not | 16:04 |
| yushiro | I believe ovsfw_consts.FW_BASE_EGRESS_TABLE = 41 and it is definitely 'integer'... | 16:05 |
| yushiro | OK | 16:05 |
| *** Tim_Eberhard has quit IRC | 16:09 | |
| yushiro | chandanc, sorry this is my bug. I forgot to cast integer value for lvlan in l2-agent side. | 16:10 |
| yushiro | port['lvlan'] = int(self.vlan_manager.get(network_id).vlan) | 16:11 |
| chandanc | sure, no probs. You have already solved all the bugs :) | 16:11 |
| yushiro | chandanc, hmm, sorry I found that in VM creation, handle_port() just called. | 16:17 |
| chandanc | ok | 16:17 |
| yushiro | In this timing, local_vlan cannot found. | 16:17 |
| yushiro | In fact, handle_port() is called twice from neutron-side. | 16:18 |
| chandanc | ya, create and update | 16:18 |
| chandanc | update is called after the port is bound i think | 16:18 |
| *** Tim_Eberhard has joined #openstack-fwaas | 16:18 | |
| yushiro | In 2nd time, local vlan can be found (in case of my env is lvlan = 1) | 16:18 |
| yushiro | ya | 16:18 |
| chandanc | hmm, so we have to differentiate this case and ignore the handle port in case of create port | 16:19 |
| chandanc | question is how do we do that | 16:19 |
| yushiro | Hmm, in my understanding, if we try to find local vlan and cannot find, then skip(do nothing) calling ovs driver. | 16:20 |
| yushiro | This is what we can do... | 16:20 |
| yushiro | Anyway, I'll try to implement and check it. | 16:20 |
| chandanc | ya skip should do it | 16:21 |
| chandanc | in any case if we dont get the lvlan we cant do much | 16:21 |
| yushiro | chandanc, indeed. We cannot setup/clear ovs flow | 16:21 |
| chandanc | yes | 16:22 |
| chandanc | yushiro: i have to go away for dinner | 16:22 |
| yushiro | chandanc, OK, enjoy your dinner time :) | 16:23 |
| chandanc | i will catch you tomorrow. I will be ready with the devstack and tests | 16:23 |
| chandanc | thanks for all your help :) | 16:23 |
| *** chandanc has quit IRC | 16:23 | |
| yushiro | np :) | 16:23 |
| *** Tim_Eberhard has quit IRC | 16:24 | |
| yushiro | ah, regarding race condition, I have an idea. | 17:16 |
| yushiro | In l2 layer, we can judge whether local vlan mapping exists or not. | 17:17 |
| yushiro | If not exist, then skipped otherwise calls driver. | 17:18 |
| yushiro | So, no need to edit chandan's patch. It's enough to refer vlan tag from ovsdb. | 17:18 |
| *** reedip_ has joined #openstack-fwaas | 17:36 | |
| reedip_ | xgerman_ ping | 17:53 |
| *** reedip_ has quit IRC | 17:53 | |
| *** reedip_ has joined #openstack-fwaas | 17:53 | |
| reedip_ | xgerman_ : review requested on https://review.openstack.org/#/c/478883/ | 17:54 |
| *** yamamoto has joined #openstack-fwaas | 18:09 | |
| *** yamamoto has quit IRC | 18:13 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 18:20 | |
| *** Tim_Eberhard has quit IRC | 18:20 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 18:21 | |
| *** yushiro has quit IRC | 18:23 | |
| *** reedip_ has quit IRC | 18:23 | |
| *** Tim_Eberhard has quit IRC | 18:25 | |
| *** SridarK has quit IRC | 18:33 | |
| *** vishwanathj has quit IRC | 19:14 | |
| *** vishwanathj has joined #openstack-fwaas | 19:14 | |
| *** yamamoto_ has joined #openstack-fwaas | 21:19 | |
| *** yamamoto_ has quit IRC | 21:21 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 21:21 | |
| *** vishwana_ has joined #openstack-fwaas | 21:49 | |
| *** vishwanathj has quit IRC | 21:52 | |
| *** yamamoto has joined #openstack-fwaas | 23:10 | |
| *** Tim_Eberhard has quit IRC | 23:22 | |
| *** yamamoto has quit IRC | 23:37 | |
| *** yamamoto has joined #openstack-fwaas | 23:51 | |
| *** yamamoto_ has joined #openstack-fwaas | 23:55 | |
| *** yamamoto has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!