| *** Tim_Eberhard has quit IRC | 00:09 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 00:09 | |
| *** Tim_Eberhard has quit IRC | 00:15 | |
| *** yamamoto_ has joined #openstack-fwaas | 00:38 | |
| *** yamamoto_ has quit IRC | 00:44 | |
| *** hoangcx has joined #openstack-fwaas | 00:51 | |
| *** cuongnv has joined #openstack-fwaas | 00:59 | |
| *** cuongnv_ has joined #openstack-fwaas | 01:14 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 01:15 | |
| *** Tim_Eberhard has quit IRC | 01:19 | |
| *** cuongnv has quit IRC | 01:21 | |
| *** yamamoto_ has joined #openstack-fwaas | 01:40 | |
| *** cuongnv_ is now known as cuongnv | 01:42 | |
| *** yamamoto_ has quit IRC | 01:45 | |
| *** yamamoto_ has joined #openstack-fwaas | 02:16 | |
| *** mickeys has joined #openstack-fwaas | 02:47 | |
| *** mickeys has quit IRC | 02:52 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 03:17 | |
| *** Tim_Eberhard has quit IRC | 03:21 | |
| *** vks1 has joined #openstack-fwaas | 03:23 | |
| *** yushiro has quit IRC | 03:59 | |
| *** yushiro has joined #openstack-fwaas | 04:25 | |
| yushiro | reedip, hi | 04:26 |
|---|---|---|
| yushiro | reedip, Do you know that "exceptions" will be migrated in neutron-lib? https://github.com/openstack/neutron-lib/tree/master/neutron_lib/exceptions | 04:27 |
| reedip | yushiro : checking | 04:28 |
| reedip | yushiro : this one ? | 04:29 |
| reedip | https://review.openstack.org/#/c/423289/ | 04:29 |
| yushiro | reedip, Yes. I'm not sure other exceptions will be migrated here. | 04:30 |
| reedip | yushiro : they are not yet migrated | 04:30 |
| yushiro | reedip, I see that current status is under migrating. | 04:31 |
| *** yamamoto_ has quit IRC | 04:44 | |
| reedip | yushiro :yep | 04:47 |
| yushiro | reedip, OK, thanks. | 04:48 |
| *** mickeys has joined #openstack-fwaas | 04:49 | |
| *** mickeys has quit IRC | 04:53 | |
| *** yamamoto has joined #openstack-fwaas | 05:31 | |
| *** mickeys has joined #openstack-fwaas | 05:49 | |
| *** mickeys has quit IRC | 05:54 | |
| *** mickeys has joined #openstack-fwaas | 05:57 | |
| *** mickeys has quit IRC | 07:07 | |
| *** mickeys has joined #openstack-fwaas | 07:14 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 07:18 | |
| *** Tim_Eberhard has quit IRC | 07:23 | |
| *** mickeys has quit IRC | 08:12 | |
| *** vks1 has quit IRC | 08:23 | |
| *** mickeys has joined #openstack-fwaas | 09:13 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 09:19 | |
| *** mickeys has quit IRC | 09:19 | |
| *** Tim_Eberhard has quit IRC | 09:23 | |
| yushiro | ZZelle, Thanks for your review!! | 09:46 |
| yushiro | ZZelle, really helpful. | 09:47 |
| *** vks1 has joined #openstack-fwaas | 09:59 | |
| *** mickeys has joined #openstack-fwaas | 10:16 | |
| *** mickeys has quit IRC | 10:20 | |
| reedip | @all : the neutron-lib change broke gate changes . A change to revert the same has been submitted : https://review.openstack.org/#/c/471699/2 | 10:24 |
| hoangcx | reedip: you mean this change affected other projects? https://review.openstack.org/#/c/471699/2/neutron_fwaas/common/fwaas_constants.py | 10:27 |
| reedip | hoangcx ; it broke midonet gate tests | 10:27 |
| hoangcx | reedip: sorry, wrong link. Correct link https://review.openstack.org/#/c/456511/22/neutron_fwaas/common/fwaas_constants.py | 10:27 |
| hoangcx | reedip: I see. | 10:28 |
| reedip | hoangcx : seems to be the correct location which you pointed | 10:28 |
| hoangcx | reedip: I was double about that change. | 10:29 |
| reedip | hoangcx : ?? | 10:30 |
| hoangcx | s/double/doubt | 10:30 |
| reedip | hoangcx : yeah, got it :) | 10:30 |
| hoangcx | reedip: So, You know how to fix it. Right? | 10:31 |
| reedip | hoangcx : not yet ... checking out the issue | 10:31 |
| hoangcx | reedip: +1. | 10:32 |
| ZZelle | yushiro, no pb | 10:37 |
| *** hoangcx has quit IRC | 10:40 | |
| reedip | hoangcx : you there ? | 10:42 |
| *** hoangcx has joined #openstack-fwaas | 10:43 | |
| yushiro | ZZelle, But an argument fwg_id, this is newly associated one... https://review.openstack.org/#/c/323971/34/neutron_fwaas/db/firewall/v2/firewall_db_v2.py@1057 | 10:44 |
| *** hoangcx has quit IRC | 10:44 | |
| yushiro | ZZelle, I'd like to delete previous association b/w port_id and fwg_id.. | 10:45 |
| ZZelle | yushiro, i don't understand | 10:45 |
| ZZelle | yushiro, current filter delete a fwg port assoc with a specific port_id and fwg_id | 10:46 |
| yushiro | ZZelle, Yes, you're right. | 10:48 |
| ZZelle | in practice changed_fwg_ids == [fwg_id] or == [] | 10:48 |
| ZZelle | yushiro, the current implementation doesn't respect the property fro the docstring: "Deletes all old relations between port_id and NOT fwg_id" | 10:50 |
| yushiro | ZZelle, I thought that it is deleted an old association in Line#1055-1057 | 10:55 |
| yushiro | ZZelle, Because in this timing, FirewallGroupPortAssociation has duplicate relations. fwg1 <--> portA(old) and fwg2 <---> portA(new) | 10:56 |
| yushiro | ZZelle, And, an argument 'fwg_id' is for 'fwg2'. | 10:56 |
| ZZelle | yushiro, oups i didn't see the ~ before the condition | 10:56 |
| yushiro | ZZelle, OK. But as you said, it is lack of readability.... | 10:57 |
| ZZelle | yushiro, it seems better to implement it differently to avoid doing too many db queries | 10:58 |
| yushiro | ZZelle, Yes, I think so. I'd like to decrease DB access ASAP. | 10:58 |
| yushiro | s/ASAP/as much as possible | 10:58 |
| ZZelle | yushiro, it seems better to: | 10:59 |
| yushiro | Hmm, How about deleting all of port_ids relation and re-associate newly them... | 11:00 |
| ZZelle | 1) query fwgs which id is not fwg_id and are associated to one of the port_ids => 1 db query | 11:00 |
| ZZelle | 2) delete obsolete associations => 1 db query | 11:00 |
| ZZelle | 3) get fwg rules: 2 * number_of_fwgs db queries | 11:01 |
| ZZelle | it avoids a useless db query | 11:02 |
| yushiro | ZZelle, Yes. 1) is difficult for me now... Just a moment... | 11:02 |
| yushiro | ZZelle, can I specify 'port_ids' for query? | 11:03 |
| yushiro | ZZelle, regarding 1) | 11:03 |
| yushiro | ZZelle, I mean FirewallGroupPortAssociation).filter(FirewallGroupPortAssociation.port_id.in_([port_ids])).all() | 11:04 |
| yushiro | oops, all() is not necessary | 11:05 |
| ZZelle | yushiro, in_(port_ids) | 11:06 |
| yushiro | ZZelle, Thanks! So, in order to run 3), I have to store firewall_group_id before 2), don't you? | 11:06 |
| ZZelle | yushiro, not firewall_group_ids BUT firewall_groups to avoid an extra db query | 11:07 |
| yushiro | ZZelle, you mean get a list of firewall_group object, right? | 11:08 |
| ZZelle | yes | 11:09 |
| yushiro | hmm, but FirewallGroupPortAssociation just stores firewall_group_id and port_id. Should we call get_firewall_group() ? | 11:10 |
| yushiro | ZZelle, sorry. I'm missing something. | 11:10 |
| *** yamamoto has quit IRC | 11:10 | |
| ZZelle | 1) query fwgs which id is not fwg_id and are associated to one of the port_ids => 1 db query | 11:12 |
| ZZelle | it queries FWG table joined with fwg port assoc table so you get fwgs instead of fwg_ids | 11:13 |
| ZZelle | yushiro, ^^ | 11:14 |
| *** mickeys has joined #openstack-fwaas | 11:17 | |
| yushiro | ZZelle, reading | 11:17 |
| *** mickeys has quit IRC | 11:21 | |
| yushiro | ZZelle, Could you see https://etherpad.openstack.org/p/fwaas-v2-l2-agent ? | 11:27 |
| yushiro | ZZelle, I'd like to check coding here.. | 11:27 |
| ZZelle | ok | 11:28 |
| yushiro | ZZelle, Thank you. I can image regarding 1). | 11:44 |
| yushiro | ZZelle, It'll be helpful to add gerrit comment which we discussed :) | 11:45 |
| *** cuongnv has quit IRC | 11:46 | |
| *** mickeys has joined #openstack-fwaas | 12:18 | |
| *** mickeys has quit IRC | 12:22 | |
| *** yamamoto has joined #openstack-fwaas | 12:36 | |
| *** yamamoto has quit IRC | 12:47 | |
| yushiro | sleepy!!! | 13:03 |
| yushiro | bye ;) | 13:03 |
| *** yushiro has quit IRC | 13:04 | |
| *** yamamoto has joined #openstack-fwaas | 13:08 | |
| *** mickeys has joined #openstack-fwaas | 13:18 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 13:21 | |
| *** mickeys has quit IRC | 13:22 | |
| *** Tim_Eberhard has quit IRC | 13:25 | |
| *** yamamoto has quit IRC | 14:03 | |
| *** yamamoto has joined #openstack-fwaas | 14:03 | |
| *** yamamoto has quit IRC | 14:08 | |
| *** mickeys has joined #openstack-fwaas | 14:19 | |
| *** mickeys has quit IRC | 14:23 | |
| *** mickeys has joined #openstack-fwaas | 15:20 | |
| *** mickeys has quit IRC | 15:24 | |
| *** reedip_ has joined #openstack-fwaas | 15:39 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:51 | |
| *** Tim_Eber_ has joined #openstack-fwaas | 15:51 | |
| *** Tim_Eberhard has quit IRC | 15:51 | |
| reedip_ | xgerman_ : yamamoto logged a bug today for the migration of neutron-lib | 16:05 |
| reedip_ | xgerman_ : Hopefully this patch fixes the issue and avoids the revert. | 16:06 |
| xgerman_ | k | 16:06 |
| reedip_ | xgerman_ : need some hints as to how to test it out though : https://review.openstack.org/#/c/471720/edit | 16:06 |
| reedip_ | xgerman_ : means this should work, but how can i test the midonet issues with this? | 16:07 |
| xgerman_ | mmh, without having a midonet? | 16:07 |
| reedip_ | xgerman_ : make a virtual env , deploy devstack with this patch and midonet and run its test cases ??? | 16:07 |
| reedip_ | yamamoto isnt here, or I would have asked him | 16:07 |
| xgerman_ | I usually let vendors fend for themselves… but yeah, that might work | 16:08 |
| xgerman_ | or they could provide us with a 3rd party CI | 16:08 |
| reedip_ | I have dropped yamamoto a message on https://review.openstack.org/#/c/471699/2 | 16:10 |
| reedip_ | xgerman_ : In case it gets pretty serious , I suggest to get Yamamoto's patch merged for now and then we can move forward once again | 16:10 |
| *** mickeys has joined #openstack-fwaas | 16:21 | |
| *** mickeys has quit IRC | 16:25 | |
| xgerman_ | ok | 16:25 |
| *** reedip_ has quit IRC | 16:30 | |
| *** vks1 has quit IRC | 16:36 | |
| *** yamamoto has joined #openstack-fwaas | 17:06 | |
| *** yamamoto has quit IRC | 17:11 | |
| *** mickeys_ has joined #openstack-fwaas | 18:26 | |
| *** yamamoto has joined #openstack-fwaas | 19:08 | |
| *** yamamoto has quit IRC | 19:12 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear some excessive connection counts while we debug the intermittent request failures reported over the past few minutes | 20:05 | |
| *** Aju has joined #openstack-fwaas | 21:29 | |
| *** afranc has quit IRC | 21:29 | |
| *** mickeys_ has quit IRC | 22:02 | |
| *** Tim_Eber_ has quit IRC | 22:57 | |
| *** mickeys_ has joined #openstack-fwaas | 23:03 | |
| *** mickeys_ has quit IRC | 23:07 | |
| *** yamamoto_ has joined #openstack-fwaas | 23:11 | |
| *** openstack has joined #openstack-fwaas | 23:13 | |
| *** yamamoto_ has quit IRC | 23:16 | |
| *** yushiro has joined #openstack-fwaas | 23:16 | |
| yushiro | reedip, morning. | 23:26 |
| yushiro | reedip, In your patch(https://review.openstack.org/#/c/471720), I just triggered with networking-midonet by using empty patch(https://review.openstack.org/#/c/443416/) | 23:27 |
| yushiro | reedip, You can check side-effect of your patch. | 23:27 |
| *** yamamoto_ has joined #openstack-fwaas | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!