| *** mickeys has joined #openstack-fwaas | 00:04 | |
| *** mickeys has quit IRC | 00:08 | |
| *** hoangcx has joined #openstack-fwaas | 00:26 | |
| *** cuongnv has joined #openstack-fwaas | 00:47 | |
| *** mickeys has joined #openstack-fwaas | 01:05 | |
| *** mickeys has quit IRC | 01:11 | |
| *** mickeys has joined #openstack-fwaas | 02:07 | |
| *** mickeys has quit IRC | 02:11 | |
| *** yamamoto_ has quit IRC | 02:14 | |
| *** yamamoto_ has joined #openstack-fwaas | 02:17 | |
| *** yamamoto_ has quit IRC | 03:04 | |
| *** mickeys has joined #openstack-fwaas | 03:07 | |
| *** mickeys has quit IRC | 03:12 | |
| reedip | yushiro : hello | 03:26 |
|---|---|---|
| reedip | yushiro : there are certain things which need to be changed in midonet as well for this migration , like firewall_extension does not have the exceptions any more, they have been moved out. | 03:26 |
| *** vks1 has joined #openstack-fwaas | 03:42 | |
| *** mickeys has joined #openstack-fwaas | 04:08 | |
| *** mickeys has quit IRC | 04:13 | |
| hoangcx | reedip: responded on https://review.openstack.org/#/c/471720/ | 04:23 |
| reedip | hi hoangcx : You can check the changes in https://review.openstack.org/#q,I6faf26d263788d21da078e570487ee4876d04efd,n,z | 04:24 |
| reedip | For example, please see neutron_fwaas/extensions/firewall.py | 04:24 |
| reedip | In https://review.openstack.org/#/c/456511/22/neutron_fwaas/extensions/firewall.py@80 , you can see that fwaas_constants.FIREWALL was changed to fwaas_constants.ALIAS | 04:26 |
| reedip | sorry firewall.ALIAS | 04:26 |
| reedip | Now https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/firewall.py#L18 states that ALIAS is fwaas | 04:26 |
| reedip | but before the patch merged, fwaas_constants.FIREWALL was 'FIREWALL' : https://review.openstack.org/#/c/456511/22/neutron_fwaas/common/fwaas_constants.py | 04:27 |
| reedip | so therefore I changed it | 04:27 |
| hoangcx | reedip: Right. | 04:31 |
| hoangcx | reedip: how is about other points I mentioned? | 04:31 |
| reedip | hoangcx : I changed https://review.openstack.org/#/c/471720/3/neutron_fwaas/services/firewall/agents/l3reference/firewall_l3_agent.py already | 04:32 |
| reedip | ohh sorry .. wait | 04:33 |
| reedip | hoangcx : I think [1] https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/services/firewall/fwaas_plugin_v2.py#L164 is correct. There has not been any change here BEFORE or AFTER the neutron-lib migration | 04:34 |
| reedip | so I should not change it | 04:34 |
| reedip | I will change [2], I think I missed it ( I doubt though, let me check ) | 04:34 |
| hoangcx | reedip: Right, +1 sorry for confusing | 04:35 |
| hoangcx | reedip: [1] is not correct as it referenced from Neutron but [2] need to changed I think | 04:35 |
| reedip | yes you are right. I missedd it | 04:36 |
| reedip | Let me grep once more ... | 04:36 |
| hoangcx | reedip: OK | 04:36 |
| yushiro | reedip, OK. | 04:42 |
| *** yamamoto has joined #openstack-fwaas | 04:48 | |
| reedip | updated and sent | 04:48 |
| reedip | thankls | 04:48 |
| hoangcx | reedip: | 04:49 |
| hoangcx | reedip: you are wrong in version of updated file? | 04:49 |
| reedip | hoangcx ? Didnt get you | 04:49 |
| hoangcx | reedip: https://review.openstack.org/#/c/471720/4/neutron_fwaas/services/firewall/agents/l3reference/firewall_l3_agent_v2.py | 04:50 |
| hoangcx | reedip: SERVICE_NAME_V1 ??? | 04:50 |
| hoangcx | reedip: I think it should be SERVICE_NAME_V2 | 04:50 |
| hoangcx | reedip: or Am I missing something? | 04:51 |
| reedip | hoangcx : maybe you are right. But I am wondering how it was working before the neutron-lib migration | 04:51 |
| reedip | before neutron-lib migration, directory plugin always took ( and still takes ) FIREWALL as a Plugin constant | 04:51 |
| reedip | and the extension expands it to V1 or V2 | 04:51 |
| reedip | hoangcx : while the extension differs in fwaas/fwaas_v2/FIREWALL/FIREWALL_V2, the plugin is always FIREWALL | 04:53 |
| reedip | yushiro : let me know if I am wrong anywhere ? | 04:53 |
| reedip | this is what I understood from the code | 04:53 |
| yushiro | reedip, I think you're correct. extension file doesn't include any exception and constants. | 04:54 |
| *** reedip is now known as reedip_afk | 04:54 | |
| yushiro | wow, timely! | 04:55 |
| reedip_afk | will be back | 04:55 |
| reedip_afk | :) | 04:55 |
| yushiro | :) | 04:55 |
| hoangcx | reedip_afk: https://review.openstack.org/#/c/472057/ need to add depend on the change above to see gate check. Though? | 04:56 |
| *** mickeys has joined #openstack-fwaas | 05:04 | |
| *** reedip_afk is now known as reedip | 05:39 | |
| reedip | hoangcx : yes it should | 05:40 |
| *** hoangcx_ has joined #openstack-fwaas | 06:52 | |
| *** hoangcx has quit IRC | 06:55 | |
| *** mickeys has quit IRC | 07:35 | |
| *** mickeys has joined #openstack-fwaas | 07:38 | |
| *** hoangcx has joined #openstack-fwaas | 07:55 | |
| *** hoangcx_ has quit IRC | 07:57 | |
| *** hoangcx_ has joined #openstack-fwaas | 08:18 | |
| *** hoangcx_ has quit IRC | 08:22 | |
| *** mickeys has quit IRC | 08:25 | |
| *** yamamoto has quit IRC | 08:58 | |
| *** mickeys has joined #openstack-fwaas | 09:26 | |
| *** mickeys has quit IRC | 09:31 | |
| *** yushiro has quit IRC | 09:32 | |
| *** hoangcx_ has joined #openstack-fwaas | 10:22 | |
| *** hoangcx has quit IRC | 10:23 | |
| *** mickeys has joined #openstack-fwaas | 10:27 | |
| *** mickeys has quit IRC | 10:31 | |
| *** mickeys has joined #openstack-fwaas | 11:28 | |
| *** mickeys has quit IRC | 11:32 | |
| *** cuongnv has quit IRC | 11:45 | |
| *** vks1 has quit IRC | 12:12 | |
| *** mickeys has joined #openstack-fwaas | 12:29 | |
| *** mickeys has quit IRC | 12:33 | |
| *** yamamoto has joined #openstack-fwaas | 12:55 | |
| *** yamamoto has quit IRC | 13:10 | |
| *** yamamoto has joined #openstack-fwaas | 13:14 | |
| *** mickeys has joined #openstack-fwaas | 13:29 | |
| *** mickeys has quit IRC | 13:34 | |
| *** ZZelle has quit IRC | 14:03 | |
| *** ZZelle has joined #openstack-fwaas | 14:03 | |
| *** ZZelle has quit IRC | 14:12 | |
| *** ZZelle has joined #openstack-fwaas | 14:12 | |
| *** ZZelle has quit IRC | 14:14 | |
| *** mickeys has joined #openstack-fwaas | 14:30 | |
| *** mickeys has quit IRC | 14:36 | |
| *** logan- has joined #openstack-fwaas | 14:52 | |
| *** yamamoto has quit IRC | 15:30 | |
| *** mickeys has joined #openstack-fwaas | 15:33 | |
| *** yamamoto has joined #openstack-fwaas | 15:35 | |
| *** mickeys has quit IRC | 15:37 | |
| *** yamamoto has quit IRC | 15:39 | |
| *** mickeys has joined #openstack-fwaas | 15:56 | |
| *** reedip_ has joined #openstack-fwaas | 16:06 | |
| *** yamamoto has joined #openstack-fwaas | 16:37 | |
| *** yamamoto has quit IRC | 16:43 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 17:06 | |
| *** amotoki is now known as amotoki_away | 17:28 | |
| *** amotoki_away is now known as amotoki | 17:35 | |
| *** reedip_ has quit IRC | 18:10 | |
| *** amotoki is now known as amotoki_away | 18:55 | |
| *** mickeys has quit IRC | 21:13 | |
| *** Tim_Eberhard has quit IRC | 21:51 | |
| *** mickeys has joined #openstack-fwaas | 22:14 | |
| *** mickeys has quit IRC | 22:18 | |
| *** mickeys has joined #openstack-fwaas | 23:14 | |
| *** mickeys has quit IRC | 23:19 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!