*** hoangcx has joined #openstack-fwaas | 00:28 | |
reedip | yushiro : small change for neutron-lib : https://review.openstack.org/469169 | 03:13 |
---|---|---|
*** vks1 has joined #openstack-fwaas | 03:15 | |
*** mickeys has quit IRC | 03:22 | |
*** yamamoto_ has joined #openstack-fwaas | 03:25 | |
*** mickeys has joined #openstack-fwaas | 03:32 | |
*** yamamoto_ has quit IRC | 05:07 | |
*** yamamoto has joined #openstack-fwaas | 05:51 | |
*** reedip has quit IRC | 06:00 | |
*** mickeys has quit IRC | 06:23 | |
*** reedip has joined #openstack-fwaas | 06:33 | |
*** yamamoto has quit IRC | 06:46 | |
*** yamamoto has joined #openstack-fwaas | 06:47 | |
*** mickeys has joined #openstack-fwaas | 07:24 | |
*** mickeys has quit IRC | 07:29 | |
*** mickeys has joined #openstack-fwaas | 08:07 | |
*** vks1 has quit IRC | 08:13 | |
*** mickeys has quit IRC | 08:32 | |
*** mickeys has joined #openstack-fwaas | 09:33 | |
*** mickeys has quit IRC | 09:38 | |
*** hoangcx has quit IRC | 10:16 | |
*** mickeys has joined #openstack-fwaas | 10:34 | |
*** mickeys has quit IRC | 10:38 | |
*** yamamoto has quit IRC | 10:52 | |
*** yamamoto has joined #openstack-fwaas | 11:56 | |
*** yamamoto has quit IRC | 12:21 | |
*** mickeys has joined #openstack-fwaas | 12:35 | |
*** yamamoto has joined #openstack-fwaas | 12:38 | |
*** mickeys has quit IRC | 12:39 | |
*** yamamoto has quit IRC | 13:10 | |
*** yamamoto has joined #openstack-fwaas | 13:11 | |
*** yamamoto has quit IRC | 13:21 | |
*** yamamoto has joined #openstack-fwaas | 13:23 | |
*** hoangcx has joined #openstack-fwaas | 13:48 | |
*** lnicolas has quit IRC | 13:48 | |
*** yushiro2 has joined #openstack-fwaas | 13:56 | |
*** vks1 has joined #openstack-fwaas | 14:01 | |
*** mickeys has joined #openstack-fwaas | 14:37 | |
*** mickeys has quit IRC | 14:42 | |
yushiro2 | ping ZZelle | 14:49 |
ZZelle | yushiro2, hi | 14:50 |
yushiro2 | ZZelle, Hi, long time no see :) | 14:50 |
yushiro2 | ZZelle, Thanks for your great review for L2-agent patch. | 14:51 |
yushiro2 | ZZelle, I'm now updating step by step for l2-agent patch. But I still has some bug. | 14:52 |
yushiro2 | ZZelle, https://review.openstack.org/#/c/323971/31/neutron_fwaas/db/firewall/v2/firewall_db_v2.py at line 1020 | 14:53 |
*** hoangcx has quit IRC | 14:54 | |
yushiro2 | ZZelle, in cleanup_ports_with_firewall_group | 14:54 |
ZZelle | yushiro2, which trouble? | 14:54 |
*** yamamoto has quit IRC | 14:55 | |
yushiro2 | ZZelle, in this method, I'd like to update FirewallGrpupPortAssociation in DB transaction. | 14:55 |
ZZelle | yushiro2, ok | 14:55 |
yushiro2 | ZZelle, Ex. fwg1 has portA and portB, and I update fwg2(no ports) with portA. As a result, fwg1 has portB and fwg2 has a portA. | 14:56 |
ZZelle | ok | 14:57 |
yushiro2 | In this method, I'd like to delete an association portA <--> fwg1 and add portA <--> fwg2 | 14:57 |
ZZelle | ok | 14:59 |
yushiro2 | Sorry for long example. A trouble is an error occurred in line 1052 (.one()) | 14:59 |
yushiro2 | Above example is success case. Failure case is as follows: | 15:00 |
yushiro2 | fwg1 has port A and B, fwg2 has port C. And try to add portA to fwg2 | 15:00 |
ZZelle | yushiro2, what is the trouble? | 15:01 |
yushiro2 | In this case, fwg2 try to add port A and C. Therefore, I cannot judge which is newer port or existing port. | 15:02 |
yushiro2 | A logic of this method(cleanup_ports_with_firewall_group), try to find a record( .one() ) by port_id and fwg_id. | 15:03 |
yushiro2 | Here is main logic: port_id and NOT fwg_id | 15:04 |
yushiro2 | If port_id is newly added port(A), above logic can find an old association record. But if the port is existing port(C), there is no association and got an error. | 15:06 |
yushiro2 | That's why I implemented that ignores DB error and continue to find a record. | 15:07 |
yushiro2 | Do you know how to judge that which port is a newly added? | 15:09 |
*** Tim_Eberhard has joined #openstack-fwaas | 15:09 | |
yushiro2 | Sorry for my long redundancy explanation... Please let me know if you don't understand a point. | 15:09 |
*** Tim_Eberhard has quit IRC | 15:13 | |
*** yushiro2 has quit IRC | 15:27 | |
*** reedip_ has joined #openstack-fwaas | 15:27 | |
reedip_ | hey guys sorry, just came back | 15:28 |
*** yushiro2 has joined #openstack-fwaas | 15:37 | |
yushiro2 | ZZelle, oops, sorry. Suddenly I dropped out from freenode. | 15:38 |
*** mickeys_ has joined #openstack-fwaas | 15:39 | |
*** mickeys_ has quit IRC | 15:43 | |
yushiro2 | reedip, thanks for your neutron-lib patch. | 15:55 |
reedip_ | yushiro2 : no thanks ... it was part of the job | 16:07 |
reedip_ | xgerman yushiro2 : I have also updated the punchlist of neutron-lib migrations for fwaas | 16:08 |
yushiro2 | reedip_, looking.. | 16:09 |
reedip_ | yushiro2 : you should really sleep soon .. its already 1:20 (almost ) | 16:12 |
yushiro2 | reedip_, I'm night man :) | 16:12 |
reedip_ | lol ok yushiro2 : I updated https://review.openstack.org/#/c/440331/12/releasenotes/notes/extend_firewall_rule_protocol_list-04893a16e7c9a46c.yaml as well for you | 16:13 |
yushiro2 | reedip_, in working time, I have to another work.. haha | 16:14 |
yushiro2 | reedip_, Just reviewed | 16:14 |
yushiro2 | reedip_, So, in your punch list, | 16:15 |
yushiro2 | reedip_, each section without gerrit URL, is there not posted any patch? | 16:16 |
*** vks1 has quit IRC | 16:17 | |
*** yamamoto has joined #openstack-fwaas | 16:26 | |
reedip_ | yushiro2 :thats correct | 16:26 |
*** yamamoto has quit IRC | 16:31 | |
*** mickeys_ has joined #openstack-fwaas | 16:39 | |
yushiro2 | reedip_, OK. | 16:40 |
yushiro2 | i'll help u in this work. | 16:41 |
*** mickeys_ has quit IRC | 16:44 | |
reedip_ | yushiro2 : sure. But I am waiting for boden :) | 16:45 |
reedip_ | once things move in neutron-lib, we can change the same in fwaas | 16:45 |
yushiro2 | OK, which patch? | 16:49 |
reedip_ | yushiro2 : Right now I also dont know. Need to track the same | 16:51 |
yushiro2 | reedip_, OK, thx | 16:51 |
reedip_ | but I know , for example, test_l2 and migrations in the punch list have not moved to neutron-lib | 16:51 |
yushiro2 | reedip_, yup. I just try to run my l2 patch with latest devstack, failed :) | 16:52 |
yushiro2 | reedip_, Can I update my l2 patch in next PS? | 16:53 |
*** reedip_ has quit IRC | 16:58 | |
*** mickeys_ has joined #openstack-fwaas | 17:40 | |
*** mickeys_ has quit IRC | 17:45 | |
*** yushiro2 has quit IRC | 18:10 | |
*** Tim_Eberhard has joined #openstack-fwaas | 18:19 | |
*** Tim_Eberhard has quit IRC | 18:19 | |
*** Tim_Eberhard has joined #openstack-fwaas | 18:23 | |
*** yamamoto has joined #openstack-fwaas | 18:29 | |
*** yamamoto has quit IRC | 18:34 | |
*** Tim_Eberhard has quit IRC | 18:43 | |
xgerman_ | SridarK_ : we are getting a release cut for P-2: https://review.openstack.org/#/c/471414/ | 18:44 |
*** yamamoto has joined #openstack-fwaas | 19:31 | |
*** yamamoto has quit IRC | 19:36 | |
*** mickeys_ has joined #openstack-fwaas | 19:42 | |
*** mickeys_ has quit IRC | 19:46 | |
*** yamamoto has joined #openstack-fwaas | 20:32 | |
*** yamamoto has quit IRC | 20:37 | |
*** mickeys_ has joined #openstack-fwaas | 20:43 | |
*** mickeys_ has quit IRC | 20:47 | |
*** Tim_Eberhard has joined #openstack-fwaas | 21:30 | |
*** yamamoto has joined #openstack-fwaas | 21:33 | |
*** yamamoto has quit IRC | 21:37 | |
*** mickeys_ has joined #openstack-fwaas | 21:43 | |
*** mickeys_ has quit IRC | 21:48 | |
*** yamamoto_ has joined #openstack-fwaas | 22:34 | |
*** yamamoto_ has quit IRC | 22:40 | |
*** yamamoto_ has joined #openstack-fwaas | 23:36 | |
*** yamamoto_ has quit IRC | 23:42 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!