openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add 2.8, 2.9 and train jobs https://review.opendev.org/713766 | 00:44 |
---|---|---|
*** evrardjp has quit IRC | 05:36 | |
*** evrardjp has joined #openstack-ansible-sig | 05:36 | |
*** sdoran has quit IRC | 08:07 | |
*** sdoran has joined #openstack-ansible-sig | 08:08 | |
*** cyberpear has quit IRC | 08:09 | |
*** guilhermesp has quit IRC | 08:09 | |
*** mwhahaha has quit IRC | 08:09 | |
*** mnaser has quit IRC | 08:10 | |
*** mwhahaha has joined #openstack-ansible-sig | 08:10 | |
*** cyberpear has joined #openstack-ansible-sig | 08:11 | |
*** mnaser has joined #openstack-ansible-sig | 08:11 | |
*** guilhermesp has joined #openstack-ansible-sig | 08:11 | |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 08:53 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 08:53 |
*** yoctozepto has quit IRC | 09:07 | |
*** yoctozepto0 has joined #openstack-ansible-sig | 09:16 | |
*** yoctozepto9 has joined #openstack-ansible-sig | 09:27 | |
*** yoctozepto0 has quit IRC | 09:27 | |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 09:37 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 09:37 |
*** dtantsur|afk is now known as dtantsur | 09:39 | |
*** sshnaidm|afk is now known as sshnaidm | 09:49 | |
*** gshippey has joined #openstack-ansible-sig | 09:59 | |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add ansible 2.9 and openstacksdk train jobs https://review.opendev.org/713766 | 10:13 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 10:32 |
*** holser has joined #openstack-ansible-sig | 10:36 | |
*** yoctozepto9 is now known as yoctozepto | 10:37 | |
*** holser has quit IRC | 11:08 | |
*** holser has joined #openstack-ansible-sig | 11:10 | |
*** holser has quit IRC | 11:11 | |
*** holser has joined #openstack-ansible-sig | 11:12 | |
*** dtantsur is now known as dtantsur|afk | 11:20 | |
odyssey4me | mordred: I think bogdando is probably right here, although it's a bit of a nit. https://review.opendev.org/#/c/713461/8/.zuul.yaml | 11:46 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 12:06 |
sshnaidm | openstackgerrit, fixed | 12:06 |
sshnaidm | odyssey4me, ^^ :) | 12:06 |
*** holser has quit IRC | 12:08 | |
*** holser has joined #openstack-ansible-sig | 12:11 | |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Add ansible 2.9 and openstacksdk train jobs https://review.opendev.org/713766 | 12:21 |
odyssey4me | sshnaidm: great, thanks | 12:21 |
* tremble thanks odyssey4me for the review on https://review.opendev.org/#/c/713633/ | 12:21 | |
odyssey4me | tremble: :) nice to see someone do that - it's been on my TODO for a loooong time, but never seems to get to the surface | 12:22 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add ansible 2.9 and openstacksdk train jobs https://review.opendev.org/713766 | 12:24 |
sshnaidm | mordred, take a look please in your time, are we good with such approach? https://review.opendev.org/#/c/713766/ | 12:25 |
tremble | Now to get the pieces in place for "Identity Provider" and "protocol" | 12:27 |
mordred | sshnaidm: yeah - I think that looks good | 13:01 |
sshnaidm | mordred, I was thinking, maybe we can replace "release" ansible with "stable-2.9"? It looks more or less the same | 13:02 |
sshnaidm | I suppose stable-2.9 is a few patches ahead of release, but not sure it's critical.. | 13:03 |
sshnaidm | mordred, in second thought, let's not.. :) this layout looks correct | 13:05 |
mordred | sshnaidm: yeah - let's leave it for now :) | 13:07 |
mordred | now that this one is working | 13:07 |
sshnaidm | mordred, cool | 13:09 |
mordred | tremble: in https://review.opendev.org/#/c/713633/1/openstack/identity/v3/mapping.py - what's up with name = Body('id') ? | 13:11 |
tremble | mordred, When I was testing "name" seemed to be auto-created but left as null. mappings only have an id | 13:14 |
tremble | mordred, I kinda just wanted to make it an alias | 13:16 |
mordred | nod. and yes - there's a way to do that ... one sec | 13:18 |
tremble | mordred, While I'm at it do you want me to add a "requires" to the ansible pieces on your 'release' change? | 13:20 |
mordred | hrm. you know - your thing is better - just looked weird | 13:21 |
tremble | mordred, What should I put as the required version? >.43 ? | 13:24 |
mordred | tremble: yeah - I was trying to come up with a better way to express the min_version parameter yesterday but I don't like anything I came up with. so I think for now let's just add a min_version=0.44 to your openstack_cloud_from_module calls | 13:26 |
tremble | Ok | 13:26 |
mordred | sshnaidm, odyssey4me: mind looking at https://review.opendev.org/#/c/711471/ ? It's similar to the functional testing patches above - but is aimed at making sure the os_ modules shipped in ansible/ansible in 2.8 and 2.9 still work with new sdk changes | 13:28 |
mordred | (then we'll update what we're running on github PRs to run those) | 13:28 |
tremble | mordred, And do you want the cross requirement on your 'Cleanup functional tests' change? | 13:28 |
sshnaidm | mordred, looking | 13:29 |
mordred | tremble: yeah - probably a good idea | 13:29 |
odyssey4me | mordred: I took a peek - looks fine, although I was wondering whether there wasn't a way of achieving it using the collection jobs instead to avoid duplicating so much stuff | 13:29 |
mordred | sshnaidm: this: https://review.opendev.org/#/c/711474/ is the corresponding project-patch | 13:29 |
mordred | odyssey4me: not really - because the content we're testing is different (although I agree that would be much better) | 13:30 |
mordred | it'll be nice once 2.9 is EOL and we can only care about the collection | 13:30 |
sshnaidm | mordred, right.. I think openstacksdk-ansible-devel-functional-devstack may be deleted as well? | 13:31 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 13:32 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 13:32 |
mordred | sshnaidm: oh - that's the one that should be throwing a quick error if someone tries to submit a PR to the ansible modules on devel | 13:33 |
mordred | sshnaidm: although - they're deleted from devel now aren't they? | 13:33 |
mordred | nope. still in devel | 13:34 |
sshnaidm | mordred, hmm.. yeah, still there | 13:35 |
mordred | yeah - that job is there for that reason (and it's still named that because it's being assigned in project-config - so it's easier to just keep the name) | 13:35 |
sshnaidm | mordred, but devel is frozen I think | 13:35 |
mordred | yeah? so maybe we don't need to worry about it? | 13:35 |
sshnaidm | mordred, well, let's hold on until it's deleted, just to be safe | 13:35 |
mordred | ++ | 13:35 |
openstackgerrit | Merged openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 13:42 |
sshnaidm | mordred, do we need override master for openstacksdk/devstack in these jobs? | 13:43 |
sshnaidm | mordred, couldn't they run on train, stein, etc? | 13:43 |
sshnaidm | using 2.8 with train can be a case | 13:44 |
sshnaidm | commented in patch | 13:46 |
mordred | sshnaidm: on the second part - we'll still be running these on ansible patches - so keeping the stable-2.8 part is important | 13:50 |
mordred | for the first part - I'm thinking ... (also you still might be right about the first part given how we attach it in project-config) | 13:51 |
sshnaidm | mordred, oh, you mean still can be patches to 2.8/2.9, sorry, forgot it's not eol yet :) | 13:51 |
mordred | yeah. :) | 13:52 |
mordred | that's the larger thing I'm worried out - we missed a broken patch to 2.8 a few weeks ago because we werent' running testing | 13:53 |
mordred | that said - I thnk there's an improvement we can make here: | 13:54 |
sshnaidm | mordred, if you remove "branch, how does zuul know which job to run on patch (2.9 or 2.8)? | 14:03 |
sshnaidm | on ansible patch | 14:03 |
mordred | that's in project-config | 14:04 |
mordred | sshnaidm: https://review.opendev.org/#/c/711474/2/zuul.d/projects.yaml | 14:04 |
sshnaidm | mordred, ah, cool | 14:05 |
sshnaidm | seems like you can't set required_projects: in job template | 14:07 |
openstackgerrit | Merged openstack/ansible-collections-openstack master: Add ansible 2.9 and openstacksdk train jobs https://review.opendev.org/713766 | 14:13 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 14:31 |
openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 14:31 |
*** holser has quit IRC | 15:08 | |
*** holser has joined #openstack-ansible-sig | 15:09 | |
sshnaidm | zbr, weshay|ruck is "AttributeError: 'module' object has no attribute 'main'" known? https://review.rdoproject.org/zuul/build/e21c312e830d4616af2ac869b3dd7fee/log/job-output.txt#4257-4268 | 15:09 |
zbr | i am talking with cloudnuul on #tripleo about this, very weird, likely another briken virtualenv release | 15:10 |
sshnaidm | sorry, wrong channel.. | 15:10 |
zbr | ahh, that is different. | 15:10 |
weshay|ruck | sshnaidm, /me looks | 15:13 |
weshay|ruck | sshnaidm, what's the patch number | 15:14 |
sshnaidm | weshay|ruck, please, on #tripleo | 15:14 |
*** holser has quit IRC | 15:28 | |
*** holser has joined #openstack-ansible-sig | 15:29 | |
*** spatel has joined #openstack-ansible-sig | 15:48 | |
*** spatel has quit IRC | 15:51 | |
*** evrardjp has quit IRC | 17:36 | |
*** evrardjp has joined #openstack-ansible-sig | 17:36 | |
*** holser has quit IRC | 18:18 | |
zbr | weshay|ruck: sshnaidm : going out now but here is a lesson learned today: put everywhere a condition "virtualenv<20", all new versions seems to cause problems. | 18:33 |
weshay|ruck | zbr, it's spread across how many repos? | 18:34 |
weshay|ruck | and places | 18:34 |
zbr | and we have again the same surprise like two days ago: openstack requirments installed the broken verison https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt | 18:35 |
zbr | twice in a week, previous one was with pytest-html | 18:36 |
*** holser has joined #openstack-ansible-sig | 18:39 | |
*** holser has quit IRC | 19:32 | |
*** holser has joined #openstack-ansible-sig | 19:33 | |
*** sshnaidm is now known as sshnaidm|off | 19:33 | |
*** holser has quit IRC | 21:43 | |
*** holser has joined #openstack-ansible-sig | 22:11 | |
*** holser has quit IRC | 22:12 | |
*** holser has joined #openstack-ansible-sig | 22:13 | |
*** gshippey has quit IRC | 22:55 | |
*** holser has quit IRC | 23:04 | |
*** spatel has joined #openstack-ansible-sig | 23:42 | |
*** spatel has quit IRC | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!