| *** holser has quit IRC | 00:42 | |
| *** evrardjp has quit IRC | 05:35 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:36 | |
| *** dtantsur|afk is now known as dtantsur | 07:34 | |
| *** dmsimard|off7 has joined #openstack-ansible-sig | 07:48 | |
| *** dmsimard|off has quit IRC | 07:48 | |
| *** dmsimard|off7 is now known as dmsimard|off | 07:48 | |
| *** yoctozepto9 has joined #openstack-ansible-sig | 08:14 | |
| *** yoctozepto has quit IRC | 08:15 | |
| *** yoctozepto9 is now known as yoctozepto | 08:15 | |
| *** sshnaidm has quit IRC | 08:29 | |
| *** yoctozepto has quit IRC | 08:49 | |
| *** yoctozepto has joined #openstack-ansible-sig | 08:59 | |
| *** openstackgerrit has joined #openstack-ansible-sig | 09:00 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Update os_client_config to use openstacksdk https://review.opendev.org/713480 | 09:00 |
|---|---|---|
| *** yoctozepto has quit IRC | 09:59 | |
| *** yoctozepto has joined #openstack-ansible-sig | 10:03 | |
| *** yoctozepto2 has joined #openstack-ansible-sig | 10:13 | |
| *** yoctozepto has quit IRC | 10:13 | |
| *** yoctozepto2 is now known as yoctozepto | 10:13 | |
| *** sshnaidm has joined #openstack-ansible-sig | 10:20 | |
| *** holser has joined #openstack-ansible-sig | 10:39 | |
| *** holser__ has joined #openstack-ansible-sig | 10:46 | |
| *** holser has quit IRC | 10:48 | |
| *** sshnaidm has quit IRC | 10:54 | |
| *** sshnaidm has joined #openstack-ansible-sig | 10:55 | |
| *** holser__ has quit IRC | 11:54 | |
| *** holser has joined #openstack-ansible-sig | 11:58 | |
| *** holser has quit IRC | 12:05 | |
| *** holser has joined #openstack-ansible-sig | 12:12 | |
| *** holser has quit IRC | 12:17 | |
| *** holser has joined #openstack-ansible-sig | 12:19 | |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 12:38 |
| *** gshippey has joined #openstack-ansible-sig | 12:40 | |
| tremble | dtantsur, Is it possible to see my test results live (like I can with shippable) or do I just need to wait? | 12:43 |
| dtantsur | tremble: zuul.openstack.org and search for change number | 12:45 |
| tremble | Thanks | 12:45 |
| dtantsur | mmm, zuul.opendev.org | 12:45 |
| dtantsur | ehmmm, no again. zuul.openstack.org gets you to the right page immediately | 12:46 |
| tremble | Heh, old habits die hard :) | 12:47 |
| * tremble hopes nobody's going to complain about him bringing his AWS style integration tests with him... https://review.opendev.org/#/c/713643/1/ci/roles/keystone_mapping/tasks/main.yml | 12:52 | |
| *** holser has quit IRC | 12:57 | |
| *** holser has joined #openstack-ansible-sig | 13:08 | |
| *** holser has quit IRC | 13:13 | |
| *** yoctozepto1 has joined #openstack-ansible-sig | 14:12 | |
| *** yoctozepto has quit IRC | 14:13 | |
| *** yoctozepto1 is now known as yoctozepto | 14:13 | |
| *** holser has joined #openstack-ansible-sig | 14:22 | |
| *** holser has quit IRC | 14:26 | |
| *** holser has joined #openstack-ansible-sig | 14:28 | |
| *** tremble has quit IRC | 14:39 | |
| *** tremble has joined #openstack-ansible-sig | 14:40 | |
| *** dtantsur is now known as dtantsur|brb | 14:48 | |
| mordred | nah - those look nice | 14:59 |
| *** priteau has joined #openstack-ansible-sig | 14:59 | |
| mordred | tremble: that said - it doesn't look like you added that testing role to the testing playbook | 15:00 |
| mordred | ci/run-collection.yml | 15:00 |
| mordred | tremble: also - fwiw - we do have a whole throwaway cloud at our disposal when we run the functional tests - so it's possible you could do more of those not in check mode. that said - since this is about federation, would we need to set up a cloud with federation enabled to make it work? | 15:03 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 15:05 |
| tremble | mordred, You need a few more components that aren't supported by Ansible yet. | 15:06 |
| tremble | mordred, I'm used to the AWS tests which are automatically run if they match the module name (or include the right alias) | 15:07 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 15:08 |
| mordred | nod | 15:09 |
| tremble | mordred, In theory I could check that the rules uploaded actually match which I'll probably do when I submit an _info module to go with it, but checking that the mappings work is a pretty significant effort | 15:14 |
| mordred | nod. also, really, that's the sort of thing that it's better for us to check in sdk (make sure the calls work right) and really just testing that the ansible maps in to the sdk prpoerly is enough in the ansible tets | 15:21 |
| *** holser has quit IRC | 15:22 | |
| sshnaidm | mordred, wrt https://review.opendev.org/#/c/713461/ I have a few questions, one is - what is advantage of using releases instead of cloned openstacksdk in src? We can then reuse this job to test openstacksdk patches | 15:23 |
| sshnaidm | mordred, I mean "ansible-collections-openstack-functional-devstack-releases" job. It also uses "last release" of ansible, instead of cloning, is it intentional? | 15:25 |
| *** holser has joined #openstack-ansible-sig | 15:39 | |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 15:54 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 15:54 |
| mordred | sshnaidm: yes - it's to test that the collections work with the most recently released versions of sdk and ansible - if we only test against git, we might miss that we're broken with the versions of things people are going to install in the real world, but that we work with latest git of everything | 16:22 |
| mordred | the releases job isn't very interesting to sdk -that's mostly a check for us to make sure we're solid with released versions. the non-releases version is great for co-gating with sdk | 16:23 |
| tremble | mordred, Would that still work where we need unreleased versions like my os_keystone_mapping modules? | 16:24 |
| *** holser has quit IRC | 16:24 | |
| sshnaidm | mordred, I see, although in ansible we can just have stable-2.9, stable-2.8, etc. However if we gate openstacksdk with this job, I don't think it can be broken release there, it shouldn't pass gates | 16:26 |
| *** sshnaidm has quit IRC | 16:28 | |
| *** sshnaidm has joined #openstack-ansible-sig | 16:28 | |
| mordred | sshnaidm: right - we would not gate sdk with -release - it makes no sense there. tremble's recent patches are actually a good example of what we should start catching (that I totally forgot when reviewing but the gate job would remind me of) | 16:29 |
| *** holser has joined #openstack-ansible-sig | 16:30 | |
| sshnaidm | mordred, ok, I can think where we need this job, if ansible module has a changes which is compatible with latest sdk code, but not with latest sdk release | 16:31 |
| mordred | those two new modules each depend on patches to sdk. but the collection shouldn't actually depend on unreleased patches - so we need to add an sdk version chefck in those modules "you need at least version 0.44" - then the -release job will _fail_ until we land the patches in sdk and cut an sdk release. but the non-release version will pass, showing us that the modules and their tests are good | 16:31 |
| *** holser has quit IRC | 16:31 | |
| mordred | then we can land the new modules safely and release them into the wild since they'll work - and appropriately error if sdk is too old | 16:31 |
| *** holser has joined #openstack-ansible-sig | 16:31 | |
| mordred | (and the job will remind us of this when we forget during review :) ) | 16:32 |
| sshnaidm | mordred, if we have "min version 0.44" then it shouldn't be executed in release job at all..? | 16:33 |
| sshnaidm | if last release is .43 | 16:33 |
| mordred | hrm. well - there's still an issue here ... | 16:33 |
| mordred | well - what we want is for it to be executed and fail with a "openstacksdk is too old" | 16:34 |
| mordred | that way the gate job will be red - if we just skip it - we're not testing anything | 16:34 |
| mordred | BUT | 16:34 |
| mordred | we're currently testing for min_version | 16:34 |
| mordred | the master sdk install won't meet that either | 16:34 |
| mordred | since it'll be at version 0.43.1.dev13 | 16:35 |
| mordred | which is _also_ not 0.44 | 16:35 |
| tremble | mordred, So final merge of my patches would need to wait for a *release* of openstacksdk? | 16:35 |
| mordred | tremble: yeah - but those are usually quick - we release all the time as needed | 16:36 |
| sshnaidm | mordred, you mean failing modules because of old sdk? Or just an external check in job, because people still may want use collection with the old sdk, just not using new options | 16:36 |
| mordred | sshnaidm: right. people should be able to use collection with old sdk - but the new module will not work with old sdk - because it needs new features. we want to see that the module approriately communicates this to the user | 16:37 |
| sshnaidm | mordred, actually "release" jobs is good for the actual release and push to galaxy | 16:37 |
| mordred | we can't do testing in a release pipeline unfortunately -it's driven by a git tag and at that point the tag is already pushed | 16:38 |
| *** holser has quit IRC | 16:38 | |
| sshnaidm | mordred, oh, I thought it still can run some jobs there.. | 16:38 |
| mordred | it can run jobs | 16:38 |
| mordred | it just can't block things | 16:38 |
| mordred | so it could certainly say "you just cut a release that is broken" | 16:38 |
| mordred | but the release will have still been cut | 16:39 |
| mordred | at least- the tag will have been pushed | 16:39 |
| sshnaidm | ack | 16:39 |
| mordred | this is why we want to make sure the gate catches all the things | 16:39 |
| *** holser has joined #openstack-ansible-sig | 16:39 | |
| mordred | that said - as much as I'm arguing for this - Im not sure our min_version logic is going to do the right thing to allow us to do this right | 16:39 |
| mordred | so we might need to rethink that a little | 16:40 |
| mordred | we don't want to say min_version=0.44 - we want to say requires_greater_then=0.43 - because the master version of sdk will be > 0.43 - but it won't be 0.44 | 16:40 |
| sshnaidm | yeah, that will work | 16:42 |
| sshnaidm | (just to ensure versions are compared correctly) | 16:42 |
| sshnaidm | do we have there option for > < ? | 16:42 |
| *** holser__ has joined #openstack-ansible-sig | 16:43 | |
| *** holser__ has quit IRC | 16:43 | |
| *** holser__ has joined #openstack-ansible-sig | 16:44 | |
| *** holser has quit IRC | 16:44 | |
| *** tremble has quit IRC | 16:44 | |
| sshnaidm | mordred, so maybe to use min_version=0.43.0001 :) | 16:47 |
| *** johanssone has quit IRC | 16:51 | |
| mordred | heh. | 16:53 |
| mordred | I'll get a patch up in just a few and we can see what we think | 16:53 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 16:55 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 16:55 |
| *** johanssone has joined #openstack-ansible-sig | 16:56 | |
| *** johanssone has quit IRC | 16:57 | |
| *** johanssone has joined #openstack-ansible-sig | 17:03 | |
| *** johanssone has quit IRC | 17:03 | |
| *** tremble has joined #openstack-ansible-sig | 17:04 | |
| *** johanssone has joined #openstack-ansible-sig | 17:05 | |
| *** johanssone has quit IRC | 17:05 | |
| *** johanssone has joined #openstack-ansible-sig | 17:06 | |
| *** johanssone has quit IRC | 17:08 | |
| *** dtantsur|brb is now known as dtantsur | 17:09 | |
| *** johanssone has joined #openstack-ansible-sig | 17:14 | |
| *** johanssone has quit IRC | 17:15 | |
| *** johanssone has joined #openstack-ansible-sig | 17:20 | |
| *** johanssone has quit IRC | 17:20 | |
| *** johanssone has joined #openstack-ansible-sig | 17:23 | |
| *** johanssone has quit IRC | 17:27 | |
| *** johanssone has joined #openstack-ansible-sig | 17:30 | |
| *** johanssone has quit IRC | 17:32 | |
| *** evrardjp has quit IRC | 17:36 | |
| *** evrardjp has joined #openstack-ansible-sig | 17:36 | |
| *** holser__ has quit IRC | 17:39 | |
| *** holser has joined #openstack-ansible-sig | 17:40 | |
| *** priteau has quit IRC | 17:42 | |
| *** johanssone has joined #openstack-ansible-sig | 17:46 | |
| *** johanssone has quit IRC | 17:54 | |
| *** holser has quit IRC | 17:58 | |
| *** johanssone has joined #openstack-ansible-sig | 18:02 | |
| *** johanssone has quit IRC | 18:02 | |
| *** johanssone has joined #openstack-ansible-sig | 18:03 | |
| *** holser has joined #openstack-ansible-sig | 18:07 | |
| *** johanssone has quit IRC | 18:08 | |
| *** dtantsur is now known as dtantsur|afk | 18:11 | |
| *** johanssone has joined #openstack-ansible-sig | 18:13 | |
| *** holser has quit IRC | 18:16 | |
| *** holser has joined #openstack-ansible-sig | 18:17 | |
| *** johanssone has quit IRC | 18:19 | |
| *** johanssone has joined #openstack-ansible-sig | 18:22 | |
| *** johanssone has quit IRC | 18:25 | |
| *** johanssone has joined #openstack-ansible-sig | 18:34 | |
| *** johanssone has quit IRC | 18:37 | |
| *** sshnaidm is now known as sshnaidm|afk | 18:41 | |
| *** johanssone has joined #openstack-ansible-sig | 18:43 | |
| *** johanssone has quit IRC | 18:47 | |
| *** johanssone has joined #openstack-ansible-sig | 18:50 | |
| *** johanssone has quit IRC | 18:57 | |
| *** johanssone has joined #openstack-ansible-sig | 19:04 | |
| *** johanssone has quit IRC | 19:04 | |
| *** johanssone has joined #openstack-ansible-sig | 19:06 | |
| *** johanssone has quit IRC | 19:06 | |
| *** johanssone has joined #openstack-ansible-sig | 19:11 | |
| *** johanssone has quit IRC | 19:14 | |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 19:17 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 19:17 |
| *** holser has quit IRC | 19:18 | |
| *** johanssone has joined #openstack-ansible-sig | 19:21 | |
| *** holser has joined #openstack-ansible-sig | 19:36 | |
| sshnaidm|afk | mordred, one question here: https://review.opendev.org/#/c/713461/6/.zuul.yaml | 20:09 |
| sshnaidm|afk | mordred, commented again, seems like ansible-devel is not used | 20:13 |
| sshnaidm|afk | I see there 2.9.6 is used | 20:13 |
| sshnaidm|afk | need to add something to print used openstacksdk version as well for better investigations | 20:14 |
| mordred | looking | 20:18 |
| sshnaidm|afk | mordred, seems like it works for devstack | 20:20 |
| sshnaidm|afk | but tox installs releases in venv and it's what used | 20:20 |
| mordred | oh - hrm. no - we skipped siblings | 20:21 |
| mordred | https://zuul.opendev.org/t/openstack/build/8b1d7295f1a549f3992c1c5e6e66cb50/log/job-output.txt#40495 | 20:21 |
| mordred | maybe we need to be more explicit - lemme see what's going on there | 20:22 |
| mordred | yup. that's my bad - thanks for finding it! | 20:22 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 20:23 |
| mordred | sshnaidm|afk: that should fix it - but let's double-check again to be sure! | 20:23 |
| sshnaidm|afk | mordred, sure, thanks | 20:23 |
| *** gshippey has quit IRC | 20:36 | |
| *** openstackstatus has joined #openstack-ansible-sig | 21:15 | |
| *** ChanServ sets mode: +v openstackstatus | 21:15 | |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 22:14 |
| *** holser has quit IRC | 22:55 | |
| *** spatel has joined #openstack-ansible-sig | 23:27 | |
| *** spatel has quit IRC | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!