| *** spatel has joined #openstack-ansible-sig | 00:38 | |
| *** spatel has quit IRC | 01:10 | |
| *** evrardjp has quit IRC | 05:36 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:36 | |
| *** dtantsur|afk is now known as dtantsur | 08:50 | |
| *** holser has joined #openstack-ansible-sig | 08:53 | |
| *** dtantsur is now known as dtantsur|learnin | 08:58 | |
| *** dtantsur|learnin is now known as dtantsur | 10:03 | |
| *** holser has quit IRC | 10:24 | |
| *** holser has joined #openstack-ansible-sig | 10:28 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add dependencies for long jobs on linters https://review.opendev.org/714070 | 10:42 |
|---|---|---|
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add rocky, stein jobs https://review.opendev.org/714073 | 10:48 |
| sshnaidm|off | mordred, dtantsur odyssey4me ^^ | 10:48 |
| dtantsur | k | 11:09 |
| tremble | dtantsur, mordred, Is there any way to prevent the OpenStack SDK proxy from sending "id" as part of a PUT? Keystone's throwing errors at me when I try to create an object : https://paste.centos.org/view/23afee01 | 12:11 |
| dtantsur | tremble: I think I did it for ironic at least once.. lemme see | 12:11 |
| dtantsur | tremble: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L438 to False? | 12:16 |
| dtantsur | mmm, no, probably no | 12:17 |
| dtantsur | the Introspection resource is essentially in the same boat: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/baremetal_introspection/v1/introspection.py#L35-L37 | 12:18 |
| dtantsur | tremble: okay, after a more careful consideration, it seems a missing feature in the SDK | 12:25 |
| dtantsur | I can look into it after lunch | 12:25 |
| dtantsur | I guess introspection works currently because ironic-inspector ignores incoming bodies :D | 12:25 |
| tremble | dtantsur, Bother I had a horrible feeling that might be the case. Thanks | 12:38 |
| mordred | yay missing feature! | 12:54 |
| * tremble attempts to wrap his head around the body generation code. | 13:14 | |
| * tremble cheers as he finds self._body._dirty.discard("id") | 13:26 | |
| dtantsur | tremble: yep, you can even just hack it in your code | 13:33 |
| tremble | dtantsur, Not so easy with create | 13:33 |
| dtantsur | mordred: I think we should discard id from body every time required_id==True, wdyt? | 13:34 |
| dtantsur | I doubt any service requires sending the ID twice (in the URL and in body) | 13:34 |
| mordred | dtantsur: I think that's a great idea | 13:34 |
| dtantsur | tremble: wanna try a patch with ^^^ or should I? | 13:34 |
| tremble | dtantsur, I have a patch which would only do it on create, but can try when required_id==True | 13:35 |
| dtantsur | tremble: it should probably go to _prepare_request in resource.py | 13:35 |
| * tremble nods | 13:35 | |
| * tremble tries to have a quick look for potential side effects before blowing everything up. | 13:39 | |
| tremble | Ok, requires_id drops the ID onto the request URI, I guess all we can do is try it and see if anything explodes... | 13:40 |
| dtantsur | yeah, so my idea is that if the ID is in the URI, we can remove it from the body | 13:42 |
| -openstackstatus- NOTICE: Gerrit (review.opendev.org) will be down for maintenance starting at 14:00 (in less than 20 mins), probably until 15:00 UTC | 13:42 | |
| dtantsur | no gerrit any more, let's go home | 13:43 |
| tremble | dtantsur, /me looks around. Damn this work from home, I'm already there | 13:44 |
| dtantsur | hehe | 13:46 |
| tremble | dtantsur, I have no idea where to add tests for this change... | 13:47 |
| dtantsur | tremble: there must be something in test_resource.py where we create simple resources to test with | 13:48 |
| dtantsur | oh, fun, we explicitly test that what breaks you works: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/test_resource.py#L1045 | 13:49 |
| dtantsur | we need to change the test.. or reflect again on why it was added | 13:49 |
| tremble | dtantsur, I could also submit my less invasive version which only drops it if explicitly requested? | 13:50 |
| dtantsur | tremble: we could have a resource-level flag, something like create_add_id_in_body (invent a better name) | 13:51 |
| tremble | create_exclude_id_from_body | 13:51 |
| tremble | would be what I was working on... | 13:51 |
| dtantsur | yeah | 13:53 |
| * tremble hugs git which still had his change as cherry-pick-able | 13:54 | |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is offline for maintenance until 15:00 UTC http://lists.opendev.org/pipermail/service-announce/2020-March/000001.html | 14:04 | |
| *** ChanServ changes topic to "The Gerrit service on review.opendev.org is offline for maintenance until 15:00 UTC http://lists.opendev.org/pipermail/service-announce/2020-March/000001.html" | 14:04 | |
| *** ChanServ changes topic to "OpenStack Ansible SIG | https://etherpad.openstack.org/p/ansible-sig" | 15:01 | |
| -openstackstatus- NOTICE: Gerrit maintenance is concluded at this time and requested renames have been performed | 15:01 | |
| *** openstack has joined #openstack-ansible-sig | 16:57 | |
| *** ChanServ sets mode: +o openstack | 16:57 | |
| *** dtantsur is now known as dtantsur|afk | 17:02 | |
| *** evrardjp has quit IRC | 17:36 | |
| *** evrardjp has joined #openstack-ansible-sig | 17:36 | |
| *** holser has quit IRC | 20:42 | |
| *** holser has joined #openstack-ansible-sig | 20:44 | |
| *** sdoran_ has joined #openstack-ansible-sig | 23:24 | |
| *** sdoran has quit IRC | 23:25 | |
| *** sdoran_ is now known as sdoran | 23:25 | |
| *** evrardjp has quit IRC | 23:25 | |
| *** evrardjp has joined #openstack-ansible-sig | 23:27 | |
| *** guilhermesp_ has joined #openstack-ansible-sig | 23:36 | |
| *** guilhermesp has quit IRC | 23:37 | |
| *** guilhermesp_ is now known as guilhermesp | 23:37 | |
| *** evrardjp has quit IRC | 23:38 | |
| *** holser has quit IRC | 23:41 | |
| *** evrardjp has joined #openstack-ansible-sig | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!