| *** holser has joined #openstack-ansible-sig | 00:14 | |
| *** holser has quit IRC | 00:28 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 01:08 |
|---|---|---|
| *** evrardjp has quit IRC | 05:35 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:36 | |
| *** holser has joined #openstack-ansible-sig | 06:49 | |
| *** dtantsur|afk is now known as dtantsur | 08:24 | |
| *** holser has quit IRC | 08:38 | |
| *** holser has joined #openstack-ansible-sig | 08:54 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 08:58 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 09:01 |
| *** priteau has joined #openstack-ansible-sig | 09:01 | |
| *** holser has quit IRC | 09:10 | |
| *** holser has joined #openstack-ansible-sig | 09:13 | |
| * tremble thanks dtantsur for his reviews and hopes that the way he's broken up the patches makes things practically review-able | 09:23 | |
| dtantsur | it's not bad at all, given the huge amount of things to change | 09:23 |
| *** priteau has quit IRC | 09:31 | |
| tremble | dtantsur, Is it considered 'ok' to use the OpenStack 'client' libraries when openstacksdk doesn't expose an interface for the objects you're interested in? | 09:48 |
| tremble | (in this case specifically the federation mapping objects) | 09:49 |
| dtantsur | tremble: to my best understanding, we're supposed to update the SDK instead | 09:54 |
| dtantsur | the client libraries tend to pull in a lot of dependencies, and the overall version management immediately becomes complex (global-requirements, etc) | 09:55 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 09:55 |
| * tremble wonders if that's going to take him too far out of his comfort zone | 09:58 | |
| tremble | dtantsur, WRT the whole 'bool' thing, would you be happy with a patch at the end of the current chain making those changes? | 10:01 |
| dtantsur | tremble: yep | 10:13 |
| dtantsur | tremble: re updating SDK: depending on the API in question it may be even easier than adding a dependency on a client library | 10:14 |
| dtantsur | the thing is.. | 10:14 |
| dtantsur | all client libraries handle authentication and endpoint discovery VASTLY differently | 10:14 |
| dtantsur | you risk going insane on this stage already | 10:14 |
| dtantsur | I always screw up authenticating with ironicclient, and I've been working on ironic for nearly 6 years! | 10:15 |
| tremble | Yeah I just noticed it's trying to talk to the admin endpoint when the public endpoint would be fine. | 10:15 |
| dtantsur | tremble: what exactly API endpoint are we talking about? maybe I can guide you through adding it? | 10:15 |
| tremble | Federation Domains and Mappings | 10:16 |
| dtantsur | a silly question: it's about Identity, right? | 10:16 |
| tremble | yup | 10:16 |
| dtantsur | tremble: sorry, I'm stupid. could you point me at the exact place in https://docs.openstack.org/api-ref/identity/v3/index.html ? | 10:17 |
| * dtantsur gets a tea real quick | 10:18 | |
| tremble | https://docs.openstack.org/api-ref/identity/v3-ext/#os-federation-api | 10:19 |
| tremble | https://docs.openstack.org/api-ref/identity/v3-ext/?expanded=list-mappings-detail#list-mappings The piece you mean? | 10:20 |
| tremble | Ah sorry it was 'identity provider' and 'mapping' | 10:21 |
| tremble | I'd started looking into mappings as they're the piece I expect to need to update periodically | 10:22 |
| tremble | ID providers would be a one-time operation | 10:22 |
| tremble | (I'm a SysAdmin who knows 'enough' programming that I try to avoid 'command' hacks with Ansible where possible) | 10:23 |
| dtantsur | tremble: you only need CRUD on that? | 10:29 |
| dtantsur | if so, you can take something simple, e.g. https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/identity/v3/group.py, and copy-paste it | 10:30 |
| dtantsur | changing URLs and updating fields | 10:30 |
| dtantsur | then do the same at the Proxy level: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/identity/v3/_proxy.py#L282-L359 | 10:31 |
| tremble | dtantsur, I *believe* I only need the CRUD... | 10:31 |
| dtantsur | so, the steps above should be enough to get you conn.identity.get_mapping (or whatever you call it) | 10:32 |
| tremble | Oh wow, that looks far too easy | 10:32 |
| tremble | But I guess that's just a side effect of the APIs being reasonably structured | 10:33 |
| dtantsur | yep | 10:33 |
| dtantsur | openstacksdk proxy layer is well designed when it comes to simple CRUD actions | 10:33 |
| tremble | Also looks to be relatively consistent. /me glares at boto3 | 10:34 |
| tremble | Ok, lunch time. Thanks for your input, I'll have a go at the proxy layer pieces when I'm back. | 10:35 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 11:16 |
| *** gshippey has joined #openstack-ansible-sig | 11:30 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 11:38 |
| *** holser has quit IRC | 11:45 | |
| *** holser has joined #openstack-ansible-sig | 11:56 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP new jobs https://review.opendev.org/713312 | 12:41 |
| tremble | dtantsur, I've got the proxy pieces and the resource class in place, but "get_mappings" on the 'cloud' object doesn't seem to exist, is there any additional glue I should need? | 12:52 |
| tremble | s/get_mappings/get_mapping/ | 12:52 |
| dtantsur | tremble: it will be cloud.identity.get_mapping | 13:01 |
| dtantsur | there are two layers, the cloud later has to be updated separately (if needed) | 13:01 |
| *** sshnaidm is now known as sshnaidm|afk | 13:02 | |
| tremble | dtantsur, Ah ok, thanks | 13:04 |
| tremble | There we go that's a better error message (my copy&paste mistake) | 13:11 |
| * tremble cheers as he manages to fetch a mapping using his new CRUD | 13:29 | |
| *** holser has quit IRC | 13:33 | |
| *** holser has joined #openstack-ansible-sig | 13:34 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Introduce ansible/openstacksdk matrix jobs https://review.opendev.org/713312 | 13:35 |
| dtantsur | tremble: awesome :) | 13:36 |
| tremble | dtantsur, Thanks for the pointers :) | 13:46 |
| dtantsur | welcome :) | 13:46 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: Introduce ansible/openstacksdk matrix jobs https://review.opendev.org/713312 | 14:04 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 14:45 |
| mordred | tremble: dtantsur said all the things already - but just to reiterrate slightly more strongly - we should _absolutely_ not use any python-*client libraries in the collection. if you ever need to add something and the sdk bits are missing and it's too much, someone will be glad to help adding the sdk bits. | 14:50 |
| tremble | mordred, Yup, just like dtantsur just did :) | 14:51 |
| mordred | yup! :) | 14:51 |
| mordred | \o/ | 14:51 |
| dtantsur | :) | 14:52 |
| * tremble has been pleasantly surprised with how responsive OpenStack devs in general seem to be. (Puppet, Ansible, Triple-O) | 14:52 | |
| dtantsur | \o/ | 14:52 |
| tremble | probably helps that I'm submitting code rather than bugs/RFEs, but still I'm getting feedback within a few days of submitting stuff. | 14:54 |
| mordred | dtantsur: yay we did something | 14:54 |
| dtantsur | so unusually for us! | 14:54 |
| mordred | tell me about it | 14:54 |
| dtantsur | I'd blame it on staying at home, but I'm always at home | 14:55 |
| mordred | dtantsur: maybe we're more productive now with other people at home? | 14:55 |
| dtantsur | I cannot imagine a mechanism for that, but maybe | 14:55 |
| mordred | dtantsur: if you have a sec, check out disagreement on https://review.opendev.org/#/c/713056/ - and also my comments on https://review.opendev.org/#/c/713312/ - I think both might be topics for our meeting but might be good to read the context first | 14:56 |
| mordred | dtantsur: on the second one, I also just pushed up https://review.opendev.org/#/c/713461/ as an alternate | 14:56 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 14:57 |
| *** sshnaidm|afk is now known as sshnaidm | 14:57 | |
| dtantsur | mordred: I'm going to check out the strange bright yellow object on the sky right now, will check once I'm back | 15:00 |
| *** dtantsur is now known as dtantsur|brb | 15:00 | |
| mordred | dtantsur|brb: we have that object here all the time - some days it's missing and those are weird | 15:01 |
| sshnaidm | the meeting is now, right? | 15:02 |
| sshnaidm | dst etc | 15:02 |
| sshnaidm | #startmeeting ansible-sig | 15:02 |
| openstack | Meeting started Tue Mar 17 15:02:33 2020 UTC and is due to finish in 60 minutes. The chair is sshnaidm. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:02 |
| *** openstack changes topic to " (Meeting topic: ansible-sig)" | 15:02 | |
| openstack | The meeting name has been set to 'ansible_sig' | 15:02 |
| sshnaidm | who is available today? | 15:03 |
| sshnaidm | mordred, dtantsur|brb tremble cloudnull | 15:03 |
| mordred | o/ | 15:03 |
| sshnaidm | hope all are safe an healthy and can join today | 15:04 |
| sshnaidm | and I hope I didn't mess up with timezones and dst | 15:04 |
| mordred | sshnaidm: dtantsur|brb is looking at the yellow dot in the key for a minute | 15:04 |
| mordred | sshnaidm: if you did I did too :) | 15:04 |
| sshnaidm | seems like good job to do in a lockdown :) | 15:04 |
| mordred | :) | 15:04 |
| sshnaidm | ok, so while people are coming... | 15:05 |
| sshnaidm | mordred, let's take the renaming topic? | 15:05 |
| sshnaidm | mordred, just did today a few tests with various ansible versions | 15:05 |
| sshnaidm | and seems like 2.9 users should rename modules if they want to use collection over 2.9 built-in modules | 15:06 |
| sshnaidm | the question is how is that important and critical | 15:06 |
| sshnaidm | and if so, can it be workarounded with symlinks or kind of..? | 15:06 |
| mordred | sshnaidm: so - I'm going to make a different argument there - which is that i do not think we should support pre-2.10 users in any way | 15:07 |
| noonedeadpunk | o/ | 15:07 |
| sshnaidm | mordred, why? | 15:08 |
| mordred | collections is how we deliver these modules to >=2.10 | 15:08 |
| mordred | if you're using 2.9, you are getting the modules from ansible | 15:08 |
| mordred | and we're already supporting you there | 15:08 |
| sshnaidm | mordred, well, usually yes, but there are no chances to use new features or merge fixes to 2.8/2.9 | 15:08 |
| mordred | gundalow: ^^ this might be a topic you have thoughts or feelings on | 15:08 |
| mordred | sshnaidm: that's right - but this has been true for all of ansible - we're fixing it with collections - but it's a new feature of 2.10 | 15:09 |
| sshnaidm | mordred, collections are in use from 2.8 including | 15:09 |
| mordred | oh? | 15:09 |
| sshnaidm | mordred, and in general there are no limitations to use them from 2.8 | 15:09 |
| mordred | ok - maybe I'm wrong here then | 15:09 |
| sshnaidm | mordred, yeah, you can easily use them, just configuring openstack.cloud.os_server etc | 15:10 |
| mordred | so people with ansible 2.8 can do ansible-galaxy collection install openstack and then put openstack.cloud.blah in their playbook and it all works? | 15:10 |
| mordred | cool | 15:10 |
| sshnaidm | mordred, yep | 15:10 |
| mordred | ok - then I agree - we should test 2.8 and 2.9 too :) | 15:10 |
| sshnaidm | mordred, that's why I do these 2.8 2.9 jobs :) | 15:10 |
| mordred | kk. I understand and agree now then :) | 15:10 |
| sshnaidm | mordred, great | 15:10 |
| mordred | (I still disagree on the mechanism - but that's just code-review :) ) | 15:11 |
| sshnaidm | mordred, so back to renaming though, and how it affects (if does) | 15:11 |
| mordred | yeah ... so - here's my thing | 15:11 |
| mordred | (and I might be wrong on this too obvs) | 15:11 |
| sshnaidm | mordred, yeah, I'm mostly trying there, would be glad for ideas in jobs | 15:11 |
| mordred | if you're installing collection yourself, you already need to add openstack.cloud into the name in your playbook - so it's no different to do openstack.cloud.server vs openstack.cloud.os_server | 15:12 |
| mordred | it's a change either way | 15:12 |
| mordred | for people using just os_server via ACD - the routing.yml is the thing that's making that work | 15:12 |
| mordred | and since that lets us point os_server -> openstack.cloud.server - I see no reason for us to keep the os_ prefix on our module names | 15:13 |
| mordred | is there something else we should be worried about? | 15:13 |
| mordred | https://github.com/ansible/ansible/pull/68215/files <-- change to the routing.yml in ansible/ansible FTR | 15:13 |
| sshnaidm | mordred, first thing that I didn't like, first case in http://paste.openstack.org/show/790784/ | 15:14 |
| sshnaidm | mordred, when you set up collection in playbook level | 15:14 |
| sshnaidm | mordred, then you override system modules by collection one | 15:14 |
| mordred | ah - nod. | 15:14 |
| mordred | so - I mean - maybe don't do that? :) | 15:15 |
| sshnaidm | and instead of system "user" we run actually os_user | 15:15 |
| sshnaidm | mordred, well, yeah.. but interesting how many people will yell :) | 15:15 |
| mordred | I mean - I guess it's maybe just me - but it seems to be a real shame to introduce namespacing and then still pretend it's not there and keep the modules in the namespace behaving as if there is a single global namespace | 15:16 |
| mordred | a user is also really unlikely to have a single play where they are making a local os level user and an openstack user too ... and if they had one of those, doing collection: openstack.cloud on that play seems like a bad practice? | 15:17 |
| mordred | but - I mean - I hear you ... so I think this is a good one to get other input | 15:17 |
| sshnaidm | mordred, I'm just not comfortable with such a ambiguity, what module will run | 15:17 |
| mordred | I'm still in favor of renaming and warning people - but I won't revolt if everyone else thinks it's too much | 15:17 |
| sshnaidm | and I suspect users can surprise us | 15:17 |
| sshnaidm | mordred, maybe we can rename modules but prevent names overlapping with core modules? | 15:18 |
| mordred | I mean - it's _not_ abiguous. the user said "collection: openstack.cloud" - they get openstack.cloud.user | 15:18 |
| mordred | hrm | 15:18 |
| mordred | that's maybe a good compromise | 15:18 |
| mordred | is it anything other than user that's an issue? | 15:18 |
| sshnaidm | mordred, yeah, and I don't think we have a lot of such.. can't think now about others | 15:19 |
| sshnaidm | maybe it's only user | 15:19 |
| mordred | so - we could call that one keystone_user and still be within the scope of sanity | 15:19 |
| mordred | (it's mostly an admin thing to use anyway) | 15:19 |
| sshnaidm | mordred, and "group" | 15:19 |
| sshnaidm | mordred, yeah, seems like a plan | 15:20 |
| sshnaidm | mordred, also it's more explaining, like which user exactly | 15:20 |
| mordred | yeah. same - keystone_group - maybe we should name project keystone_project too - just for consistency for people doing a lot of keystone things? | 15:21 |
| sshnaidm | mordred, yep | 15:21 |
| sshnaidm | also coming back to best naming of modules | 15:21 |
| sshnaidm | mordred, not only removing os_ | 15:21 |
| sshnaidm | but have them "service" based? | 15:22 |
| mordred | well - I think we should mostly avoid that | 15:22 |
| sshnaidm | I think we talked with dtantsur|brb about that | 15:22 |
| mordred | (except for when something like keystone makes it make more sense) | 15:22 |
| mordred | biggest example of why is floating_ip | 15:22 |
| sshnaidm | mordred, it may make sense if there is only one service responsible for that | 15:23 |
| mordred | it started life as a nova resource and is now a neutron resources - the end user doesn't care either way and our module works with both | 15:23 |
| sshnaidm | yeah, agree | 15:23 |
| mordred | so - in general - the service name doesn't tend to add much value | 15:23 |
| mordred | but - there's definitely times when it's better | 15:23 |
| sshnaidm | I think we wanted to rename ironic to "baremetal"? | 15:24 |
| mordred | we might just have to make group judgement calls :) | 15:24 |
| mordred | ah - yeah | 15:24 |
| sshnaidm | mordred, yeah, totally | 15:24 |
| mordred | hrm | 15:24 |
| mordred | should we do identity_user instead of keystone user? | 15:24 |
| sshnaidm | I don't know if there are other services manage identities | 15:25 |
| sshnaidm | could be such? | 15:25 |
| sshnaidm | if yes, then maybe identity_user is better | 15:26 |
| sshnaidm | or project_user | 15:26 |
| mordred | well, project_user wouldn't be quite right - because you need to map a user to a project with a role | 15:26 |
| sshnaidm | well, naming stuff may take the whole day, I'd propose to get more people involved in your review and decide there | 15:27 |
| mordred | yeah. and I agree - we can make comments on individual renames and get specific ones (like user) migrated to what we want it to be | 15:27 |
| mordred | and then I'll update that ansible PR once we're happy | 15:27 |
| sshnaidm | if we are good with 2.9/2.8 users to be more careful, I'm fine with renaming | 15:28 |
| sshnaidm | mordred, yeah, agree | 15:28 |
| sshnaidm | mordred, and more careful I mean the third case: http://paste.openstack.org/show/790784/ | 15:28 |
| sshnaidm | when you set openstack.cloud in playbook level but still use "os_user" | 15:29 |
| sshnaidm | you'll get your old 2.9 module, not from collection | 15:29 |
| sshnaidm | but this seems to me like a pure misconfiguration issue | 15:29 |
| mordred | yeah - that one I think is on them | 15:29 |
| mordred | yup | 15:29 |
| mordred | you opted in to the new thing - you took action - and then you did it wrong | 15:30 |
| mordred | (also - the old os_usr will probably still work anyway :) ) | 15:30 |
| sshnaidm | yeah, mostly | 15:30 |
| mordred | so it would only be an issue if they're trying to get a new feature - so they'd hopefully figure it out | 15:30 |
| sshnaidm | mordred, yep, agree | 15:30 |
| sshnaidm | ok, so we're cool with that I think | 15:30 |
| sshnaidm | moving on | 15:31 |
| sshnaidm | jobs matrix that I'm working on it currently | 15:31 |
| mordred | yeah- so - I'll update my most recent comments there based on this | 15:31 |
| sshnaidm | are any objection to support 2.8, 2.9, devel on openstacksdk from rocky? | 15:31 |
| sshnaidm | mordred, cool | 15:31 |
| sshnaidm | mordred, I'll take a look at siblings, wasn't familiar with it | 15:32 |
| mordred | well - one facet | 15:32 |
| mordred | sshnaidm: it's the magic that handles "I want to install this dependency from source" | 15:32 |
| mordred | just requires the project in question be in required-projects | 15:32 |
| mordred | sshnaidm: I pushed up https://review.opendev.org/#/c/713461/ as a stab at reworking what we have now a little bit - it might be a good example to build your matrix on | 15:33 |
| sshnaidm | great, it's what I was looking for.. | 15:33 |
| *** priteau has joined #openstack-ansible-sig | 15:33 | |
| sshnaidm | mordred, ack | 15:33 |
| mordred | sshnaidm: so - one thing on the matrix | 15:33 |
| mordred | nah - nevermind. let's see how it goes :) | 15:34 |
| sshnaidm | mordred, btw, about 2.8 - we need 2.9 minimum to build and install the connection, you can't do it with 2.8 but you can USE collection with 2.8 | 15:34 |
| sshnaidm | mordred, so 2.8 is kinda special case | 15:34 |
| mordred | JEEZ | 15:34 |
| sshnaidm | nice, ah | 15:34 |
| mordred | so - maybe ... | 15:34 |
| mordred | maybe it's not super important to test with 2.8 directly - we're not really doing things where ansible internals changes should impact us at all | 15:34 |
| mordred | so maybe just testing that our collection works with 2.9 is good enough to test that the concept of pre-2.10 is working | 15:35 |
| mordred | broadly we also need to test sdk against 2.8 and 2.9 - because that's a combo that users will hit - but that's not a collections thing | 15:35 |
| sshnaidm | mordred, maybe, but we use it heavily in tripleo, especially in train, and I wanted to be covered there in case we'll want to use collections in train | 15:36 |
| sshnaidm | mordred, I mean 2.8 | 15:36 |
| sshnaidm | mordred, I will add job for each stable branch in openstacksdk when they're ready | 15:36 |
| mordred | nod. ok. well - it'll be "fun" to get that built | 15:36 |
| mordred | oh - you know what? | 15:36 |
| mordred | this is actually going to be easy :) | 15:36 |
| mordred | the tox -ebuild command builds the collection - but it's something called in the ci setup script | 15:37 |
| mordred | it knows nothing about siblings | 15:37 |
| mordred | (because it's not the zuul role invoking tox) | 15:37 |
| mordred | so it'll build even for 2.8 | 15:37 |
| mordred | using latest ansible release - which is good | 15:38 |
| sshnaidm | mordred, it installs requirements from test-requirements.txt | 15:38 |
| sshnaidm | and we have ansible there | 15:38 |
| mordred | yup | 15:38 |
| sshnaidm | mordred, but wouldn't this "ansible" in test-requirements.txt conflict with "siblings"? | 15:38 |
| mordred | nopt | 15:38 |
| mordred | it's a completely different virtualenv | 15:38 |
| mordred | it's actually just going to DTRT | 15:38 |
| sshnaidm | great, then it will be easier | 15:39 |
| mordred | oh - so - the siblings code needs ansible to be in test-requirements - it doesn't install _everything_ in required-projects - only things that the project's tox would have installed naturally without siblings | 15:39 |
| sshnaidm | mordred, because ansible-test for linting is also available from 2.9 at least | 15:39 |
| mordred | the idea is that you acn have a tox setup that expresses real release depends | 15:39 |
| mordred | but then have zuul jobs that test that against source checkouts too | 15:40 |
| mordred | yeah - I think we can just do linting with latest - it'll be the most comprehensive | 15:40 |
| mordred | so you don't need the stable-2.9 in those jobs | 15:41 |
| sshnaidm | mordred, so, should I add "openstack" to test-requirements.txt as well? | 15:41 |
| mordred | openstacksdk | 15:41 |
| mordred | yes - but I did that in mine | 15:41 |
| mordred | sshnaidm: I'll go back through and re-review your patch and try to point out some better/easier ways to accomplish what you're trying to do | 15:42 |
| mordred | now that I fully understand :) | 15:42 |
| sshnaidm | cool, thanks a lot | 15:42 |
| sshnaidm | also need to reduce duplications with jobs parenting, but this I know to do :) | 15:43 |
| sshnaidm | great, so we're good on this too | 15:43 |
| sshnaidm | any other issues, questions, topics | 15:43 |
| mordred | woot! omg - a useful meeting | 15:43 |
| mordred | that almost never happens :) | 15:43 |
| sshnaidm | yeah! | 15:44 |
| sshnaidm | that's how meetings should be done :) | 15:44 |
| sshnaidm | point to think about it in a virtual summit :) | 15:44 |
| mordred | yeah. ugh | 15:45 |
| sshnaidm | ok, so if no topics, we are fine | 15:45 |
| mordred | stupid virus | 15:45 |
| sshnaidm | #endmeeting | 15:45 |
| *** openstack changes topic to "OpenStack Ansible SIG | https://etherpad.openstack.org/p/ansible-sig" | 15:45 | |
| openstack | Meeting ended Tue Mar 17 15:45:22 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:45 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-03-17-15.02.html | 15:45 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-03-17-15.02.txt | 15:45 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-03-17-15.02.log.html | 15:45 |
| sshnaidm | mordred, yeah, I don't believe summit will happen in June.. even if it disappears in May | 15:45 |
| mordred | sshnaidm: you may want to check out https://review.opendev.org/#/q/status:open+project:openstack/ansible-collections-openstack+branch:master+topic:sanity/mass-clean-1 | 15:45 |
| gundalow | sshnaidm: mordred I personally view collections as an Ansible 2.10 or newer. If you want new shiny features use ansible-base 2.10 and the OS collection | 15:46 |
| mordred | sshnaidm: we should probably land that one before I respin the renaming patch just to reduce conflicts (I haven't reviewed it yet - I just know it'll conflict) | 15:46 |
| sshnaidm | mordred, yeah, this is really *mass* clean | 15:47 |
| sshnaidm | will look today and if it's ok, let's merge it asap.. | 15:47 |
| sshnaidm | gundalow, well, I think we still can use it from 2.8 if we're locked for a specific ansible version for some reason | 15:48 |
| sshnaidm | gundalow, like release deps.. | 15:48 |
| sshnaidm | our modules fortunately don't use a lot of ansible core stuff | 15:49 |
| sshnaidm | and mostly independent | 15:49 |
| gundalow | If you want to use the collection with Ansible 2.9 or older I believe you'll need to use the FQCN. Also there will no doubt be bug fixes on Ansible that don't make it into ansible/ansible:stable-2.8 | 15:50 |
| mordred | tremble: +A but with some inline comments in https://review.opendev.org/#/c/713255/ - things we can handle in a followup I think | 15:52 |
| mordred | sshnaidm, dtantsur|brb: ^^ see that one - good question from dtantsur|brb about setting a min version of sdk everywhere | 15:53 |
| sshnaidm | gundalow, ack, that's why we test it with 2.8 in CI :) | 15:55 |
| sshnaidm | mordred, it would be nice, yeah, although will require some work to check what is supported where | 15:56 |
| tremble | mordred, Ack my general approach was to change as little as possible, but ensure the documentation matches the specs. | 15:56 |
| sshnaidm | tremble, great work on the modules | 15:59 |
| mordred | totally. I think for the next one I agree with dtantsur|brb - let's go ahead and "change the behavior" and update it to bool (can be done in a followup) - because non-bool string values are going to be broken anyway, so it's not really a break | 15:59 |
| mordred | but yeah - this is all really good stuff - thank you | 15:59 |
| tremble | mordred, I'm happy to do a second pass and tweak things like the 'bools' that aren't currently 'bools' (which dtantsur picked up on), to make things easier to follow (they're monster patches) I'd prefer to make the bool-changes in a follow-up change | 16:00 |
| mordred | tremble: ok. I'll switch that vote to a +2 then | 16:01 |
| tremble | Right now I'm working on the net-new module that I actually need for work, time and energy dependent I'll look into the bool bits this evening. | 16:04 |
| mordred | cool. | 16:05 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 16:21 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Update os_client_config to use openstacksdk https://review.opendev.org/713480 | 16:21 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Move default availability_zone docs into doc_fragment https://review.opendev.org/713254 | 16:37 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Fix doc requirements, and consistently require python 3.6+ https://review.opendev.org/713255 | 16:38 |
| *** dtantsur|brb is now known as dtantsur | 16:40 | |
| *** priteau has quit IRC | 17:12 | |
| *** evrardjp has quit IRC | 17:35 | |
| *** evrardjp has joined #openstack-ansible-sig | 17:36 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Add missing type information to docs https://review.opendev.org/713256 | 17:39 |
| *** gshippey has quit IRC | 17:40 | |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Update os_client_config to use openstacksdk https://review.opendev.org/713480 | 17:42 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 17:42 |
| mordred | dtantsur, sshnaidm: ^^ had to rebase due to conflict | 17:42 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Clean up doc-required-mismatch https://review.opendev.org/713257 | 17:52 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Ensure defaults match spec https://review.opendev.org/713258 | 17:52 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Use dict rather than complex for os_quota return type. https://review.opendev.org/713259 | 17:52 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Ensure documented choices match spec https://review.opendev.org/713260 | 17:52 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Fixup elements related sanity failures https://review.opendev.org/713261 | 17:52 |
| dtantsur | mordred: gerrit shows "cannot merge" on https://review.opendev.org/#/c/713480/ for me | 17:59 |
| dtantsur | I'll get back to all this stuff tomorrow | 17:59 |
| *** dtantsur is now known as dtantsur|afk | 17:59 | |
| mordred | dtantsur|afk: cool. hopefully it'll be in steady state by then | 18:03 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Update os_client_config to use openstacksdk https://review.opendev.org/713480 | 18:36 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Cleanup functional tests https://review.opendev.org/713461 | 18:36 |
| *** openstackgerrit has quit IRC | 19:33 | |
| *** noonedeadpunk has quit IRC | 22:29 | |
| *** noonedeadpunk has joined #openstack-ansible-sig | 22:31 | |
| *** holser has quit IRC | 22:56 | |
| *** holser has joined #openstack-ansible-sig | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!