Thursday, 2021-03-25

*** uzumaki has quit IRC00:10
airship-irc-bot1<rishabh.k.jain> Hi Team, I have got 2 baby ps for review. Fixes max width in airship/read the docs theme: https://review.opendev.org/c/airship/airshipctl/+/782597 Updated (caopd )Docker Provider Documentation: https://review.opendev.org/c/airship/airshipctl/+/777210 Thank you !02:19
airship-irc-bot1<kk6740> for those who review @rishabh.k.jain patchset with doc site changes: Please make sure that your browser correctly displays documents site. You can do so using following instructions: 1) go to zuul vote comment in patchset https://review.opendev.org/c/airship/airshipctl/+/782597 2) click openstack-tox-docs job 3) go to artifacts tab 4) click preview site at the bottom02:33
*** uzumaki has joined #airshipit08:33
*** muhaha has joined #airshipit09:58
*** francisy has quit IRC11:05
airship-irc-bot1<ak3216> Good day, everyone. I've noticed something recent with the Airshipbot where an issue is getting closed on a patchset merge & almost immediately reopened. https://github.com/airshipit/airshipctl/issues/485 & https://github.com/airshipit/airshipctl/issues/482 are examples. One thing I've noticed is the commit messages in both of the patchsets for these issues have both "Related-To:" & "Closes:" tags which is making me think the bot is11:21
airship-irc-bot1processing both of them & if the "Relates-To:" gets processed 2nd, it causes the issue to be reopened. I don't know if anything can be done with the bot. If not, then perhaps the commit messages should contain either "Relates-To:" or "Closes:" when it's for one issue but not both.11:21
airship-irc-bot1<ak3216> Well, I may have spoken, too soon. https://github.com/airshipit/airshipctl/issues/419 is another one yesterday that closed & then reopened, but the patchset commit message only has "Closes:" So, there may be more of a general issue with the bot, and not just a tagging thing.11:28
*** muhaha has quit IRC11:35
*** muhaha has joined #airshipit13:22
airship-irc-bot1<sb464f> can i get some reviews on this please -> https://review.opendev.org/c/airship/airshipctl/+/78259114:10
*** uzumaki has quit IRC15:08
*** roman_g has joined #airshipit15:59
*** uzumaki has joined #airshipit16:01
*** muhaha has quit IRC16:14
airship-irc-bot1<ashlee> @joseph.kamula Thanks for reaching out about contributing! Please meet @mattmceuen and @james.gu, who will be able to get you started.16:44
airship-irc-bot1<mattmceuen> Hey @joseph.kamula, welcome!  Ashlee let me know that you're interested in contributing some documentation?  That would be really great.  @james.gu and @mf4716 are coordinating several documentation efforts at the moment, and we have more planned for our 2.1 release.  If you can give us a bit of an idea what you're interested in, we can help get you tied into it16:48
airship-irc-bot1<mattmceuen> We have our bi-weekly IRC/Slack team meeting next Tuesday too, and could have a deeper dive discussion if that would be helpful16:49
airship-irc-bot1<sb464f> @Team created an issue in airshipctl for capm3 v0.4.0-> https://github.com/airshipit/airshipctl/issues/50117:17
*** mugsie has quit IRC17:20
*** jhesketh has quit IRC17:20
*** anticw has quit IRC17:20
*** airship-irc-bot1 has quit IRC17:20
*** mugsie has joined #airshipit17:20
*** airship-irc-bot has joined #airshipit17:20
*** anticw has joined #airshipit17:20
*** jhesketh has joined #airshipit17:20
*** v1k0d3n has quit IRC17:42
*** aprice has quit IRC17:42
*** thansen has quit IRC17:42
*** Anticimex has quit IRC17:42
*** spy has quit IRC17:42
*** ildikov has quit IRC17:42
*** lamt has quit IRC17:42
*** lemko has quit IRC17:42
*** portdirect has quit IRC17:42
*** jemangs has quit IRC17:42
*** alanmeadows has quit IRC17:42
*** phrobb has quit IRC17:42
*** thansen has joined #airshipit17:42
*** Anticimex has joined #airshipit17:42
*** spy has joined #airshipit17:43
*** parallax has quit IRC17:45
*** parallax has joined #airshipit17:48
*** jhesketh has quit IRC17:52
*** jhesketh has joined #airshipit17:52
airship-irc-bot<sean.eagan> please review (for 2.0 release): https://review.opendev.org/c/airship/airshipctl/+/78285917:56
*** mnaser has quit IRC17:57
*** dasp_ has quit IRC17:58
*** donnyd has quit IRC17:58
*** vdrok has quit IRC17:58
*** mattmceuen has quit IRC17:58
*** iamweswilson has quit IRC17:58
*** rpioso has quit IRC17:58
*** srwilkers has quit IRC17:58
*** mnaser has joined #airshipit17:58
*** dasp has joined #airshipit17:58
*** vdrok has joined #airshipit17:58
*** donnyd has joined #airshipit17:58
*** iamweswilson has joined #airshipit17:58
*** rpioso has joined #airshipit17:58
*** srwilkers has joined #airshipit17:58
*** mattmceuen has joined #airshipit17:58
*** openstack has joined #airshipit18:02
*** ChanServ sets mode: +o openstack18:02
*** dasp has quit IRC18:03
*** megheisler has quit IRC18:03
*** jayahn has quit IRC18:03
*** donnyd has quit IRC18:03
*** iamweswilson has quit IRC18:03
*** parallax has quit IRC18:03
*** dasp has joined #airshipit18:04
*** openstackstatus has joined #airshipit18:04
*** ChanServ sets mode: +v openstackstatus18:04
*** jayahn has joined #airshipit18:04
*** iamweswilson has joined #airshipit18:04
*** donnyd has joined #airshipit18:04
*** parallax has joined #airshipit18:04
*** megheisler has joined #airshipit18:04
*** donnyd has quit IRC18:05
*** iamweswilson has quit IRC18:05
*** parallax has quit IRC18:05
*** iamweswilson has joined #airshipit18:05
airship-irc-bot<kk6740> @sb464f would the solution be to add labeling back?18:06
airship-irc-bot<kk6740> easiest one18:06
*** gagehugo has quit IRC18:06
*** gagehugo has joined #airshipit18:06
*** donnyd has joined #airshipit18:06
airship-irc-bot<sb464f> i mean adding label back will be as a workaround, as I guess we don’t want to annotate with pause label. I created this issue to track work for capm3.18:08
airship-irc-bot<sb464f> @mattmceuen18:08
airship-irc-bot<kk6740> we dont want, but i am wondering if that is going to help18:09
airship-irc-bot<kk6740> do u know why it is being restarted?18:10
airship-irc-bot<kk6740> i know it sounds like a stupid question :slightly_smiling_face:18:10
airship-irc-bot<sb464f> i think it’s because we are re applying. I guess it not only issue with one node. even after all three nodes are provisioned and we re apply the bmh object I guess three nodes will restart.18:11
airship-irc-bot<sb464f> if there is no pause label.18:12
airship-irc-bot<sb464f> and if we add pause label the status is not getting moved from ephemeral to target cluster.18:12
*** parallax has joined #airshipit18:13
*** ildikov has joined #airshipit18:14
*** anticw has quit IRC18:16
*** airship-irc-bot has quit IRC18:16
*** mugsie has quit IRC18:16
*** uzumaki has quit IRC18:16
*** roman_g has quit IRC18:16
*** irclogbot_2 has quit IRC18:16
*** jbryce has quit IRC18:16
*** mugsie has joined #airshipit18:16
*** airship-irc-bot has joined #airshipit18:17
airship-irc-bot<sb464f> the single target node.  but i guess even if we deploy all nodes and we re run target-control plane phase i guess all three nodes restart.18:18
airship-irc-bot<sb464f> i can quickly verify on that now.18:18
airship-irc-bot<mattmceuen> Yeah it would be good to see what happens -- if they restart all at once, then it won't help, but if they to a rolling restart that would probably help18:19
*** irclogbot_2 has joined #airshipit18:20
*** anticw has joined #airshipit18:21
*** roman_g has joined #airshipit18:35
airship-irc-bot<sb464f> okay just tested I have all three bmh in provisioned state ``` k get bmh NAME          STATUS   PROVISIONING STATUS   CONSUMER                       BMC                                                                  HARDWARE PROFILE   ONLINE   ERROR au4txrsv149   OK       provisioned           cluster-controlplane-jwsh5     redfish+https://xx.xx.xx.xx/redfish/v1/Systems/System.Embedded.1   unknown            true      au4txrsv15018:36
airship-irc-botOK       provisioned           cluster-controlplane-2-f6pcz   redfish+https://xx.xx.xx.xx/redfish/v1/Systems/System.Embedded.1   unknown            true      au4txrsv151   OK       provisioned           cluster-controlplane-2-9cpw9   redfish+https://xx.xx.xx.xx/redfish/v1/Systems/System.Embedded.1   unknown            true     ``` I re applied `controlplane-target` and all three nodes got restarted.18:36
airship-irc-bot<mattmceuen> at the same time?18:36
airship-irc-bot<sb464f> yes18:36
airship-irc-bot<mattmceuen> boo18:36
airship-irc-bot<mattmceuen> for our workaround, can we apply the label, deploy the rest of the CP, and then remove the label?18:37
airship-irc-bot<mattmceuen> thanks for trying it btw18:37
airship-irc-bot<sb464f> NP :slightly_smiling_face:,  i mean if we remove the label it is fine but here the issue is we will never be able to reapply a bmh object once it is provisioned.18:38
airship-irc-bot<sb464f> I guess earlier it was not the case in older versions.18:39
airship-irc-bot<mattmceuen> Yeah, it sure sounds like a bug we need to fix18:39
airship-irc-bot<mattmceuen> (I mean a bug that metal3 needs to fix :slightly_smiling_face: )18:39
airship-irc-bot<mattmceuen> and in the meantime, we might have to sequence any BMH updates ourselves -- apply a BMH, wait, repeat18:40
airship-irc-bot<sb464f> yeah. I can add back the pause label now give me 2 mins.18:41
airship-irc-bot<sb464f> https://review.opendev.org/c/airship/airshipctl/+/78308218:46
airship-irc-bot<sb464f> this msg from airshipctl when not able to reach apiserver `server sent GOAWAY and closed the connection`  :-)18:49
airship-irc-bot<mattmceuen> rude18:50
airship-irc-bot<mattmceuen> Yeah I remember that meesage -- IIRC, GOAWAY should not be interpreted as an error, and instead should be considered "try again later"18:51
airship-irc-bot<mattmceuen> If that's right, maybe we can add some smarter handling into airshipctl18:51
*** roman_g has quit IRC18:55
airship-irc-bot<kk6740> i remember we had some labeling code in airshipctl cluster-move19:40
airship-irc-bot<kk6740> done by @awander19:40
airship-irc-bot<rishabh.k.jain> Hi Team, I have got 2 baby ps for review. Updated (capd ) Docker Provider Documentation: https://review.opendev.org/c/airship/airshipctl/+/777210 Changed default worker count in capd : https://review.opendev.org/c/airship/airshipctl/+/782608 Thank you!19:45
*** roman_g has joined #airshipit20:00
airship-irc-bot<niha.twinkle> Hi Team, Requesting for reviews on this PS related to phase list cmd https://review.opendev.org/c/airship/airshipctl/+/769392 https://review.opendev.org/c/airship/airshipctl/+/76925120:08
airship-irc-bot<sidney.shiba> [*V2.0 Priority*] ready for review: https://review.opendev.org/c/airship/images/+/78258320:12
airship-irc-bot<sreejith.punnapuzha> Team, can i get a review on these one line ps? https://review.opendev.org/c/airship/treasuremap/+/783086 -> ps to align manifest directory in treasuremap https://review.opendev.org/c/airship/airshipctl/+/783087 -> ps to provide permission for pip installation21:34
*** roman_g has quit IRC23:49

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!