| airship-irc-bot | <awander> @sb464f What exactly does "reapply" do? It sounds like you want to patch an existing BMH, if so what are the changes? Changes to BMH will cause reconcile to happen which *may* trigger a reprovision. Using the `baremetalhost.metal3.io/paused` annotation will only temporarily prevent reconcile from moving forward, when remove the pause it will continue. | 00:58 |
|---|---|---|
| *** vdrok has quit IRC | 07:05 | |
| *** vdrok has joined #airshipit | 07:06 | |
| *** roman_g has joined #airshipit | 07:39 | |
| *** roman_g has quit IRC | 10:07 | |
| *** roman_g has joined #airshipit | 13:35 | |
| airship-irc-bot | <mattmceuen> We should get this layering documentation merged before the v2.0 release please -- there's more that can be added, but I'd like to get what exists already in for the release (and this patchset is sooo old :slightly_smiling_face: ) https://review.opendev.org/c/airship/docs/+/745974 | 14:26 |
| airship-irc-bot | <sb464f> @awander not patching existing bmh. all three control nodes are active and deployed. if I re run `controlplane-target` phase all three nodes getting restarted. | 14:34 |
| airship-irc-bot | <awander> What does `controlplane-target` do? | 14:35 |
| airship-irc-bot | <awander> If you're updating the KCP object, that may also trigger it. | 14:37 |
| airship-irc-bot | <niha.twinkle> Hi All, Could you please review this PS related to phase list cmd , need one more +2 for the following https://review.opendev.org/c/airship/airshipctl/+/769392 https://review.opendev.org/c/airship/airshipctl/+/769251 | 14:39 |
| airship-irc-bot | <ao129q> May I have review on please https://review.opendev.org/c/airship/airshipctl/+/783141 | 15:03 |
| airship-irc-bot | <mattmceuen> @kk6740 @dwalt @sreejith.punnapuzha Andrii's change would be good to get your eyes on too, it's a big change to how we plumb in the isoURL. I think it probably makes sense, but want to make sure we land on the simplest possible good solution | 15:12 |
| airship-irc-bot | <kk6740> @ao129q @mattmceuen so by default it is going to use whatever we have in here https://review.opendev.org/c/airship/airshipctl/+/783141/8/manifests/phases/executors.yaml#202 | 15:17 |
| airship-irc-bot | <kk6740> and someone specified env variable ISO_URL it is going to be pull it from there? | 15:18 |
| airship-irc-bot | <ao129q> could you elaborate on your question please? in airshipctl gates we still use a catalogue value | 15:21 |
| airship-irc-bot | <awander> @sb464f looking at `airshipctl/manifests/site/test-site/target/controlplane` I see that BareMetalHosts are being created and applied. | 15:21 |
| airship-irc-bot | <ao129q> i'm looking now if i can use approach @mattmceuen suggested in his review | 15:22 |
| airship-irc-bot | <kk6740> Which value would be used if ISO_URL is not defined | 15:22 |
| airship-irc-bot | <awander> Maybe I'm missing something but if the control planes are already active and deployed, what is `controlplane-taget` suppose to do? | 15:22 |
| airship-irc-bot | <ao129q> https://review.opendev.org/c/airship/airshipctl/+/783141/8/manifests/site/test-site/phases/catalogue.yaml | 15:22 |
| airship-irc-bot | <awander> LMK if you need help debugging this on the side. | 15:22 |
| airship-irc-bot | <sb464f> @awander controlplna-target applied kcp and bmh objects. This is after applying again without any change. | 15:25 |
| airship-irc-bot | <kk6740> Ok, this looks good. my only concern is that user may have hard time understanding which takes precedence env ISO_URL or variable catalog | 15:25 |
| airship-irc-bot | <kk6740> so if you could add comments about this both to variable catalog and the template, it would be great | 15:26 |
| airship-irc-bot | <awander> @sb464f see my comments above. if we're doing a reapply without any changes, then we need to make certain there are no changes. | 15:27 |
| airship-irc-bot | <awander> It would be good to compare the existing BMH to the one generated by controlplane-target | 15:28 |
| airship-irc-bot | <mattmceuen> Yeah agree. I'm not insisting on the env-vars catalogue, but if using that helps make it more understandable that would be good | 15:28 |
| airship-irc-bot | <mattmceuen> And this will have an impact on other site definitions as well, so it would need to be followed up with changes to treasuremap and downstream repos, right? | 15:29 |
| airship-irc-bot | <sb464f> Hi Arvinder, do you want to join a bridge I can explain what’s happening. | 15:30 |
| airship-irc-bot | <ao129q> @mattmceuen I agree, if we can utilize env-vars-catalogue it would be neat. though i need some time to evaluate if i can achieve the same behavior | 15:31 |
| airship-irc-bot | <kk6740> ISO_URL also sound a bit generic for global env variable, it would be better to rename it to AIRSHIPCTL_EPHEMERAL_ISO_URL or similar. But this is just a personal preference | 15:31 |
| airship-irc-bot | <ao129q> @mattmceuen yes, eventually, though it's not a breaking change, as i see patch down the road will have a precedence | 15:32 |
| airship-irc-bot | <mattmceuen> ah ok - I see that now, the environment variable is only used if the catalogue substitution is applied; otherwise it is BAU. I had it backwards | 15:33 |
| airship-irc-bot | <mattmceuen> it's "opt in" not "opt out" :slightly_smiling_face: | 15:33 |
| airship-irc-bot | <ao129q> @kk6740 agree. thank you for the suggestion | 15:41 |
| airship-irc-bot | <ao129q> @kk6740 @mattmceuen updated with comments and env var renaming according to your suggestions https://review.opendev.org/c/airship/airshipctl/+/783141 | 16:10 |
| airship-irc-bot | <ao129q> updated commit msg as well.. | 16:15 |
| airship-irc-bot | <ao129q> @ao129q hating PollyGerrit UI commit msg formatting | 16:17 |
| airship-irc-bot | <ma257n> Hello all, looking for additional +2 for https://review.opendev.org/c/airship/treasuremap/+/782473 Thanks in advance. | 17:11 |
| airship-irc-bot | <niha.twinkle> Team, can I get a review on this ps related to plan status cmd https://review.opendev.org/c/airship/airshipctl/+/772890 | 17:42 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!