| *** rezroo has joined #airshipit | 03:50 | |
| *** rezroo has quit IRC | 07:23 | |
| *** parallax has quit IRC | 07:29 | |
| *** parallax has joined #airshipit | 09:53 | |
| airship-irc-bot1 | <ma257n> Hello All, Could you please review https://review.opendev.org/c/airship/treasuremap/+/782473 And i need one more +2 for the following https://review.opendev.org/c/airship/treasuremap/+/775557 and https://review.opendev.org/c/airship/treasuremap/+/778953 Thanks in advance. | 11:29 |
|---|---|---|
| airship-irc-bot1 | <sidney.shiba> Hello core reviewers, could you please review the following PSs aimed for 2.0 release? https://review.opendev.org/c/airship/images/+/782583 https://review.opendev.org/c/airship/treasuremap/+/781172 https://review.opendev.org/c/airship/treasuremap/+/778728 The latter PS is not mine but need it to be merged so https://review.opendev.org/c/airship/treasuremap/+/779413 can move forward the review process. | 14:21 |
| *** SRao has joined #airshipit | 14:59 | |
| airship-irc-bot1 | <james.gu> @mattmceuen @dwalt @alexander.hughes and team, can I have please have some core review's on the PS that is needed by the 2.0 baremetal reference site work: https://review.opendev.org/c/airship/treasuremap/+/781903 | 15:01 |
| airship-irc-bot1 | <kk6740> @james.gu are you installing so many packages unly to use python3 yaml? | 15:04 |
| airship-irc-bot1 | <kk6740> this patchset looks like a hack tbh | 15:05 |
| airship-irc-bot1 | <james.gu> No, the other packages that I found were needed during running the deployment scripts or other commands during deployment on a new build node | 15:09 |
| airship-irc-bot1 | <james.gu> @kk6740 feel free to propose a better way to do it. anything specific that you think is too much a hack? | 15:10 |
| airship-irc-bot1 | <kk6740> `read_yaml()` lets use airshipctl for this. | 15:11 |
| airship-irc-bot1 | <kk6740> airshipctl allows to render documents | 15:12 |
| airship-irc-bot1 | <kk6740> so you can `airshipctl phase render <phase-name> -k BaremetalHost` | 15:12 |
| airship-irc-bot1 | <kk6740> if u point it to the phase in which u are looking for the documents, it will kind all BMH objects for u | 15:13 |
| airship-irc-bot1 | <james.gu> ah, there is a new way of doing it. read_yaml was from AS 1. where will be the output of the phase render command? | 15:15 |
| airship-irc-bot1 | <raliev> moreover, default python yaml package allows only YAML 1.1, 1.2 isn’t supported explicitly | 15:15 |
| airship-irc-bot1 | <kk6740> but the general problem i see, is that you are trying to unhardcode BMH host names, at the same time hardcoding document entrypoints and paths inside the yamls (this is all dynamic information) | 15:17 |
| airship-irc-bot1 | <kk6740> so lets use the airshipctl if we can | 15:18 |
| airship-irc-bot1 | <kk6740> and if not, lets extend it to work, it can be done easily, otherwise you can use a container as well | 15:18 |
| airship-irc-bot1 | <kk6740> but first I need to understand what is needed exactly | 15:18 |
| airship-irc-bot1 | <kk6740> if u have time we can join a call, where u can explain what u are doing | 15:19 |
| airship-irc-bot1 | <james.gu> @kk6740 sure, let me ping you privately for the webex | 15:19 |
| airship-irc-bot1 | <kk6740> thanks | 15:20 |
| *** SRao has quit IRC | 15:54 | |
| airship-irc-bot1 | <ashlee> Hello @channel! We'd really appreciate any company/org running or evaluating Airship taking the brief Airship User Survey to help the community gain knowledge around use cases and plan for future releases. Responses can be designated as public or confidential (shared just within committees and OpenInfra Foundation). Thanks! https://www.surveymonkey.com/r/D5Q3KZ2 | 16:14 |
| *** uzumaki has joined #airshipit | 16:37 | |
| *** uzumaki has quit IRC | 16:41 | |
| *** uzumaki has joined #airshipit | 16:42 | |
| airship-irc-bot1 | <sean.eagan> Please review, needed for AS 2.0: https://review.opendev.org/c/airship/airshipctl/+/767179 | 16:42 |
| airship-irc-bot1 | <mattmceuen> @james.gu @kk6740 were you guys able to determine a path forward on the BM-friendly deployment scripts? +1 to using airshipctl render & avoid YAML paths | 17:16 |
| airship-irc-bot1 | <james.gu> yes, will use the airshipctl render. working on a newer version | 17:16 |
| airship-irc-bot1 | <mattmceuen> awesome - ty | 17:19 |
| *** SRao has joined #airshipit | 17:55 | |
| *** SRao has quit IRC | 17:58 | |
| airship-irc-bot1 | <mf4192> Hi team, a couple of small changes are ready for review. These simply amend the README in the `v2` and `master` branches of Treasuremap with info about the upcoming changes to the branching structure: https://review.opendev.org/c/airship/treasuremap/+/782601 | 19:07 |
| airship-irc-bot1 | <mf4192> https://review.opendev.org/c/airship/treasuremap/+/782604 | 19:07 |
| *** uzumaki has quit IRC | 19:20 | |
| airship-irc-bot1 | <sreejith.punnapuzha> Team, can i get a review on this commit? https://review.opendev.org/c/airship/treasuremap/+/782590 -> this is to align treasuremap with airshipctl. this fixed iso build failure issue on treasuremap | 19:24 |
| airship-irc-bot1 | <kk6740> @sreejith.punnapuzha could you explain why is it needed? :slightly_smiling_face: | 19:30 |
| airship-irc-bot1 | <kk6740> is it referenced somewhere? | 19:31 |
| airship-irc-bot1 | <sreejith.punnapuzha> The empty folder and kustomization file was added in airshipctl as part of this PS. https://review.opendev.org/c/airship/airshipctl/+/774350. Currently treasuremap iso build is failing with the error that its not able to find empty folder | 19:34 |
| airship-irc-bot1 | <sreejith.punnapuzha> ```error creating new loader with git: uri looks like abs path: /home/ubuntu/workspace/development/Treasuremap/TreasuremapV2-AirshipctlMaster/treasuremap/manifests/site/test-site/empty, dir: evalsymlink failure on '/home/ubuntu/workspace/development/Treasuremap/TreasuremapV2-AirshipctlMaster/treasuremap/manifests/site/test-site/empty' : lstat | 19:34 |
| airship-irc-bot1 | /home/ubuntu/workspace/development/Treasuremap/TreasuremapV2-AirshipctlMaster/treasuremap/manifests/site/test-site/empty: no such file or directory, get: invalid source string: /home/ubuntu/workspace/development/Treasuremap/TreasuremapV2-AirshipctlMaster/treasuremap/manifests/site/test-site/empty``` | 19:34 |
| airship-irc-bot1 | <sreejith.punnapuzha> after adding this empty folder and kustomization iso build was successfull | 19:34 |
| *** uzumaki has joined #airshipit | 19:35 | |
| airship-irc-bot1 | <raliev> there will be no empty folder once we fix this bug with Container exec a PS is here https://review.opendev.org/c/airship/airshipctl/+/779638 | 19:35 |
| airship-irc-bot1 | <kk6740> @james.gu can we instead create a change to have one empty folder, and reference it in the container instead? for example in manifests/functions . So that instead of empty entrypoint per site, we would have one `generic` empty entrypoint :slightly_smiling_face: | 19:38 |
| airship-irc-bot1 | <james.gu> @kk6740 did You mean to @sreejith.punnapuzha ? | 19:40 |
| airship-irc-bot1 | <kk6740> oh sorry :slightly_smiling_face: | 19:40 |
| airship-irc-bot1 | <sreejith.punnapuzha> thats great, thanks @raliev i will abandon my commit and wait this your commit is merged | 19:40 |
| airship-irc-bot1 | <sreejith.punnapuzha> *till your commit is merged | 19:40 |
| airship-irc-bot1 | <james.gu> No problemo | 19:41 |
| airship-irc-bot1 | <kk6740> hey @james.gu can you also take a look at this file https://github.com/airshipit/airshipctl/blob/master/tools/gate/00_setup.sh | 20:04 |
| airship-irc-bot1 | <kk6740> i think it installs everything you need | 20:04 |
| airship-irc-bot1 | <ratnopam.chakrabarti> Hi, can I get some core reviews on https://review.opendev.org/c/airship/treasuremap/+/779889. This is about subcluster-networking catalogue. Thanks! | 20:08 |
| airship-irc-bot1 | <james.gu> ah, that's pretty close. but this gate set up script seems to set up ansible which the treasuremap general deployment doesn't use. | 20:12 |
| airship-irc-bot1 | <kk6740> can we instead split it to avoid script dubplication? like install_essentials/install_ansbile… because adding new preparation script may further add problem with treasuremap being out of synch with airshipctl | 20:14 |
| airship-irc-bot1 | <james.gu> I am not sure why the 00_setup.sh didn't have the package install in such separated scripts as yq, jq install in provider_common folder. I agree with what you said about split. But can we do the refactoring later (in 2.1). This PS is badly needed for the baremetal reference site pipeline which is 1 2.0 must and is needed before we can finish the 2.0 authoring and deployment guide. | 20:19 |
| airship-irc-bot1 | <kk6740> sure | 20:27 |
| airship-irc-bot1 | <james.gu> Thanks! | 20:27 |
| airship-irc-bot1 | <james.gu> Hello team, could I have core reviews on this PS: https://review.opendev.org/c/airship/treasuremap/+/781903. Moved to use airshipctl render to get the environment variables used by the deployment scripts | 21:26 |
| airship-irc-bot1 | <mattmceuen> VRRP Ingress in treasuremap v2 still needs some review - ty! https://review.opendev.org/c/airship/treasuremap/+/778953 | 22:36 |
| airship-irc-bot1 | <mf4716> +1 reviews needed (please) on a PS by Sidney for "OIDC API Server Kustomization - airship-core Type", https://review.opendev.org/c/airship/treasuremap/+/781172. | 23:39 |
| *** uzumaki has quit IRC | 23:49 | |
| *** uzumaki has joined #airshipit | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!