Tuesday, 2022-08-09

« Monday, 2022-08-08 Index Wednesday, 2022-08-10 »
-@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 849670: Improve gitea trigger testing https://review.opendev.org/c/zuul/zuul/+/84967006:47
-@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 849680: Implement gitea reporter interface https://review.opendev.org/c/zuul/zuul/+/84968006:47
-@gerrit:opendev.org- Artem Goncharov proposed:06:47
- [zuul/zuul] 849719: Implement gitea commit status reporter https://review.opendev.org/c/zuul/zuul/+/849719
- [zuul/zuul] 849720: Implement gitea comment trigger https://review.opendev.org/c/zuul/zuul/+/849720
-@gerrit:opendev.org- Artem Goncharov proposed:06:47
- [zuul/zuul] 849727: Add gitea pr dyn_reconf test https://review.opendev.org/c/zuul/zuul/+/849727
- [zuul/zuul] 849728: Implement gitea refs https://review.opendev.org/c/zuul/zuul/+/849728
-@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 850008: Implement gitea merge reporter https://review.opendev.org/c/zuul/zuul/+/85000806:47
-@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 850413: Implement gitea requirement https://review.opendev.org/c/zuul/zuul/+/85041306:47
-@gerrit:opendev.org- Artem Goncharov proposed:06:47
- [zuul/zuul] 850883: Implement gitea review trigger https://review.opendev.org/c/zuul/zuul/+/850883
- [zuul/zuul] 850898: Implement gitea label_updated event trigger https://review.opendev.org/c/zuul/zuul/+/850898
-@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 850941: Tune gitea trigger events https://review.opendev.org/c/zuul/zuul/+/85094106:48
-@gerrit:opendev.org- Ian Wienand proposed:07:08
- [zuul/zuul] 850593: zuul-stream: implement a protocol and version https://review.opendev.org/c/zuul/zuul/+/850593
- [zuul/zuul] 850270: zuul-stream: automatically remove streaming files https://review.opendev.org/c/zuul/zuul/+/850270
- [zuul/zuul] 851942: docs: update console streaming docs https://review.opendev.org/c/zuul/zuul/+/851942
@q:fricklercloud.deall the examples for "recheck" comment triggers for pipelines other than gerrit explicitly only allow "empty" rechecks. maybe we want to amend those in order to be more liberal too?12:23
@sean-k-mooney:matrix.orgyou mean say for the experimental pipeline12:30
@sean-k-mooney:matrix.orgwe normally only have 2 upstream12:30
@sean-k-mooney:matrix.orgbut third party ci can have differnt behavior depending on what is configured12:30
@q:fricklercloud.deoh, I actually meant drivers other than gerrit, got confused because the examples are in the pipelines section. 12:40
@q:fricklercloud.delike github, gitlab, pagure12:41
@fungicide:matrix.orgon a related note, i've noticed in opendev we don't explicitly end our comment match for recheck with a space, but zuul seems to require one (based on my experiments) if any text follows the word. does the driver implicitly append a space to the match string in such cases?? https://opendev.org/openstack/project-config/src/branch/master/zuul.d/pipelines.yaml16:08
@fungicide:matrix.orgif i leave a comment like `reckeck` or `recheck foo` it works but `recheckfoo` doesn't seem to trigger anything. the docs don't indicate it's expected behavior: https://zuul-ci.org/docs/zuul/latest/drivers/gerrit.html#attr-pipeline.trigger.%3Cgerrit%20source%3E.comment16:13
@jim:acmegating.comfungi: i think `recheckfoo` should match that16:20
@fungicide:matrix.orglooking at the GerritEventFilter.matches() implementation, i'm starting to think that my observations were wrong16:20
@fungicide:matrix.orgi'll try the experiment again16:20
@jim:acmegating.comfungi: i just `recheckfoo`d this https://zuul.opendev.org/t/zuul/status/change/847387,316:21
@clarkb:matrix.orgya it does an re.search()16:21
@jim:acmegating.comi believe the zuul and openstack tenants have the same regex16:21
@fungicide:matrix.orgthe case i ran into was users putting in comments like `recheck: some other text` and not getting anything reenqueued16:22
@jim:acmegating.comfungi: ```16:23
>>> r = re.compile('(?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*recheck')
>>> r.search('recheck: some other text')
<re.Match object; span=(0, 7), match='recheck'>
```
@fungicide:matrix.orgso it seemed like the `:` was causing things not to match, but i may have been mistaken16:23
@jim:acmegating.com * fungi: ```16:23
> > > r = re.compile('(?i)^(Patch Set \[0-9\]+:)?( \[\\w\\+-\]_)_(\\n\\n)?\\s\*recheck')
> > > r.search('recheck: some other text')
> > > \<re.Match object; span=(0, 7), match='recheck'>
```
@jim:acmegating.com * fungi: ```16:23
r = re.compile('(?i)^(Patch Set \[0-9\]+:)?( \[\\w\\+-\]_)_(\\n\\n)?\\s\*recheck')
r.search('recheck: some other text')
\<re.Match object; span=(0, 7), match='recheck'>
```
@jim:acmegating.com * fungi: ```r = re.compile('(?i)^(Patch Set \[0-9\]+:)?( \[\\w\\+-\]_)_(\\n\\n)?\\s\*recheck')16:24
r.search('recheck: some other text')
\<re.Match object; span=(0, 7), match='recheck'>
```
@jim:acmegating.com * fungi: ```16:24
r = re.compile('(?i)^(Patch Set \[0-9\]+:)?( \[\\w\\+-\]_)_(\\n\\n)?\\s\*recheck')
r.search('recheck: some other text')
\<re.Match object; span=(0, 7), match='recheck'>
```
@fungicide:matrix.orgconfirmed i was mistaken. `recheck: testing` triggered check on https://review.opendev.org/85260516:33
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 852670: Add support for dynamic tags https://review.opendev.org/c/zuul/nodepool/+/85267019:54
-@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul] 850269: zuul-stream: start new console for stream tests https://review.opendev.org/c/zuul/zuul/+/85026920:20
« Monday, 2022-08-08 Index Wednesday, 2022-08-10 »

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!