| -@gerrit:opendev.org- Zuul merged on behalf of Tobias Henkel: [zuul/nodepool] 777719: Use different image in nodepool-functional-k8s https://review.opendev.org/c/zuul/nodepool/+/777719 | 06:25 | |
| @jpew:matrix.org | I'm looking at diskimage builder documentation for https://zuul-ci.org/docs/nodepool/latest/openstack.html#attr-providers.[openstack].diskimages.meta and it says the number of metadata properties is limited to 5, but my openstack admin it telling me to set about 15 parameters for the images; is there documentation on the "5" limit? | 14:05 |
|---|---|---|
| @jpew:matrix.org | Or perhaps more directly, how do I set the image properties shown here https://docs.openstack.org/glance/pike/admin/manage-images.html#create-or-update-an-image-glance with nodepool-builder | 14:12 |
| @fungicide:matrix.org | i wonder why the limit is five entries, but the change which added that note in the docs was 8 years ago so it may no longer be correct for modern systems? https://review.openstack.org/123639 | 14:17 |
| @fungicide:matrix.org | https://docs.openstack.org/python-novaclient/latest/reference/api/novaclient.v2.servers.html#novaclient.v2.servers.Server.create_image doesn't mention any limit to the number of entries | 14:22 |
| @jpew:matrix.org | I *think* if I'm reading the right documentation, https://docs.openstack.org/api-ref/compute/?expanded=create-image-createimage-action-detail says that there is a limit of 255 per key-value pair, but no limit on the number of properties | 14:22 |
| @fungicide:matrix.org | i concur | 14:23 |
| @fungicide:matrix.org | if you can confirm that adding more than 5 entries is working in your environment, we can probably just remove that confusing bit from the docs | 14:23 |
| @jpew:matrix.org | Ok, will do | 14:23 |
| @fungicide:matrix.org | thanks! | 14:24 |
| @fungicide:matrix.org | i'm sure it's not the only 8-10 year old outdated info in our docs, sometimes outside changes like that don't get noticed | 14:25 |
| @fungicide:matrix.org | the change which added that note referred to the nova v1 api, which hasn't been supported in an age | 14:25 |
| @jpew:matrix.org | Grossly, the code just blanks out all the metadata silently if you break any of the rules | 14:26 |
| @fungicide:matrix.org | ick | 14:26 |
| @fungicide:matrix.org | "the code" in nova's api? | 14:26 |
| @fungicide:matrix.org | or on the nodepool side? | 14:27 |
| @jpew:matrix.org | nodepool: https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/config.py#L271 | 14:27 |
| @fungicide:matrix.org | oh, yep i see it in the original commit nodepool | 14:27 |
| @fungicide:matrix.org | * oh, yep i see it in the original commit to nodepool | 14:28 |
| @fungicide:matrix.org | ianw: i know it's asking a lot, but do you recall why you had to limit it to 5 entries back then? | 14:29 |
| @jpew:matrix.org | Maybe we can just remove the whole check? Presumably openstack would reject the request if you don't follow the rules | 14:29 |
| @fungicide:matrix.org | probably | 14:29 |
| @jpew:matrix.org | It's also unclear from the openstack documentation if the 255 limit is for the key and value independntly or combined | 14:30 |
| @fungicide:matrix.org | though rejection at image upload is kinda late to be letting the admin know, since it's after the (often lengthy) image build process | 14:30 |
| @fungicide:matrix.org | but yes, i do feel like leaving it up to openstack to enforce openstack's limits is probably easier for the long-term maintenance of nodepool. otherwise we have redundant safety checks which can diverge over time | 14:31 |
| @clarkb:matrix.org | I think there is still a limit set by quotas. Metadata-items or similar | 14:32 |
| @clarkb:matrix.org | It isn't unlimited but very likely more than 5 and 5 was probably a very old openstack limit | 14:32 |
| @clarkb:matrix.org | Also image properties and instance metadata are distinct | 14:35 |
| @jpew:matrix.org | Yes, I saw that | 14:36 |
| @jpew:matrix.org | Clark: https://zuul-ci.org/docs/nodepool/latest/openstack.html#attr-providers.[openstack].diskimages.meta vs https://zuul-ci.org/docs/nodepool/latest/openstack.html#attr-providers.[openstack].pools.labels.instance-properties ? | 14:37 |
| @clarkb:matrix.org | https://zuul-ci.org/docs/nodepool/latest/openstack.html#attr-providers.[openstack].pools.labels.instance-properties | 14:37 |
| -@gerrit:opendev.org- Joshua Watt proposed: [zuul/nodepool] 842719: openstack: Remove metadata limit checks https://review.opendev.org/c/zuul/nodepool/+/842719 | 14:40 | |
| @fungicide:matrix.org | since ianw wrote the initial implementation of those checks, hopefully he can provide some context when reviewing 842719 | 14:42 |
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add role variable delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 16:25 | |
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add role variable delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 16:31 | |
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add role variable delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 17:02 | |
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add role variable delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 17:15 | |
| -@gerrit:opendev.org- Joshua Watt proposed: [zuul/nodepool] 842719: openstack: Remove metadata limit checks https://review.opendev.org/c/zuul/nodepool/+/842719 | 18:11 | |
| @jpew:matrix.org | > <@gerrit:opendev.org> Joshua Watt proposed: [zuul/nodepool] 842719: openstack: Remove metadata limit checks https://review.opendev.org/c/zuul/nodepool/+/842719 | 18:13 |
| This works on our version of OpenStack FWIW | ||
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!