| -@gerrit:opendev.org- Felix Edel proposed: | 05:23 | |
| - [zuul/zuul] Don't use executor.builds when processing build result events https://review.opendev.org/c/zuul/zuul/+/808091 | ||
| - [zuul/zuul] WIP Use ZooKeeper builds as source for waitUntilSettled() https://review.opendev.org/c/zuul/zuul/+/808792 | ||
| -@gerrit:opendev.org- Pierre-Louis Bonicoli proposed: [zuul/nodepool] openshiftpods: fix exception in cleanup https://review.opendev.org/c/zuul/nodepool/+/808873 | 06:50 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 06:59 | |
| - [zuul/zuul-registry] Do not allow incorrect sized layers https://review.opendev.org/c/zuul/zuul-registry/+/808621 | ||
| - [zuul/zuul-registry] Fix head_blob Content-Length return https://review.opendev.org/c/zuul/zuul-registry/+/808622 | ||
| - [zuul/zuul-registry] Do not accept missing sizes https://review.opendev.org/c/zuul/zuul-registry/+/808623 | ||
| - [zuul/zuul-registry] Fix manifest HEAD requests https://review.opendev.org/c/zuul/zuul-registry/+/808624 | ||
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 07:11 | |
| @iwienand:matrix.org | corvus: Clark responded to comments with the zuul-registry. also i've put in links in comments to several mitmproxy traces using both podman and docker to confirm their behaviour | 07:12 |
|---|---|---|
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 07:53 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 08:20 | |
| -@gerrit:opendev.org- Felix Edel proposed: | 09:22 | |
| - [zuul/zuul] Don't use executor.builds when processing build result events https://review.opendev.org/c/zuul/zuul/+/808091 | ||
| - [zuul/zuul] Don't use executor.builds to find out if tests are settled https://review.opendev.org/c/zuul/zuul/+/808792 | ||
| - [zuul/zuul] Fix race in test_data_return_child_from_retried_paused_job https://review.opendev.org/c/zuul/zuul/+/808918 | ||
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 09:29 | |
| @lyr:matrix.org | Hi there. I set up a "self approve" pipeline, which seems to be doing its job approving PR on 'self-approve' label. Github UI seems fine with it | 10:04 |
| @lyr:matrix.org | But Zuul seems unhappy with it | 10:04 |
| ``` | ||
| 2021-09-14 09:56:16,668 DEBUG zuul.Pipeline.local.gate: [e: ffb1e970-1541-11ec-9a5e-a539c85eb574] Change <Change 0x7f512c14cda0 TinxHQ/zuul-test-job 9,5b3cfb12e30ba323c4e3d22100b0d1f813c27617> does not match pipeline requirement <GithubRefFilter connection_name: github.com statuses: (?i)^wazo-community-zuul.*:local/check:success$ required-reviews: [{'permission': 'write', 'type': 'approved'}] open: True current-patchset: True labels: ['mergeit']> because Required reviews [{'permission': 'write', 'type': 'approved'}] does not match dict_values([{'by': {'username': 'wazo-community-zuul[bot]', 'email': None, 'name': None}, 'grantedOn': 1631613011, 'type': 'approved', 'submitted_at': '2021-09-14T09:50:11Z', 'permission': 'read'}]) | ||
| ``` | ||
| @lyr:matrix.org | If I understand this correctly Zuul think it's missing a write permission ? | 10:06 |
| @lyr:matrix.org | (Though it's admin) | 10:15 |
| @tobias.henkel:matrix.org | maybe it has outdated cached permissions | 10:15 |
| @tobias.henkel:matrix.org | lyr: however you likely want to remove the review requirement in gate now and just rely on github's branch protection settings | 10:15 |
| @tobias.henkel:matrix.org | lyr: zuul thinks it's read permission: | 10:17 |
| ``` | ||
| {'username': 'wazo-community-zuul[bot]', 'email': None, 'name': None}, 'grantedOn': 1631613011, 'type': 'approved', 'submitted_at': '2021-09-14T09:50:11Z', 'permission': 'read'} | ||
| ``` | ||
| @lyr:matrix.org | Cache is unlikely, since the permission didn't changed recently | 10:17 |
| @gtema:matrix.org | iirc write privs granted through branch protection are not explicitly meaning user has write permission on project | 10:18 |
| @lyr:matrix.org | The user is owner of the github org | 10:18 |
| @gtema:matrix.org | for GH it is ok, but in the webhook it is not really present | 10:18 |
| @lyr:matrix.org | Maybe it's in the github app ? | 10:19 |
| @tobias.henkel:matrix.org | it could also be that zuul is unable to gather the permission since the 'user' is an app and falls back to 'read' | 10:19 |
| @lyr:matrix.org | Is it something that changed recently (like zuul 4.0) ? | 10:19 |
| @gtema:matrix.org | nope - it was always tricky. That's why I wrote you we are not using self-approving with GH | 10:19 |
| @lyr:matrix.org | 'kay well | 10:21 |
| @tobias.henkel:matrix.org | lyr: I'd recommend to just remove the review requirement from the gate pipeline. Zuul asks github if the change could merge. So there usually is no need to additionally require reviews in gate. | 10:21 |
| @lyr:matrix.org | Gonna update my software factory _pipelines.yaml.j2 patch to kick our the required review | 10:21 |
| @lyr:matrix.org | It works | 10:51 |
| @lyr:matrix.org | One last question, the gate pipeline doesn't remove the branch, is there a setting for that ? Couldn't find one in the doc | 10:52 |
| @tobias.henkel:matrix.org | lyr: there is a setting in the github repository config | 11:32 |
| @tobias.henkel:matrix.org | that's independent of zuul | 11:32 |
| @tobias.henkel:matrix.org | it's named `Automatically delete head branches ` | 11:33 |
| @westphahl:matrix.org | corvus Clark : re. 805835 I found some other potential race conditions so I probably need some more time to iron those out | 12:58 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Remove time database https://review.opendev.org/c/zuul/zuul/+/808841 | 13:34 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 13:38 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 13:51 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 13:52 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 13:56 | |
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] Don't use executor.builds to find out if tests are settled https://review.opendev.org/c/zuul/zuul/+/808792 | 13:58 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 14:38 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 16:10 | |
| - [zuul/zuul] Remove time database https://review.opendev.org/c/zuul/zuul/+/808841 | ||
| - [zuul/zuul] Fix race involving job request locks https://review.opendev.org/c/zuul/zuul/+/808994 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] Add "slots" to static node driver https://review.opendev.org/c/zuul/nodepool/+/807806 | 16:24 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 16:27 | |
| @clarkb:matrix.org | I have approved ianw's zuul-registry fixup | 17:14 |
| @clarkb:matrix.org | * I have approved ianw's zuul-registry fixup stack | 17:14 |
| -@gerrit:opendev.org- Pierre-Louis Bonicoli proposed: [zuul/nodepool] openshiftpods: fix TypeError exception in cleanup https://review.opendev.org/c/zuul/nodepool/+/808873 | 17:17 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: | 17:25 | |
| - [zuul/zuul-registry] Do not allow incorrect sized layers https://review.opendev.org/c/zuul/zuul-registry/+/808621 | ||
| - [zuul/zuul-registry] Fix head_blob Content-Length return https://review.opendev.org/c/zuul/zuul-registry/+/808622 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-registry] Do not accept missing sizes https://review.opendev.org/c/zuul/zuul-registry/+/808623 | 17:29 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-registry] Fix manifest HEAD requests https://review.opendev.org/c/zuul/zuul-registry/+/808624 | 17:35 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] Further fix of config change detection in gerrit https://review.opendev.org/c/zuul/zuul/+/808132 | 17:47 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 21:06 | |
| - [zuul/zuul] Remove time database https://review.opendev.org/c/zuul/zuul/+/808841 | ||
| - [zuul/zuul] Fix waitUntilSettled nodepool race https://review.opendev.org/c/zuul/zuul/+/809013 | ||
| @clarkb:matrix.org | I'll try to review those test fixes and the time db removal today | 21:38 |
| @clarkb:matrix.org | If anyone else has time for the test fixups they are actually pretty concise and well documented | 21:45 |
| @clarkb:matrix.org | corvus: left a minor suggestion on https://review.opendev.org/c/zuul/zuul/+/808841 | 22:00 |
| @jim:acmegating.com | Clark: done, thanks! | 22:11 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Remove time database https://review.opendev.org/c/zuul/zuul/+/808841 | 22:11 | |
| @hwangbro:matrix.org | Is it still possible to use the Jenkins Gearman plugin to spawn jobs in Jenkins from Zuul 4+? I see documentation for it in older versions of Zuul, but I can't find anything in the current documentation for it. | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!