| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] PoC: pipeline state in Zookeeper https://review.opendev.org/c/zuul/zuul/+/808579 | 06:11 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 08:26 | |
| - [zuul/zuul-registry] Fix range response https://review.opendev.org/c/zuul/zuul-registry/+/808620 | ||
| - [zuul/zuul-registry] Do not allow incorrect sized layers https://review.opendev.org/c/zuul/zuul-registry/+/808621 | ||
| - [zuul/zuul-registry] Fix head_blob Content-Length return https://review.opendev.org/c/zuul/zuul-registry/+/808622 | ||
| - [zuul/zuul-registry] Do not accept missing sizes https://review.opendev.org/c/zuul/zuul-registry/+/808623 | ||
| - [zuul/zuul-registry] Fix manifest HEAD requests https://review.opendev.org/c/zuul/zuul-registry/+/808624 | ||
| @iwienand:matrix.org | mordred: corvus: Clark ^ the above is opening the pandora's box from the very helpful comment https://github.com/docker/for-linux/issues/1296#issuecomment-917315081. Have a look, but I have run out of time to validate that exact stack (it's a cleanup of things i've pushed into my test stack; still to do is to revert that and apply these cleaned-up changes and validate i didn't break anything in translation -- i've just run out of time today). | 08:28 |
|---|---|---|
| -@gerrit:opendev.org- Simon Westphahl proposed: | 08:30 | |
| - [zuul/zuul] Move update w/ retry logic to change cache https://review.opendev.org/c/zuul/zuul/+/808612 | ||
| - [zuul/zuul] DNM: test correct change cache (de-)serialization https://review.opendev.org/c/zuul/zuul/+/807890 | ||
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] PoC: pipeline state in Zookeeper https://review.opendev.org/c/zuul/zuul/+/808579 | 12:02 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 13:37 | |
| -@gerrit:opendev.org- Simon Westphahl proposed on behalf of Felix Edel: [zuul/zuul] Make reporting asynchronous https://review.opendev.org/c/zuul/zuul/+/691253 | 13:42 | |
| -@gerrit:opendev.org- Simon Westphahl proposed on behalf of Tobias Henkel: [zuul/zuul] Increase cherrypy thread pool https://review.opendev.org/c/zuul/zuul/+/708377 | 13:50 | |
| @clarkb:matrix.org | Wait the server sets all the size values and the clients just echo them back? That is amazing to me since the client has all of the data locally (and created at least some of it). That is very unexpected to me. | 13:57 |
| @clarkb:matrix.org | There is a pep8 issue in that stack I can fix it after doing morning errands | 13:58 |
| -@gerrit:opendev.org- Felix Edel proposed: | 15:11 | |
| - [zuul/zuul] WIP: Don't use executor.builds when processing build result events https://review.opendev.org/c/zuul/zuul/+/808091 | ||
| - [zuul/zuul] WIP Use ZooKeeper builds as source for waitUntilSettled() https://review.opendev.org/c/zuul/zuul/+/808792 | ||
| -@gerrit:opendev.org- Clark Boylan proposed on behalf of Ian Wienand: | 15:24 | |
| - [zuul/zuul-registry] Fix range response https://review.opendev.org/c/zuul/zuul-registry/+/808620 | ||
| - [zuul/zuul-registry] Do not allow incorrect sized layers https://review.opendev.org/c/zuul/zuul-registry/+/808621 | ||
| - [zuul/zuul-registry] Fix head_blob Content-Length return https://review.opendev.org/c/zuul/zuul-registry/+/808622 | ||
| - [zuul/zuul-registry] Do not accept missing sizes https://review.opendev.org/c/zuul/zuul-registry/+/808623 | ||
| - [zuul/zuul-registry] Fix manifest HEAD requests https://review.opendev.org/c/zuul/zuul-registry/+/808624 | ||
| @clarkb:matrix.org | That should fix the pep8 issue. I'll work on reviews in a bit too | 15:28 |
| @jim:acmegating.com | ianw, Clark: that is very surprising they chose to implement the clients that way. the changes lgtm, though i think we should drop the strict option (it's either necessary or it isn't). if 'docker build' (with and without buildkit) works with docker and podman pull, then i think that covers all the failure cases we observed. | 15:49 |
| @clarkb:matrix.org | corvus: makes sense to remove the strict option if it is expected to always work after this stack | 15:54 |
| @clarkb:matrix.org | and yes I find it very odd the clients work that way | 15:54 |
| @clarkb:matrix.org | corvus: I've approved the Range fix but I'll hold off approving the others given your comments around strict. Will still look through and review the stack though | 16:08 |
| @clarkb:matrix.org | corvus: ianw left a question on https://review.opendev.org/c/zuul/zuul-registry/+/808624 as well | 16:25 |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-registry] Fix range response https://review.opendev.org/c/zuul/zuul-registry/+/808620 | 16:27 | |
| @clarkb:matrix.org | Update your Matrix element clients: https://matrix.org/blog/2021/09/13/vulnerability-disclosure-key-sharing and potentially libs that things like weechat use? | 16:38 |
| @jim:acmegating.com | Clark: done, thanks! notice says matrix-nio (what weechat and also the log bot use) are not affected | 16:45 |
| @jim:acmegating.com | i posted this in #opendev, but it's relevant to both: | 16:53 |
| @jim:acmegating.com | looking over zuul stats, everything seems nominal, except that the zuul event processing times seem longer than normal. that measures the amount of time it takes for an event once received from gerrit to make it to the scheduler. i don't think our nodepool changes should have affected this, unless they are just slowing everything down, a lot. the times still seem spikey, which is typical, as usually the spikes are caused by tenant reconfiguration events. looking at the logs, it seems like we have an unusually high number of tenant reconfig events happening right now -- about 3x so far compared to some random days last week. one potential cause could be larger than usual numbers of zuul.yaml changes due to the release cycle. | 16:53 |
| @jim:acmegating.com | in short, the only metric change i've seen appears to be related to a change in usage patterns, so i think i'm happy with the nodepool series. | 16:54 |
| @jim:acmegating.com | Clark: another sos series is ready to merge; starts at https://review.opendev.org/805844 -- it has +2s from tobiash and me, but it can wait if you want to take a look. | 16:56 |
| @clarkb:matrix.org | corvus: ya I can take a look this morning. but if I get distracted and haven't reviewed it in a couple of hours feel free to land it without my review | 16:57 |
| @clarkb:matrix.org | The commit message on that sos change makes me suddenly realize this is a serious update :) | 17:21 |
| @jim:acmegating.com | we're starting to run out of things that aren't in zk :) | 17:52 |
| @clarkb:matrix.org | question about a very minor thing on the first change in the stack. But +2 as it should be fine with or without that to start | 17:56 |
| @clarkb:matrix.org | Going to keep trying to work through that stack, but don't wait up for me if I fall behind. Its a dense set of changes I expect and I'm feeling slow after yesterday | 17:57 |
| @jim:acmegating.com | several of them are near-identical :) | 17:57 |
| @clarkb:matrix.org | corvus: I think I found an issue on 805835. I'm trying to finish up my review of it and will post soon. But wanted to call taht out in case you did approve before I finished reviewing | 18:20 |
| @jim:acmegating.com | Clark: ack; will keep finger away from trigger :) | 18:23 |
| @clarkb:matrix.org | and now I'm having local connectivity issues to review :/ | 18:35 |
| @clarkb:matrix.org | pretty sure its on my end (though I suppose it could be my isp too?) | 18:36 |
| @clarkb:matrix.org | looks like my isp according to mtr. ugh | 18:37 |
| @clarkb:matrix.org | I'll give it another minute or two but then switch to a phone tether if I need to I guess | 18:37 |
| @clarkb:matrix.org | This is fun, I'm tethered now | 18:45 |
| @clarkb:matrix.org | corvus: ok I posted comments. THe one about quoting is the one I'm most concerned about. Also note I haven't fully reviewed the test file change, but I'm thinking that switching to the tether means I should go eat lunch | 18:47 |
| @clarkb:matrix.org | and hope that I don't need the tether afterwards | 18:47 |
| @jim:acmegating.com | Clark, tobiash, swest: i validated Clark's issue and found another one in the process; i think they're both substantial and we need to fix them. | 20:10 |
| @clarkb:matrix.org | cool it was a bit confusing to trace out what was quoted and what wasn't but it seemed we had a mismatch of intent at least. Also I was fighting with network issues which probably made that worse on my end and not necessary a problem with the change being understandable | 20:22 |
| -@gerrit:opendev.org- Emmanuel Odeyemi proposed: [zuul/zuul] modify pr files to allow job triggers on a push event for a deleted files https://review.opendev.org/c/zuul/zuul/+/807411 | 20:35 | |
| @jim:acmegating.com | Clark: since you reviewed the parent, can you give https://review.opendev.org/808132 a quick look? | 21:24 |
| @jim:acmegating.com | we haven't heard from guillaumec on 807975 (but i'd still love to!) so i think maybe we should go ahead and merge those | 21:25 |
| @clarkb:matrix.org | corvus: oh I only +2'd the child change as I wasnt' sure we wanted to approve them yet. I'll let you approve if you want to do that still | 21:27 |
| @clarkb:matrix.org | but ya seems like it is completely broken now, but your changes will fix it for at least most situations even if there are corner cases that don't work | 21:27 |
| @clarkb:matrix.org | and we acn sort out those other cases if guillaumec points them out | 21:27 |
| @jim:acmegating.com | ++ | 21:27 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] Add "slots" to static node driver https://review.opendev.org/c/zuul/nodepool/+/807806 | 21:56 | |
| @clarkb:matrix.org | corvus: swest see my comments on https://review.opendev.org/c/zuul/zuul/+/805837 I think they are related to some of the prior comments on that change | 22:25 |
| @jim:acmegating.com | Clark: what prior comments? | 22:35 |
| @jim:acmegating.com | Clark: you mean line 1058? | 22:35 |
| @clarkb:matrix.org | ya the 1058 comments | 22:36 |
| @clarkb:matrix.org | basically the idea is to move the code elsewhere and I didn't want any potential updates to that code to get lost when it is moved | 22:37 |
| @jim:acmegating.com | gotcha | 22:37 |
| @clarkb:matrix.org | Basically I'm wondering if it should just bail out there similar to how the other code does? I'm not sure how we reconcile that safely. Can we know who has the most up todate attribute info? | 22:41 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] Query gerrit files endpoint https://review.opendev.org/c/zuul/zuul/+/807975 | 22:44 | |
| @jim:acmegating.com | Clark: i took a stab at responding to that | 22:47 |
| @clarkb:matrix.org | I see, we largely only expect conflict where we're either setting values on different keys or setting the same values on the same keys | 22:48 |
| @clarkb:matrix.org | we need to retry to update the different values on different keys | 22:48 |
| @jim:acmegating.com | yes that is a very succinct summary :) | 22:48 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Remove time database https://review.opendev.org/c/zuul/zuul/+/808841 | 23:21 | |
| @jim:acmegating.com | i'll be a little sad to see that go ^ it was an extremely fast, efficient, and reliable database (i don't recall ever having a single problem with it) | 23:22 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!