| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Query gerrit files endpoint https://review.opendev.org/c/zuul/zuul/+/807975 | 00:15 | |
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] Make parameter names for build result events more explicit https://review.opendev.org/c/zuul/zuul/+/808010 | 06:42 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed on behalf of Tobias Henkel: [zuul/zuul] Optionally support mitogen for job execution https://review.opendev.org/c/zuul/zuul/+/657024 | 07:28 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed on behalf of Tobias Henkel: [zuul/zuul] Optionally support mitogen for job execution https://review.opendev.org/c/zuul/zuul/+/657024 | 07:38 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 07:43 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] WIP: Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 07:46 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] Add source interface for setting change attributes https://review.opendev.org/c/zuul/zuul/+/805836 | 08:22 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 09:08 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: | 09:59 | |
| - [zuul/zuul] [web] Early support for pagination in builds, buildsets search https://review.opendev.org/c/zuul/zuul/+/808041 | ||
| - [zuul/zuul] [zuul-web] Add pagination information when querying builds, buildsets endpoints https://review.opendev.org/c/zuul/zuul/+/808042 | ||
| - [zuul/zuul] Pagination: remove compatibility code https://review.opendev.org/c/zuul/zuul/+/808043 | ||
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 09:59 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] [web] Early support for pagination in builds, buildsets search https://review.opendev.org/c/zuul/zuul/+/808041 | 10:05 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] [zuul-web] Add pagination information when querying builds, buildsets endpoints https://review.opendev.org/c/zuul/zuul/+/808042 | 10:05 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] Pagination: remove compatibility code https://review.opendev.org/c/zuul/zuul/+/808043 | 10:08 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed on behalf of Tobias Henkel: [zuul/zuul] Optionally support mitogen for job execution https://review.opendev.org/c/zuul/zuul/+/657024 | 10:50 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] WIP: Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 11:25 | |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 11:35 | |
| @tristanc_:matrix.org | corvus: about the operator podman test failure, it seems like the actual error is `Error: credentials key has https[s]:// prefix` (from https://303203e2c1792c8c7292-9add4719a9922a9385555a8552fc2366.ssl.cf1.rackcdn.com/807798/2/check/zuul-operator-functional-k8s/796fce8/docker/k8s_test-registry_test-registry-4rsz2_default_c52d5742-8b57-42a5-989c-483f5b36873c_0.txt ) | 12:06 |
|---|---|---|
| In the docker logs, batch job are not prefixed with _POD_ | ||
| @ssbarnea:matrix.org | what is the policy about broken zuul-jobs tests? How long they need to be broken before we make them non-voting or removing them? https://zuul.opendev.org/t/zuul/builds?job_name=zuul-jobs-test-ensure-pip-ubuntu-xenial&project=zuul/zuul-jobs | 12:28 |
| @ssbarnea:matrix.org | I am asking because i tried to make a simple fix which now blocked by some broken jobs. https://review.opendev.org/c/zuul/zuul-jobs/+/807877 | 12:29 |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] WIP: Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 13:42 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] [GUI] Buildset: add "show retries" toggles https://review.opendev.org/c/zuul/zuul/+/806201 | 13:47 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] WIP: Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 13:54 | |
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] Combine build result event data structure in base class https://review.opendev.org/c/zuul/zuul/+/808010 | 14:17 | |
| @ssbarnea:matrix.org | fungi: any recommandation about broken zuul-jobs-test-ensure-pip-ubuntu-xenial? please do not ask me to fix it. | 14:18 |
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] Combine build result event data structure in common base class https://review.opendev.org/c/zuul/zuul/+/808010 | 14:18 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] web UI: add "show retries" toggles on buildset page https://review.opendev.org/c/zuul/zuul/+/806201 | 14:20 | |
| @jim:acmegating.com | tristanC: thanks. and wow -- that looks related to https://github.com/containers/common/commit/f8136e70f9c80eabcb137081fd7f2c118f8853ad which seems really strange to me. | 14:22 |
| @jim:acmegating.com | i don't see why path based creds is mutually exclusive with https:// | 14:22 |
| @jim:acmegating.com | but regardless, i verified that dropping that and just using "zuul-registry" works | 14:23 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Tristan Cacqueray https://matrix.to/#/@tristanc_:matrix.org: [zuul/zuul-operator] Fix functional test job https://review.opendev.org/c/zuul/zuul-operator/+/807931 | 14:27 | |
| @jim:acmegating.com | tristanC: ^ omnibus patch which should hopefully unblock. | 14:28 |
| @tristanc_:matrix.org | corvus: LGTM, but the change is abandoned | 14:29 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-operator] Fix functional test job https://review.opendev.org/c/zuul/zuul-operator/+/807805 | 14:29 | |
| @jim:acmegating.com | oops i got the wrong change id :/ | 14:29 |
| @jim:acmegating.com | that looks right | 14:30 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-operator] Update doc theme settings to match Zuul https://review.opendev.org/c/zuul/zuul-operator/+/807798 | 14:35 | |
| @ssbarnea:matrix.org | my impression is that the current implementation of update-test-platforms does not allow me to make a single job non-voting, it will keep overriding my change | 14:40 |
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] WIP: Remove executor.builds list https://review.opendev.org/c/zuul/zuul/+/808091 | 14:45 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] Show emoji to highlight failed jobs in build result in Github https://review.opendev.org/c/zuul/zuul/+/803547 | 14:45 | |
| @jim:acmegating.com | zuul-maint: we restarted opendev on commit 04678e25e666c5e97b76e68838a0ce1cf0761144 but we merged 4f318047ba2ac5b936ab0fff96ea68864253970d shortly afterword; i think it's safe and desirable to tag that commit as the next point release (that was change https://review.opendev.org/807421 ) | 14:48 |
| @jim:acmegating.com | zuul-maint: i propose: commit 4f318047ba2ac5b936ab0fff96ea68864253970d (tag: 4.8.2) | 14:49 |
| @jim:acmegating.com | thoughts? | 14:49 |
| -@gerrit:opendev.org- Jiri Podivin proposed: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 15:05 | |
| @clarkb:matrix.org | corvus: agreed 807421 should be safe to include | 15:24 |
| @tobias.henkel:matrix.org | sounds good to me | 15:24 |
| @clarkb:matrix.org | 4f318047ba2ac5b936ab0fff96ea68864253970d is the merge commit I see for 807421. Is 4.9.0 more appropriate with the zk secrets handling? | 15:25 |
| @jim:acmegating.com | Clark: yeah i think you may be right | 15:26 |
| @jim:acmegating.com | Clark: tobiash how about commit 4f318047ba2ac5b936ab0fff96ea68864253970d (tag: 4.9.0) | 15:27 |
| @clarkb:matrix.org | > <@ssbarnea:matrix.org> fungi: any recommandation about broken zuul-jobs-test-ensure-pip-ubuntu-xenial? please do not ask me to fix it. | 15:30 |
| Starting with "please do not ask me to fix it" isn't a very constructive way to figure out the best course here. Someone has to fix it somehow otherwise you'll continue to be blocked. I think this issue is that distutils on xenial and centos 7 with python2 doesn't do SNI with TLS. Pypi requires SNI now due to their CDN hosting requirements. The fix is to preinstall PBR with pip. | ||
| @ssbarnea:matrix.org | fungi: i will try to answer that but i am trying to write it in a nice way, as i do not want to offend anyone | 15:40 |
| @jim:acmegating.com | 4.9.0 pushed | 15:42 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-operator] Fix functional test job https://review.opendev.org/c/zuul/zuul-operator/+/807805 | 16:48 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] web UI: add "show retries" toggles on buildset page https://review.opendev.org/c/zuul/zuul/+/806201 | 17:01 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] Web UI: add checkbox, selects to filter toolbar https://review.opendev.org/c/zuul/zuul/+/729265 | 17:14 | |
| @jim:acmegating.com | tobiash, Clark: it looks like most of the node request stack is well-reviewed except for the last 4 changes or so starting at https://review.opendev.org/807196 -- i think that's the next think now that we have a checkpoint release done | 17:15 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] Web UI: make more filters selectable in build, buildset searches https://review.opendev.org/c/zuul/zuul/+/793159 | 17:16 | |
| @jim:acmegating.com | (note there's a sneaky nodepool change via depends-on in there too) | 17:16 |
| @jim:acmegating.com | * tobiash, Clark: it looks like most of the node request stack is well-reviewed except for the last 4 changes or so starting at https://review.opendev.org/807196 -- i think that's the next thing now that we have a checkpoint release done | 17:17 |
| @tobias.henkel:matrix.org | corvus: do you think we need to release nodepool and bump the nodepool version for https://review.opendev.org/c/zuul/zuul/+/807406/3 ? | 17:19 |
| @tobias.henkel:matrix.org | oh wait, we don't have nodepool as requirement ... | 17:19 |
| @tobias.henkel:matrix.org | but needs a release note for that I guess | 17:20 |
| @jim:acmegating.com | tobiash: because of https://review.opendev.org/807362 ? yes i think that would be best. | 17:20 |
| @tobias.henkel:matrix.org | jepp | 17:20 |
| @clarkb:matrix.org | corvus: yup I've got a standing item on my todo list for the last bit to keep working on that stack. I just finished melting my brain on gerrit account stuff and will context switch to zuul reviews shortly | 17:20 |
| @jim:acmegating.com | yeah, so as soon as 807406 merges i'll prep a nodepool release then update 807362 with a reno with the version | 17:21 |
| @jim:acmegating.com | sigh | 17:22 |
| @jim:acmegating.com | strike that, reverse it :) | 17:22 |
| @jim:acmegating.com | yeah, so as soon as 807362 merges i'll prep a nodepool release then update 807406 with a reno with the version | 17:22 |
| @jim:acmegating.com | * <del>yeah, so as soon as 807406 merges i'll prep a nodepool release then update 807362 with a reno with the version</del> | 17:23 |
| @jim:acmegating.com | * strike that, reverse it :) https://www.youtube.com/watch?v=ZWJo2EZW8yU | 17:24 |
| @clarkb:matrix.org | I have approved 807362 | 17:26 |
| @jim:acmegating.com | 4.9.0 announcement sent. | 17:27 |
| @fungicide:matrix.org | ssbarnea: that was Clark's reply, not mine. though i do generally agree... preinstalling pbr is likely the easiest path forward | 17:40 |
| @jim:acmegating.com | fungi, tristanC: if you have a second for "topic:op-docs" those 3 changes should get zuul-operator docs linked on the website (they're already published but unlinked) | 17:42 |
| @fungicide:matrix.org | seems it began failing between 2021-03-28 and 2021-04-04 | 17:42 |
| -@gerrit:opendev.org- Jeremy Stanley proposed: [zuul/zuul-jobs] Preinstall PBR in ensure-pip test playbook https://review.opendev.org/c/zuul/zuul-jobs/+/808118 | 17:48 | |
| @fungicide:matrix.org | ssbarnea: ^ | 17:49 |
| @jim:acmegating.com | fungi: thank you for that patch | 17:50 |
| @fungicide:matrix.org | i'm not sure it will work (or is the only problem in the job now) but it seems like a place to start | 17:53 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-website] Correct client link in FAQ documentation menu https://review.opendev.org/c/zuul/zuul-website/+/807801 | 17:55 | |
| @fungicide:matrix.org | speaking of zuul-jobs patches, topic:tox-role would be nice to get some feedback on | 17:55 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-website] Add zuul-operator to doc index https://review.opendev.org/c/zuul/zuul-website/+/807802 | 17:58 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Jeremy Stanley: [zuul/zuul-jobs] Preinstall PBR in ensure-pip test playbook https://review.opendev.org/c/zuul/zuul-jobs/+/808118 | 18:02 | |
| @ssbarnea:matrix.org | thanks! i will look tomorrow as i al already out for today. | 18:08 |
| @ssbarnea:matrix.org | the interesting thing while i was working on my patch is that i may have discovered some podman security issues related to registries. if registry certs/keys are secured, rootless podman no longer works. Now it works because file permissions are… unsecure. probably not a big deal but good to know. | 18:10 |
| @clarkb:matrix.org | gerrit reports https://review.opendev.org/c/zuul/zuul/+/807711/2 has a merge conflict though maybe rebasing that after the things ahead of it merge is easiest to rereview? | 18:11 |
| @clarkb:matrix.org | ssbarnea: the rootless processes will have to read the files | 18:11 |
| @clarkb:matrix.org | and generally certs and CAs are not private data. Only the keys are | 18:11 |
| @ssbarnea:matrix.org | if auth is made using only certs, they can be considered as private. i will test tomorrow with several options to see which settings are required and avoid giving more permissions than needed. | 18:14 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] Add user_data field to Node https://review.opendev.org/c/zuul/nodepool/+/807362 | 18:21 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-operator] Update doc theme settings to match Zuul https://review.opendev.org/c/zuul/zuul-operator/+/807798 | 18:23 | |
| @fungicide:matrix.org | ssbarnea: Clark: the pbr preinstallation seems to have worked... https://zuul.opendev.org/t/zuul/builds?job_name=zuul-jobs-test-ensure-pip-ubuntu-xenial-nv | 18:43 |
| @clarkb:matrix.org | corvus: couple of things on https://review.opendev.org/c/zuul/zuul/+/807406 but none worthy of a -1 I don't think | 18:52 |
| @clarkb:matrix.org | corvus: however if you update things to reflect the nodepool release may be worth addressing some of them? | 18:53 |
| @jim:acmegating.com | thx, will follow up after lunch | 18:53 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] Add node request cache to zk nodepool interface https://review.opendev.org/c/zuul/zuul/+/806639 | 19:19 | |
| @tobias.henkel:matrix.org | corvus: I've posted a q on https://review.opendev.org/c/zuul/zuul/+/807975 | 19:37 |
| @jim:acmegating.com | tobiash: ack, thx. i'll do a followup with that | 19:47 |
| @tobias.henkel:matrix.org | corvus: I think this is an overlapping change that already leverages fileschanges: https://review.opendev.org/c/zuul/zuul/+/762886 | 19:48 |
| @tobias.henkel:matrix.org | I think that does exactly what I was suggesting so that could be rebased on top of yours | 19:50 |
| @jim:acmegating.com | tobiash: well, i think to implement your suggestion is a one line change :) | 19:53 |
| @tobias.henkel:matrix.org | corvus: can you check the comments on https://review.opendev.org/c/zuul/zuul/+/762886/ ? Looks guillaumec found out that files/parent=1 seems to not work in all cases | 19:54 |
| @tobias.henkel:matrix.org | so he falls back to fileschanges for both protocols if merge commits are processed | 19:55 |
| @tobias.henkel:matrix.org | * corvus: can you check the comments on https://review.opendev.org/c/zuul/zuul/+/762886/ ? Looks like guillaumec found out that files/parent=1 seems to not work in all cases | 19:56 |
| @jim:acmegating.com | tobiash: well, there's no supporting documentation that it doesn't work? | 19:56 |
| @tobias.henkel:matrix.org | guillaumec: do you know what didn't work there? | 19:56 |
| @jim:acmegating.com | yeah, more detail would be appreciated. i have tested it and don't see an issue, and i suspect that's what the gerrit ui uses? | 19:57 |
| @mhuin:matrix.org | corvus: I replied on https://review.opendev.org/c/zuul/zuul/+/793159 - TL;DR It looks like it's the intended behavior in patternfly | 19:58 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Further fix of config change detection in gerrit https://review.opendev.org/c/zuul/zuul/+/808132 | 20:01 | |
| @jim:acmegating.com | mhu: hrm, i agree that the example behaves that way, but i really hope that's a mistake... otherwise, maybe we're using it incorrectly. it seems very counter-intuitive to me. and potentially annoying/dangerous (imagine spending a few minutes getting all the queries just right and then blowing it away because you were trying to correct a typo :/ ) | 20:06 |
| @clarkb:matrix.org | https://review.opendev.org/c/zuul/zuul/+/806653/12 failed to merge which kicked the remainder of that approved stack out. Looks like one job timed out and the other failed | 20:06 |
| @jim:acmegating.com | mhu: i note that their example doesn't have (x) buttons on the chips? | 20:07 |
| @jim:acmegating.com | er, well, one does, another doesn't | 20:07 |
| @mhuin:matrix.org | corvus: I think they do? | 20:07 |
| @jim:acmegating.com | "multiple with custom chip group props" does, but "multiple with render custom chip group" doesn't | 20:08 |
| @jim:acmegating.com | wait on the second they start adding x's after the first chip | 20:08 |
| @jim:acmegating.com | nevermind, it doesn't matter anyway. :) | 20:08 |
| @jim:acmegating.com | mhu: okay, replied on the change with a slightly more thought out response :) | 20:11 |
| @jim:acmegating.com | Clark: yeah, "doing a pass through fixing test races" is climbing up my priority list | 20:12 |
| @jim:acmegating.com | also, we probably need to bump timeouts a bit | 20:12 |
| @mhuin:matrix.org | corvus: thx, I'll see what can be done with the onClean function tomorrow | 20:13 |
| @tobias.henkel:matrix.org | corvus: the github3.py devs are complaining that the openstack/third-party-check consistently fails, should we repair or remove this job? https://github.com/sigmavirus24/github3.py/pull/1035 | 20:22 |
| @tobias.henkel:matrix.org | if we want to repair I guess we need to update to py38 (py35 is unsupported on github3.py as well as zuul itself) | 20:22 |
| @tobias.henkel:matrix.org | it also feels a little bit weird that the tox-py35-on-zuul is on the openstack tenant and not in zuul | 20:23 |
| @jim:acmegating.com | tobiash: do you think that's a valuable job? | 20:24 |
| @tobias.henkel:matrix.org | I think github3.py has been pretty stable and we're bypassing it in many cases anyway. So I'm not sure if it's that valuable (given that it fails for months and nobody cares) | 20:26 |
| @tobias.henkel:matrix.org | further the zuul jobs are also kind of flaky atm (I guess we need tp plan a make our tests stable again session) | 20:26 |
| @jim:acmegating.com | tobiash: okay, then maybe let's ask if they want us to fix it or turn it off? you want to or shall i? | 20:27 |
| @tobias.henkel:matrix.org | I can ask | 20:27 |
| @jim:acmegating.com | https://review.opendev.org/558323 was original add; i don't see a link to any external discussion but i assume it happened somewhere :) | 20:28 |
| @tobias.henkel:matrix.org | ah jeah, Jesse got maintainer there and probably added that job | 20:29 |
| -@gerrit:opendev.org- Zuul merged on behalf of Matthieu Huin https://matrix.to/#/@mhuin:matrix.org: [zuul/zuul] web: yarn update to patternfly 2021.11 https://review.opendev.org/c/zuul/zuul/+/807904 | 20:32 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Felix Edel: [zuul/zuul] Combine build result event data structure in common base class https://review.opendev.org/c/zuul/zuul/+/808010 | 20:32 | |
| @tobias.henkel:matrix.org | oh actually that job is broken since 2019 | 20:36 |
| @jim:acmegating.com | tobiash: that's only a few months for a stable software project though. :) | 20:37 |
| @jim:acmegating.com | Clark: replied on 807406 | 20:37 |
| @clarkb:matrix.org | corvus: thanks and ya seems like the easiest thing for now is to leave it as is | 20:40 |
| @clarkb:matrix.org | I couldnt' come up with a better way of naming things to make it more clear in the cache vs zk check method | 20:40 |
| @clarkb:matrix.org | Is there a tldr on those gerrit driver changes? I guess they are all centered around handling merge commits which opendev users don't do much of? I'm happy to help review them but worried there are two stacks that might need to be reconciled first | 20:42 |
| @jim:acmegating.com | Clark: i didn't notice the change from guillaumec (sorry!) and independently made a similar change to correct an issue which has repeatedly come up on gerrit's zuul. | 20:42 |
| -@gerrit:opendev.org- Zuul merged on behalf of Felix Edel: [zuul/zuul] Improve some log messages in the executor/builds context https://review.opendev.org/c/zuul/zuul/+/807874 | 20:43 | |
| @clarkb:matrix.org | gotcha, in that case review guillaumec's stack? | 20:43 |
| @jim:acmegating.com | Clark: i like my approach better because it uses the gerrit API more to avoid unecessary use of zuul mergers. guillaumec left a comment on their change saying the api method i used doesn't work in all cases. | 20:44 |
| @jim:acmegating.com | but there was no detail on that, and i'm having trouble understanding why it would be insufficient | 20:44 |
| @jim:acmegating.com | i think we should review/merge my change unless guillaumec comes back with a compelling reason why it's no good, in which case we should flip and review/merge the older one | 20:45 |
| @clarkb:matrix.org | ok | 20:45 |
| @jim:acmegating.com | the api used is the same one that the gerrit web ui uses to show the file list on merge commits | 20:46 |
| @jim:acmegating.com | so i feel like even if there's some edge case, it's probably "good enough"? as in, it seems like it shouldn't produce unexpected behaviors | 20:46 |
| @jim:acmegating.com | (just checked that with gerrit container image) | 20:48 |
| @clarkb:matrix.org | corvus: tobiash https://review.opendev.org/c/zuul/zuul/+/807406 is the last change in that sos stack without double +2s and it needs the nodepool release stuff. | 20:49 |
| @jim:acmegating.com | \o/ i will herd <del>cats</del> changes | 20:49 |
| @clarkb:matrix.org | > For merge commits only, the integer-valued request parameter parent changes the response to return a map of the files which are different in this commit compared to the given parent commit. The value is the 1-based index of the parent’s position in the commit object, with the first parent always belonging to the target branch. | 21:00 |
| @clarkb:matrix.org | The important bit there is "the first parent always belonging to the target branch" | 21:00 |
| @jim:acmegating.com | yep | 21:01 |
| @clarkb:matrix.org | If that doesn't work it would be a gerrit bug based on the documentation. But my only hunch is that maybe the index of 1 isn't always the target branch? maybe gerrit version dependent? | 21:01 |
| @jim:acmegating.com | maybe things have changed since guillaumec originally wrote that comment | 21:01 |
| @clarkb:matrix.org | corvus: left a question on https://review.opendev.org/c/zuul/zuul/+/807975 which might be related to what tobiash commented on. I haven't fully reviewed that chagne but need to pop out shortly so thought I'd go ahead and post it | 21:07 |
| @jim:acmegating.com | rpld | 21:12 |
| @jim:acmegating.com | zuul-maint: how does this look for nodepool: commit 5dc0aed2e6d2375de93c38f1389d19512c563b99 (HEAD -> master, tag: 4.3.0, origin/master) | 21:23 |
| @jim:acmegating.com | current release notes here: https://zuul-ci.org/docs/nodepool/releasenotes.html | 21:23 |
| @jim:acmegating.com | (i think the tenant-resource-limits warrants a 4.3 | 21:23 |
| @clarkb:matrix.org | looking | 21:52 |
| @clarkb:matrix.org | 5dc0aed2e6d2375de93c38f1389d19512c563b99 looks like a good commit. I agree tenant scoped limits deserves the feature indication. 4.3.0 lgtm as well | 21:54 |
| @clarkb:matrix.org | corvus: ^ | 21:54 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] Wrap nodepool request completed events with election https://review.opendev.org/c/zuul/zuul/+/806653 | 21:58 | |
| @jim:acmegating.com | pushed nodepool 4.3.0 | 22:46 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 22:53 | |
| - [zuul/zuul] Report nodepool resource stats gauges in scheduler https://review.opendev.org/c/zuul/zuul/+/807406 | ||
| - [zuul/zuul] Add ZK session-aware elections https://review.opendev.org/c/zuul/zuul/+/807656 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Felix Edel: [zuul/zuul] Don't use the AnsibleJob in the nodepool client https://review.opendev.org/c/zuul/zuul/+/807711 | 22:53 | |
| @jim:acmegating.com | updated with release note | 22:53 |
| @jim:acmegating.com | release announcement sent | 23:46 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!