| *** jamesmcarthur has quit IRC | 00:09 | |
| *** rlandy|rover has quit IRC | 00:26 | |
| *** jamesmcarthur has joined #zuul | 00:40 | |
| *** jamesmcarthur has quit IRC | 00:48 | |
| *** freenzyfriday has joined #zuul | 00:51 | |
| *** freenzyfriday has quit IRC | 00:55 | |
| *** jamesmcarthur has joined #zuul | 00:56 | |
| *** rfolco has quit IRC | 01:01 | |
| *** hamalq has quit IRC | 01:04 | |
| *** jamesmcarthur has quit IRC | 01:23 | |
| *** jamesmcarthur has joined #zuul | 01:24 | |
| *** freenzyfriday has joined #zuul | 01:41 | |
| *** zenkuro has quit IRC | 01:43 | |
| *** saneax has joined #zuul | 01:46 | |
| *** freenzyfriday has quit IRC | 01:46 | |
| *** flaper87 has quit IRC | 02:19 | |
| *** flaper87 has joined #zuul | 02:20 | |
| *** freenzyfriday has joined #zuul | 02:35 | |
| *** freenzyfriday has quit IRC | 02:44 | |
| *** bhavikdbavishi has joined #zuul | 02:50 | |
| *** bhavikdbavishi1 has joined #zuul | 02:53 | |
| *** bhavikdbavishi has quit IRC | 02:54 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 02:54 | |
| *** jamesmcarthur has quit IRC | 03:41 | |
| *** jamesmcarthur has joined #zuul | 03:48 | |
| *** jamesmcarthur has quit IRC | 03:53 | |
| *** jamesmcarthur has joined #zuul | 03:58 | |
| *** saneax has quit IRC | 04:01 | |
| *** bhavikdbavishi has quit IRC | 04:28 | |
| *** bhavikdbavishi has joined #zuul | 04:28 | |
| *** freenzyfriday has joined #zuul | 04:31 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** freenzyfriday has quit IRC | 04:36 | |
| *** jamesmcarthur has quit IRC | 04:40 | |
| *** jamesmcarthur has joined #zuul | 04:41 | |
| *** jamesmcarthur has quit IRC | 04:46 | |
| *** jamesmcarthur has joined #zuul | 05:17 | |
| *** saneax has joined #zuul | 05:34 | |
| *** jamesmcarthur has quit IRC | 05:40 | |
| *** saneax has quit IRC | 05:45 | |
| bolg | clarkb: the ChangeDatabase in https://review.opendev.org/#/c/712958/44..45/tests/base.py was dropped because of the comment on patch 44. I would have only one dictionary, therefore I replaced it with that dictionary | 05:51 |
|---|---|---|
| bolg | *it would have... | 05:53 |
| *** saneax has joined #zuul | 05:54 | |
| bolg | tobiash: could you please elaborate on your comment https://review.opendev.org/#/c/717269/48/zuul/zk/__init__.py ? | 05:54 |
| *** jfoufas1 has joined #zuul | 05:57 | |
| tobiash | The specialized clients currently get connect, disconnect events in the sense started and stopped. We later might want to not only log zk session events but also react on them in one of that clients | 05:57 |
| tobiash | this will make it possible to do e.g. cleanup or recovery things when a component lost its session | 05:58 |
| tobiash | But this comment was not meant tonchange something in this change | 06:00 |
| *** bhavikdbavishi1 has joined #zuul | 06:07 | |
| *** bhavikdbavishi has quit IRC | 06:09 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:09 | |
| *** vishalmanchanda has joined #zuul | 06:19 | |
| *** freenzyfriday has joined #zuul | 06:32 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Configure redux for development https://review.opendev.org/755499 | 06:36 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Avoid state mutations in build reducers https://review.opendev.org/755500 | 06:36 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Improve fetch build actions and state-to-props handling on BuildPage https://review.opendev.org/755501 | 06:36 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Don't overwrite builds when retrieving the buildset https://review.opendev.org/755502 | 06:36 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Only request the buildset if it's not already available https://review.opendev.org/755503 | 06:36 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Add redux integration tests for build actions https://review.opendev.org/755504 | 06:36 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: PF4: Rework of log viewer page https://review.opendev.org/751140 | 06:36 |
| *** mach1na has joined #zuul | 06:45 | |
| jfoufas1 | I do not know if this is the right forum, but we are pondering how to trigger Hardware In the Loop (HIL) riggs in zuul. Today we must update some file in gerrit or use a timer. Is a MQTT driver as trigger totally out of the questions? | 06:54 |
| jfoufas1 | We might also use Concourse, @albin is looking into that | 06:56 |
| *** jcapitao has joined #zuul | 07:04 | |
| *** mach1na has quit IRC | 07:12 | |
| *** saneax has quit IRC | 07:13 | |
| *** bhavikdbavishi has quit IRC | 07:17 | |
| *** mach1na has joined #zuul | 07:19 | |
| *** mach1na has quit IRC | 07:32 | |
| *** sshnaidm|afk is now known as sshnaidm | 07:36 | |
| *** tosky has joined #zuul | 07:43 | |
| *** bhavikdbavishi has joined #zuul | 07:44 | |
| *** mach1na has joined #zuul | 07:50 | |
| *** rpittau|afk is now known as rpittau | 07:52 | |
| avass | jfoufas1: http://eavesdrop.openstack.org/irclogs/%23zuul/%23zuul.2020-10-13.log.html#t2020-10-13T17:57:29 :) | 07:53 |
| *** jpena|off is now known as jpena | 07:57 | |
| jfoufas1 | avass perfect, you already raised the topic! | 08:03 |
| *** nils has joined #zuul | 08:09 | |
| *** jamesmcarthur has joined #zuul | 08:16 | |
| *** saneax has joined #zuul | 08:20 | |
| *** jamesmcarthur has quit IRC | 08:21 | |
| *** hashar has joined #zuul | 08:24 | |
| openstackgerrit | Merged zuul/zuul master: Configure redux for development https://review.opendev.org/755499 | 08:46 |
| *** mach1na has quit IRC | 08:59 | |
| *** mach1na has joined #zuul | 09:01 | |
| openstackgerrit | Merged zuul/zuul master: Avoid state mutations in build reducers https://review.opendev.org/755500 | 09:13 |
| openstackgerrit | Merged zuul/zuul master: Improve fetch build actions and state-to-props handling on BuildPage https://review.opendev.org/755501 | 09:13 |
| openstackgerrit | Merged zuul/zuul master: Don't overwrite builds when retrieving the buildset https://review.opendev.org/755502 | 09:13 |
| openstackgerrit | Merged zuul/zuul master: Only request the buildset if it's not already available https://review.opendev.org/755503 | 09:13 |
| openstackgerrit | Merged zuul/zuul master: Add redux integration tests for build actions https://review.opendev.org/755504 | 09:13 |
| bolg | zuul-maint: Do we want to register zuul for https://www.openstack.org/ptg/. I guess we have some topics we could discuss: roadmap, scale-out scheduler, ... (https://storyboard.openstack.org/#!/story/2007192, https://etherpad.opendev.org/p/zuulv4) ? | 09:25 |
| *** freenzyfriday has quit IRC | 09:32 | |
| *** zenkuro has joined #zuul | 09:46 | |
| *** zenkuro has quit IRC | 10:16 | |
| *** zenkuro has joined #zuul | 10:16 | |
| *** wuchunyang has joined #zuul | 10:32 | |
| *** wuchunyang has quit IRC | 10:36 | |
| *** saneax has quit IRC | 10:44 | |
| *** bhavikdbavishi has quit IRC | 10:54 | |
| *** saneax has joined #zuul | 11:03 | |
| *** mach1na has quit IRC | 11:08 | |
| *** vishalmanchanda has quit IRC | 11:08 | |
| *** jcapitao is now known as jcapitao_lunch | 11:12 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Cache sql connection names in zuul-web https://review.opendev.org/758092 | 11:31 |
| *** jpena is now known as jpena|lunch | 11:36 | |
| *** mach1na has joined #zuul | 11:51 | |
| *** mach1na has quit IRC | 11:52 | |
| *** mach1na has joined #zuul | 11:52 | |
| *** rlandy has joined #zuul | 12:00 | |
| *** rlandy is now known as rlandy|rover | 12:00 | |
| *** jamesmcarthur has joined #zuul | 12:18 | |
| tristanC | bolg: i'd be happy to join, could we also add the zuul-runner spec to the agenda? https://review.opendev.org/681277 | 12:19 |
| *** ikhan has joined #zuul | 12:20 | |
| avass | i think i'd like to join that, gotta make sure i have some time over for it though :) | 12:22 |
| *** jamesmcarthur has quit IRC | 12:22 | |
| *** jamesmcarthur has joined #zuul | 12:26 | |
| *** jcapitao_lunch is now known as jcapitao | 12:28 | |
| *** rfolco has joined #zuul | 12:31 | |
| *** jamesmcarthur has quit IRC | 12:34 | |
| *** jpena|lunch is now known as jpena | 12:35 | |
| *** jamesmcarthur has joined #zuul | 12:35 | |
| *** Goneri has joined #zuul | 13:04 | |
| *** wuchunyang has joined #zuul | 13:04 | |
| ttx | something weird is happening when I browse to https://tarballs.opendev.org/zuul/zuul/ -- it seems to redirect to the Zuul console for some reason | 13:04 |
| *** jamesmcarthur has quit IRC | 13:05 | |
| fungi | not quite | 13:07 |
| *** jamesmcarthur has joined #zuul | 13:07 | |
| fungi | there was a problem with the webui javascript tarball publishing job for zuul | 13:07 |
| fungi | and it was publishing an unpacked copy of the content there | 13:07 |
| ttx | ah ok | 13:07 |
| fungi | zuul doesn't really use tarballs.o.o anyway, they consider the copies on pypi to be canonical (and can recreate packages from git if necessary) | 13:08 |
| *** wuchunyang has quit IRC | 13:09 | |
| *** jfoufas1 has quit IRC | 13:09 | |
| fungi | the javascript tarball publication is also obsolete at this point probably, we had some recent discussion about whether we could drop it as we don't think it's used by anyone these days | 13:09 |
| *** hashar has quit IRC | 13:11 | |
| ttx | yeah it seems nodepool wasn't refreshed there recently either | 13:13 |
| fungi | we were (maybe still are) publishing some master branch tip tarballs but i also don't know how useful those are to anyone | 13:15 |
| *** wuchunyang has joined #zuul | 13:15 | |
| *** Goneri has quit IRC | 13:18 | |
| *** wuchunyang has quit IRC | 13:20 | |
| *** jamesmcarthur has quit IRC | 13:28 | |
| bolg | tristanC: I guess some zuul-maint needs to register the project right? I would be happy to support where I can. | 13:33 |
| corvus | bolg, tristanC: if we're interested in having ptg discussions, i can see about getting us added | 13:37 |
| fungi | yeah, the deadline to sign up for timeslots was a little over a month ago per http://lists.zuul-ci.org/pipermail/zuul-discuss/2020-August/001317.html but they may still be able to make accommodations for us | 13:37 |
| fungi | but also, there's nothing stopping us from picking some times which work for folks whether it's that week or some other week and jumping in https://meetpad.opendev.org/ and working on whatever we want | 13:38 |
| corvus | i think we've done a pretty good job of asynchronous design on v4 and runner; i'm not sure there are big issues that we need a real-time meeting to work out? | 13:39 |
| bolg | corvus: great, definetely interested | 13:41 |
| corvus | bolg: what do you think a real-time meeting will bring? | 13:41 |
| corvus | ie, how will it help? | 13:41 |
| *** mach1na has quit IRC | 13:44 | |
| *** vishalmanchanda has joined #zuul | 13:44 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline" https://review.opendev.org/732069 | 13:44 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "job secrets" https://review.opendev.org/732070 | 13:44 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "job dependencies" https://review.opendev.org/732071 | 13:44 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Rename quick-start to zuul-tutorial-quick-start https://review.opendev.org/737656 | 13:44 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: [DNM] TEST run zuul tutorials to test stream+callback (+ zuul-jobs change) https://review.opendev.org/735477 | 13:44 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: [DNM] Test: run multiple tutorials ('job dependencies' 2 times) https://review.opendev.org/741558 | 13:44 |
| *** Goneri has joined #zuul | 13:48 | |
| bolg | corvus: I think it may be benefitial to discuss the current state, roadmap, progress, vision of v4. | 13:48 |
| *** jamesmcarthur has joined #zuul | 13:50 | |
| corvus | bolg: okay. i think we all agree on those things (we approved the v4 spec and have started on it). i get the most value out of ptg sessions when there is a clear problem statement and outcome. | 13:50 |
| corvus | bolg: if we still just want to get together to build comraderie, there's value in that too, but i think it's good to set expectations. :) | 13:51 |
| tristanC | perhaps a zuul-discuss thread would be more valuable for the important things, then we could discuss it after in real time | 13:54 |
| tristanC | i'd like to know what is the review order, for example i don't know where to rebase the zuul-runner changes | 13:54 |
| corvus | tristanC: for runner, it looks like we should see if any other zuul-maint folks want to approve the spec, then merge it | 13:57 |
| corvus | tristanC, bolg: but yes, we should probably figure out which of the runner / v4 changes we want to merge first because they are certain to conflict | 13:57 |
| *** mach1na has joined #zuul | 13:58 | |
| corvus | mailing list threads are usually a good base to build on at a ptg. so we should probably at least start with that. | 14:00 |
| corvus | and if feel like a real-time discussion would be good, we can schedule one | 14:01 |
| tobiash | zuul-maint: ftr, this is the runner spec and has +2 from corvus and me: https://review.opendev.org/681277 | 14:05 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Cache sql connection names in zuul-web https://review.opendev.org/758092 | 14:24 |
| *** Goneri has quit IRC | 14:31 | |
| *** ianychoi_ has quit IRC | 14:33 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Test zuul-client builds subcommand https://review.opendev.org/758141 | 14:33 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Test zuul-client builds subcommand https://review.opendev.org/758141 | 14:36 |
| *** Goneri has joined #zuul | 14:36 | |
| *** avass has quit IRC | 14:46 | |
| *** lliu82 has joined #zuul | 14:48 | |
| *** ianychoi has joined #zuul | 14:51 | |
| lliu82 | hi, I am trying to connect a new gerrit to zuul. I am now trying to create a zuul user in the new gerrit instance. However, the ssh result shows that fatal: Group "Registered Users" does not exist | 14:51 |
| clarkb | lliu82: can you check the gerrit error_log in review_site/logs to see if there is more info? | 14:53 |
| clarkb | registered users is a meta group iirc so maybe there is some issue in dynamically generating its membership | 14:53 |
| lliu82 | although it send out the error, zuul user is created | 15:01 |
| *** ikhan has quit IRC | 15:04 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Test zuul-client builds subcommand https://review.opendev.org/758141 | 15:07 |
| *** ikhan has joined #zuul | 15:07 | |
| *** ikhan has quit IRC | 15:14 | |
| *** ikhan has joined #zuul | 15:14 | |
| *** nils has quit IRC | 15:26 | |
| *** mach1na has quit IRC | 15:29 | |
| *** nils has joined #zuul | 15:30 | |
| *** nils has quit IRC | 15:30 | |
| *** nils has joined #zuul | 15:31 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Test zuul-client builds subcommand https://review.opendev.org/758141 | 15:35 |
| *** saneax has quit IRC | 15:38 | |
| *** mach1na has joined #zuul | 15:45 | |
| *** mach1na has quit IRC | 15:50 | |
| *** saneax has joined #zuul | 15:51 | |
| *** bhavikdbavishi has joined #zuul | 16:02 | |
| *** rpittau is now known as rpittau|afk | 16:05 | |
| *** hashar has joined #zuul | 16:15 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Test zuul-client builds subcommand https://review.opendev.org/758141 | 16:18 |
| *** tosky has quit IRC | 16:21 | |
| *** bhavikdbavishi1 has joined #zuul | 16:22 | |
| *** bhavikdbavishi has quit IRC | 16:23 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 16:23 | |
| *** nils has quit IRC | 16:33 | |
| *** rlandy|rover is now known as rlandy|rover|brb | 16:33 | |
| *** iurygregory has quit IRC | 16:41 | |
| *** hamalq has joined #zuul | 16:41 | |
| *** iurygregory has joined #zuul | 16:44 | |
| *** saneax has quit IRC | 16:46 | |
| *** saneax has joined #zuul | 16:48 | |
| *** lliu82 has quit IRC | 16:48 | |
| *** zenkuro has quit IRC | 16:55 | |
| *** zenkuro has joined #zuul | 17:00 | |
| *** jamesmcarthur has quit IRC | 17:02 | |
| *** mach1na has joined #zuul | 17:05 | |
| *** hamalq has quit IRC | 17:08 | |
| *** mach1na has quit IRC | 17:10 | |
| *** hamalq has joined #zuul | 17:12 | |
| *** avass has joined #zuul | 17:13 | |
| *** rlandy|rover|brb is now known as rlandy|rover | 17:13 | |
| *** wuchunyang has joined #zuul | 17:13 | |
| *** jamesmcarthur has joined #zuul | 17:14 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: [DNM] TEST run tutorials with increased logging https://review.opendev.org/758217 | 17:14 |
| *** jamesmcarthur has quit IRC | 17:15 | |
| *** jamesmcarthur has joined #zuul | 17:15 | |
| *** wuchunyang has quit IRC | 17:18 | |
| *** jamesmcarthur has quit IRC | 17:19 | |
| *** jpena is now known as jpena|off | 17:22 | |
| *** avass has quit IRC | 17:23 | |
| *** avass has joined #zuul | 17:26 | |
| *** avass has quit IRC | 17:27 | |
| *** avass has joined #zuul | 17:28 | |
| *** avass_ has joined #zuul | 17:32 | |
| *** avass_ has quit IRC | 17:32 | |
| *** avass has quit IRC | 17:38 | |
| *** Goneri has quit IRC | 17:45 | |
| *** Goneri has joined #zuul | 17:47 | |
| *** freenzyfriday has joined #zuul | 17:54 | |
| *** hashar is now known as hasharDinner | 17:55 | |
| *** jamesmcarthur has joined #zuul | 17:59 | |
| *** jamesmcarthur has quit IRC | 18:05 | |
| *** jamesmcarthur has joined #zuul | 18:05 | |
| openstackgerrit | Merged zuul/zuul-jobs master: Consolidate common log upload code into module_utils https://review.opendev.org/742736 | 18:28 |
| fungi | is https://review.opendev.org/753199 safe to merge or should we give folks who are using it more time to make sure their executors have https://review.opendev.org/753222 deployed? | 18:29 |
| *** bhavikdbavishi has quit IRC | 18:31 | |
| *** bhavikdbavishi has joined #zuul | 18:32 | |
| clarkb | I think it should be safe because the old version needs to run trusted | 18:35 |
| corvus | fungi: i think that role currently only works in trusted jobs | 18:35 |
| corvus | yeah that | 18:35 |
| corvus | :) | 18:35 |
| corvus | so if someone is running that in the trusted context in either old or new zuul, that should work because shell and find both work in trusted context. | 18:36 |
| corvus | if someone is running old zuul, that already doesn't work in untrusted context | 18:36 |
| corvus | but if someone is running new zuul, and that merges, they will be able to run that untrusted. | 18:36 |
| fungi | aha, got it | 18:36 |
| fungi | thanks | 18:36 |
| *** saneax has quit IRC | 18:39 | |
| *** avass has joined #zuul | 18:44 | |
| openstackgerrit | Merged zuul/zuul-jobs master: Refactor fetch-sphinx-tarball to be executor safe https://review.opendev.org/753199 | 18:51 |
| AJaeger | thanks, fungi! | 18:51 |
| *** avass has left #zuul | 19:03 | |
| *** freenzyfriday has quit IRC | 19:05 | |
| *** avass has joined #zuul | 19:06 | |
| *** avass has quit IRC | 19:06 | |
| *** mach1na has joined #zuul | 19:07 | |
| *** yourname_ has joined #zuul | 19:07 | |
| *** yourname_ has quit IRC | 19:09 | |
| *** yourname_ has joined #zuul | 19:09 | |
| *** mach1na has quit IRC | 19:12 | |
| *** bhavikdbavishi has quit IRC | 19:21 | |
| *** mach1na has joined #zuul | 19:24 | |
| *** mach1na has quit IRC | 19:29 | |
| corvus | fungi: i just had a *very* brief conversation with someone in the booth about zuul | 19:46 |
| fungi | woah! | 19:46 |
| fungi | the one from the electronics company? | 19:46 |
| corvus | they just learned about it today, wondered if there were any distributors of it | 19:46 |
| corvus | yeah | 19:47 |
| fungi | did you reach out to them, or they you? | 19:47 |
| corvus | they contacted me | 19:47 |
| fungi | awesome. i have yet to see any chat requests other than your tests yesterday | 19:47 |
| corvus | they are a redhat reseller i think? so that text under my name may have been the deciding factor... | 19:48 |
| corvus | anyway, i answered some really basic questions then they went on to the next booth before i could say much more | 19:48 |
| fungi | still, that's the most live interaction the booth has gotten these past two days | 19:49 |
| *** tosky has joined #zuul | 19:53 | |
| *** vishalmanchanda has quit IRC | 20:08 | |
| *** saneax has joined #zuul | 20:10 | |
| *** saneax has quit IRC | 20:14 | |
| tobiash | corvus, clarkb: I've seen a few post failures in opendev with missing logs. We enhanced our log uploading with a list of failover clouds. Maybe such a failover would make sense in opendev (and generally for the upload-logs roles) as well? | 20:18 |
| clarkb | tobiash: how did you enhance it? (and can that go in zuul-jobs?) | 20:19 |
| clarkb | that was a feature pabelanger wanted for ansible too, we couldn't figure out how to wrangle ansible to do it | 20:19 |
| tobiash | clarkb: currently we loop over the role until it succeeded in the post playbook, but actually a preferred way would be to enhance the roles to do that by themselves probably | 20:20 |
| clarkb | tobiash: I think the reason we didn't change the roles is we don't want to give them a giant list of credentials and instead prefer to give them one thing to do at a time | 20:20 |
| clarkb | the problem with that though is ansible's logic for randomly try the next one is non existant | 20:20 |
| clarkb | tobiash: do you randomly loop somehow? | 20:21 |
| clarkb | fwiw figuring this out would be great | 20:21 |
| tobiash | I did random at first (it worked) but since we have a log proxy with the same failover I changed it to be sequential to have a primary cloud for log proxy performance reasons | 20:21 |
| tobiash | the random was just implemented by a shuffling of the list before the loop | 20:22 |
| clarkb | got it | 20:22 |
| clarkb | I think we'd still want random but that sounds great. Do you think that is something you could push to zuul-jobs? | 20:22 |
| clarkb | or wait thats in base-jobs I guess | 20:23 |
| clarkb | just the role is in zuul-jobs. Maybe share what you've got in base-jobs and we can adapt it? | 20:23 |
| tobiash | maybe on zuul-jobs a generic upload-logs-with-failover would make sense (with support of different failover cloud types) | 20:23 |
| corvus | that sounds like it would make sense | 20:23 |
| tobiash | I can try to get something tomorrow then (basically a modified version of our thing as a role in zj) | 20:24 |
| corvus | keep the individual roles simple, and for advanced use cases, have the containing role which requires lots of data :) | 20:24 |
| tobiash | it works really well and saved us of having no logs already a few times | 20:25 |
| clarkb | ya the only concern I have iwth it is that it will easily hide broken upload targets | 20:25 |
| tobiash | since we have that log upload has been a non-issue so far | 20:25 |
| clarkb | but from a user perspecitve its much better | 20:25 |
| corvus | (putting on my opendev hat though -- what clarkb said) | 20:25 |
| corvus | we should totally have that capability in zuul-jobs; then we should think about whether/how we should use it in opendev :) | 20:26 |
| tobiash | it also could spit out warnings using https://review.opendev.org/651526 if one target failed ;) | 20:27 |
| corvus | ya | 20:27 |
| Goneri | https://opendev.org/zuul/zuul-jobs/commit/5d1662b56b09093eb837d74b39b2efd25dc09943 broke us (Ansible CI) | 20:28 |
| Goneri | it has a new dependency on google.auth that we don't have: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-base/module_utils/zuul_jobs/upload_utils.py#L45 | 20:29 |
| tobiash | oh that should not be in the generic part | 20:30 |
| corvus | Goneri: oops, that was not intentional | 20:30 |
| corvus | tobiash: do you think we can hotfix or should we revert? | 20:30 |
| tobiash | corvus: checking, can you prepare the revert in parallel? | 20:30 |
| corvus | will do | 20:30 |
| tobiash | thx | 20:31 |
| Goneri | great, should we work on some workaround in the meantime? | 20:32 |
| *** jamesmcarthur has quit IRC | 20:32 | |
| yourname_ | looks like it shouldn't be too hard to fix | 20:32 |
| corvus | Goneri: i think we will approve a fix within 10 minutes and it should be merged by maybe 15 minutes after that | 20:32 |
| Goneri | ok, great. | 20:33 |
| openstackgerrit | James E. Blair proposed zuul/zuul-jobs master: Revert "Consolidate common log upload code into module_utils" https://review.opendev.org/758247 | 20:33 |
| *** yourname_ is now known as avass | 20:33 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Remove unneeded gce from upload_utils https://review.opendev.org/758248 | 20:34 |
| tobiash | I think this hotfix should work ^ | 20:34 |
| avass | tobiash: lgtm looks like it's completely dupliated and unused in that file | 20:35 |
| corvus | ianw: ^ are you around to +3 758248 (is urgent) | 20:35 |
| tobiash | Goneri: sorry for this oversight | 20:35 |
| corvus | fungi: thx; ianw ^ still available for retro-review :) | 20:36 |
| Goneri | np, thanks for the reactivity | 20:37 |
| fungi | Goneri: thanks for the heads up, i didn't spot that when reviewing earlier | 20:37 |
| corvus | those reorg changes can make you cross-eyed reviewing, and of course we do have all the deps in the tests :/ | 20:37 |
| fungi | i didn't directly review it, but i skimmed and told AJaeger i'd be around to watch for fallout from it | 20:39 |
| fungi | and yeah, it was not entirely small, but overall seems like a big improvement for maintainability | 20:39 |
| corvus | yeah, it's a great change | 20:39 |
| fungi | so glad it doesn't look like we need to revert | 20:40 |
| tobiash | :) | 20:40 |
| *** jamesmcarthur has joined #zuul | 20:40 | |
| tobiash | oh I think I need to push an update real quick, there are now unused imports | 20:41 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Remove unneeded gce from upload_utils https://review.opendev.org/758248 | 20:43 |
| corvus | tobiash, avass, fungi, ianw: can you look at the failure here: https://9dfd50a9331e5f6b74ea-fdc6c3614653bf0b139fa050a159caa6.ssl.cf1.rackcdn.com/712958/45/gate/zuul-build-python-release/044cdd0/job-output.txt | 20:50 |
| corvus | 2020-10-14 20:10:32.546891 | TASK [merge-output-to-logs : Copy artifacts into log root] | 20:50 |
| avass | corvus: exector? | 20:50 |
| corvus | avass: yeah that would do it | 20:50 |
| corvus | maybe that's a typo in the thing that just merged | 20:50 |
| corvus | yeah | 20:51 |
| corvus | that clearly wasn't tested | 20:51 |
| corvus | we may need to force-merge a revert of that and re-enqueue tobiash's change | 20:52 |
| corvus | the fix is obvious, but i actually want to revert that one instead of fixing because i think we were counting on that being self-tested | 20:52 |
| corvus | so i'd like to see it actually be tested before we fix it | 20:53 |
| openstackgerrit | James E. Blair proposed zuul/zuul-jobs master: Revert "Refactor fetch-sphinx-tarball to be executor safe" https://review.opendev.org/758250 | 20:54 |
| tobiash | ++ | 20:55 |
| corvus | tobiash: we may escape that issue hitting your change | 20:55 |
| corvus | (the jobs running on it might not exercise that role) | 20:56 |
| corvus | so hopefully we can let the gce fix continue | 20:56 |
| tobiash | yepp | 20:57 |
| tobiash | btw, there are two typos in that change | 20:57 |
| fungi | completely agree | 20:57 |
| corvus | glad i didn't chose the hotfix option for that one :) | 20:57 |
| *** hasharDinner has quit IRC | 20:57 | |
| tobiash | if zuul-jobs doesn't produce artifact files it probably won't be hit by that | 20:58 |
| openstackgerrit | Merged zuul/zuul-jobs master: Remove unneeded gce from upload_utils https://review.opendev.org/758248 | 20:58 |
| corvus | Goneri: ^ should be good now | 20:58 |
| corvus | my time estimate was off by 1 minute | 20:59 |
| tobiash | wow :D | 20:59 |
| fungi | unforeseen circumstances | 20:59 |
| fungi | (and untested changes) | 21:00 |
| fungi | which i definitely should have noticed when reviewing and approving it | 21:02 |
| ianw | hrm, my understanding was re-enabling the test meant it was being tested ... which clearly isn't the case | 21:03 |
| fungi | corvus: unrelated, we're abandoning the ansiblefest booth interface now that the conference is over | 21:04 |
| fungi | thanks for being on hand for questions (and fielding the only one we got) | 21:04 |
| tobiash | ianw: it ran the job, but the test probably didn't create artifact and docs files so it didn't run into the error | 21:06 |
| tobiash | without such files it skips the tasks with the typos | 21:06 |
| corvus | fungi: thanks, i'll head out too then | 21:07 |
| openstackgerrit | Merged zuul/zuul-jobs master: Revert "Refactor fetch-sphinx-tarball to be executor safe" https://review.opendev.org/758250 | 21:07 |
| fungi | yeah, but i feel like i should have checked the build results for it executing those tasks | 21:07 |
| ianw | fungi: yeah, i think we all assumed the original test was actually a test, and ergo the revert must mean the test was passing. which is a fair assumption for a long-standing extant test | 21:09 |
| ianw | anyway, i'll fiddle on a revert-revert that does actually test | 21:09 |
| avass | maybe we should add some tests that test the tests to make sure that they're tested :) | 21:10 |
| *** zenkuro has quit IRC | 21:10 | |
| tobiash | ianw: maybe changing doc to docs and adding something to artifacts here does the job: https://opendev.org/zuul/zuul-jobs/src/branch/master/test-playbooks/python/fetch-sphinx-tarball.yaml#L12 | 21:10 |
| corvus | avass: heh, it's um... something we've had to do before (i'm looking at nosetest exit codes) | 21:10 |
| corvus | ("exit 0! ran 0 tests!") | 21:11 |
| fungi | for some reason the hardest part of testing software is being sure you actually tested it | 21:11 |
| avass | corvus: oh.. | 21:11 |
| avass | fungi: usually doing a quick check to make sure that they break when they should before is enough. but yeah it's a bit hard to enforce that | 21:15 |
| *** mach1na has joined #zuul | 21:25 | |
| *** mach1na has quit IRC | 21:30 | |
| *** rfolco has quit IRC | 21:38 | |
| *** rf0lc0 has joined #zuul | 21:38 | |
| *** rf0lc0 has quit IRC | 21:56 | |
| *** ikhan has quit IRC | 22:06 | |
| *** erbarr has quit IRC | 22:13 | |
| *** erbarr has joined #zuul | 22:15 | |
| *** rlandy|rover has quit IRC | 22:16 | |
| openstackgerrit | Merged zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 22:25 |
| *** ikhan has joined #zuul | 22:28 | |
| *** wuchunyang has joined #zuul | 22:38 | |
| *** wuchunyang has quit IRC | 22:42 | |
| *** hamalq has quit IRC | 23:02 | |
| *** hamalq has joined #zuul | 23:08 | |
| *** jamesmcarthur has quit IRC | 23:11 | |
| *** jamesmcarthur has joined #zuul | 23:17 | |
| *** tosky has quit IRC | 23:27 | |
| *** mach1na has joined #zuul | 23:42 | |
| *** mach1na has quit IRC | 23:46 | |
| *** zenkuro has joined #zuul | 23:51 | |
| *** holser has quit IRC | 23:51 | |
| *** Goneri has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!