| *** freenzyfriday has joined #zuul | 00:10 | |
| *** freenzyfriday has quit IRC | 00:20 | |
| *** jamesmcarthur has quit IRC | 00:23 | |
| *** hamalq has quit IRC | 00:32 | |
| *** yolanda has quit IRC | 00:38 | |
| *** yolanda has joined #zuul | 00:39 | |
| *** Goneri has quit IRC | 00:39 | |
| *** freenzyfriday has joined #zuul | 01:04 | |
| *** freenzyfriday has quit IRC | 01:09 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 01:33 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 01:33 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 01:33 |
| openstackgerrit | Merged zuul/zuul-jobs master: Make sure that we pass list in loop https://review.opendev.org/754612 | 01:35 |
| *** hamalq has joined #zuul | 01:37 | |
| *** freenzyfriday has joined #zuul | 01:59 | |
| *** jamesmcarthur has joined #zuul | 02:04 | |
| *** freenzyfriday has quit IRC | 02:08 | |
| *** mmedvede has quit IRC | 02:21 | |
| *** mmedvede has joined #zuul | 02:24 | |
| *** hamalq has quit IRC | 02:45 | |
| *** jamesmcarthur has quit IRC | 03:00 | |
| *** bhavikdbavishi has joined #zuul | 03:07 | |
| *** bhavikdbavishi1 has joined #zuul | 03:10 | |
| *** bhavikdbavishi has quit IRC | 03:12 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:12 | |
| *** freenzyfriday has joined #zuul | 03:47 | |
| *** freenzyfriday has quit IRC | 03:56 | |
| *** jamesmcarthur has joined #zuul | 04:06 | |
| *** jamesmcarthur has quit IRC | 04:11 | |
| *** bhavikdbavishi has quit IRC | 04:27 | |
| *** bhavikdbavishi has joined #zuul | 04:28 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** freenzyfriday has joined #zuul | 05:37 | |
| *** freenzyfriday has quit IRC | 05:46 | |
| *** freenzyfriday has joined #zuul | 06:00 | |
| *** bhavikdbavishi1 has joined #zuul | 06:01 | |
| *** bhavikdbavishi has quit IRC | 06:03 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:03 | |
| *** mach1na has joined #zuul | 06:10 | |
| *** mach1na has quit IRC | 06:10 | |
| *** mach1na has joined #zuul | 06:10 | |
| *** mach1na has quit IRC | 06:22 | |
| *** mach1na has joined #zuul | 06:26 | |
| *** jfoufas1 has joined #zuul | 06:29 | |
| *** bhavikdbavishi has quit IRC | 06:35 | |
| *** noonedeadpunk has quit IRC | 06:37 | |
| *** noonedeadpunk has joined #zuul | 06:37 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 06:38 |
| openstackgerrit | Merged zuul/zuul-jobs master: Fix promote cleanup https://review.opendev.org/754865 | 06:42 |
| *** saneax has joined #zuul | 06:48 | |
| *** jfoufas194 has joined #zuul | 07:00 | |
| *** jfoufas1 has quit IRC | 07:00 | |
| *** hamalq has joined #zuul | 07:02 | |
| *** hamalq has quit IRC | 07:08 | |
| *** jcapitao has joined #zuul | 07:09 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 07:10 |
| *** hamalq has joined #zuul | 07:24 | |
| *** hamalq has quit IRC | 07:29 | |
| felixedel | clarkb, fungi: Regarding the clickable row/not markable text on the builds and buildsets page. It was my intentation to make the whole row clickable, but to be honest I didn't think about marking the text in row and that it would break this behaviour. I would avoid making only the text clickable as this feels a little weird IMHO and it would also confuse as the change itself is clickable but points to a different URL. | 07:37 |
| felixedel | A solution to the problem would be a something like an "action column" that shows a button (e.g. "Show build" resp. "Show buildset") like here https://www.patternfly.org/v4/documentation/react/components/table#actions (instead of the menu icon, we could directly provide a button). I wanted to avoid those action columns as I'm not a big fan of them but I have to admit that I don't have a better solution. | 07:37 |
| felixedel | Maybe as an extension to that we could make the table rows collapsible, meaning when clicking on the row a detail row would open (so you could still click the whole row to see more information), but don't change the page. That would also allow to mark the text under the cursor without activating a link. Like so https://www.patternfly.org/v4/documentation/react/components/table#compact-expandable We would still need to | 07:40 |
| felixedel | use an action column to provide a button to switch to the build result page though | 07:40 |
| felixedel | The same applies for the build list on the buildset result page. Should we then also use an action column with a "Show build" button for those to be consistent? | 07:40 |
| *** tosky has joined #zuul | 07:45 | |
| *** jpena|off is now known as jpena | 07:55 | |
| *** hamalq has joined #zuul | 08:01 | |
| *** bhavikdbavishi has joined #zuul | 08:06 | |
| *** hamalq has quit IRC | 08:06 | |
| *** jamesmcarthur has joined #zuul | 08:10 | |
| *** jamesmcarthur has quit IRC | 08:15 | |
| *** hashar has joined #zuul | 08:20 | |
| *** sshnaidm|off is now known as sshnaidm | 08:33 | |
| *** bhavikdbavishi1 has joined #zuul | 08:40 | |
| *** bhavikdbavishi has quit IRC | 08:42 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 08:42 | |
| *** systemd has quit IRC | 09:07 | |
| *** saneax has quit IRC | 09:14 | |
| *** systemd has joined #zuul | 09:19 | |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Partial address ansible-lint E208 https://review.opendev.org/748480 | 09:31 |
| *** arxcruz has quit IRC | 09:35 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 09:43 |
| *** arxcruz has joined #zuul | 09:46 | |
| *** jamesmcarthur has joined #zuul | 10:14 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 10:15 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Optimize stats reporting per node request https://review.opendev.org/754967 | 10:31 |
| *** bhavikdbavishi has quit IRC | 10:38 | |
| *** hashar has quit IRC | 10:50 | |
| *** jcapitao is now known as jcapitao_lunch | 11:07 | |
| *** mach1na has quit IRC | 11:10 | |
| *** bhavikdbavishi has joined #zuul | 11:25 | |
| *** jpena is now known as jpena|lunch | 11:31 | |
| *** hashar has joined #zuul | 11:38 | |
| *** mach1na has joined #zuul | 11:49 | |
| *** Goneri has joined #zuul | 11:51 | |
| *** mach1na has quit IRC | 11:53 | |
| *** mach1na has joined #zuul | 11:59 | |
| zbr | felixedel: pf4 example is correct, the expand button is at the start of the row, now a random column in the middle. Also this does not prevent people from selecting/copy from the table row without interfering with expand/collapse. | 12:07 |
| *** rlandy has joined #zuul | 12:08 | |
| *** jamesmcarthur has quit IRC | 12:12 | |
| *** jamesmcarthur has joined #zuul | 12:16 | |
| *** rfolco|ruck has joined #zuul | 12:22 | |
| felixedel | zbr: Yes, the expand button is at the start of the row. Never said something else, or? What I meant with "action column" was to add a column to the end of the row to provide some action buttons. | 12:23 |
| zbr | felixedel: which actions do you have in mind? | 12:25 |
| felixedel | "Show build/set" to avoid the whole table row being a link to the build/set page. Which is the main reson why you can't mark the text inside the row. Unless you have a better solution for that. There might be some hacky JS solution where you could prevent the click when something is marked, but I think we shouldn't go for something like this :D | 12:26 |
| zbr | i would personally celebrate if we replace the button-popup with an expand section, that click on colored button is worse than option-click on Apple UI ;) | 12:26 |
| felixedel | We would still need a link to the build/set page somewhere. If we put that in the details view, one would always need two clicks to get there. | 12:27 |
| zbr | ahh, that is about "builds" page.... | 12:27 |
| felixedel | yes, it's about the link from the builds table to the build page | 12:28 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 12:28 |
| *** jcapitao_lunch is now known as jcapitao | 12:28 | |
| felixedel | That's at least my understanding :D Maybe there is a similar problem somewhere else but that's the one I'm aware of | 12:28 |
| zbr | usually one of the first columns should be an "id" one, and that one should be clickable, but at this moment we have no such columns | 12:29 |
| zbr | and clearly we do not want to display a GUID as a column | 12:29 |
| felixedel | And I made the whole row clickable as I wanted to avoid having buttons at the end of the raw. But this has indeed the drawback that you can't mark text within the row | 12:29 |
| felixedel | We could make the result icon clickable, but this might also be not intuitive enough to everybody | 12:29 |
| felixedel | It would be the same like the result column in the old version of the table which was IMHO also not intuitive that you have to click this one to get to the builds page | 12:30 |
| zbr | lets avoid hidden link (result) and add new narrow column, one with a magnifying glass on each row. | 12:32 |
| zbr | preferably an unicode based one, so we can see it using normal hyperlink color (blue) | 12:33 |
| *** jpena|lunch is now known as jpena | 12:33 | |
| zbr | and if visited will likely be colored with magenta (not up to you to do it, that is browser stuff). | 12:33 |
| *** AshBullock has joined #zuul | 12:33 | |
| *** yolanda has quit IRC | 12:38 | |
| AshBullock | Hey all, since pulling in this recent change https://opendev.org/zuul/zuul/commit/83281e33565dfe872c3b82bb4a80733971ff216e our github driver is failing to pull the commit information and as a result jobs fail to schedule http://paste.openstack.org/show/798515/ | 12:39 |
| *** yolanda has joined #zuul | 12:39 | |
| * zbr thinking to advertise https://github.com/pycontribs/gri -- command line interface to deal with CRs/PRs | 12:40 | |
| AshBullock | prior to this change jobs were scheduling on the github driver as expected, is there anything I could be missing or could there be a bug with this? | 12:40 |
| felixedel | Using a magnifying glass would indeed use less space than some "Show build" button. I can try that out tomorrow and see how it looks - unless somebody else wants to do that. | 12:42 |
| *** goneri_ has joined #zuul | 12:43 | |
| *** armstrongs has joined #zuul | 12:53 | |
| *** goneri_ has quit IRC | 12:56 | |
| *** AshBullock has quit IRC | 13:08 | |
| *** AshBullock has joined #zuul | 13:08 | |
| openstackgerrit | zbr proposed zuul/zuul master: Enable optional pre-wrapping on console and output https://review.opendev.org/723603 | 13:14 |
| *** iurygregory has quit IRC | 13:15 | |
| *** bhavikdbavishi has quit IRC | 13:21 | |
| *** jamesmcarthur has quit IRC | 13:27 | |
| *** jamesmcarthur has joined #zuul | 13:28 | |
| *** iurygregory has joined #zuul | 13:30 | |
| armstrongs | hey guys i think these changes are breaking the github driver https://review.opendev.org/#/c/753243/ we are using github enterprise 2.17.4 at the moment. Events are no longer firing seeing the same thing as AshBullock | 13:32 |
| armstrongs | I am using a github app to schedule the events to the driver | 13:37 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/691253 | 13:38 |
| tobiash | armstrongs: do you have more detailed logs? | 13:40 |
| tobiash | armstrongs: the graphql query used there is already there since a longer time | 13:40 |
| fungi | armstrongs: AshBullock reported a similar suspicion about that commit roughly an hour ago | 13:45 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/691253 | 13:45 |
| tobiash | armstrongs: are you planning to update your github enterprise? 2.17 is deprecated by github since may | 13:46 |
| *** sshnaidm has quit IRC | 13:48 | |
| armstrongs | im asking the team that manage github at the moment | 13:48 |
| tobiash | armstrongs: can you manually run this query against your github and tell me the error message? https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/github/graphql/canmerge-legacy.graphql | 13:48 |
| tobiash | we're already having a versioned query there so maybe we can just remove the stuff 2.17 doesn't support and add another version | 13:49 |
| AshBullock | tobiash the logs don't show much more than the fetch_canmerge method failing http://paste.openstack.org/ but it's across all projects and seems it was not originally calling that method until now here: https://opendev.org/zuul/zuul/src/commit/83281e33565dfe872c3b82bb4a80733971ff216e/zuul/driver/github/githubconnection.py#L1493 | 13:50 |
| tobiash | before it was calling this method in canmerge before enqueing changes into the gate | 13:50 |
| tobiash | it would be helpful to get a github response to the above linked query | 13:51 |
| tobiash | if it's really that change that breaks it (if gate worked previously) then it's probably those additions: https://review.opendev.org/#/c/753243/6/zuul/driver/github/graphql/canmerge-legacy.graphql | 13:51 |
| AshBullock | ok cool, I'll run that against our github instance and post the output | 13:55 |
| *** sshnaidm has joined #zuul | 13:58 | |
| AshBullock | hey tobiash here's the output of that canmerge-legacy.graphql http://paste.openstack.org/show/798518/ | 14:10 |
| tobiash | AshBullock: did you test with app auth or a personal access token? | 14:11 |
| AshBullock | tobiash that was with a personal access token | 14:13 |
| *** jamesmcarthur has quit IRC | 14:13 | |
| tobiash | AshBullock: this also already includes the isDraft: https://review.opendev.org/#/c/709836/ | 14:13 |
| tobiash | (that merged in march) | 14:14 |
| tobiash | that is weird, are you using gate pipelines? | 14:14 |
| AshBullock | yeah it's odd as we are using gate pipelines for PR's and it was definitely working for us before that change | 14:16 |
| danpawlik | clarkb, ianw: hey, could you check that change in free time please? https://review.opendev.org/#/c/644927/ | 14:17 |
| AshBullock | were you thinking it could of been an access issue with the graphql query? it seems like the response returning correct output rather than a permissions issue | 14:18 |
| tobiash | AshBullock: could be, are you able to run it with app auth just like zuul? | 14:18 |
| tobiash | github has even already removed the docs of 2.17 :/ | 14:20 |
| tobiash | AshBullock: what could help you is to run tools/github-debugging.py manually (need to edit some things in there) | 14:25 |
| tobiash | with that you can instanciate a real zuul GithubConnection object and call any methods in there (in this case getChange probably) | 14:25 |
| AshBullock | I wondering if it could be due to our app permissions | 14:25 |
| tobiash | do you have check run permissions? | 14:26 |
| AshBullock | Yeah we have check run enabled | 14:27 |
| *** jfoufas194 has quit IRC | 14:28 | |
| *** hashar has quit IRC | 14:29 | |
| AshBullock | I'll look further at the app permissions and try run the graphql as the app, thanks for the help with this | 14:32 |
| *** jpena is now known as jpena|off | 14:53 | |
| *** jpena|off is now known as jpena | 14:55 | |
| clarkb | felixedel: fungi: ya I'm not sure what the best option is, I just mentioned how gitea does directory listings and that seems to work reasonably well. You are correct that different text may have different links though which could be confusing to people | 14:57 |
| corvus | clarkb, felixedel: was just having the result text as a link to the result page a problem? | 15:07 |
| clarkb | corvus: I think that is how the old code worked and I think some people did have a hard time realizing the SUCCESS/FAILURE text were links? | 15:09 |
| clarkb | maybe if we add the little url icon thing like we do on the change urls that would help people see that? | 15:09 |
| *** AshBullock has quit IRC | 15:09 | |
| corvus | or underline them? | 15:09 |
| clarkb | guillaumec: fyi I left a note on https://review.opendev.org/#/c/754359/ confirming ianw's suspicion there if you have a moment to push a new patchset and confirm it with testing | 15:15 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix bindep.txt: clean remaining python3.7 https://review.opendev.org/754359 | 15:16 |
| guillaumec | clarkb, here you are ^ | 15:16 |
| clarkb | thanks! | 15:17 |
| *** iurygregory has quit IRC | 15:20 | |
| openstackgerrit | Andrii Ostapenko proposed zuul/zuul-jobs master: Fix certificate issue with use buildset registry https://review.opendev.org/741584 | 15:21 |
| openstackgerrit | Andrii Ostapenko proposed zuul/zuul-jobs master: Fix certificate issue with use buildset registry https://review.opendev.org/741584 | 15:24 |
| *** iurygregory has joined #zuul | 15:28 | |
| *** mach1na has quit IRC | 15:30 | |
| clarkb | alright last call on python3.8 docker iamges for zuul. I'm going to approve that before my bike ride if no one objects | 15:30 |
| *** mach1na has joined #zuul | 15:31 | |
| corvus | clarkb: what change? | 15:32 |
| corvus | oh i think it's https://review.opendev.org/727374 | 15:34 |
| clarkb | ya https://review.opendev.org/#/c/727374/ | 15:34 |
| corvus | +2 on that and guillaumec's change; will let clarkb +w both | 15:35 |
| *** bhavikdbavishi has joined #zuul | 15:36 | |
| *** mach1na has quit IRC | 15:36 | |
| *** bhavikdbavishi1 has joined #zuul | 15:39 | |
| *** bhavikdbavishi has quit IRC | 15:40 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 15:40 | |
| *** hashar has joined #zuul | 15:51 | |
| *** hamalq has joined #zuul | 16:00 | |
| guillaumec | zuul-maint: multiple changes involving tutorials waiting for reviews: to give more context: https://etherpad.opendev.org/p/zuul-tutorial | 16:18 |
| *** jcapitao has quit IRC | 16:25 | |
| *** smyers has quit IRC | 16:55 | |
| *** hamalq has quit IRC | 16:58 | |
| *** jpena is now known as jpena|off | 17:06 | |
| openstackgerrit | Merged zuul/zuul master: Update images to use python 3.8 https://review.opendev.org/727374 | 17:11 |
| openstackgerrit | Merged zuul/zuul master: Fix bindep.txt: clean remaining python3.7 https://review.opendev.org/754359 | 17:11 |
| *** ianychoi_ has joined #zuul | 17:17 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 17:18 |
| *** ianychoi has quit IRC | 17:20 | |
| *** freenzyfriday has quit IRC | 17:36 | |
| *** erbarr has quit IRC | 17:37 | |
| *** iamweswilson has quit IRC | 17:37 | |
| *** PrinzElvis has quit IRC | 17:37 | |
| *** gmann has quit IRC | 17:37 | |
| *** mnasiadka has quit IRC | 17:37 | |
| *** donnyd has quit IRC | 17:37 | |
| *** ChrisShort has quit IRC | 17:37 | |
| *** gundalow has quit IRC | 17:37 | |
| *** mwhahaha has quit IRC | 17:38 | |
| *** johnsom has quit IRC | 17:38 | |
| *** dcastellani has quit IRC | 17:38 | |
| *** samccann has quit IRC | 17:38 | |
| *** guilhermesp has quit IRC | 17:38 | |
| *** aprice has quit IRC | 17:38 | |
| *** Open10K8S has quit IRC | 17:38 | |
| *** jbryce has quit IRC | 17:38 | |
| *** webknjaz has quit IRC | 17:39 | |
| *** gouthamr has quit IRC | 17:39 | |
| *** wxy has quit IRC | 17:39 | |
| *** stevthedev has quit IRC | 17:39 | |
| *** johnsom has joined #zuul | 17:40 | |
| *** stevthedev has joined #zuul | 17:48 | |
| *** guilhermesp has joined #zuul | 17:48 | |
| *** samccann has joined #zuul | 17:49 | |
| *** wxy has joined #zuul | 17:49 | |
| *** erbarr has joined #zuul | 17:49 | |
| *** mwhahaha has joined #zuul | 17:49 | |
| *** mnasiadka has joined #zuul | 17:49 | |
| tristanC | tobiash: about the scale-out-scheduler topic, do you know if the changes are ready for review or is it still experimental? | 17:50 |
| *** Open10K8S has joined #zuul | 17:50 | |
| tobiash | tristanC: most changes at the beginning are preparing stuff and ready for review | 17:51 |
| *** aprice has joined #zuul | 17:54 | |
| *** gmann_ has joined #zuul | 17:54 | |
| *** donnyd has joined #zuul | 17:54 | |
| *** gmann_ is now known as gmann | 17:56 | |
| *** gundalow has joined #zuul | 17:58 | |
| *** jbryce has joined #zuul | 17:59 | |
| *** webknjaz has joined #zuul | 18:00 | |
| *** PrinzElvis has joined #zuul | 18:00 | |
| *** dcastellani has joined #zuul | 18:01 | |
| *** ChrisShort has joined #zuul | 18:05 | |
| *** smyers has joined #zuul | 18:10 | |
| *** iamweswilson has joined #zuul | 18:10 | |
| *** gouthamr has joined #zuul | 18:23 | |
| *** gouthamr__ has joined #zuul | 18:26 | |
| *** bhavikdbavishi has quit IRC | 18:49 | |
| *** aprice has quit IRC | 19:05 | |
| *** dcastellani has quit IRC | 19:06 | |
| *** aprice has joined #zuul | 19:06 | |
| *** dcastellani has joined #zuul | 19:08 | |
| fungi | corvus: from what denise was saying, the zuul sponsor "booth" at virtual ansiblefest is basically a digital brochure with asynchronous contact. there was a higher priced sponsorship tier which gets live text chat on the conference platform but it was apparently expensive (i don't know the exact numbers) | 19:10 |
| corvus | bummer; i'd think that live interaction would benefit both parties more. | 19:11 |
| fungi | i think so too, like i said not sure how much that was going to cost, but sounded like it wasn't subsidized for community projects this time | 19:13 |
| *** gouthamr has quit IRC | 19:39 | |
| *** gouthamr__ is now known as gouthamr | 19:39 | |
| *** tosky has quit IRC | 19:51 | |
| ianw | zuul-maint: if you have some time for https://review.opendev.org/#/q/status:open+project:zuul/zuul+branch:master+topic:synchronize-find that should allow us to rewrite some command: usage in zuul-jobs back to executor safe code | 20:21 |
| ianw | that was what led to our recent inspection of the uri code | 20:22 |
| *** hashar has quit IRC | 20:44 | |
| *** freenzyfriday has joined #zuul | 20:58 | |
| *** freenzyfriday has quit IRC | 21:02 | |
| Pilou | fungi: Zuul could be a subject at the ansible contributor summit (Thursday October 15th), isn'it? | 21:22 |
| fungi | Pilou: potentially, though i gather there are also some zuul presentations during ansiblefest as normal conference sessions too | 21:32 |
| *** gundalow has quit IRC | 21:52 | |
| *** johnsom has quit IRC | 21:52 | |
| *** freenzyfriday has joined #zuul | 21:52 | |
| *** ericsysmin has quit IRC | 21:52 | |
| *** Open10K8S has quit IRC | 21:52 | |
| *** dcastellani has quit IRC | 21:53 | |
| *** jbryce has quit IRC | 21:53 | |
| *** erbarr has quit IRC | 21:53 | |
| *** iamweswilson has quit IRC | 21:53 | |
| *** webknjaz has quit IRC | 21:53 | |
| *** wxy has quit IRC | 21:53 | |
| *** samccann has quit IRC | 21:53 | |
| *** guilhermesp has quit IRC | 21:53 | |
| *** piotrowskim has quit IRC | 21:53 | |
| *** rpittau|afk has quit IRC | 21:53 | |
| *** johnsom has joined #zuul | 21:54 | |
| *** mnasiadka has quit IRC | 21:54 | |
| *** aprice has quit IRC | 21:54 | |
| *** PrinzElvis has quit IRC | 21:54 | |
| *** stevthedev has quit IRC | 21:54 | |
| *** piotrowskim has joined #zuul | 21:55 | |
| *** erbarr has joined #zuul | 21:55 | |
| *** aprice has joined #zuul | 21:55 | |
| *** samccann has joined #zuul | 21:55 | |
| *** stevthedev has joined #zuul | 21:55 | |
| *** mnasiadka has joined #zuul | 21:55 | |
| *** gundalow has joined #zuul | 21:55 | |
| *** ericsysmin has joined #zuul | 21:55 | |
| *** jbryce has joined #zuul | 21:55 | |
| *** dcastellani has joined #zuul | 21:56 | |
| *** Open10K8S has joined #zuul | 21:56 | |
| *** wxy has joined #zuul | 21:57 | |
| *** rpittau|afk has joined #zuul | 21:57 | |
| *** webknjaz has joined #zuul | 21:57 | |
| *** PrinzElvis has joined #zuul | 21:57 | |
| *** guilhermesp has joined #zuul | 21:57 | |
| *** iamweswilson has joined #zuul | 21:58 | |
| *** freenzyfriday has quit IRC | 22:01 | |
| *** Goneri has quit IRC | 22:07 | |
| *** Goneri has joined #zuul | 22:26 | |
| clarkb | corvus: fwiw I think https://review.opendev.org/#/c/709735/40 is close now, just have to determine if the followons from tristanC and your previous reviews should be done in that change or a followup | 22:26 |
| clarkb | I think that removes the big barrier to landing more of the zk stuff further in the stack | 22:26 |
| tristanC | clarkb: i think it's fine to do follow-up, after all the stack is already quite big. However I'd like to know what is the purpose of the `paused_on_start` option. | 22:31 |
| clarkb | tristanC: tobiash answered that fwiw | 22:34 |
| clarkb | tristanC: its to make testing more deterministic | 22:34 |
| corvus | so we're making a user-facing option in order to make tests deteriministic? | 22:35 |
| tristanC | in that situation i don't think this should be added to the documentation, this is a bit confusing for regular operator | 22:36 |
| clarkb | yes, I don't think its necessary to expose it to users, but I'm also not sure it is harmful | 22:36 |
| clarkb | other than information overloading I guess | 22:37 |
| corvus | did anyone ever answer the question about why 709735 was so much more complicated than https://review.opendev.org/588610 ? | 22:37 |
| clarkb | oh that was a top levelcomment, looking at history I don't think that was addressed (the inline comments were) | 22:38 |
| tristanC | 709735 do not pause if the event_queues are not empty | 22:39 |
| clarkb | I think that is the major difference ^ | 22:41 |
| corvus | if that's important, maybe we could base it on 588610 and make that change? because honestly, i'd rather deal with code like "if paused" rather than "if not stoppend and resumed". i can barely figure out what that means. | 22:42 |
| corvus | er, stopped. but you get the idea. | 22:42 |
| clarkb | also looking at the event queue flushing I think there may be a bug | 22:43 |
| corvus | clarkb: i have left a -1 on the change asking for my comment to be responded to. honestly, i think we should set a really high bar for this code. it should be really simple and easy to follow. pausing the scheduler should not be nearly so complicated. | 22:45 |
| *** freenzyfriday has joined #zuul | 22:46 | |
| clarkb | ya I left a comment related to the bug which I think is directly related to the complexity and pointed to your change as well | 22:47 |
| clarkb | might be worth having a more synchronous sync up if possible too? we've gone back and forth on this change a few times now | 22:49 |
| *** freenzyfriday has quit IRC | 22:50 | |
| corvus | i can try to be available first thing tomorrow for that | 22:51 |
| *** ianychoi_ is now known as ianychoi | 23:00 | |
| *** rlandy has quit IRC | 23:01 | |
| clarkb | ianw: re allowing find I think one of my concerns previously was that you can exec with find | 23:21 |
| clarkb | curious if that was handled at all | 23:21 |
| ianw | clarkb: it's not really find though, as such, it's ansible's find. like it doesn't handle "depth" | 23:22 |
| clarkb | I think you can still apss in arbitrary find args? | 23:23 |
| clarkb | maybe we can block those? | 23:23 |
| clarkb | oh no I'm wrong | 23:23 |
| clarkb | so ya maybe this is fine and I was worried for nothing | 23:23 |
| fungi | that's rsync where it lets you pass in arbitrary parameters | 23:24 |
| ianw | it looks like it acquired "depth", but yeah, i don't think there's anything you can pass | 23:24 |
| ianw | anyway, let's not rush that one, as you say we want to be sure | 23:24 |
| *** kklimonda has left #zuul | 23:28 | |
| *** freenzyfriday has joined #zuul | 23:40 | |
| *** Goneri has quit IRC | 23:41 | |
| *** freenzyfriday has quit IRC | 23:49 | |
| *** Goneri has joined #zuul | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!