*** wuchunyang has joined #zuul | 00:32 | |
*** wuchunyang has quit IRC | 00:37 | |
*** sshnaidm is now known as sshnaidm|off | 00:41 | |
openstackgerrit | Merged zuul/zuul master: Fix multiple prs found when commit is not head https://review.opendev.org/741402 | 00:56 |
---|---|---|
openstackgerrit | Merged zuul/zuul master: gitlab: merge request approval: specify the commit https://review.opendev.org/752031 | 01:45 |
*** bstinson has quit IRC | 02:12 | |
openstackgerrit | Merged zuul/zuul master: FakeGitlabAPIClient: use subject instead of title https://review.opendev.org/752035 | 02:12 |
*** freenzyfriday has joined #zuul | 03:04 | |
*** freenzyfriday has quit IRC | 03:09 | |
openstackgerrit | Merged zuul/zuul master: Ansible command module: allow to use stdin param https://review.opendev.org/744814 | 03:09 |
*** bhavikdbavishi has joined #zuul | 03:20 | |
*** bhavikdbavishi1 has joined #zuul | 03:45 | |
*** bhavikdbavishi has quit IRC | 03:47 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:47 | |
*** freenzyfriday has joined #zuul | 03:54 | |
*** freenzyfriday has quit IRC | 03:59 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 04:19 |
*** bhavikdbavishi has quit IRC | 04:19 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 04:19 |
*** bhavikdbavishi has joined #zuul | 04:20 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #zuul | 04:33 | |
*** freenzyfriday has joined #zuul | 04:48 | |
*** freenzyfriday has quit IRC | 04:58 | |
*** freenzyfriday has joined #zuul | 06:01 | |
*** bhavikdbavishi1 has joined #zuul | 06:07 | |
*** bhavikdbavishi has quit IRC | 06:08 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 06:09 | |
*** mach1na has joined #zuul | 06:09 | |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed zuul/zuul-jobs master: Make sure that we pass list in loop https://review.opendev.org/754612 | 06:09 |
*** CraigR has joined #zuul | 06:31 | |
*** CraigR has quit IRC | 06:33 | |
*** mach1na has quit IRC | 06:35 | |
*** saneax has joined #zuul | 06:37 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup https://review.opendev.org/754636 | 06:43 |
*** hashar has joined #zuul | 06:52 | |
openstackgerrit | Merged zuul/zuul-jobs master: Add ability to use *-docker-image roles in periodic jobs https://review.opendev.org/740560 | 06:53 |
*** mach1na has joined #zuul | 06:55 | |
*** aluria has quit IRC | 06:56 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup https://review.opendev.org/754636 | 06:56 |
*** jcapitao has joined #zuul | 06:58 | |
*** aluria has joined #zuul | 07:00 | |
*** bolg has joined #zuul | 07:01 | |
*** mach1na has quit IRC | 07:20 | |
*** mach1na has joined #zuul | 07:22 | |
*** tosky has joined #zuul | 07:23 | |
*** jpena|off is now known as jpena | 07:29 | |
*** bhavikdbavishi has quit IRC | 07:43 | |
*** aluria has quit IRC | 07:47 | |
*** arxcruz has joined #zuul | 07:48 | |
*** aluria has joined #zuul | 07:49 | |
*** saneax has quit IRC | 07:54 | |
*** saneax has joined #zuul | 07:55 | |
*** yolanda has joined #zuul | 08:07 | |
*** saneax has quit IRC | 08:10 | |
*** bhavikdbavishi has joined #zuul | 08:27 | |
*** bhavikdbavishi1 has joined #zuul | 08:30 | |
*** bhavikdbavishi has quit IRC | 08:31 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 08:31 | |
*** armstrongs has joined #zuul | 08:34 | |
*** holser has joined #zuul | 08:41 | |
*** ttx has joined #zuul | 08:41 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 08:44 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: Test zuul-client encrypt subcommand https://review.opendev.org/754103 | 08:44 |
*** saneax has joined #zuul | 08:49 | |
*** armstrongs has quit IRC | 08:57 | |
*** zbr has joined #zuul | 09:09 | |
*** bhavikdbavishi has quit IRC | 09:10 | |
*** bhavikdbavishi has joined #zuul | 09:13 | |
*** bhavikdbavishi1 has joined #zuul | 09:26 | |
*** brendangalloway has quit IRC | 09:28 | |
*** bhavikdbavishi has quit IRC | 09:28 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 09:28 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup https://review.opendev.org/754636 | 09:41 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup https://review.opendev.org/754636 | 09:44 |
*** piotrowskim has joined #zuul | 09:49 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup https://review.opendev.org/754636 | 09:49 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Add logging and monitoring of reporting timings https://review.opendev.org/752443 | 10:19 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup https://review.opendev.org/754636 | 10:24 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: Test zuul-client encrypt subcommand https://review.opendev.org/754103 | 10:43 |
*** bhavikdbavishi has quit IRC | 10:49 | |
*** jcapitao is now known as jcapitao_lunch | 11:01 | |
*** mach1na has quit IRC | 11:10 | |
*** saneax has quit IRC | 11:16 | |
*** jpena is now known as jpena|lunch | 11:25 | |
*** saneax has joined #zuul | 11:25 | |
*** mach1na has joined #zuul | 11:51 | |
*** rfolco has joined #zuul | 11:52 | |
*** rfolco is now known as rfolco|ruck | 11:52 | |
*** mach1na has quit IRC | 11:55 | |
*** bhavikdbavishi has joined #zuul | 12:03 | |
*** mach1na has joined #zuul | 12:05 | |
*** mach1na has quit IRC | 12:24 | |
*** jcapitao_lunch is now known as jcapitao | 12:24 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Improve typings in context of 744416 https://review.opendev.org/753578 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Merge Zookeeper connection methods and specialize exceptions https://review.opendev.org/754360 | 12:28 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 12:28 |
*** jpena|lunch is now known as jpena | 12:29 | |
*** mach1na has joined #zuul | 12:30 | |
*** jfoufas1 has joined #zuul | 12:32 | |
*** jfoufas1 has quit IRC | 12:44 | |
*** saneax has quit IRC | 13:23 | |
*** saneax has joined #zuul | 13:24 | |
*** benoit_lbc has joined #zuul | 13:28 | |
benoit_lbc | Hello, Do you see it will be possible to have this review https://review.opendev.org/#/c/740328/ merged regarding my last answer ? (patchset 25). Thanks in advance :) | 13:29 |
benoit_lbc | think* | 13:29 |
*** saneax has quit IRC | 13:41 | |
*** jamesmcarthur has joined #zuul | 13:53 | |
*** gmann_pto is now known as gmann | 13:55 | |
*** bhavikdbavishi has quit IRC | 14:19 | |
*** hashar has quit IRC | 14:24 | |
fungi | anybody noticed you can't highlight text on the builds view any longer? | 14:27 |
fungi | when i try to click and drag to highlight text there, my browser acts like it's trying to drag-n-drop some page element | 14:27 |
*** jamesmcarthur has quit IRC | 14:41 | |
*** jamesmcarthur has joined #zuul | 14:42 | |
*** jamesmcarthur has quit IRC | 14:46 | |
*** jamesmcarthur has joined #zuul | 14:51 | |
*** hashar has joined #zuul | 15:01 | |
openstackgerrit | zbr proposed zuul/zuul master: Enable display of dnf/yum failures inside console https://review.opendev.org/734833 | 15:04 |
clarkb | fungi: I don't seem to have this problem on | 15:04 |
clarkb | https://zuul.opendev.org/t/openstack/builds | 15:04 |
clarkb | hit return a half second too quickly | 15:05 |
fungi | yeah, that's where i'm seeing it. my cursor shows up as a grabby hand icon and can't highlight text anywhere on that page (firefox 80) | 15:06 |
clarkb | I'm on FF 81 beta | 15:07 |
clarkb | its a grabby hand icon on links | 15:07 |
clarkb | but I can still select link text by highlighting from just off the link first | 15:08 |
openstackgerrit | zbr proposed zuul/zuul master: Enable ANSI rendering via react-ansi https://review.opendev.org/739444 | 15:08 |
openstackgerrit | zbr proposed zuul/zuul-jobs master: More E208 mode fixes https://review.opendev.org/748498 | 15:09 |
openstackgerrit | zbr proposed zuul/zuul-jobs master: Add file mode to fetch-sphinx-tarball https://review.opendev.org/748606 | 15:13 |
openstackgerrit | zbr proposed zuul/zuul-jobs master: Partial address ansible-lint E208 https://review.opendev.org/748480 | 15:13 |
fungi | yeah, no matter where on the page i try to click and drag, it shows the hand cursor dragging a little document icon and doesn't highlight anything | 15:19 |
fungi | well, i take that back, i can highlight the column headings, just not anything on the rows beneath them | 15:21 |
*** hashar has quit IRC | 15:41 | |
*** freenzyfriday has quit IRC | 16:03 | |
*** jcapitao has quit IRC | 16:04 | |
*** freenzyfriday has joined #zuul | 16:07 | |
*** bhavikdbavishi has joined #zuul | 16:09 | |
*** mach1na has quit IRC | 16:09 | |
*** bhavikdbavishi1 has joined #zuul | 16:12 | |
*** tosky has quit IRC | 16:12 | |
*** freenzyfriday has quit IRC | 16:13 | |
*** bhavikdbavishi has quit IRC | 16:13 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 16:13 | |
*** freenzyfriday has joined #zuul | 16:15 | |
*** hamalq has joined #zuul | 16:21 | |
*** benoit_lbc has quit IRC | 16:24 | |
*** jpena is now known as jpena|off | 16:43 | |
clarkb | fungi: I had to do a hard refresh and now I see what you see | 17:10 |
clarkb | (I should've started with one of those) | 17:10 |
clarkb | fungi: it is because the whole row on the builds page has become a link to the build | 17:11 |
fungi | ahh | 17:15 |
clarkb | https://opendev.org/zuul/zuul/src/branch/master/web/src/index.css#L103-L115 is the code that causes that to happen | 17:15 |
fungi | not to my taste, but i assume that was an intentional behavior change | 17:15 |
fungi | probably helps people trying to browse using their thumbs on telephones | 17:16 |
clarkb | I wonder if we can change pointer-events to modify the behavior to be more like what you expect | 17:16 |
clarkb | if I change pointer-events to none then its no longer a clickable link :/ | 17:22 |
clarkb | but the text does become selectable | 17:22 |
clarkb | maybe we can make the text clickable but not the fill area (I think that means dropping the ::after entirely and turning each text there into a url?) | 17:24 |
clarkb | I've quickly surpassed my web dev knowledge here. Its definitely doing what you describe though and we can possibly fix it by changing the link clickable area | 17:26 |
clarkb | looking at gitea it does the clickable text but not fill area for dir listings | 17:26 |
openstackgerrit | Merged zuul/zuul-jobs master: Allow skip files when download logs https://review.opendev.org/751973 | 19:03 |
clarkb | tristanC: I'm not sure https://review.opendev.org/#/c/736367/5 is a ruel we should enforce | 19:03 |
*** bhavikdbavishi has quit IRC | 19:09 | |
tristanC | clarkb: i'm not sure either, i thought that would help container based user who do not want to run ensure-* role during ci | 19:13 |
clarkb | my concern is that there are valid reasons for running roles in different phases depending on the job | 19:14 |
tristanC | clarkb: that doesn't seems to be case for existing zuul-jobs | 19:15 |
clarkb | it is the case for a lot of zuul-tests.d | 19:16 |
clarkb | because the roles themselves are under test | 19:16 |
*** Goneri has joined #zuul | 19:16 | |
clarkb | (I don't know if we run ansible-lint on those files though) | 19:16 |
tristanC | clarkb: iirc the rule only apply to playbook defined in the zuul.d configuration | 19:16 |
*** freenzyfriday has quit IRC | 19:18 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint https://review.opendev.org/736367 | 19:19 |
clarkb | tristanC: we should probably document why that rule exists if we are adding it then because its completely valid as the testing shows | 19:20 |
*** tosky has joined #zuul | 19:27 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 19:29 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 19:29 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 19:29 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Improve typings in context of 744416 https://review.opendev.org/753578 | 19:29 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Merge Zookeeper connection methods and specialize exceptions https://review.opendev.org/754360 | 19:29 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 19:29 |
clarkb | mhu: looking at the zuul-client testing change (https://review.opendev.org/#/c/752039/) I'm curious why we don't put those in zuul-client then zuul can run the job from there? Is it because we're relying on zuul's test framework to run a zuul and zuulweb? | 19:41 |
*** armstrongs has joined #zuul | 19:51 | |
corvus | clarkb, mhu: that's my assumption | 19:53 |
clarkb | ok left a -1 because that change isn't testing what it seems to be trying to test due to stestr config (details in line) | 19:56 |
clarkb | its a little weird at first glance to put the tests in zuul/zuul but ya we already have the bootstrapping machinery there | 19:56 |
*** armstrongs has quit IRC | 19:58 | |
corvus | i don't think these should be part of the standard unit tests though | 20:01 |
corvus | so more like 264 rather than 039 | 20:01 |
clarkb | ya they are separated into their own subtree which is related to my -1 | 20:06 |
clarkb | the implication is we want to run them as normal unittests but we dont currently | 20:06 |
clarkb | (I mentioned adding a new job for that) | 20:06 |
*** holser has quit IRC | 20:07 | |
*** holser has joined #zuul | 20:08 | |
*** jamesmcarthur_ has joined #zuul | 20:54 | |
*** jamesmcarthur has quit IRC | 20:57 | |
*** rfolco|ruck has quit IRC | 21:08 | |
mhu | clarkb, corvus I was thinking about moving these back to zuul/zuul-client but yeah, there are many imports from the test framework that is proper to zuul | 21:11 |
mhu | unless the tests lib gets moved to the zuul python package, it's going to be cumbersome to use in zuul/zuul-client | 21:12 |
mhu | I don't like it much because you need to add tests *after* the feature patchset in zuul/zuul-client | 21:13 |
corvus | mhu: yeah -- and i'm strongly opposed to declaring the zuul test framework part of the package (it's way too tightly coupled for that) | 21:14 |
mhu | but it's the same with nodepool's zuul functional testing right? | 21:14 |
corvus | mhu: it is | 21:14 |
mhu | corvus, of course, totally understandable | 21:14 |
corvus | i think it's worth brainstorming ways we could improve it though. i don't have good ideas now. but the problem is annoying me in a good way. :) | 21:16 |
mhu | and I am about ready to jump in bed so no good ideas over there either :) | 21:18 |
mhu | and for that reason, clarkb I'll answer your comments on 039 tomorrow, good night! | 21:18 |
clarkb | swest: tobiash https://review.opendev.org/#/c/752886 looks mergeable but ianw has a good point about cleaning up dead code | 21:44 |
clarkb | want to do a followup change or update that one? | 21:44 |
clarkb | zuulians any reason to not land https://review.opendev.org/#/c/727374/7 and update the zuul docker images to python3.8? | 21:49 |
clarkb | on the nodepool side we're relying on python3.7 wheels for arm64 currently | 21:49 |
clarkb | but for zuul I think this is fine | 21:50 |
openstackgerrit | Andrii Ostapenko proposed zuul/zuul-jobs master: Fix promote cleanup https://review.opendev.org/754865 | 21:58 |
clarkb | corvus: https://review.opendev.org/#/c/754636/ is an intersting one that makes cat job failures on zuul startup non fatal | 22:11 |
clarkb | I'm not sure I have a good enough grasp on zuul's config loading on startup to undertsand if that should be fatal or not. Seems like we do already allow broken configs but only when we can get the files first | 22:11 |
corvus | clarkb: it seems like it could be dangerous | 22:13 |
corvus | it's one thing to "allow" broken configurations by allowing projects to bypass gating; but folks who chose not to do that might still end up running with a half-complete config with a change like that | 22:14 |
clarkb | ianw: oh you just acked https://review.opendev.org/#/c/752443/ I just left a suggestion on there for making the logging perhaps less noisy if you have a chance to check it again | 22:29 |
ianw | clarkb: yeah, good suggestion too. i don't feel too strongly if it's related to an error that has been seen (i guess by definition the debugging was helpful if it helped debug something :) but it does seem chatty | 22:31 |
*** tosky has quit IRC | 22:40 | |
*** rfolco|ruck has joined #zuul | 22:45 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Make sure that we pass list in loop https://review.opendev.org/754612 | 22:45 |
clarkb | ianw: also I left a couple thoughts on the json file editing changesin zuul-jobs earlier today if want to check those | 22:46 |
ianw | clarkb: thanks, will go over | 22:47 |
openstackgerrit | Merged zuul/zuul master: Remove zuul-stream-functional-2.7 https://review.opendev.org/753683 | 22:55 |
openstackgerrit | Merged zuul/zuul master: Use bionic images for zuul-stream-functional tests https://review.opendev.org/749967 | 22:55 |
openstackgerrit | Merged zuul/zuul master: gitlab: an "update" event isn't always a "labeled" action https://review.opendev.org/750544 | 22:55 |
*** jamesmcarthur_ has quit IRC | 22:57 | |
*** jamesmcarthur has joined #zuul | 23:06 | |
*** tosky has joined #zuul | 23:09 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 23:15 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 23:15 |
*** rfolco|ruck has quit IRC | 23:15 | |
*** freenzyfriday has joined #zuul | 23:16 | |
*** tosky has quit IRC | 23:19 | |
*** freenzyfriday has quit IRC | 23:20 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!