openstackgerrit | Ian Wienand proposed zuul/nodepool master: Install gdisk/dosfstools on nodepool-builder images https://review.opendev.org/750532 | 00:09 |
---|---|---|
openstackgerrit | Ian Wienand proposed zuul/nodepool master: [dnm] testing uefi https://review.opendev.org/748929 | 00:09 |
*** Goneri has quit IRC | 00:22 | |
*** hamalq has quit IRC | 00:31 | |
*** piotrowskim has quit IRC | 00:43 | |
*** frenzyfriday has joined #zuul | 00:44 | |
*** frenzyfriday has quit IRC | 00:51 | |
*** wxy has joined #zuul | 01:31 | |
openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: gitlab: an "update" event isn't always a "labeled" action https://review.opendev.org/750544 | 01:49 |
openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: [gitlab] approvals: fix error with community edition https://review.opendev.org/750546 | 01:50 |
openstackgerrit | Merged zuul/nodepool master: Install gdisk/dosfstools on nodepool-builder images https://review.opendev.org/750532 | 01:56 |
*** wuchunyang has joined #zuul | 02:38 | |
*** rlandy has joined #zuul | 03:03 | |
*** rlandy has quit IRC | 03:31 | |
*** systemd has quit IRC | 03:58 | |
*** systemd has joined #zuul | 03:58 | |
*** wuchunyang has quit IRC | 04:00 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 04:22 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 04:29 |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #zuul | 04:33 | |
*** saneax has joined #zuul | 04:50 | |
*** sanjayu_ has joined #zuul | 04:53 | |
*** saneax has quit IRC | 04:54 | |
*** frenzyfriday has joined #zuul | 05:16 | |
*** frenzyfriday has quit IRC | 05:25 | |
*** sanjayu_ has quit IRC | 05:30 | |
*** sanjayu_ has joined #zuul | 05:37 | |
*** sanjayu_ has quit IRC | 05:38 | |
*** sanjayu_ has joined #zuul | 05:39 | |
*** frenzyfriday has joined #zuul | 06:00 | |
*** bhavikdbavishi has joined #zuul | 06:06 | |
*** vishalmanchanda has joined #zuul | 06:14 | |
felixedel | corvus, ianw, clarkb: Thanks for the squash change to test everything together. I didn't came to that yesterday. I've left a comment on that change. To sum up the "div scrolling" vs "viewport scrolling": IMHO the div scrolling is the way to go in case the content of a container is too wide (which is basically what every other website does that I'm aware of). Viewport scrolling is IMHO a no-go unless you find a way to | 06:24 |
felixedel | achieve this without breaking the whole page layout (which I'm not aware of at least - but I'm also not a CSS expert). The other solution would be - like you said - to wrap the text so we avoid scrolling at all. I'm not sure what's the best solution here since I don't like horizontal scrolling but I'm also not a big fan of wrapped code/log snippets since you often loose track on where you and where a new line actually | 06:24 |
felixedel | starts :D | 06:24 |
felixedel | I just took a look at the old (pf3) version of the frontend, which also used div-scrolling on the tab containers in case the log lines are too long. | 06:28 |
felixedel | It seems that this didn't bother anybody at that time | 06:29 |
*** mach1na has joined #zuul | 06:32 | |
felixedel | side topic: I just noticed that there is a tree-view (beta ) available in PF 4 now. | 06:38 |
*** mach1na has quit IRC | 06:46 | |
*** mach1na has joined #zuul | 06:53 | |
*** jcapitao has joined #zuul | 07:00 | |
*** hashar has joined #zuul | 07:17 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 07:18 |
*** kmalloc has quit IRC | 07:27 | |
ianw | felixedel: for mine, i think a wrap would be good. as i mentioned with some links in that bug it seems the same as contemporary sites such as github and gitlab | 07:28 |
ianw | did you also see the log page horizontal issue though? that seems more of a blocker because you can't seem to access the long lines at all | 07:29 |
*** jpena|off is now known as jpena | 07:30 | |
felixedel | ianw: Which issue do you mean? That the scrollbar is inside the div and not on the viewport? | 07:31 |
ianw | felixedel: on the log viewer page, for me (and corvus) long lines are cut off, with no horizontal scroll option, and you can't even move the page over selecting the text? | 07:33 |
ianw | i'm guessing it must be something with having each line in a table? | 07:33 |
felixedel | No, I'm not aware of that. Can you point me to an example? | 07:34 |
ianw | felixedel: ohhh, i just realised that i uploaded over your change this morning, my time | 07:37 |
ianw | sorry about that. i meant to squash all three changes into a separate change, but i guess i left the change-id at the bottom from the rebase/squash and took over your change | 07:37 |
ianw | felixedel: i'm using the sample site @ https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7ca/750322/2/check/zuul-build-dashboard-opendev/7cae351/npm/html/ | 07:38 |
ianw | i just go openstack->builds->select any build->logs->job-output.txt | 07:39 |
felixedel | ah, now I see. That looks indead weird. Let me check | 07:39 |
ianw | felixedel: do you mind if i stack the changes and restore your v1? | 07:40 |
ianw | of the modal box i mean | 07:41 |
felixedel | I think we could also sqash all changes | 07:41 |
felixedel | That might make it more clear that they are all needed together | 07:42 |
felixedel | But we should then also explain that in the commit message | 07:42 |
ianw | i agree, maybe stack them for review as we sort out these last bits, and we can either squash them for commit or just do it at once sort-of-atomically | 07:42 |
ianw | how about i stack them, then we go from there | 07:42 |
felixedel | ok | 07:43 |
openstackgerrit | Ian Wienand proposed zuul/zuul master: Revert "web: restore scrollbars and scroll behaviour" https://review.opendev.org/750361 | 07:45 |
openstackgerrit | Ian Wienand proposed zuul/zuul master: Revert "Revert PF4 build page" https://review.opendev.org/750365 | 07:45 |
openstackgerrit | Ian Wienand proposed zuul/zuul master: Use Modal to show config errors and fix scrolling https://review.opendev.org/750322 | 07:45 |
felixedel | Regarding the horizontal scroll issue on the log viewer page: It could be solved by removing the "overflow: inherit;" attribute on the "pre.zuul-log-output" selector in CSS. IMHO it's also weird to have a table inside a pre. But that whole topic is independent of the other changes, so we should fix that in a follow-up | 07:45 |
felixedel | Regarding the pre-wrap that corvus mentioned: I would go for a that if we could prepend the log lines with the line number (similar to the log viewer page) so you don't loose the context of the line in case it's split across multiple lines due to the wrap. But I would also prefer to do this in a follow up rather than merging it into the existing changes. Like I said, PF3 showed the same behaviour so it's not like PF4 | 07:48 |
felixedel | broke that. | 07:48 |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: DNM: Assert clean state on start https://review.opendev.org/750589 | 07:49 |
felixedel | It might not have been that relevant in the past since the font size was smaller and more of the line fit into the screen | 07:49 |
felixedel | :D | 07:49 |
openstackgerrit | Ian Wienand proposed zuul/zuul master: web: Fix error modal contents https://review.opendev.org/744095 | 07:51 |
ianw | felixedel: hrm with the current site i get a horizontal scrollbar though? | 07:51 |
ianw | it does blow out the top nav bar as wide as the content | 07:52 |
ianw | i think the bad regression with pf4 is that there's *no* way to see the long content. whereas on pf3 it just looks bad i guess | 07:53 |
*** tosky has joined #zuul | 07:57 | |
felixedel | iawn: "it does blow out the top nav bar as wide as the content" Where is that? | 08:08 |
ianw | felixedel: on https://zuul.opendev.org/t/zuul/build/7cae351a0c0943268910f43d4dbf26b3/log/job-output.txt i see a horizontal scrollbar | 08:09 |
ianw | so the nav bar is as wide as the log content, if you get what i mean | 08:09 |
ianw | (which i probably agree isn't great either, but you can at least see the logs i guess) | 08:09 |
ianw | (gotta run for dinner) | 08:10 |
felixedel | Right, that is the version were your scrollbar fix is deployed ;-) And that has the drawback that everything is spread across the whole page width (which kind of breaks the layout). | 08:11 |
felixedel | But I think we should avoid this | 08:11 |
felixedel | But maybe I'm still missing what you want to achieve in the end? | 08:12 |
*** nils has joined #zuul | 08:19 | |
*** ianychoi__ has quit IRC | 08:40 | |
ianw | felixedel: umm, i don't know if i have a great answer, sorry. so without my fix we could never see the whole log lines and nobody noticed you're saying? | 08:41 |
ianw | maybe that is possible ... | 08:41 |
felixedel | In wanted to say that we are dealing with two different problems here, both related to horizontal scrolling: The first is on the build result page (where the results and failed tasks are shown). With your fix the tab layout is broken due to the whole page content set to overflow: visible. Thhe bevaiour on this page was untouched by PF4. The second one is on the log viewer page (which I wasn't aware of) and was | 08:46 |
felixedel | introduced by PF4. There the log lines are "unreachable" because the honrizontal scroll is completely disabled. This seems to be related by PF4 but can be solved by removing the overflow: inherit on the pre tag. | 08:46 |
ianw | yes i agree there's two issues; for me the log viewer one is a blocker | 08:48 |
felixedel | Ok, but this seems to be fixed by simply updating the CSS. | 08:49 |
felixedel | And there is no need to enable "global viewport scrollbars" (if you want to call it like that) for the whole website | 08:49 |
ianw | felixedel: ok, i mean for mine i think stack a change on top with it so corvus can verify, and i think we'll all be happy :) | 08:50 |
ianw | the other scroll issue is https://imgur.com/MlK1s8h | 08:50 |
ianw | for that, i think wrapping that box is sensible, and consistent with contemporary sites like github and gitlab from what i saw | 08:50 |
felixedel | Like I said, I'm fine with the wrapping, but this issue wasn't introduced by PF4, but already existed with PF3 in the same way | 08:51 |
ianw | ok, i wouldn't consider that a blocker. since it's identified it would be nice to fix, corvus did seem to feel strongly when he noticed it | 08:51 |
ianw | again IMO i'd stack a change separately just to keep it clear what's fixing what | 08:52 |
ianw | s/separately/on-top/ | 08:52 |
felixedel | Ok, so update the CSS to fix the blocker in a follow up and clarifiy how we deal with the non-blocker first | 08:52 |
ianw | i think it's easier to just stack them and then we can all look at the top change and know everything underneath is good, rather than separate changes that get confusing | 08:53 |
felixedel | I'm fine with stacking. Just wanted to clarifiy that we need all together to fix the whole "scrolling issue" part :) | 08:53 |
ianw | yeah, i mean the pf4 stuff is a fait accompli; so it's just these little corner cases i guess | 08:54 |
felixedel | Like I said, I wanted to stack them myself, but didn't came to that yesterday anymore :) | 08:54 |
ianw | i'm afraid i have to disappear for the night | 08:55 |
ianw | thanks for working on it, and fixing my crappy "fixes" :) | 08:55 |
felixedel | Good night. It's still a little confusing to work across different timezones without knowing from where everybody is working :D | 08:57 |
*** frenzyfriday has quit IRC | 09:25 | |
*** frenzyfriday has joined #zuul | 09:26 | |
*** hashar has quit IRC | 09:57 | |
*** mach1na has quit IRC | 10:13 | |
*** mach1na has joined #zuul | 10:13 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 10:21 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 10:22 |
*** bhavikdbavishi has quit IRC | 10:32 | |
*** jcapitao is now known as jcapitao_lunch | 10:42 | |
*** frenzyfriday has quit IRC | 11:00 | |
*** bhavikdbavishi has joined #zuul | 11:15 | |
*** mach1na has quit IRC | 11:21 | |
*** jpena is now known as jpena|lunch | 11:30 | |
*** harrymichal has joined #zuul | 11:34 | |
*** sanjayu_ has quit IRC | 11:46 | |
*** bhavikdbavishi has quit IRC | 11:50 | |
*** sassyn has joined #zuul | 11:55 | |
sassyn | Hi All | 11:55 |
*** jcapitao_lunch is now known as jcapitao | 11:56 | |
sassyn | Hope is everyone doing fine! A quick question since It being 2 month the last time I work on our Zuul system. Can someone please tell me what is the difference when you use in the zuul-config/project.yaml a regex configuration compare to the untrusted-projects configuration in the tenant . | 11:57 |
*** sanjayu_ has joined #zuul | 11:57 | |
sassyn | If I have wildcard as a regex - why should I declare my git project in the untrusted-projects place ? | 11:57 |
*** mach1na has joined #zuul | 11:58 | |
*** rfolco has joined #zuul | 12:02 | |
*** armstrongs has joined #zuul | 12:03 | |
*** Goneri has joined #zuul | 12:07 | |
*** rlandy has joined #zuul | 12:09 | |
*** jfoufas1 has joined #zuul | 12:17 | |
*** bhavikdbavishi has joined #zuul | 12:17 | |
*** jhesketh has quit IRC | 12:17 | |
*** jhesketh has joined #zuul | 12:17 | |
*** jpena|lunch is now known as jpena | 12:32 | |
*** piotrowskim has joined #zuul | 12:45 | |
*** jfoufas1 has quit IRC | 13:04 | |
*** armstrongs has quit IRC | 13:06 | |
*** mach1na has quit IRC | 13:09 | |
*** mach1na has joined #zuul | 13:10 | |
*** jhesketh has quit IRC | 13:31 | |
*** bhavikdbavishi has quit IRC | 13:43 | |
*** sassyn has quit IRC | 13:45 | |
openstackgerrit | Benoît Bayszczak proposed zuul/nodepool master: [provider][aws] use one API call to create tags https://review.opendev.org/746921 | 13:54 |
corvus | felixedel: showing a code snippet on a website is very different than showing logs that are hundreds of lines long. it's unworkable to have a horizontal scroll bar below the bottom of the viewport, because to look at the right-hand part of a long line at the top, you have to scroll down, move the horizontal scrollbar (and you have to guess how far because you can't see the top line any more). then scroll | 13:58 |
corvus | back up | 13:58 |
corvus | felixedel: div scrolling only works if the whole div fits in the viewport | 13:58 |
openstackgerrit | Benoît Bayszczak proposed zuul/nodepool master: [provider][aws] use one API call to create tags https://review.opendev.org/746921 | 13:59 |
corvus | felixedel: i agree though that at the console tab in the pf3 version uses div scrolling; i thought it did not, but perhaps i was wrong about that | 14:00 |
corvus | (it does look like the summary tab uses viewport scrolling) | 14:00 |
zbr | corvus: https://review.opendev.org/#/c/748688/ please | 14:02 |
zbr | corvus: i disagree regarding the log vs code snippet, IMHO the same rule apply for both. | 14:04 |
corvus | zbr: my argument is that it is never okay to have a horizontal scroll bar outside of the viewport | 14:04 |
zbr | ahh, sure | 14:05 |
corvus | zbr: my understanding is that you feel that it's never okay to have a horizontal scroll bar period :) so in that sense, we likely agree at least as far as my statement goes, you would just take it further. | 14:05 |
zbr | my view is that I never want a horizontal scroll, ever. but that is why i hope we will endup merging the change that makes it configurable. | 14:05 |
zbr | the prefs will help us find a middle ground | 14:06 |
corvus | felixedel: i appear to be wrong about the console tab, sorry about that. i'm going to drop my objection to div-scrolling since it's not a regression (at least, not compared to the state before the pf4 work started) so it's not in scope for your changes | 14:09 |
corvus | felixedel: i think that leaves us with 2 things: error modal pre-wrap, and the logs tab. i think div-scrolling would be fine on the logs tab too -- we just do need it to scroll | 14:11 |
corvus | ianw: ^ fyi; also updated comment on https://review.opendev.org/750322 | 14:14 |
*** rfolco is now known as rfolco|ruck | 14:53 | |
*** bschanzel has quit IRC | 14:54 | |
*** bschanzel has joined #zuul | 14:55 | |
*** sanjayu_ has quit IRC | 15:07 | |
*** bhagyashris is now known as bhagyashris|ruck | 15:11 | |
*** bhagyashris|ruck is now known as bhagyashris|rove | 15:11 | |
*** jhesketh has joined #zuul | 15:23 | |
felixedel | Corvus: Ok. I will add a follow-up change for scrolling the logs tab (which obviously broke with PF4). The "modal pre-wrap" topic is what https://review.opendev.org/#/c/744095/4 is about, or? But that's also something new which wasn't there before if I'm not mistaken? | 15:28 |
corvus | felixedel: yeah, i think that broke recently and 744095 is the fix -- will 744095 work with your changes as written, or does it need to be updated? | 15:30 |
corvus | oh | 15:30 |
corvus | i just noticed that 744095 is rebased to be on your change now | 15:30 |
corvus | so i think that means it should be taken care of -- once we get it fixed | 15:31 |
felixedel | Sry if I was a little harsh about the topic. I think the whole thing just led to a lot of confusion and was hard to clarify which change (or which part of the code) is responsible for what. | 15:31 |
corvus | felixedel: no worries -- and a lot of the confusion was contributed by me, and i'm sorry about that. i think we're all just about on the same page now and doing our best to find the right way out now. :) | 15:32 |
felixedel | I didn't check out https://review.opendev.org/#/c/744095/4 in detail. Will do that tomorrow morning and put my follow-up on top of it. We can then use the latest change to test if all is working together and everybody is happy with the solution | 15:33 |
corvus | to recap: 1) we should fix 744095 to correct the pre-wrap in config errors; 2) fix scrolling in logs (div-scrolling is ok) | 15:33 |
corvus | i wonder why the jobs failed there | 15:34 |
felixedel | eslint most probably? | 15:34 |
corvus | oh i see it | 15:34 |
corvus | i'm going to fix that syntax error real quick | 15:34 |
openstackgerrit | James E. Blair proposed zuul/zuul master: web: Fix error modal contents https://review.opendev.org/744095 | 15:36 |
corvus | ianw, felixedel: ^ that works locally | 15:40 |
felixedel | Yes, works and looks fine I would say. Just as a nit: Could we stick to the max line length of 80 characters in App.jsx and spread the "title" and "variant" attributes in different lines? :) | 15:43 |
corvus | sure i'll respin real quick | 15:43 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: synchronize-repos: Remove unecessary git path modifications https://review.opendev.org/747640 | 15:44 |
openstackgerrit | James E. Blair proposed zuul/zuul master: web: Fix error modal contents https://review.opendev.org/744095 | 15:44 |
felixedel | Because I really hate horizontal scrolling in source code :-P | 15:44 |
avass | tobiash: should we expect git to aleady be present in PATH on windows nodes or should we add those PATH modifications before the ssh+git check instead? ^ | 15:45 |
corvus | felixedel: me too, but my limit is more like 100 chars :) but this looks great at 80 and it's no cost to fix | 15:45 |
*** mach1na has quit IRC | 15:45 | |
felixedel | Thanks :) Mine is usually at 90, but 80 worked quite well with most of the jsx code. Due the mix of javascript, html tags and all the {} when mixing both, I find that you shouldn't put too much in a single line as this becomes hard to read very quickly | 15:48 |
avass | I think I'd expect the user to make sure that git is available instead of us hoping that it's installed in %ProgramFiles%\git\mingw64\bin | 15:49 |
corvus | felixedel: ++ | 15:51 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add encrypt subcommand https://review.opendev.org/750709 | 16:06 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Initialize repository https://review.opendev.org/749775 | 16:08 |
*** harrymichal has quit IRC | 16:08 | |
*** harrymichal has joined #zuul | 16:09 | |
*** bhavikdbavishi has joined #zuul | 16:13 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: REST API: improve tenant scoping of autohold, authorizations https://review.opendev.org/728118 | 16:15 |
*** bhavikdbavishi1 has joined #zuul | 16:16 | |
*** bhavikdbavishi has quit IRC | 16:18 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 16:18 | |
mhu | hey there, can I get the final round of reviews on https://review.opendev.org/#/c/728994/ please? thanks! | 16:19 |
*** nils has quit IRC | 16:27 | |
*** jcapitao has quit IRC | 16:36 | |
*** bhavikdbavishi has quit IRC | 16:44 | |
*** bhavikdbavishi has joined #zuul | 16:44 | |
*** jpena is now known as jpena|off | 17:11 | |
*** Deknos has joined #zuul | 17:22 | |
*** harrymichal has quit IRC | 17:45 | |
*** harrymichal has joined #zuul | 17:46 | |
*** harrymichal has quit IRC | 17:47 | |
*** bhavikdbavishi has quit IRC | 17:47 | |
tobiash | avass: ++ | 17:49 |
*** hashar has joined #zuul | 18:13 | |
*** hashar has quit IRC | 18:31 | |
*** harrymichal has joined #zuul | 18:32 | |
corvus | mhu: lgtm; we can restart opendev with that and then evaluate the web change | 18:37 |
*** hashar has joined #zuul | 18:58 | |
*** piotrowskim has quit IRC | 19:34 | |
*** tosky has quit IRC | 19:37 | |
openstackgerrit | Merged zuul/zuul master: Builds: add "held" attribute https://review.opendev.org/728994 | 19:41 |
*** vishalmanchanda has quit IRC | 19:45 | |
*** openstackgerrit has quit IRC | 20:17 | |
*** harrymichal has quit IRC | 20:32 | |
*** Deknos has quit IRC | 20:39 | |
*** zenkuro has joined #zuul | 20:40 | |
*** rfolco|ruck has quit IRC | 21:03 | |
*** hashar has quit IRC | 21:06 | |
*** openstackgerrit has joined #zuul | 22:05 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: web: Fix error modal contents https://review.opendev.org/744095 | 22:05 |
*** avass has quit IRC | 22:34 | |
openstackgerrit | Ian Wienand proposed zuul/nodepool master: Dockerfile: add xz-utils https://review.opendev.org/750839 | 22:50 |
ianw | clarkb: ^ i might hand add that like we did for elfutils, and see if the gentoo build is happier ... | 22:50 |
ianw | clearly we don't watch it closely | 22:50 |
ianw | hang on, it's paused anyway ... | 22:53 |
ianw | This moves the nb04 config back to | 22:54 |
ianw | nodepool.yaml and unpauses everything except gentoo, which is still | 22:54 |
ianw | constantly failing. | 22:54 |
ianw | let me try unpausing it with xz i guess | 22:54 |
clarkb | the xz-utils change lgtm | 22:55 |
ianw | i've install xz and unpaused gentoo by hand on nb01 and will see if it works | 22:56 |
ianw | if it doesn't, i guess i'll spend some time converting the dib test into a container test at least | 22:56 |
ianw | i want to get rid of the non-container nodepool testing | 22:56 |
*** Goneri has quit IRC | 23:21 | |
*** cloudnull has quit IRC | 23:26 | |
*** cloudnull has joined #zuul | 23:26 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!