Wednesday, 2020-09-09

openstackgerritIan Wienand proposed zuul/nodepool master: Install gdisk/dosfstools on nodepool-builder images  https://review.opendev.org/75053200:09
openstackgerritIan Wienand proposed zuul/nodepool master: [dnm] testing uefi  https://review.opendev.org/74892900:09
*** Goneri has quit IRC00:22
*** hamalq has quit IRC00:31
*** piotrowskim has quit IRC00:43
*** frenzyfriday has joined #zuul00:44
*** frenzyfriday has quit IRC00:51
*** wxy has joined #zuul01:31
openstackgerritPierre-Louis Bonicoli proposed zuul/zuul master: gitlab: an "update" event isn't always a "labeled" action  https://review.opendev.org/75054401:49
openstackgerritPierre-Louis Bonicoli proposed zuul/zuul master: [gitlab] approvals: fix error with community edition  https://review.opendev.org/75054601:50
openstackgerritMerged zuul/nodepool master: Install gdisk/dosfstools on nodepool-builder images  https://review.opendev.org/75053201:56
*** wuchunyang has joined #zuul02:38
*** rlandy has joined #zuul03:03
*** rlandy has quit IRC03:31
*** systemd has quit IRC03:58
*** systemd has joined #zuul03:58
*** wuchunyang has quit IRC04:00
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441604:22
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441604:29
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** saneax has joined #zuul04:50
*** sanjayu_ has joined #zuul04:53
*** saneax has quit IRC04:54
*** frenzyfriday has joined #zuul05:16
*** frenzyfriday has quit IRC05:25
*** sanjayu_ has quit IRC05:30
*** sanjayu_ has joined #zuul05:37
*** sanjayu_ has quit IRC05:38
*** sanjayu_ has joined #zuul05:39
*** frenzyfriday has joined #zuul06:00
*** bhavikdbavishi has joined #zuul06:06
*** vishalmanchanda has joined #zuul06:14
felixedelcorvus, ianw, clarkb: Thanks for the squash change to test everything together. I didn't came to that yesterday. I've left a comment on that change. To sum up the "div scrolling" vs "viewport scrolling": IMHO the div scrolling is the way to go in case the content of a container is too wide (which is basically what every other website does that I'm aware of). Viewport scrolling is IMHO a no-go unless you find a way to06:24
felixedelachieve this without breaking the whole page layout (which I'm not aware of at least - but I'm also not a CSS expert). The other solution would be - like you said - to wrap the text so we avoid scrolling at all. I'm not sure what's the best solution here since I don't like horizontal scrolling but I'm also not a big fan of wrapped code/log snippets since you often loose track on where you and where a new line actually06:24
felixedelstarts :D06:24
felixedelI just took a look at the old (pf3) version of the frontend, which also used div-scrolling on the tab containers in case the log lines are too long.06:28
felixedelIt seems that this didn't bother anybody at that time06:29
*** mach1na has joined #zuul06:32
felixedelside topic: I just noticed that there is a tree-view (beta ) available in PF 4 now.06:38
*** mach1na has quit IRC06:46
*** mach1na has joined #zuul06:53
*** jcapitao has joined #zuul07:00
*** hashar has joined #zuul07:17
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441607:18
*** kmalloc has quit IRC07:27
ianwfelixedel: for mine, i think a wrap would be good.  as i mentioned with some links in that bug it seems the same as contemporary sites such as github and gitlab07:28
ianwdid you also see the log page horizontal issue though?  that seems more of a blocker because you can't seem to access the long lines at all07:29
*** jpena|off is now known as jpena07:30
felixedelianw: Which issue do you mean? That the scrollbar is inside the div and not on the viewport?07:31
ianwfelixedel: on the log viewer page, for me (and corvus) long lines are cut off, with no horizontal scroll option, and you can't even move the page over selecting the text?07:33
ianwi'm guessing it must be something with having each line in a table?07:33
felixedelNo, I'm not aware of that. Can you point me to an example?07:34
ianwfelixedel: ohhh, i just realised that i uploaded over your change this morning, my time07:37
ianwsorry about that.  i meant to squash all three changes into a separate change, but i guess i left the change-id at the bottom from the rebase/squash and took over your change07:37
ianwfelixedel: i'm using the sample site @ https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7ca/750322/2/check/zuul-build-dashboard-opendev/7cae351/npm/html/07:38
ianwi just go openstack->builds->select any build->logs->job-output.txt07:39
felixedelah, now I see. That looks indead weird. Let me check07:39
ianwfelixedel: do you mind if i stack the changes and restore your v1?07:40
ianwof the modal box i mean07:41
felixedelI think we could also sqash all changes07:41
felixedelThat might make it more clear that they are all needed together07:42
felixedelBut we should then also explain that in the commit message07:42
ianwi agree, maybe stack them for review as we sort out these last bits, and we can either squash them for commit or just do it at once sort-of-atomically07:42
ianwhow about i stack them, then we go from there07:42
felixedelok07:43
openstackgerritIan Wienand proposed zuul/zuul master: Revert "web: restore scrollbars and scroll behaviour"  https://review.opendev.org/75036107:45
openstackgerritIan Wienand proposed zuul/zuul master: Revert "Revert PF4 build page"  https://review.opendev.org/75036507:45
openstackgerritIan Wienand proposed zuul/zuul master: Use Modal to show config errors and fix scrolling  https://review.opendev.org/75032207:45
felixedelRegarding the horizontal scroll issue on the log viewer page: It could be solved by removing the "overflow: inherit;" attribute on the "pre.zuul-log-output" selector in CSS. IMHO it's also weird to have a table inside a pre. But that whole topic is independent of the other changes, so we should fix that in a follow-up07:45
felixedelRegarding the pre-wrap that corvus mentioned: I would go for a that if we could prepend the log lines with the line number (similar to the log viewer page) so you don't loose the context of the line in case it's split across multiple lines due to the wrap. But I would also prefer to do this in a follow up rather than merging it into the existing changes. Like I said, PF3 showed the same behaviour so it's not like PF407:48
felixedelbroke that.07:48
openstackgerritTobias Henkel proposed zuul/zuul master: DNM: Assert clean state on start  https://review.opendev.org/75058907:49
felixedelIt might not have been that relevant in the past since the font size was smaller and more of the line fit into the screen07:49
felixedel:D07:49
openstackgerritIan Wienand proposed zuul/zuul master: web: Fix error modal contents  https://review.opendev.org/74409507:51
ianwfelixedel: hrm with the current site i get a horizontal scrollbar though?07:51
ianwit does blow out the top nav bar as wide as the content07:52
ianwi think the bad regression with pf4 is that there's *no* way to see the long content.  whereas on pf3 it just looks bad i guess07:53
*** tosky has joined #zuul07:57
felixedeliawn: "it does blow out the top nav bar as wide as the content" Where is that?08:08
ianwfelixedel: on https://zuul.opendev.org/t/zuul/build/7cae351a0c0943268910f43d4dbf26b3/log/job-output.txt i see a horizontal scrollbar08:09
ianwso the nav bar is as wide as the log content, if you get what i mean08:09
ianw(which i probably agree isn't great either, but you can at least see the logs i guess)08:09
ianw(gotta run for dinner)08:10
felixedelRight, that is the version were your scrollbar fix is deployed ;-) And that has the drawback that everything is spread across the whole page width (which kind of breaks the layout).08:11
felixedelBut I think we should avoid this08:11
felixedelBut maybe I'm still missing what you want to achieve in the end?08:12
*** nils has joined #zuul08:19
*** ianychoi__ has quit IRC08:40
ianwfelixedel: umm, i don't know if i have a great answer, sorry.  so without my fix we could never see the whole log lines and nobody noticed you're saying?08:41
ianwmaybe that is possible ...08:41
felixedelIn wanted to say that we are dealing with two different problems here, both related to horizontal scrolling: The first is on the build result page  (where the results and failed tasks are shown). With your fix the tab layout is broken due to the whole page content set to overflow: visible. Thhe bevaiour on this page was untouched by PF4. The second one is on the log viewer page (which I wasn't aware of) and was08:46
felixedelintroduced by PF4. There the log lines are "unreachable" because the honrizontal scroll is completely disabled. This seems to be related by PF4 but can be solved by removing the overflow: inherit on the pre tag.08:46
ianwyes i agree there's two issues; for me the log viewer one is a blocker08:48
felixedelOk, but this seems to be fixed by simply updating the CSS.08:49
felixedelAnd there is no need to enable "global viewport scrollbars" (if you want to call it like that) for the whole website08:49
ianwfelixedel: ok, i mean for mine i think stack a change on top with it so corvus can verify, and i think we'll all be happy :)08:50
ianwthe other scroll issue is https://imgur.com/MlK1s8h08:50
ianwfor that, i think wrapping that box is sensible, and consistent with contemporary sites like github and gitlab from what i saw08:50
felixedelLike I said, I'm fine with the wrapping, but this issue wasn't introduced by PF4, but already existed with PF3 in the same way08:51
ianwok, i wouldn't consider that a blocker.  since it's identified it would be nice to fix, corvus did seem to feel strongly when he noticed it08:51
ianwagain IMO i'd stack a change separately just to keep it clear what's fixing what08:52
ianws/separately/on-top/08:52
felixedelOk, so update the CSS to fix the blocker in a follow up and clarifiy how we deal with the non-blocker first08:52
ianwi think it's easier to just stack them and then we can all look at the top change and know everything underneath is good, rather than separate changes that get confusing08:53
felixedelI'm fine with stacking. Just wanted to clarifiy that we need all together to fix the whole "scrolling issue" part :)08:53
ianwyeah, i mean the pf4 stuff is a fait accompli; so it's just these little corner cases i guess08:54
felixedelLike I said, I wanted to stack them myself, but didn't came to that yesterday anymore :)08:54
ianwi'm afraid i have to disappear for the night08:55
ianwthanks for working on it, and fixing my crappy "fixes" :)08:55
felixedelGood night. It's still a little confusing to work across different timezones without knowing from where everybody is working :D08:57
*** frenzyfriday has quit IRC09:25
*** frenzyfriday has joined #zuul09:26
*** hashar has quit IRC09:57
*** mach1na has quit IRC10:13
*** mach1na has joined #zuul10:13
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441610:21
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441610:22
*** bhavikdbavishi has quit IRC10:32
*** jcapitao is now known as jcapitao_lunch10:42
*** frenzyfriday has quit IRC11:00
*** bhavikdbavishi has joined #zuul11:15
*** mach1na has quit IRC11:21
*** jpena is now known as jpena|lunch11:30
*** harrymichal has joined #zuul11:34
*** sanjayu_ has quit IRC11:46
*** bhavikdbavishi has quit IRC11:50
*** sassyn has joined #zuul11:55
sassynHi All11:55
*** jcapitao_lunch is now known as jcapitao11:56
sassynHope is everyone doing fine! A quick question since It being 2 month the last time I work on our Zuul system. Can someone please tell me what is the difference when you use in the zuul-config/project.yaml a regex configuration compare to the untrusted-projects  configuration in the tenant .11:57
*** sanjayu_ has joined #zuul11:57
sassynIf I have wildcard as a regex - why should I declare my git project in the untrusted-projects place ?11:57
*** mach1na has joined #zuul11:58
*** rfolco has joined #zuul12:02
*** armstrongs has joined #zuul12:03
*** Goneri has joined #zuul12:07
*** rlandy has joined #zuul12:09
*** jfoufas1 has joined #zuul12:17
*** bhavikdbavishi has joined #zuul12:17
*** jhesketh has quit IRC12:17
*** jhesketh has joined #zuul12:17
*** jpena|lunch is now known as jpena12:32
*** piotrowskim has joined #zuul12:45
*** jfoufas1 has quit IRC13:04
*** armstrongs has quit IRC13:06
*** mach1na has quit IRC13:09
*** mach1na has joined #zuul13:10
*** jhesketh has quit IRC13:31
*** bhavikdbavishi has quit IRC13:43
*** sassyn has quit IRC13:45
openstackgerritBenoît Bayszczak proposed zuul/nodepool master: [provider][aws] use one API call to create tags  https://review.opendev.org/74692113:54
corvusfelixedel: showing a code snippet on a website is very different than showing logs that are hundreds of lines long.  it's unworkable to have a horizontal scroll bar below the bottom of the viewport, because to look at the right-hand part of a long line at the top, you have to scroll down, move the horizontal scrollbar (and you have to guess how far because you can't see the top line any more). then scroll13:58
corvusback up13:58
corvusfelixedel: div scrolling only works if the whole div fits in the viewport13:58
openstackgerritBenoît Bayszczak proposed zuul/nodepool master: [provider][aws] use one API call to create tags  https://review.opendev.org/74692113:59
corvusfelixedel: i agree though that at the console tab in the pf3 version uses div scrolling; i thought it did not, but perhaps i was wrong about that14:00
corvus(it does look like the summary tab uses viewport scrolling)14:00
zbrcorvus: https://review.opendev.org/#/c/748688/ please14:02
zbrcorvus: i disagree regarding the log vs code snippet, IMHO the same rule apply for both.14:04
corvuszbr: my argument is that it is never okay to have a horizontal scroll bar outside of the viewport14:04
zbrahh, sure14:05
corvuszbr: my understanding is that you feel that it's never okay to have a horizontal scroll bar period :)  so in that sense, we likely agree at least as far as my statement goes, you would just take it further.14:05
zbrmy view is that I never want a horizontal scroll, ever. but that is why i hope we will endup merging the change that makes it configurable.14:05
zbrthe prefs will help us find a middle ground14:06
corvusfelixedel: i appear to be wrong about the console tab, sorry about that.  i'm going to drop my objection to div-scrolling since it's not a regression (at least, not compared to the state before the pf4 work started) so it's not in scope for your changes14:09
corvusfelixedel: i think that leaves us with 2 things: error modal pre-wrap, and the logs tab.  i think div-scrolling would be fine on the logs tab too -- we just do need it to scroll14:11
corvusianw: ^ fyi; also updated comment on https://review.opendev.org/75032214:14
*** rfolco is now known as rfolco|ruck14:53
*** bschanzel has quit IRC14:54
*** bschanzel has joined #zuul14:55
*** sanjayu_ has quit IRC15:07
*** bhagyashris is now known as bhagyashris|ruck15:11
*** bhagyashris|ruck is now known as bhagyashris|rove15:11
*** jhesketh has joined #zuul15:23
felixedelCorvus: Ok. I will add a follow-up change for scrolling the logs tab (which obviously broke with PF4). The "modal pre-wrap" topic is what https://review.opendev.org/#/c/744095/4 is about, or? But that's also something new which wasn't there before if I'm not mistaken?15:28
corvusfelixedel: yeah, i think that broke recently and 744095 is the fix -- will 744095 work with your changes as written, or does it need to be updated?15:30
corvusoh15:30
corvusi just noticed that 744095 is rebased to be on your change now15:30
corvusso i think that means it should be taken care of -- once we get it fixed15:31
felixedelSry if I was a little harsh about the topic. I think the whole thing just led to a lot of confusion and was hard to clarify which change (or which part of the code) is responsible for what.15:31
corvusfelixedel: no worries -- and a lot of the confusion was contributed by me, and i'm sorry about that.  i think we're all just about on the same page now and doing our best to find the right way out now.  :)15:32
felixedelI didn't check out  https://review.opendev.org/#/c/744095/4 in detail. Will do that tomorrow morning and put my follow-up on top of it. We can then use the latest change to test if all is working together and everybody is happy with the solution15:33
corvusto recap: 1) we should fix 744095 to correct the pre-wrap in config errors; 2) fix scrolling in logs (div-scrolling is ok)15:33
corvusi wonder why the jobs failed there15:34
felixedeleslint most probably?15:34
corvusoh i see it15:34
corvusi'm going to fix that syntax error real quick15:34
openstackgerritJames E. Blair proposed zuul/zuul master: web: Fix error modal contents  https://review.opendev.org/74409515:36
corvusianw, felixedel: ^ that works locally15:40
felixedelYes, works and looks fine I would say. Just as a nit: Could we stick to the max line length of 80 characters in App.jsx and spread the "title" and "variant" attributes in different lines? :)15:43
corvussure i'll respin real quick15:43
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: synchronize-repos: Remove unecessary git path modifications  https://review.opendev.org/74764015:44
openstackgerritJames E. Blair proposed zuul/zuul master: web: Fix error modal contents  https://review.opendev.org/74409515:44
felixedelBecause I really hate horizontal scrolling in source code :-P15:44
avasstobiash: should we expect git to aleady be present in PATH on windows nodes or should we add those PATH modifications before the ssh+git check instead? ^15:45
corvusfelixedel: me too, but my limit is more like 100 chars :)  but this looks great at 80 and it's no cost to fix15:45
*** mach1na has quit IRC15:45
felixedelThanks :) Mine is usually at 90, but 80 worked quite well with most of the jsx code. Due the mix of javascript, html tags and all the {} when mixing both, I find that you shouldn't put too much in a single line as this becomes hard to read very quickly15:48
avassI think I'd expect the user to make sure that git is available instead of us hoping that it's installed in %ProgramFiles%\git\mingw64\bin15:49
corvusfelixedel: ++15:51
openstackgerritMatthieu Huin proposed zuul/zuul-client master: Add encrypt subcommand  https://review.opendev.org/75070916:06
openstackgerritMatthieu Huin proposed zuul/zuul-client master: Initialize repository  https://review.opendev.org/74977516:08
*** harrymichal has quit IRC16:08
*** harrymichal has joined #zuul16:09
*** bhavikdbavishi has joined #zuul16:13
openstackgerritMatthieu Huin proposed zuul/zuul master: REST API: improve tenant scoping of autohold, authorizations  https://review.opendev.org/72811816:15
*** bhavikdbavishi1 has joined #zuul16:16
*** bhavikdbavishi has quit IRC16:18
*** bhavikdbavishi1 is now known as bhavikdbavishi16:18
mhuhey there, can I get the final round of reviews on https://review.opendev.org/#/c/728994/ please? thanks!16:19
*** nils has quit IRC16:27
*** jcapitao has quit IRC16:36
*** bhavikdbavishi has quit IRC16:44
*** bhavikdbavishi has joined #zuul16:44
*** jpena is now known as jpena|off17:11
*** Deknos has joined #zuul17:22
*** harrymichal has quit IRC17:45
*** harrymichal has joined #zuul17:46
*** harrymichal has quit IRC17:47
*** bhavikdbavishi has quit IRC17:47
tobiashavass: ++17:49
*** hashar has joined #zuul18:13
*** hashar has quit IRC18:31
*** harrymichal has joined #zuul18:32
corvusmhu: lgtm; we can restart opendev with that and then evaluate the web change18:37
*** hashar has joined #zuul18:58
*** piotrowskim has quit IRC19:34
*** tosky has quit IRC19:37
openstackgerritMerged zuul/zuul master: Builds: add "held" attribute  https://review.opendev.org/72899419:41
*** vishalmanchanda has quit IRC19:45
*** openstackgerrit has quit IRC20:17
*** harrymichal has quit IRC20:32
*** Deknos has quit IRC20:39
*** zenkuro has joined #zuul20:40
*** rfolco|ruck has quit IRC21:03
*** hashar has quit IRC21:06
*** openstackgerrit has joined #zuul22:05
openstackgerritIan Wienand proposed zuul/zuul master: web: Fix error modal contents  https://review.opendev.org/74409522:05
*** avass has quit IRC22:34
openstackgerritIan Wienand proposed zuul/nodepool master: Dockerfile: add xz-utils  https://review.opendev.org/75083922:50
ianwclarkb: ^ i might hand add that like we did for elfutils, and see if the gentoo build is happier ...22:50
ianwclearly we don't watch it closely22:50
ianwhang on, it's paused anyway ...22:53
ianwThis moves the nb04 config back to22:54
ianw    nodepool.yaml and unpauses everything except gentoo, which is still22:54
ianw    constantly failing.22:54
ianwlet me try unpausing it with xz i guess22:54
clarkbthe xz-utils change lgtm22:55
ianwi've install xz and unpaused gentoo by hand on nb01 and will see if it works22:56
ianwif it doesn't, i guess i'll spend some time converting the dib test into a container test at least22:56
ianwi want to get rid of the non-container nodepool testing22:56
*** Goneri has quit IRC23:21
*** cloudnull has quit IRC23:26
*** cloudnull has joined #zuul23:26

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!