| *** wuchunyang has quit IRC | 00:03 | |
| *** armstrongs has joined #zuul | 00:04 | |
| *** armstrongs has quit IRC | 00:13 | |
| *** jpena|off has quit IRC | 00:32 | |
| *** jpena|off has joined #zuul | 00:32 | |
| *** mhu has quit IRC | 00:33 | |
| *** mhu has joined #zuul | 00:34 | |
| *** frenzyfriday has joined #zuul | 01:10 | |
| *** frenzyfriday has quit IRC | 01:19 | |
| *** noonedeadpunk has quit IRC | 01:47 | |
| *** noonedeadpunk has joined #zuul | 01:50 | |
| *** frenzyfriday has joined #zuul | 01:51 | |
| *** frenzyfriday has quit IRC | 01:56 | |
| *** frenzyfriday has joined #zuul | 02:46 | |
| *** frenzyfriday has quit IRC | 02:51 | |
| *** bhavikdbavishi has joined #zuul | 03:12 | |
| *** bhavikdbavishi1 has joined #zuul | 03:15 | |
| *** bhavikdbavishi has quit IRC | 03:17 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:17 | |
| *** bhavikdbavishi has quit IRC | 03:34 | |
| *** bhavikdbavishi has joined #zuul | 03:34 | |
| *** frenzyfriday has joined #zuul | 03:40 | |
| *** frenzyfriday has quit IRC | 03:49 | |
| *** vishalmanchanda has joined #zuul | 03:52 | |
| *** bhavikdbavishi has quit IRC | 04:32 | |
| *** bhavikdbavishi has joined #zuul | 04:32 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** wuchunyang has joined #zuul | 04:55 | |
| *** frenzyfriday has joined #zuul | 05:29 | |
| *** frenzyfriday has quit IRC | 05:37 | |
| felixedel | pf4 | 06:15 |
|---|---|---|
| *** frenzyfriday has joined #zuul | 06:15 | |
| *** saneax has joined #zuul | 06:18 | |
| *** bhavikdbavishi1 has joined #zuul | 06:28 | |
| *** bhavikdbavishi has quit IRC | 06:30 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:30 | |
| *** hashar has joined #zuul | 06:53 | |
| *** bhavikdbavishi has quit IRC | 06:54 | |
| *** jcapitao has joined #zuul | 07:00 | |
| *** sanjayu_ has joined #zuul | 07:01 | |
| *** saneax has quit IRC | 07:03 | |
| *** bhavikdbavishi has joined #zuul | 07:08 | |
| felixedel | zuul-maint: I just came back from my vacation and saw that you reverted the build result page https://review.opendev.org/#/c/749098/ due to some conflicts with the new tab layout and long log lines. | 07:23 |
| felixedel | Honestly, it makes me sad that you simply reverted the change without further investigation of the actual problem. | 07:23 |
| felixedel | I took a look this morning and the problem is the scrollbar fix from Ian https://review.opendev.org/#/c/742759/. | 07:23 |
| felixedel | Honestly I wasn't aware of this, otherwise I would have commented on this change directly, but it took only a few minutes of investigation. | 07:23 |
| felixedel | The problem is the "overflow: visible" which basically tells the browser to show the whole content of the element (no matter if it fits or not). | 07:23 |
| felixedel | If the element is too big for the browser window the browser comes up with scroll bars to make the content accessible to the user. | 07:23 |
| felixedel | The same behaviour can still be seen in the "fixed/reverted" version of zuul-web https://zuul.opendev.org/t/openstack/build/81dbd69b47534170bfaf857e87feb87d | 07:23 |
| felixedel | This seems to break the page layout as designed by PF4 and all components which would provide their own scrollbar (like the tab contents). | 07:23 |
| felixedel | In combination with the "isFilled" setting I used for the new tabs on the build page, tihs makes the tabs inaccessible as they are spread equally across the whole page width. | 07:23 |
| felixedel | Without this scrolling fix, the page layout works fine and the tabs with a larger content provide their own scrollbar to scroll the tab content independently of the whole page. | 07:23 |
| felixedel | ^ianw: In case you are also interested in this | 07:23 |
| *** tosky has joined #zuul | 07:35 | |
| *** mach1na has quit IRC | 07:35 | |
| *** mach1na has joined #zuul | 07:35 | |
| *** wuchunyang has quit IRC | 07:43 | |
| *** jpena|off is now known as jpena | 07:53 | |
| *** mach1na has quit IRC | 07:55 | |
| *** mach1na has joined #zuul | 07:56 | |
| *** tosky has quit IRC | 08:05 | |
| *** jfoufas1 has joined #zuul | 08:06 | |
| *** tosky has joined #zuul | 08:10 | |
| *** tosky has quit IRC | 08:14 | |
| *** tosky has joined #zuul | 08:14 | |
| zbr | felixedel: people tried to get hold of you around the problem, waited, revert was a last resort measure. | 08:19 |
| zbr | they were not against the change, but the its broke several critical areas. | 08:19 |
| felixedel | I don't think that anybody is "against my change" I just wanted to clarify that the wrong change was reverted to fix the root cause. I also don't want to blame ianw for that change, because I wasn't aware of that impact either. | 08:25 |
| felixedel | Wat exactly do you mean by "broke several critical areas"? | 08:25 |
| ianw | felixedel: yeah, i think we are not happy with removing it. i agree it was probably my "fix" that broke it, although I never claimed it was anything more than me playing with the inspector rather than and understanding of patternfly | 08:27 |
| ianw | i think you are definitely the expert here :) | 08:29 |
| ianw | hopefully we can make any minor updates and just revert the revert, and it's all back | 08:29 |
| ianw | i think navigation keys not working when you open the logs is a bit of a blocker, we probably shouldn't have let it get into that state | 08:31 |
| ianw | s/log/any page | 08:31 |
| ianw | maybe we need to reconsider the focus fix, despite the accessibility issues | 08:32 |
| ianw | ? i haven't seen any comments on the upstream issue either? | 08:32 |
| ianw | i agree that, e.g. https://zuul.opendev.org/t/openstack/build/7e5c7683820440d4be11bd9635a27197/log/logs/ubuntu-minimal_focal-arm64-build-succeeds.PASS.log has gone too wide | 08:34 |
| ianw | but how can we fix that, but also keep keys working, and accessibility, i, i guess the question. | 08:34 |
| ianw | (which, i guess, was probably the original question too :) | 08:34 |
| felixedel | So far there is no response to the issue. I just asked about it in the PF4 slack channel. Maybe I get some response later on. Regarding "How to fix that, but also keep the keys working": The closest I got is the combination of https://review.opendev.org/#/c/743239/ and https://review.opendev.org/#/c/743917/. IIRC the only drawback is the accessibility of the navigation items via tabbing. Since the focus is set to the | 08:41 |
| felixedel | page content explicitly, one must tab backwards through the navigation bar rather than starting from the zuul logo. | 08:41 |
| *** frenzyfriday has quit IRC | 08:42 | |
| felixedel | The first patch https://review.opendev.org/#/c/743239/ itself doesn't harm anything and at least allows accessibility via keys when first clicked (via mouse) somewhere in the page content. | 08:43 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Use weakref to reference item from buildset https://review.opendev.org/750197 | 08:45 |
| felixedel | A fix that would for sure work is to dump the drawer component and come up with something else for the config errors. Question: Do we have to show them on top of the current page or could we directly point to the config error page when clicking on the bell icon? That would still be not an ideal solution but maybe the one with the least accessibility impact. I was just thinking: How many people are frequently looking at | 08:45 |
| felixedel | their config errors (if there are some)? | 08:45 |
| *** nils has joined #zuul | 08:45 | |
| tobiash | imho a modal dialog would do it as well when clicking on the bell | 08:47 |
| felixedel | Thinking about the topic now I would rather dumpt the Drawer component. I don't think we need something this "prominent" to show the config errors details. | 08:48 |
| tobiash | that drawer seems to cause more problems than it's worth the look and feel | 08:48 |
| felixedel | Modal also came to my mind. Not sure how that will look for larger number of errors, but I can try it out | 08:48 |
| tobiash | can a modal have a scrollbar? | 08:49 |
| tobiash | the drawer anyway has the drawback that it's too narrow for many error messages | 08:50 |
| felixedel | I'm not sure about the scrollbar in the modal, that's why I want to test it. | 08:50 |
| felixedel | The openstack tenant has 104! config errors. Should be a good test candidat :D | 08:50 |
| felixedel | Modal has a scrollbar and doesn't look bad at all. | 09:00 |
| tobiash | awesome, I think this would solve some problems :) | 09:07 |
| ianw | felixedel: ++ on dropping the drawer if that helps, i agree it doesn't need to be something you pull out all the time | 09:07 |
| openstackgerrit | Merged zuul/nodepool master: [provider][aws] fix exception when instance not found during cleanup https://review.opendev.org/746932 | 09:17 |
| *** sanjayu_ has quit IRC | 09:30 | |
| *** sanjayu_ has joined #zuul | 09:30 | |
| *** tosky has quit IRC | 09:39 | |
| *** tosky has joined #zuul | 09:54 | |
| *** sanjayu_ has quit IRC | 10:07 | |
| *** holser has quit IRC | 10:17 | |
| *** harrymichal has joined #zuul | 10:32 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Use Modal to show config errors and fix scrolling https://review.opendev.org/750322 | 11:03 |
| *** wuchunyang has joined #zuul | 11:09 | |
| *** jcapitao is now known as jcapitao_lunch | 11:10 | |
| felixedel | zuul-maint: This https://review.opendev.org/#/c/750322/1 uses a modal instead of a drawer to show the config errors. In combination with a floating navbar this should fix the scrolling issues. Both are part of this change. I've tested it also with the PF4 builds page and without the other scroll fix https://review.opendev.org/#/c/742759/. | 11:12 |
| *** wuchunyang has quit IRC | 11:13 | |
| *** wuchunyang has joined #zuul | 11:13 | |
| *** piotrowskim has joined #zuul | 11:14 | |
| zbr | ianw: cabn you +W https://review.opendev.org/#/c/749702/ ? -- i have the impression the felix supports the indentation fixes on js. | 11:20 |
| *** mach1na has quit IRC | 11:23 | |
| *** mach1na has joined #zuul | 11:23 | |
| *** mach1na has quit IRC | 11:31 | |
| *** rfolco has joined #zuul | 11:50 | |
| *** harrymichal has quit IRC | 11:52 | |
| *** harrymichal has joined #zuul | 11:53 | |
| *** rlandy has joined #zuul | 11:56 | |
| *** mach1na has joined #zuul | 12:00 | |
| *** jpena is now known as jpena|lunch | 12:00 | |
| *** saneax has joined #zuul | 12:00 | |
| *** harrymichal has quit IRC | 12:02 | |
| *** harrymichal has joined #zuul | 12:03 | |
| *** wuchunyang has quit IRC | 12:11 | |
| *** harrymichal has quit IRC | 12:16 | |
| *** wuchunyang has joined #zuul | 12:22 | |
| *** harrymichal has joined #zuul | 12:22 | |
| *** jcapitao_lunch is now known as jcapitao | 12:31 | |
| openstackgerrit | Benjamin Schanzel proposed zuul/zuul master: Optionally support mitogen for job execution https://review.opendev.org/657024 | 12:32 |
| *** holser has joined #zuul | 12:34 | |
| *** ikhan has joined #zuul | 12:37 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 12:40 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 12:43 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 12:43 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 12:44 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 12:44 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 12:44 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 12:44 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 12:44 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 12:44 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 12:44 |
| *** harrymichal has quit IRC | 12:47 | |
| *** harrymichal has joined #zuul | 12:48 | |
| *** bhavikdbavishi has quit IRC | 12:52 | |
| *** jfoufas1 has quit IRC | 13:01 | |
| *** Goneri has joined #zuul | 13:03 | |
| *** jpena|lunch is now known as jpena | 13:12 | |
| tristanC | felixedel: you can observe the issue with the buildpage by picking a build before the revert got merged, for example: https://review.opendev.org/#/c/748733/ (job zuul-build-dashboard-opendev) , then go to openstack tenant, and pick a tempest failure from neutron. You'll see the whole build page to overflow, rendering navigation difficult | 13:12 |
| *** harrymichal has quit IRC | 13:12 | |
| tristanC | felixedel: because it affected openstack user, the build change was reverted until further investigation | 13:13 |
| tristanC | felixedel: would you mind clicking revert on the reverted change 749098 by adding the needed css statement? | 13:14 |
| *** harrymichal has joined #zuul | 13:14 | |
| *** harrymichal has quit IRC | 13:18 | |
| *** harrymichal has joined #zuul | 13:19 | |
| felixedel | tristanC: Please see my last message. 1. https://review.opendev.org/#/c/750322/1 should fix the scroll behaviour. With that, we could revert https://review.opendev.org/#/c/742759/ and revert https://review.opendev.org/#/c/749098/ to restore the new design and fix the scroll issue. | 13:25 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Revert "web: restore scrollbars and scroll behaviour" https://review.opendev.org/750361 | 13:29 |
| tristanC | felixedel: was the build page overflow caused by the config errors drawer? could you please pick the revert of 749098 on top of the config error change to see if it works as expected. | 13:42 |
| *** harrymichal has quit IRC | 13:44 | |
| *** harrymichal has joined #zuul | 13:45 | |
| felixedel | tristanC: The build page overflow was caused by https://review.opendev.org/#/c/742759/ and the fact that the tabs on the new build page are split equally across the whole page width (and not collapsed to the left like before). | 13:46 |
| felixedel | Thus, reverting https://review.opendev.org/#/c/742759/ would fix the build page overflow. https://review.opendev.org/#/c/750322/1 fixes the scroll behaviour (which is the root cause why we came up with the various "scroll fixes" in the first place). The new build page was unrelated to the scroll behaviour and didn't change anything about it. Just the placement of the tabs made them "inaccessible" due to the scroll bug. | 13:50 |
| *** hashar is now known as hasharAway | 13:51 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Revert "Revert PF4 build page" https://review.opendev.org/750365 | 13:53 |
| *** bhavikdbavishi has joined #zuul | 14:02 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add promote, release jobs https://review.opendev.org/750193 | 14:05 |
| *** bhavikdbavishi1 has joined #zuul | 14:05 | |
| *** bhavikdbavishi has quit IRC | 14:06 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 14:06 | |
| *** harrymichal has quit IRC | 14:09 | |
| *** wuchunyang has quit IRC | 14:17 | |
| *** wuchunyang has joined #zuul | 14:17 | |
| *** harrymichal has joined #zuul | 14:21 | |
| *** harrymichal_ has joined #zuul | 14:25 | |
| *** harrymichal has quit IRC | 14:28 | |
| *** harrymichal_ is now known as harrymichal | 14:28 | |
| *** sgw has joined #zuul | 15:01 | |
| *** zenkuro has joined #zuul | 15:10 | |
| *** saneax has quit IRC | 15:14 | |
| *** hasharAway has quit IRC | 15:19 | |
| *** mach1na has quit IRC | 15:29 | |
| *** hasharAway has joined #zuul | 15:50 | |
| *** hasharAway is now known as hashar | 15:51 | |
| *** harrymichal has quit IRC | 15:56 | |
| *** harrymichal has joined #zuul | 15:56 | |
| *** nils has quit IRC | 15:58 | |
| *** nils has joined #zuul | 15:59 | |
| *** nils has quit IRC | 16:00 | |
| corvus | felixedel: sorry we reverted the wrong change -- but reverts aren't permanent. we reverted that in order to get back to something that worked for the most number of folks as quickly as possible. with so many people away, we didn't have a lot of bandwidth to try to figure out the best solution, we just needed to reverse a regression. now that you're back, we can work on fixing things up right. | 16:01 |
| corvus | felixedel: if you haven't noticed, 'revert revert' is a pretty common commit subject line :) | 16:02 |
| corvus | also 'revert revert revert revert' has been seen more than a few times | 16:02 |
| corvus | felixedel: any reason you didn't stack all the changes in series (i think tristanC suggested that) so we can see the whole system working? | 16:05 |
| corvus | iiuc, we want 750361 + 750365 + 750322 right? | 16:05 |
| *** vishalmanchanda has quit IRC | 16:21 | |
| corvus | fbo: see https://review.opendev.org/742165 | 16:22 |
| *** ashbullock has joined #zuul | 16:23 | |
| *** harrymichal has quit IRC | 16:25 | |
| *** harrymichal has joined #zuul | 16:25 | |
| *** jcapitao has quit IRC | 16:31 | |
| *** hamalq has joined #zuul | 16:42 | |
| harrymichal | Hi! I already asked in #softwarefactory but I'm asking also here. Fedora 33 branched out from Rawhide some time ago already. Could you add a cloud-fedora-33 label on SF any time soon? Thank you! | 16:52 |
| *** harrymichal has quit IRC | 16:55 | |
| *** harrymichal has joined #zuul | 16:56 | |
| fungi | tristanC: ^ | 17:01 |
| *** harrymichal has quit IRC | 17:05 | |
| *** harrymichal has joined #zuul | 17:06 | |
| *** jpena is now known as jpena|off | 17:12 | |
| *** hashar has quit IRC | 17:27 | |
| *** mach1na has joined #zuul | 17:31 | |
| *** ashbullock has quit IRC | 17:33 | |
| *** mach1na has quit IRC | 17:36 | |
| tristanC | harrymichal: sorry we missed your request, #softwarefactory is the appropriate channel to ask sf related things. thank you fungi for the heads-up :-) | 17:39 |
| harrymichal | np | 17:40 |
| *** bhavikdbavishi has quit IRC | 17:44 | |
| *** bhavikdbavishi has joined #zuul | 17:45 | |
| *** bhavikdbavishi has quit IRC | 18:03 | |
| *** hashar has joined #zuul | 18:43 | |
| *** _erlon_ has joined #zuul | 19:31 | |
| *** harrymichal has quit IRC | 20:06 | |
| *** rlandy is now known as rlandy|mtg | 20:11 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: [dnm] test squashed web revert & modal fix https://review.opendev.org/750322 | 20:14 |
| ianw | felixedel: ^ thanks for looking, i didn't want to go fiddling your changes but it seems to me we want to stack the revert of the css fix, the new build page and removing the drawer component | 20:15 |
| ianw | i think if that looks good together, we should go with all three basically at once | 20:16 |
| ianw | so that change is just a dnm squashing them all together that i'll look at once it reports | 20:17 |
| *** frenzyfriday has joined #zuul | 20:30 | |
| *** armstrongs has joined #zuul | 20:30 | |
| *** frenzyfriday has quit IRC | 20:35 | |
| *** hashar has quit IRC | 20:38 | |
| *** armstrongs has quit IRC | 20:39 | |
| *** rfolco has quit IRC | 20:51 | |
| *** rlandy|mtg is now known as rlandy | 21:08 | |
| corvus | ianw: ++ | 21:32 |
| *** ikhan has quit IRC | 21:55 | |
| *** zenkuro has quit IRC | 22:01 | |
| *** frenzyfriday has joined #zuul | 22:01 | |
| *** frenzyfriday has quit IRC | 22:10 | |
| ianw | corvus/felixedel: quick link https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7ca/750322/2/check/zuul-build-dashboard-opendev/7cae351/npm/html/ | 22:52 |
| ianw | all looks good to me! navigation buttons work, and console logs (and everything else) seems to fit in the page | 22:52 |
| ianw | one thing is that the error dialogs are still wrong; https://review.opendev.org/#/c/744095/ | 22:53 |
| ianw | i guess i should rebase that on the new modal dialog, because that seems the way to go | 22:53 |
| corvus | ianw: checking it out now; i'm going to remember to look for some really bad failures this time | 22:54 |
| clarkb | ianw: corvus was there a specific change in the unreverting to fix things? if so any chance you have a link? | 22:55 |
| *** tosky has quit IRC | 22:55 | |
| ianw | clarkb: the main thing is dropping the drawer for the zuul error log for a modal dialog i think | 22:55 |
| clarkb | gotcha | 22:55 |
| corvus | but really i'm with ianw and tristanC: we need all three, so ianw's change is the best way to evaluate if they're all ready | 22:56 |
| corvus | clarkb: ^ | 22:56 |
| *** _erlon_ has quit IRC | 22:56 | |
| clarkb | got it for testing use the squash | 22:56 |
| corvus | the first thing i notice is that horizontal scroll is moved to interior containers | 22:58 |
| corvus | i think that makes it unworkable | 22:59 |
| corvus | (if you want to scroll to the right on the top line of an error report, then you need to scroll down to the bottom, scroll to the right, then scroll back up) | 22:59 |
| ianw | corvus: where are you seeing horizontal scroll? | 23:00 |
| corvus | ianw: in the output boxes on both the summary and console tabs | 23:01 |
| corvus | (be sure to look at a failed job so that an error report appears on the summary tab) | 23:02 |
| corvus | https://zuul.opendev.org/t/openstack/build/0c0b5375cf3343fa9a214af8a12d5c8a/console | 23:03 |
| corvus | that's the build i'm looking at | 23:03 |
| corvus | obv that's the live site for comparison; can search for uuid to find it in preview site | 23:03 |
| corvus | ianw: re error dialogs -- i agree; i think we should switch to pre-wrap as suggested in 744095. the current modal should take care of the width problem. | 23:05 |
| ianw | corvus: ok, so i guess i see what you mean, that the error box has the horizontal scroll in it | 23:07 |
| ianw | but isn't that correct? | 23:07 |
| corvus | i don't think so | 23:08 |
| corvus | i went to great pains with my original console tab implementation to make sure that the horizontal scroll was always visible | 23:08 |
| corvus | i don't understand how horizontal scroll can be usable if it's not visible on the page at all times | 23:09 |
| ianw | the current site blows out the title bar as wide as the content, putting the right hand navigation bits well off screen | 23:10 |
| ianw | which i guess you're saying is your desired behaviour | 23:10 |
| corvus | well, not strictly no | 23:11 |
| corvus | i think that's a new behavior that also just went unnoticed | 23:11 |
| corvus | i think under pf3 that didn't happen, but i couldn't say for sure | 23:11 |
| corvus | i will freely admit that i did not think about that when i reviewed the initial pf4 changes | 23:11 |
| corvus | so i can't say for sure if or when it changed | 23:12 |
| ianw | i understand what you mean, in that if your long line is up the top, and you have more than a screen-height amount of content, you have to scroll down, moving your long-line off the screen, before you can horizontally scroll it | 23:13 |
| ianw | describing it it words is quite painful :) | 23:13 |
| corvus | yep. that's it exactly. | 23:13 |
| ianw | ... how does github handle it? | 23:14 |
| corvus | ianw: the way it works in felixedel's patches | 23:15 |
| clarkb | github is really bad with wide text | 23:15 |
| ianw | https://github.com/pyca/cryptography/pull/5428/checks just seems to wrap | 23:15 |
| clarkb | they also window it to some limited number of characters much tinner than my monitor | 23:15 |
| corvus | i don't see any long text there | 23:16 |
| ianw | i don't know how to direct link, but if i click on a job, then down arrow to expand out steps | 23:16 |
| corvus | ianw: are you logged in? | 23:16 |
| ianw | which is roughly equivalent to the console | 23:16 |
| ianw | zuul console | 23:16 |
| corvus | (because i'm not, so i may not be seeing what you are) | 23:17 |
| ianw | ... how bizarre! when i look in an incognito window, you can't expand the "steps" to see the results | 23:17 |
| corvus | yeah, that's par for the course for github for some reason | 23:17 |
| ianw | you just have a tick. when i'm logged in, you can expand that | 23:17 |
| corvus | anyway, i'll take your word that they wrap ci output | 23:17 |
| corvus | and they horizontally scroll repo files | 23:18 |
| corvus | probably the one thing they don't do is horizontally scroll the viewport which is what zuul does | 23:18 |
| corvus | i think we need to either maintain the current behavior of viewport scrolling, or drop horizontal scrolling and only wrap. because (i'm going to call the thing that felixedel's patch does "div-scrolling" i don't know if it has a better name, but hopefully that describes it well enough) and i say this as probably the biggest champion of horizontal scrolling: div-scrolling makes it unusable. | 23:21 |
| ianw | i'm trying to find a similar sample from gitlab | 23:21 |
| corvus | ianw: similar to? | 23:21 |
| ianw | how it shows ci console results with long lines | 23:22 |
| corvus | gotcha | 23:22 |
| ianw | https://gitlab.com/wireshark/wireshark/-/jobs/727727170 appears to be the general interface, but that doesn't seem to have long lines | 23:22 |
| corvus | well, if you shrink your window it wraps | 23:23 |
| ianw | https://gitlab.com/wireshark/wireshark/-/jobs/727727167 | 23:23 |
| ianw | heh, yes, that's a good way to do it :) that has longer lines, and yes, wraps | 23:23 |
| corvus | hrm, the logs tab in the proposed change is really weird | 23:30 |
| corvus | it has wide text and no horizontal scrollbar at all | 23:30 |
| ianw | well, good old jenkins, i don't know what i'm looking at but i clicked on something and it's trying to show me a garbled 200mb zip file as text | 23:30 |
| corvus | i can't find a way to scroll to the right -- even selecting and dragging text isn't scrolling it | 23:31 |
| corvus | ianw, clarkb, felixedel: i think i left a coherent summary comment on https://review.opendev.org/750322 | 23:33 |
| corvus | does that seem clear enough? | 23:33 |
| ianw | corvus: i have to agree on the log page, when you shrink the window | 23:34 |
| ianw | i bet it has to do with every line being a table cell | 23:34 |
| *** rlandy has quit IRC | 23:35 | |
| *** kmalloc has joined #zuul | 23:37 | |
| ianw | corvus: ++ | 23:41 |
| *** frenzyfriday has joined #zuul | 23:50 | |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Install gdisk on nodepool-builder images https://review.opendev.org/750532 | 23:50 |
| clarkb | ianw: fungi ^ fyi Ithink that is the fix for the fatal image build error | 23:51 |
| openstackgerrit | Ian Wienand proposed zuul/nodepool master: Install gdisk on nodepool-builder images https://review.opendev.org/750532 | 23:56 |
| openstackgerrit | Ian Wienand proposed zuul/nodepool master: [dnm] testing uefi https://review.opendev.org/748929 | 23:56 |
| *** frenzyfriday has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!