| openstackgerrit | Merged zuul/zuul master: model.py : remove unused inheritable_attributes dictionary https://review.opendev.org/747600 | 00:05 |
|---|---|---|
| *** _erlon_ has quit IRC | 00:25 | |
| *** frenzyfriday has joined #zuul | 00:29 | |
| *** frenzyfriday has quit IRC | 00:38 | |
| *** mgoddard has quit IRC | 00:41 | |
| *** mgoddard has joined #zuul | 00:47 | |
| *** sgw has quit IRC | 01:14 | |
| *** rlandy has quit IRC | 01:15 | |
| *** mgoddard has quit IRC | 01:17 | |
| *** reiterative has quit IRC | 01:22 | |
| *** reiterative has joined #zuul | 01:24 | |
| *** mgoddard has joined #zuul | 01:24 | |
| *** sgw has joined #zuul | 01:33 | |
| *** frenzyfriday has joined #zuul | 02:14 | |
| *** frenzyfriday has quit IRC | 02:18 | |
| *** bhavikdbavishi has joined #zuul | 02:59 | |
| *** frenzyfriday has joined #zuul | 03:08 | |
| *** frenzyfriday has quit IRC | 03:17 | |
| *** bhavikdbavishi has quit IRC | 03:18 | |
| *** bhavikdbavishi has joined #zuul | 03:42 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** saneax has joined #zuul | 04:46 | |
| *** bhagyashris|away is now known as bhagyashris | 05:02 | |
| *** vishalmanchanda has joined #zuul | 05:10 | |
| *** kmalloc has quit IRC | 05:40 | |
| *** reiterative has quit IRC | 05:43 | |
| *** reiterative has joined #zuul | 05:43 | |
| *** frenzyfriday has joined #zuul | 05:47 | |
| *** mach1na has joined #zuul | 05:48 | |
| *** bhavikdbavishi1 has joined #zuul | 05:55 | |
| *** bhavikdbavishi has quit IRC | 05:56 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 05:56 | |
| *** mach1na has quit IRC | 06:38 | |
| *** bhavikdbavishi has quit IRC | 06:45 | |
| *** frenzyfriday has quit IRC | 06:48 | |
| *** frenzyfriday has joined #zuul | 06:49 | |
| *** frenzyfriday has quit IRC | 06:54 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Annotate logger with event ID when (un)locking node set https://review.opendev.org/748365 | 06:55 |
| *** LLIU82 has joined #zuul | 06:55 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Annotate logger with event ID when (un)locking node set https://review.opendev.org/748122 | 06:58 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 07:02 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 07:02 |
| *** mach1na has joined #zuul | 07:04 | |
| *** mach1na has quit IRC | 07:17 | |
| *** bhavikdbavishi has joined #zuul | 07:24 | |
| *** yoctozepto has quit IRC | 07:34 | |
| *** tosky has joined #zuul | 07:47 | |
| *** mach1na has joined #zuul | 07:49 | |
| *** nils has joined #zuul | 08:06 | |
| openstackgerrit | Merged zuul/zuul-jobs master: bindep: Fixed runtime warnings https://review.opendev.org/747781 | 08:24 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 08:28 |
| *** yoctozepto has joined #zuul | 08:55 | |
| LLIU82 | I met a problem of when I try to run a child job of tox-doc. I have set the proxy information as environment variable for the ansible user. But the error shows the connection problem to pypi.org | 09:08 |
| LLIU82 | 2020-08-27 08:54:31.886616 | TASK [bindep : Install bindep into temporary venv] | 09:09 |
| LLIU82 | redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7f783632b790>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/bindep/\n WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken | 09:09 |
| LLIU82 | by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7f783632b9a0>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/bindep/\n WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by | 09:09 |
| LLIU82 | 'ConnectTimeoutError(<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7f783632b730>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/bindep/\n WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by | 09:09 |
| LLIU82 | 'ConnectTimeoutError(<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7f783632b400>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/bindep/\n WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by | 09:09 |
| LLIU82 | 'ConnectTimeoutError(<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7f783632b490>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/bindep/\n ERROR: Could not find a version that satisfies the requirement bindep (from versions: none)\nERROR: No matching distribution found for bindep\n" | 09:09 |
| LLIU82 | 09:01:07.989124 | zuul-doc-server | } | 09:09 |
| *** LLIU82 has quit IRC | 09:19 | |
| *** LLIU82 has joined #zuul | 09:22 | |
| *** hashar has joined #zuul | 09:45 | |
| *** holser has quit IRC | 09:45 | |
| *** bhavikdbavishi has quit IRC | 09:58 | |
| *** holser has joined #zuul | 09:59 | |
| *** tkc17 has joined #zuul | 10:01 | |
| tkc17 | Hi Guys, when using 3.19.1.dev155, we are seeing an issue with integrated gate queue, unrelated jobs are made dependent i.e., even though one job is completed the results are not posted till an other unrelated job is done (can see a black line indicating they are dependant but they are not), this is seen with the latest move to DEV but my colleague says he has seen this earlier as well but not sure. Any ideas? | 10:07 |
| *** bhavikdbavishi has joined #zuul | 10:14 | |
| *** sshnaidm|afk is now known as sshnaidm | 10:30 | |
| *** bhavikdbavishi has quit IRC | 10:44 | |
| *** hashar is now known as hasharLunch | 10:48 | |
| *** mach1na has quit IRC | 11:10 | |
| avass | Is there a reason for why the mergers don't do a sparse checkout with only the relevant zuul directories? compatibility with older git versions? | 11:11 |
| openstackgerrit | Benjamin Schanzel proposed zuul/nodepool master: k8s Driver: Fix Node Launch For Secrets Without API Credentials https://review.opendev.org/748414 | 11:19 |
| avass | oh, it's still experimental. that's probably why :) | 11:24 |
| *** Goneri has joined #zuul | 11:34 | |
| *** mach1na has joined #zuul | 11:47 | |
| *** rlandy has joined #zuul | 11:57 | |
| *** mach1na has quit IRC | 12:00 | |
| *** mach1na has joined #zuul | 12:00 | |
| *** hasharLunch is now known as hashar | 12:01 | |
| *** bhavikdbavishi has joined #zuul | 12:26 | |
| *** bhavikdbavishi has quit IRC | 13:08 | |
| *** bhavikdbavishi has joined #zuul | 13:14 | |
| *** bhavikdbavishi has quit IRC | 13:36 | |
| *** rlandy is now known as rlandy|mtg | 14:00 | |
| fungi | tkc17: i'm having trouble following your problem description... i wonder if maybe you mean changes when you say jobs? dependent queues are all about testing changes in a series, so if a change has another ahead of it, the later change's build results can't be reported until zuul is sure the change ahead of it worked, since they were tested together (if the change ahead of it fails, all jobs for the second | 14:05 |
| fungi | change have to be rerun to get new build results without the first change included) | 14:05 |
| tkc17 | Sorry, let me elaborte. There are 2 different jobs submitted from 2 repos with no depends-on for gate pipeline, but still Zuul marked them as dependent. | 14:07 |
| fungi | tkc17: are you maybe saying that zuul is putting unrelated changes into the same queue and you're not sure why? if so, it probably means it's worth reviewing the section of the zuul docs on how it determines what changes share a queue to make sure none of those are the cause | 14:07 |
| * fungi finds that part of the docs | 14:07 | |
| tkc17 | Yes, we are using a "integrated" queue for all gating jobs. | 14:08 |
| fungi | the beginning of https://zuul-ci.org/docs/zuul/reference/project_def.html talks about that | 14:09 |
| fungi | if you tell all your projects to share a named queue called "integrated" then all their changes will be serialized in that queue in dependent pipelines | 14:09 |
| tkc17 | yes, but normally I see the changes are independent of each other (serial/parallel) and once jobs for a change are done the changes gets merged/rejected. | 14:11 |
| tkc17 | Even the above docs say that serialization checks dependencies, and also specifically it mentions "Zuul could simply assume that all projects are related, or even infer relationships by which projects a job indicates it uses, however, in a large system that would become unwieldy very quickly, and *unnecessarily delay changes to unrelated projects*" | 14:13 |
| tkc17 | that last section is the issue I am seeing. | 14:13 |
| fungi | yes, it sounds like you created that by putting all your projects in a single queue | 14:14 |
| tkc17 | okay, I need to group things properly with different queues? | 14:15 |
| tkc17 | (using different queue names) | 14:15 |
| fungi | to be able to mix and match those conditions, zuul would need to be able to merge different queues on the fly, and i'm not entirely clear how you would work out what order to put in-flight changes in when that happened. consider you have several changes approved for project-a and they're being tested in the project-a queue, separately you have several changes approved for project-b and they're being tested in | 14:16 |
| fungi | the project-b queue. now you aprove a new change for project-b which depends-on an already approved and queued change for project-a... how does zuul decide which queue to put it in? if the queues aren't shared then the current behavior is to not enqueue the project-b change into the project-b queue until the change it depends-on in project-a has merged | 14:16 |
| fungi | you've effectively told zuul to share a single queue for project-a and project-b, which means that when changes for either are approved, they're sequenced together with one another | 14:17 |
| fungi | and so can only be reported in sequence | 14:17 |
| tkc17 | okay, but changeB jobs which run faster wait on changeA jobs which take longer | 14:18 |
| tkc17 | as ChangeA was submitted first to the queue | 14:18 |
| fungi | (each change has to report or be separated from the queue sequence due to a failing build before the change after it can be reported) | 14:18 |
| tkc17 | even though changeA and changeB are in no way related, just that they share the same queue | 14:19 |
| fungi | tkc17: correct, because if you tell zuul to use a shared queue for both projects, it assumes that an error introduced in a change in one project could imply altered behavior for the builds for the other project | 14:19 |
| tkc17 | I understand, thanks. | 14:20 |
| fungi | say, a repository for an application and a repository for a tightly-coupled library, you might have a change adding a new method in the library and a related change in the application which uses that new method... so zuul wants to make sure that the change to the application still gets exercised based on the state of the change for the library if the library change was approved before the application change | 14:21 |
| fungi | those are cases where you would likely know ahead of time that you wanted an explicit depends-on, so maybe a better example is that there's a change for the library to remove an unused method, and a separate change in the application to start using that method. if those were tested and merged independently in parallel in separate queues you could effectively wedge both projects | 14:24 |
| tkc17 | Got it, but normally we mark that dependency explicitly eg: In Gerrit using Depends-on | 14:24 |
| tkc17 | yes, second case is a better example as there could be a clash and both developers aren't aware so no explicit depends-on. | 14:26 |
| tkc17 | But in my case it wasn't the case, so, need to divide the repos into some more groups. | 14:27 |
| clarkb | LLIU82: depending on how you set the env var for the proxy certain ansible tasks may not load it | 14:42 |
| clarkb | command vs shell in particular | 14:42 |
| fungi | tkc17: my rule of thumb for when to avoid vs when to apply shared queues is that if projects consume each other from release versions (or not at all) then they're safe to have their changes queued independently. if they consume each other continuously from source (e.g. a git branch) then they likely are better off in a shared queue | 14:43 |
| tkc17 | okay, inline with my understanding. Thanks. | 14:52 |
| *** rlandy|mtg is now known as rlandy | 15:09 | |
| zbr | corvus: clarkb: does https://review.opendev.org/#/c/740733/ look fine? cmd rendering inside pre, like the other interesting keys | 15:12 |
| zbr | sometimes cmd can be long and/or multiline, we should render it nicely | 15:12 |
| zbr | current implementation breaks it so multiline ones cannot be copied, and much harder to read | 15:13 |
| fungi | catching up on yesterday's accessibility discussions, i'm not blind so my case is likely trivial compared with someone who is. while i don't use mice specifically, i do have systems with pointer devices (trackballs, trackpoints, trackpads, drafting/drawing tablets, touchscreens...) and will use them when it's the more efficient solution, say for graphic arts tasks. and if i really want to use the keyboard as a | 15:26 |
| fungi | pointer i also have the keynav driver installed (it's awesome, check it out sometime). though for browser navigation of hyperlinks and form fields i have an extension that enumerates all the links with short letter/number codes when i hit the right key, and then i can type one or a few keys to follow the link i'm interested in, so i haven't really missed tab working. spacebar and pgup/pgdn/home/end/arrows are | 15:26 |
| fungi | more what i use for page scrolling | 15:26 |
| fungi | i will note that javascript onclick and hover events are something i wind up needing a pointer (like keynav's) to activate | 15:28 |
| *** mach1na has quit IRC | 15:28 | |
| *** mach1na has joined #zuul | 15:28 | |
| zbr | a11y is quite complex to test, to do a good job we would need someone (qa-ish) with experience in that field, something hard to find. | 15:29 |
| clarkb | fungi: ya https://review.opendev.org/#/c/742759/ seems to be the best compromise for now | 15:29 |
| clarkb | I think corvus was hoping felixedel might be able to weigh in today before we land that though | 15:30 |
| *** mach1na has quit IRC | 15:33 | |
| *** tkc17 has left #zuul | 15:34 | |
| corvus | felixedel: ^ are you around to review that? | 15:39 |
| corvus | zbr: i agree that there's a lot to good a11y testing. but the minimum that we can do to avoid making things harder for folks with impairments is to try to avoid breaking standard behaviors and conventions. this is why changing tab navigation configurations (that turned out to be fine) and forcing-focus (that turned out to be hard to navigate) are things that raised a red flag with me that we should | 15:42 |
| corvus | investigate further. | 15:42 |
| *** spotz has joined #zuul | 15:42 | |
| corvus | zbr: at least, if we're going to do something weird like that, that's probably something we should get confirmation isn't going to cause a11y problems, and i don't think we got that, so i'd prefer not to do it | 15:43 |
| spotz | Hey all, it was pointed out that https://zuul-ci.org/docs/zuul/tutorials/user.html is empty but I did confirm there are tutorial files in git. I'd put up a patch but not seeing how you'd call those pages | 15:43 |
| zbr | i did observe our lack of attention while doing my other changes, use of "title" seems to quire rare in our code. | 15:43 |
| zbr | and i know well that this is made mandatory for a11y reasons for most html elements | 15:44 |
| corvus | zbr: indeed, i think there's actually some low-hanging a11y problems we can fix on our own | 15:44 |
| zbr | I could easily rephrase https://review.opendev.org/#/c/740733 to say that it addresses a11y issues, and it would not false | 15:45 |
| corvus | spotz: i think that page was created by a user who was hoping for a field-of-dreams scenario which has not yet come to pass, though guillaumec has been working on some | 15:45 |
| corvus | spotz: i think the only existing tutorial is an 'admin' tutorial | 15:46 |
| corvus | spotz: guillaumec work starts at https://review.opendev.org/732066 | 15:46 |
| fungi | spotz: as for where to edit, https://opendev.org/zuul/zuul/src/branch/master/doc/source/tutorials/user.rst is the file it's built from | 15:46 |
| spotz | corvus the quick-start looks pretty decent but I haven't run through it | 15:47 |
| corvus | spotz: it's relatively admin-focused | 15:47 |
| clarkb | I'm looking at setting file modes to avoid future problems for zuul roles/playbooks if/when ansible does the file perms change again. At the same time I'm thinking setting owner and group is a good idea. The docs don't say but I assume the defaults for those are the current user and their primary group? | 15:47 |
| spotz | fungi so users.rst is like index.rst in like OpenStack docs? | 15:47 |
| fungi | spotz: no, it's just a documentation file | 15:47 |
| spotz | fungi: ok | 15:48 |
| fungi | https://opendev.org/zuul/zuul/src/branch/master/doc/source/tutorials is lacking a index.rst, so there winds up being no fancy index at https://opendev.org/zuul/zuul/src/branch/master/doc/source/tutorials/ (and apache's mod_autoindex is kicking in to fill in the void) | 15:49 |
| spotz | fungi corvus - If you want me to throw up something let me know, but I'll pass it back that it's WIP | 15:50 |
| corvus | spotz: i honestly don't know what to do there. maybe a quick pgraph that says "WIP" and points to https://zuul-ci.org/docs/zuul/tutorials/admin.html ? | 15:51 |
| corvus | since that's the only extant tutorial at the moment | 15:51 |
| spotz | corvus: Ok I'll throw up a patch you can change/reject/etc. I won't be offended with a -2 what were you thinking:) | 15:52 |
| corvus | spotz: thanks! | 15:52 |
| clarkb | corvus: the oldest ansible zuul supports is 2.6? | 15:53 |
| spotz | corvus: Ok I think I've realized the perception here, the user Tutorials page is blank but the navigation updates to what is available and if you don't notice that it seems blank | 15:54 |
| spotz | blank=broke | 15:54 |
| corvus | this page intentionally left broke | 15:55 |
| *** dustinc has quit IRC | 16:07 | |
| *** LLIU82 has quit IRC | 16:14 | |
| *** nils has quit IRC | 16:15 | |
| zbr | corvus: i got a similar intentional blank page on another project which i had to remove after one year, seeing the guy that was supposed to write the docs moved to another project. | 16:17 |
| zbr | what can be seen temporary today, may become more of a permanent thing, regardless if we like it or not | 16:17 |
| corvus | yep | 16:19 |
| corvus | so it'll be nice to put something there until we finish up reviewing guillaumec's changes | 16:20 |
| clarkb | zbr: is it an ansible-lint bug that it complains about missing mode on symlinks? | 16:22 |
| zbr | clarkb: lol, there are ~3-4 and one unreleased fix. E208 made my last two weeks, hard to forget | 16:22 |
| clarkb | zbr: ok so thats a known issue and I can ignore it for now? | 16:23 |
| zbr | i will release the last fix today, waiting for two more merges. | 16:23 |
| zbr | wait for me to ping you when release is done, these fixes removed some false positives on the rule | 16:23 |
| zbr | basically the lack of mode is a very real issue, but original rule was not very smart, had some false-positives | 16:24 |
| *** sshnaidm is now known as sshnaidm|afk | 16:24 | |
| zbr | take a look at https://github.com/ansible/ansible-lint/pulls?q=E208+ | 16:24 |
| clarkb | yes I know there are false positives it wants me to set a mode on a symlink :) | 16:25 |
| clarkb | and requiring mode on unarchive is really clunky | 16:25 |
| clarkb | I don't know how you can do that sanely | 16:25 |
| zbr | wait ~1hour, and you will get better results, also there is a new alternative to skip_list, a warn_list | 16:25 |
| zbr | which makes is return success, but still print the rules inside it | 16:26 |
| zbr | you could put a "noqa: E208" to silence it in that particular place. looking to fix in the future. | 16:27 |
| clarkb | ya I don't expect these changes to merge in the immediate future so will just assume that bug fixes will address it | 16:27 |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: WIP: Address ansible-lint E208 https://review.opendev.org/748480 | 16:29 |
| clarkb | thats sort of a halfway step | 16:29 |
| zbr | clarkb: i can help you to finish it | 16:32 |
| *** tosky has quit IRC | 16:45 | |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Partial address ansible-lint E208 https://review.opendev.org/748480 | 17:21 |
| *** mach1na has joined #zuul | 17:29 | |
| *** mach1na has quit IRC | 17:34 | |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: More E208 mode fixes https://review.opendev.org/748498 | 17:41 |
| clarkb | zbr: https://zuul.opendev.org/t/zuul/build/457c2d0ac3fb459ab4002e4c794865cd/log/job-output.txt#254 is a fun one. The ansible docs say mode: "preserve" is valid from ansible 2.6 and that job ran with 2.9 but failed | 17:50 |
| clarkb | I guess the docs are wrong | 17:50 |
| clarkb | corvus: I wonder if https://review.opendev.org/#/c/747661/ is somehow tripping https://zuul.opendev.org/t/zuul/build/31820ad35e8e4e59aed9eba43d3ee94b/log/job-output.txt#17436-17449 (iirc maplines is used to process the zuul_return info) | 17:54 |
| corvus | waiting for my browser to parse that | 17:55 |
| corvus | hrm | 17:55 |
| corvus | the anchor link did not scroll to the line | 17:55 |
| clarkb | if you grep 'Error mapping line:' that should take you to it too | 17:56 |
| corvus | i guess add that to the list of stuff messed up by pf4? | 17:56 |
| clarkb | corvus: I just opened in a new browser and confirm it doesn't jump to the line | 17:57 |
| corvus | thx, sounds like it | 17:57 |
| corvus | clarkb: do you think that caused the test failure in 741157, or do you think it's a non-fatal error unrelated to the failure? | 18:00 |
| corvus | clarkb: because if it actually caused the failure, it should have failed 747661 | 18:00 |
| corvus | but if it's non-fatal, then it certainly could be a new thing | 18:01 |
| corvus | clarkb: unless it did fail 741157 but only due to a race? | 18:01 |
| clarkb | corvus: well the final error is an ordering thing I think | 18:01 |
| clarkb | and I'm wondering if the earlier error is affecting that final ordering | 18:02 |
| corvus | where's the final error? it's unsurprisingly hard to navigate in a 20,000 line file only using the scrollback | 18:02 |
| corvus | scrollbar | 18:02 |
| clarkb | line 17594 | 18:02 |
| clarkb | it is an assert looking for a line 21 otherfile.txt comment (the thing that errored on my first link) but is getting a line 21 path/to/file.py comment instead | 18:03 |
| corvus | got it | 18:04 |
| clarkb | oh | 18:04 |
| clarkb | ok it sactually git failing because otherfile.txt has only one line in it | 18:04 |
| clarkb | and then maybe we don't load that in the final comments content as a result | 18:05 |
| clarkb | that has me thinking maybe the eralier change didn't break anything but exposed a problem in our test fixtures | 18:05 |
| corvus | fwiw this is much easier to deal with: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_318/741157/7/gate/tox-py35/31820ad/testr_results.html | 18:05 |
| clarkb | ya we're just doing a single line of 'test2' in otherfile.txt I think | 18:07 |
| clarkb | but that should've failed in the earlier change as you mentioned (that should be deterministic) | 18:07 |
| corvus | clarkb: i think the git error is a red herring | 18:07 |
| corvus | it's present in the old code | 18:08 |
| corvus | zuul captures it and includes it as a warning in the message reported back | 18:08 |
| clarkb | ya it looks curious because the filenames line up but I agree old code would've hit it | 18:08 |
| corvus | so i think we can ignore the git error for file having 1 line, and the real issue is the new code or test is non-deterministic | 18:08 |
| clarkb | the new code is much more reliant on ordering | 18:09 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Revert "Merge file comments from multiple tasks" https://review.opendev.org/748501 | 18:10 |
| corvus | clarkb: ^ | 18:10 |
| clarkb | I wonder if we sort by linenumber | 18:12 |
| clarkb | both of those have the same line number so sort is not stable? if that is the case we can fix the tests by making them stable or not having comments on the same line numbers across files in the tests | 18:13 |
| clarkb | ah yup the sort is by line | 18:13 |
| clarkb | ok I can actually fix this really quickly | 18:13 |
| clarkb | rather than revert | 18:13 |
| clarkb | trying to test a fix locally now | 18:24 |
| clarkb | I need more memory | 18:24 |
| fungi | i say that every time i forget where i left my car keys | 18:31 |
| corvus | clarkb: if you want to push it up i can run it through a few cycles | 18:32 |
| *** holser has quit IRC | 18:33 | |
| clarkb | src/re2.cpp:14806:13: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_traceback’; did you mean ‘curexc_traceback’? is what I'm hitting now s oya I'll just push it up | 18:34 |
| *** holser has joined #zuul | 18:34 | |
| *** tosky has joined #zuul | 18:35 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Sort comments in file_comments testing https://review.opendev.org/748508 | 18:35 |
| clarkb | corvus: ^ I think we may need another level of sorting in the path/to/file.py line 42 comments | 18:35 |
| clarkb | I'm not sure if those are stable on their own | 18:36 |
| clarkb | https://github.com/axiak/pyre2/issues/55 is the upstream re2 issue. I think py38 must've changed its internal structs for thread state on a minor update? | 18:37 |
| clarkb | we don't see it on ubuntu because its an older py38? | 18:37 |
| clarkb | (I'm on tumbleweed not OSX but I expect I get up to date python3.8) | 18:37 |
| corvus | AttributeError: 'dict' object has no attribute 'file' | 18:38 |
| corvus | clarkb: File "/home/corvus/git/zuul/zuul/tests/unit/test_gerrit.py", line 251, in test_file_comments | 18:38 |
| clarkb | hrm maybe we have comments in the list that don't have files associated with them? | 18:39 |
| clarkb | like top level comment? | 18:40 |
| fungi | i've got 3.8.5 here compiled from source if something needs confirming quickly | 18:40 |
| clarkb | fungi: try to pip install re2 | 18:41 |
| clarkb | thats the version I've got too | 18:41 |
| corvus | clarkb: here's the structure that's failing on: http://paste.openstack.org/show/797222/ | 18:41 |
| corvus | should be able to test that out in repl | 18:41 |
| clarkb | thanks | 18:41 |
| fungi | clarkb: mmm, i get compilation errors | 18:42 |
| fungi | src/re2.cpp:1502:101: warning: ‘int PyObject_AsCharBuffer(PyObject*, const char**, Py_ssize_t*)’ is deprecated [-Wdeprecated-declarations] | 18:42 |
| fungi | ahh, in the not warnings i have a bunch of "src/re2.cpp:14765:25: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_value’; did you mean ‘curexc_value’?" and so on | 18:44 |
| clarkb | fungi: ya I think python3.newerthanbionicandfocal changed the internal api | 18:44 |
| clarkb | and re2 breaks on it | 18:44 |
| clarkb | good to confirm it isn't just me | 18:44 |
| fungi | okay, so that's the same as what you're seeing then | 18:44 |
| fungi | and yeah, this is literally just checkout the 3.8.5 tag in git and configure;make | 18:44 |
| fungi | on a reasonably up to date debian/unstable system | 18:45 |
| *** LLIU82 has joined #zuul | 18:45 | |
| fungi | (i mean, i also turn on some build optimizations and whatnot, but it's still vanilla built toolchain) | 18:45 |
| clarkb | corvus: I can reproduce the issue using attrgetter but not using lambda x: x['file'] also all of them have a file attribute. I must not fully understand attrgetter | 18:46 |
| corvus | clarkb: i don't understand it which is why i didn't just fix it :) | 18:47 |
| corvus | i love me some lambda though | 18:47 |
| fungi | https://github.com/andreasvc/pyre2/issues/10 | 18:47 |
| clarkb | oh its because attrgetter is just class attributes derp | 18:47 |
| clarkb | so ya I'll update the lambda instead | 18:47 |
| fungi | huh, odd | 18:47 |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Sort comments in file_comments testing https://review.opendev.org/748508 | 18:48 |
| clarkb | fungi: https://github.com/axiak/pyre2/issues/55 too. which is the canonical repo? | 18:49 |
| fungi | or maybe https://github.com/facebook/pyre2/issues/20 ? | 18:59 |
| clarkb | aha | 19:03 |
| clarkb | I think the extra PyThreadState bits are generated by cython | 19:03 |
| clarkb | cpython never has them, cython mixes them in | 19:03 |
| clarkb | fungi: aha | 19:10 |
| clarkb | fb-re2 is what we actually dep on and that is the facebook repo you point to and install fb-re2 doesn't explode (probably why we use it) but then fails for me on finding the libre2.so.7 | 19:11 |
| clarkb | I have libre2 intsalled so now I get to figure out why my .so isn't good | 19:12 |
| clarkb | because i have libre2.so.8 | 19:14 |
| clarkb | how is it linking libre2.so.7 if that doesn't exist on my system | 19:14 |
| clarkb | maybe a wheel cache? | 19:14 |
| clarkb | wow that was it, sorry for all the noise. I guess I should periodically flush my wheel cache | 19:17 |
| clarkb | and with all that done I think I've just confirmed that latest patchset does pass (though not run enough iterations to know if there is still an ordering concern) | 19:21 |
| fungi | yeah, i clear ~/.cache/pip every time i recompile python | 19:21 |
| fungi | and rebuild all my venvs | 19:21 |
| clarkb | fungi: in this case it was libre2 updating not python | 19:22 |
| clarkb | which broke the linker paths | 19:22 |
| clarkb | I've not got that test running on a loop (its not super fast on my laptop) to see if we trip over any additional ordering issues | 19:24 |
| *** vishalmanchanda has quit IRC | 19:25 | |
| clarkb | 4 successful runs so far | 19:33 |
| clarkb | looking good | 19:34 |
| clarkb | it did 7 without error before I stopped it due to eating my cpu | 19:44 |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: More E208 mode fixes https://review.opendev.org/748498 | 19:47 |
| *** LLIU82 has quit IRC | 20:16 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Sort comments in file_comments testing https://review.opendev.org/748508 | 20:35 |
| *** hashar has quit IRC | 21:23 | |
| *** saneax has quit IRC | 21:32 | |
| *** Goneri has quit IRC | 21:39 | |
| corvus | clarkb: i'm going to single-core approve your test fix, abandon my revert, then approve ianw's scroll fix | 21:41 |
| clarkb | k | 21:41 |
| *** holser has quit IRC | 22:33 | |
| openstackgerrit | Merged zuul/zuul master: Sort comments in file_comments testing https://review.opendev.org/748508 | 22:42 |
| *** holser has joined #zuul | 22:56 | |
| *** saneax has joined #zuul | 23:02 | |
| *** sanjayu_ has joined #zuul | 23:10 | |
| *** saneax has quit IRC | 23:13 | |
| *** frenzyfriday has joined #zuul | 23:24 | |
| *** frenzyfriday has quit IRC | 23:28 | |
| clarkb | looks like the css thing failed on a zuul-tox-remote fialure | 23:30 |
| clarkb | I've reapproved it | 23:30 |
| clarkb | there was another change that hit the file comments issue that I have reapproed as well. will see if those continue to fail on zuul-tox-remote | 23:32 |
| *** sanjayu_ has quit IRC | 23:54 | |
| *** tosky has quit IRC | 23:59 | |
| openstackgerrit | Amy Marrich (spotz) proposed zuul/zuul master: Add content to User Tutorials page https://review.opendev.org/748555 | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!