| *** rfolco has quit IRC | 00:19 | |
| *** sanjayu_ has quit IRC | 00:25 | |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: Ansible command module: allow to use stdin param https://review.opendev.org/744814 | 00:25 |
|---|---|---|
| *** armstrongs has joined #zuul | 00:46 | |
| *** armstrongs has quit IRC | 00:54 | |
| *** Goneri has quit IRC | 01:01 | |
| *** bhavikdbavishi has joined #zuul | 03:05 | |
| *** bhavikdbavishi has quit IRC | 03:32 | |
| *** bhavikdbavishi has joined #zuul | 03:46 | |
| *** bhavikdbavishi1 has joined #zuul | 03:51 | |
| *** bhavikdbavishi has quit IRC | 03:53 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:53 | |
| *** bhavikdbavishi has quit IRC | 04:25 | |
| *** bhavikdbavishi has joined #zuul | 04:26 | |
| *** dmellado has quit IRC | 04:31 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** sanjayu_ has joined #zuul | 05:28 | |
| *** raukadah is now known as chandankumar | 05:44 | |
| *** bhavikdbavishi1 has joined #zuul | 06:08 | |
| *** bhavikdbavishi has quit IRC | 06:09 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:09 | |
| *** bhavikdbavishi has quit IRC | 06:28 | |
| *** vishalmanchanda has joined #zuul | 06:49 | |
| *** mach1na has joined #zuul | 06:56 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Annotate logger with event ID when locking node set https://review.opendev.org/748122 | 07:00 |
| *** bhavikdbavishi has joined #zuul | 07:07 | |
| *** tosky has joined #zuul | 07:40 | |
| *** holser has quit IRC | 07:49 | |
| *** nils has joined #zuul | 08:06 | |
| *** bhavikdbavishi has quit IRC | 08:07 | |
| *** bhavikdbavishi has joined #zuul | 08:08 | |
| *** mgoddard has quit IRC | 08:10 | |
| *** mgoddard has joined #zuul | 08:11 | |
| bolg | zuul-maint: small change to enhance loging: https://review.opendev.org/c/748122/ | 08:20 |
| *** holser has joined #zuul | 08:24 | |
| *** hashar has joined #zuul | 08:31 | |
| *** tosky has quit IRC | 08:32 | |
| *** tosky has joined #zuul | 08:33 | |
| *** tdasilva has quit IRC | 08:33 | |
| *** evgenyl has quit IRC | 08:33 | |
| *** evgenyl has joined #zuul | 08:34 | |
| *** tdasilva has joined #zuul | 08:35 | |
| *** mach1na has quit IRC | 09:06 | |
| *** mach1na has joined #zuul | 09:17 | |
| *** mach1na has quit IRC | 09:29 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Annotate logger with event ID when (un)locking node set https://review.opendev.org/748122 | 09:35 |
| *** bhavikdbavishi has quit IRC | 10:04 | |
| *** mach1na has joined #zuul | 10:06 | |
| *** mach1na has quit IRC | 10:50 | |
| *** mach1na has joined #zuul | 10:50 | |
| *** mach1na has quit IRC | 11:00 | |
| *** bhavikdbavishi has joined #zuul | 11:23 | |
| *** bhavikdbavishi1 has joined #zuul | 11:26 | |
| *** bhavikdbavishi has quit IRC | 11:27 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 11:27 | |
| *** mach1na has joined #zuul | 11:32 | |
| *** rlandy has joined #zuul | 11:36 | |
| *** sshnaidm|afk is now known as sshnaidm|mtg | 11:56 | |
| openstackgerrit | Benjamin Schanzel proposed zuul/zuul master: GitHub Reporter: Fix User Email in Merge Commit Message https://review.opendev.org/741157 | 11:57 |
| *** rlandy is now known as rlandy|mtg | 12:03 | |
| *** _erlon_ has joined #zuul | 12:22 | |
| *** AshBullock has joined #zuul | 12:42 | |
| *** mach1na has quit IRC | 12:50 | |
| *** mach1na has joined #zuul | 12:50 | |
| *** mach1na has quit IRC | 13:01 | |
| *** bhagyashris is now known as bhagyashris|away | 13:06 | |
| *** bhavikdbavishi has quit IRC | 13:29 | |
| *** bhavikdbavishi has joined #zuul | 13:30 | |
| *** rfolco has joined #zuul | 13:34 | |
| *** bhavikdbavishi has quit IRC | 13:34 | |
| *** mach1na has joined #zuul | 13:36 | |
| *** Goneri has joined #zuul | 13:47 | |
| *** sshnaidm|mtg is now known as sshnaidm | 13:52 | |
| zbr | cosmetic fix on bindep role: https://review.opendev.org/#/c/747781/ | 14:24 |
| zbr | zuul-maint: changes waiting for W: https://review.opendev.org/#/c/747781/ https://review.opendev.org/#/c/746508/ https://review.opendev.org/#/c/733419/ | 14:33 |
| *** ikhan has joined #zuul | 14:35 | |
| *** dustinc has joined #zuul | 14:37 | |
| *** rlandy|mtg is now known as rlandy | 14:50 | |
| clarkb | zbr: is it a warning to use failed_when: false without changed_when: false? | 15:08 |
| zbr | afaik, failed_when does not produce warnings, but lack of changed_when on modules that cannot implement idempotency testing themselves it is | 15:09 |
| zbr | like cmd/shell/.... -- ansible needs a hint about the outcome | 15:09 |
| zbr | it also produce better output (green vs orange), but that is less important than the state change report | 15:10 |
| openstackgerrit | Merged zuul/zuul-jobs master: Multi Node/Context support for mirroring Git workspaces via kubectl https://review.opendev.org/746508 | 15:24 |
| openstackgerrit | Merged zuul/zuul-jobs master: Add python_version for tox27 https://review.opendev.org/733419 | 15:27 |
| openstackgerrit | Merged zuul/zuul-jobs master: Update upload-logs-s3 with access/secret key variable documentation https://review.opendev.org/742710 | 15:27 |
| clarkb | bolg: can you check my comments on that logging change? | 15:33 |
| *** bhavikdbavishi has joined #zuul | 15:41 | |
| *** ikhan has quit IRC | 15:54 | |
| bolg | clarkb: replied, new patch coming in couple mins | 16:04 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Annotate logger with event ID when (un)locking node set https://review.opendev.org/748122 | 16:07 |
| *** kmalloc has joined #zuul | 16:10 | |
| *** rlandy is now known as rlandy|mtg | 16:17 | |
| *** tflink has quit IRC | 16:19 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Add pause/unpause support to scheduler https://review.opendev.org/588610 | 16:19 |
| *** tflink has joined #zuul | 16:19 | |
| corvus | bolg: ^ can you take a look at that? it's a 2 year old change that attempts to accomplish the same as https://review.opendev.org/709735 but is much smaller | 16:20 |
| corvus | maybe we missed something the first time around, but i'd love to keep this simple if we can | 16:23 |
| *** bhavikdbavishi has quit IRC | 16:26 | |
| bolg | corvus: I replied to ur comments I will check the other change tomorrow | 16:27 |
| *** rlandy|mtg is now known as rlandy | 16:51 | |
| *** nils has quit IRC | 16:53 | |
| *** CraigR has joined #zuul | 17:03 | |
| *** mach1na has quit IRC | 17:05 | |
| *** CraigR has quit IRC | 17:26 | |
| *** mach1na has joined #zuul | 17:26 | |
| *** mach1na has quit IRC | 17:38 | |
| zbr | clarkb: corvus: may I dare to reopen the ANSI subject? https://review.opendev.org/#/c/739444/ | 17:59 |
| zbr | the previous PR did had some comments but used another library, that one seems better. | 18:00 |
| *** hashar has quit IRC | 18:07 | |
| *** sshnaidm is now known as sshnaidm|afk | 18:11 | |
| *** olaph has quit IRC | 18:56 | |
| *** hamalq has joined #zuul | 19:02 | |
| *** sanjayu_ has quit IRC | 19:22 | |
| masterpe | What does it mean if someone says Workflow-1 as comment? | 19:32 |
| clarkb | masterpe: "Work in Progress" should be the flavor text | 19:37 |
| clarkb | masterpe: usually its a way to ensure something doesn't merge too early | 19:37 |
| masterpe | ah | 19:37 |
| *** tosky has quit IRC | 19:38 | |
| *** frenzyfriday has joined #zuul | 19:53 | |
| *** frenzyfriday has quit IRC | 19:58 | |
| clarkb | corvus: felixedel: ianw: it would be good to make progress on the pageup/down/spacebar/arrow keys navigation issues with zuul web | 20:08 |
| clarkb | I'm definitely not the person to decide on the best options there, but more and more users are noticing and complaining | 20:08 |
| corvus | it's driving me nuts | 20:09 |
| corvus | last i saw, felix/ian were batting around options; is there a recommendation? | 20:09 |
| corvus | clarkb: can you see my -1 on https://review.opendev.org/748122 ? | 20:11 |
| corvus | that's really a -1.9 from me | 20:12 |
| clarkb | corvus: yes | 20:12 |
| corvus | just wanted to get the msg out since i'm seeing that in several changes | 20:12 |
| clarkb | re recommendation on the navigation buttons there was a followon change that does more things but I'm not sure if those are an either or or if the followon addresses concerns on the parent | 20:12 |
| clarkb | corvus: re underscores it seems to be an assumption that maybe is based in not very pythonic practices | 20:14 |
| clarkb | and I agree i'd prefer single _ in most places | 20:14 |
| corvus | yeah. we make *heavy* use of overriding protected methods in subclasses (especially in, but not limited to tests), so it's a significant direction change that i'm not on board with | 20:15 |
| corvus | there's one place we intentionally use it in gear i believe | 20:15 |
| corvus | (because we really don't want subclasses mucking with it; i don't remember the circumstance) | 20:16 |
| corvus | but there are no hostile subclasses in zuul :) | 20:16 |
| clarkb | in the js navigation thing I'm mostly clueless and trying to point out its becoming more and more problematic for users. I'm happy to help if given direction | 20:17 |
| corvus | clarkb: it looks like https://review.opendev.org/743239 is the state of the art | 20:18 |
| corvus | clarkb: and https://review.opendev.org/742759 is the alternate | 20:19 |
| clarkb | corvus: fwiw I use spacebar scrolling way more than I do tabbing | 20:21 |
| corvus | clarkb: i'm worried about a11y | 20:22 |
| clarkb | hrm ya and folks like fungi that lack mice | 20:22 |
| corvus | typically a screen reader will read the links as someone tabs through, so i'm worried about starting the cursor *after* main navigation | 20:22 |
| corvus | i was hoping someone would look into that to determine whether it's a problem | 20:22 |
| corvus | but it doesn't look like anyone has done that research | 20:23 |
| clarkb | zbr says that pf4 is fixing the issue too, does anyone know if there is a bug tracking that? | 20:28 |
| corvus | i'm trying to get orca to work, but it's not playing well with xfce | 20:37 |
| *** vishalmanchanda has quit IRC | 20:37 | |
| clarkb | corvus: does https://review.opendev.org/#/c/743917/2 chagne anything for the tab use case? | 20:37 |
| clarkb | looks like for the nav bar you'd have to tab in reverse but it would be accessible? | 20:37 |
| corvus | clarkb: as a blind user, how do you know you need to tab backwards? | 20:37 |
| clarkb | I don't know | 20:37 |
| corvus | me neither, that's why i think we need to look into this | 20:38 |
| corvus | best way i know how is for someone to fire up a screen reader and see what happens | 20:38 |
| corvus | i was hoping someone would have done that by now, but since they haven't, and this is becoming an issue, i'll try to look into it myself | 20:39 |
| corvus | but i don't run a regular gnome or windows desktop, so i'm unsure how to get orca going | 20:39 |
| corvus | but what i do know is i really don't want to knowingly merge something that makes this harder for visually impaired people | 20:39 |
| clarkb | corvus: do you understand why https://review.opendev.org/#/c/743239/2 and https://review.opendev.org/#/c/743917/2 are split? I'm not sure I grok the distinction between the two (behavior wise) | 20:45 |
| corvus | clarkb: not really | 20:45 |
| *** frenzyfriday has joined #zuul | 20:47 | |
| *** frenzyfriday has quit IRC | 20:55 | |
| corvus | clarkb: okay, i have orca working on my *xenial* machine, so it's a bit old | 21:02 |
| corvus | the first thing i note is that this whole drawer thing really messes stuff up for screen readers too. in the same way that it's screwing up keyboard navigation because it sort of takes over the page, the screen reader is seeing the same thing, and so it starts reading the error messages when you first open the page | 21:03 |
| corvus | (i'm looking at the current prod site, not the preview with the proposed changes) | 21:03 |
| corvus | so iow, the drawer thing is already making things pretty bad for the screen reading case | 21:04 |
| clarkb | the drawer is just for the error listings right? I wonder if we can drop it entirely (and have a separate page for those or something) | 21:04 |
| corvus | yeah, keep the icon, and just have it load in a new page? may solve a lot of problems | 21:08 |
| corvus | anyway, still putzing with orca | 21:08 |
| corvus | trying to get a baseline for how it works now | 21:08 |
| openstackgerrit | Merged zuul/zuul master: Merge file comments from multiple tasks https://review.opendev.org/747661 | 21:15 |
| corvus | clarkb: okay, tab navigation is a pretty good approximation for what it's like using a screen reader. mostly because the way our nav is set up in pf4, there's no real alternative. | 21:35 |
| corvus | not sure if anyone has noticed, but if there are config errors, and you hit tab, the drawer opens. and the close x button doesn't seem to work | 21:35 |
| corvus | tbh, i'm not sure pf4 is ready for prime-time | 21:35 |
| corvus | anyway, as expected, 743917 starts the cursor after all the top navigation stuff, which makes the navigation menu a bit less discoverable | 21:36 |
| clarkb | you'd have to rotate completely around | 21:39 |
| clarkb | a screen reader would eventually get there but dependingon the page may take a while so less than ideal? | 21:39 |
| corvus | yeah, or guess that shift-tab would get you something interesting | 21:39 |
| corvus | clarkb: i think we can land 743239 with no adverse affect for anyone, and enable keyboard scrolling after selection, which is half the fix | 21:40 |
| corvus | clarkb: it's 743917, the second half, which jumps to the main content on page load which makes the navigation weird; maybe we can hold that one | 21:40 |
| clarkb | gotcha so from a screen reader perspective the first one isn't a regression | 21:41 |
| corvus | correct | 21:41 |
| clarkb | its just that as a user you have to click to focus | 21:41 |
| corvus | okay, i approved the first change and -1d the second | 21:46 |
| clarkb | as far as removing the drawer goes and replacing it with a proper page I think froma useability standpoint that would be fine. It won't be as "shiny" modern web dev as it can be but the info would still be accessible | 21:53 |
| clarkb | corvus: ianw should we abandon https://review.opendev.org/#/c/742759/ given the earlier testing? | 22:05 |
| corvus | clarkb: hrm, after playing with it a bit, maybe that is a better option? | 22:07 |
| clarkb | oh, interest | 22:07 |
| clarkb | *interesting | 22:07 |
| clarkb | I'm happy with anything that makes it better :) | 22:08 |
| *** AshBullock has quit IRC | 22:08 | |
| corvus | basically the only downside there is the navbar doesn't scroll | 22:12 |
| corvus | or rather, it does scroll | 22:12 |
| corvus | tbh, i'd consider that a feature :) | 22:13 |
| corvus | but even if we call that a regression, i think it's a smaller regression than breaking tab navigation | 22:13 |
| corvus | so all things considered, maybe we should go with that | 22:13 |
| clarkb | I tend to dislike the scrolling navbars because they often don't page properly (cover text if you hit spacebar) | 22:14 |
| clarkb | but I agree even if that happened being able to use the psace bar would be an improvment | 22:14 |
| corvus | sorry i think i'm being unclear | 22:14 |
| corvus | the status quo, and felix's change cause navbars to always be visible, and i think that causes the behavior you just described not liking | 22:15 |
| corvus | ianw's change alters it so that the navbar is just part of the page and goes out of view when you scroll down | 22:15 |
| clarkb | ah yup ++ | 22:16 |
| ianw | corvus: ahh sorry yes i think that was superseded by similar but different change ... (searching) | 22:16 |
| ianw | https://review.opendev.org/#/c/743917/ | 22:17 |
| corvus | so for folks like us, it's a double improvement :) but i also recognize that isn't the intent of the patternfly framework and am willing to go along with a fixed navbar all things being equal | 22:17 |
| corvus | ianw: yeah, clarkb and i have been working through this, and i'm coming to the conclusion that we should go with your change and not felixedel's at the moment | 22:17 |
| corvus | i think the regression in tab navigation introduced by felixedel's change is too great | 22:18 |
| ianw | oh right, sorry, scrolling back :) | 22:18 |
| corvus | i think the navbar "regression" in your change is minor by comparison (and it doesn't hurt that clarkb and i actually *prefer* that :) | 22:19 |
| ianw | yes tbh i think the floating nav bar is a bit of a space waste | 22:19 |
| clarkb | to be clear corvus is doing most of the work here, I'm just making sure I keep up :) | 22:20 |
| ianw | we discussed that a bit and felixedel and i both noted that other sites that have a big navbar on load tend to use magic to shrink it down to a thin line with key components as you scroll down | 22:20 |
| corvus | ianw: yeah, that's a good middle ground | 22:21 |
| ianw | (I do not know how to do that, but sites like github.com show it is possible :) | 22:22 |
| corvus | i removed my +W from felixedel's first change, and left a +2 on ianw's | 22:23 |
| corvus | i'll try to catch up with felixedel tomorrow morning | 22:23 |
| corvus | maybe he'll have managed to read through all the scrollback by the time i wake up :) | 22:24 |
| ianw | note that i came up with that just by fiddling around in the inspector till it did what i wanted ... not sure if that is dumb luck, or modern web engineering | 22:24 |
| ianw | the line between often seems thin ... | 22:24 |
| corvus | ianw: u r web exprt | 22:24 |
| clarkb | any objects if I approve ianw's change or should we wait for felixedel to weigh in? | 22:25 |
| clarkb | I'm not sure I understand why the css change would break pf4's eventual fix | 22:26 |
| clarkb | (maybe more that it won't have the desired outcome with the navbar following scroll?) | 22:26 |
| ianw | ... that i couldn't say; i know there was an issue filed | 22:27 |
| corvus | clarkb: if it's not urgent, maybe wait for tomorrow? | 22:27 |
| ianw | https://github.com/patternfly/patternfly-react/issues/4624 | 22:27 |
| clarkb | corvus: I can wait | 22:27 |
| corvus | i mean, it's trivial to back out, so not a big deal if we do feel we should merge it soon | 22:27 |
| ianw | apropos cryptography wheels -- do we have any examples of event matching on tag pushes from github? | 22:27 |
| ianw | is it just going to look like our gerrit matches for release pipeline? | 22:28 |
| corvus | i think so | 22:31 |
| corvus | i think it should look like that | 22:31 |
| corvus | i don't think we have examples | 22:31 |
| corvus | ianw: but maybe check the ansible zuul? | 22:31 |
| corvus | lemme see if i can dig that up | 22:31 |
| corvus | ianw: | 22:32 |
| corvus | ianw: https://github.com/ansible/project-config/blob/master/zuul.d/pipelines.yaml#L132 | 22:32 |
| ianw | corvus: perfect, thanks! | 22:33 |
| ianw | next question -- i should be able to enqueue a ref to this for the current release right? | 22:33 |
| ianw | for some context, https://github.com/pyca/cryptography/pull/5386 is putting out good wheels now | 22:34 |
| corvus | ianw: yep | 22:34 |
| ianw | their current process, if i've understood, is to tag and release their sdist, then manually trigger github actions that download and build wheels and publish to github artifacts, which are manually uploaded | 22:35 |
| * clarkb wishes the wheels would be uploaded first | 22:35 | |
| ianw | i've made that change make an sdist from the checkout and build that; rather than download externally | 22:35 |
| ianw | tbh i'm secretly hoping they see the zuul workflow is much better and can do it all automatically, but one thing at a time :) | 22:36 |
| ianw | no reason we can't do x86 too | 22:36 |
| ianw | however they do have a bunch of osx and windows stuff which complicates things :/ | 22:36 |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-pip: Clarify situation with ensure_pip_from_packages_with_python2 https://review.opendev.org/742571 | 23:14 |
| *** Goneri has quit IRC | 23:17 | |
| *** hamalq has quit IRC | 23:35 | |
| *** armstrongs has joined #zuul | 23:43 | |
| *** armstrongs has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!