| *** harrymichal has quit IRC | 00:09 | |
| *** jamesmcarthur has quit IRC | 00:11 | |
| *** jamesmcarthur has joined #zuul | 00:22 | |
| *** saneax has quit IRC | 00:42 | |
| *** rlandy|ruck has quit IRC | 00:46 | |
| *** jamesmcarthur has quit IRC | 01:03 | |
| *** jamesmcarthur has joined #zuul | 01:05 | |
| *** jamesmcarthur has quit IRC | 01:30 | |
| *** Goneri has quit IRC | 01:43 | |
| *** jamesmcarthur has joined #zuul | 01:51 | |
| *** sgw1 has quit IRC | 02:23 | |
| openstackgerrit | Paul Belanger proposed zuul/zuul master: Round width of change progress bar to 2 decimals https://review.opendev.org/741073 | 02:38 |
|---|---|---|
| *** jamesmcarthur has quit IRC | 02:43 | |
| *** jamesmcarthur has joined #zuul | 02:43 | |
| *** jamesmcarthur has quit IRC | 02:47 | |
| *** sgw1 has joined #zuul | 02:54 | |
| *** bhavikdbavishi has joined #zuul | 03:04 | |
| *** bhavikdbavishi1 has joined #zuul | 03:11 | |
| *** bhavikdbavishi has quit IRC | 03:12 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:12 | |
| *** rfolco has quit IRC | 03:14 | |
| *** harrymichal has joined #zuul | 03:16 | |
| *** jamesmcarthur has joined #zuul | 03:43 | |
| *** jamesmcarthur has quit IRC | 03:45 | |
| *** jamesmcarthur_ has joined #zuul | 03:45 | |
| *** rfolco has joined #zuul | 03:52 | |
| *** rfolco has quit IRC | 03:56 | |
| *** sgw1 has quit IRC | 04:04 | |
| *** sgw1 has joined #zuul | 04:06 | |
| *** bhavikdbavishi has quit IRC | 04:30 | |
| *** harrymichal has quit IRC | 04:30 | |
| *** bhavikdbavishi has joined #zuul | 04:31 | |
| *** harrymichal has joined #zuul | 04:31 | |
| *** ysandeep|away is now known as ysandeep|rover | 04:32 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** sgw1 has quit IRC | 04:48 | |
| *** vishalmanchanda has joined #zuul | 04:50 | |
| *** sgw1 has joined #zuul | 04:52 | |
| *** marios has joined #zuul | 05:31 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: Add a more conversational overview to README.rst https://review.opendev.org/683085 | 05:48 |
| *** saneax has joined #zuul | 05:50 | |
| *** jamesmcarthur_ has quit IRC | 05:57 | |
| *** bhavikdbavishi has quit IRC | 05:59 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: Add a more conversational overview of Zuul concepts https://review.opendev.org/683085 | 06:01 |
| *** bhavikdbavishi has joined #zuul | 06:16 | |
| *** bhavikdbavishi1 has joined #zuul | 06:21 | |
| *** bhavikdbavishi has quit IRC | 06:23 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:23 | |
| *** zbr|ruck has quit IRC | 07:02 | |
| *** zbr|ruck has joined #zuul | 07:03 | |
| *** holser has joined #zuul | 07:04 | |
| *** jcapitao has joined #zuul | 07:04 | |
| *** zbr has quit IRC | 07:06 | |
| *** bhavikdbavishi has quit IRC | 07:11 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: PF4: Update buildset result page (new layout and styling) https://review.opendev.org/738011 | 07:20 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Consolidate summary, logs and console on a single build page https://review.opendev.org/740629 | 07:20 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: PF4: Update build result page layout https://review.opendev.org/739972 | 07:20 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Fix fetching function on build result page https://review.opendev.org/741103 | 07:20 |
| felixedel | corvus: I've updated my PF4 changes. I think you will like the new version ;-) | 07:20 |
| *** bhavikdbavishi has joined #zuul | 07:39 | |
| *** zbr has joined #zuul | 07:41 | |
| *** tosky has joined #zuul | 07:46 | |
| *** ysandeep|rover has left #zuul | 08:08 | |
| *** nils has joined #zuul | 08:08 | |
| *** dmsimard has quit IRC | 08:25 | |
| *** dmsimard has joined #zuul | 08:26 | |
| *** harrymichal has quit IRC | 08:40 | |
| *** bhavikdbavishi has quit IRC | 08:42 | |
| *** bhagyashris is now known as bhagyashris|lunc | 08:43 | |
| *** harrymichal has joined #zuul | 09:03 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 09:32 |
| openstackgerrit | Benoît Bayszczak proposed zuul/nodepool master: [provider][aws] now performs a multi-describe at once https://review.opendev.org/740328 | 09:38 |
| avass | mnaser: vexxhost seem to be throwing node failures: https://review.opendev.org/#/c/726830/ | 09:47 |
| *** bhavikdbavishi has joined #zuul | 10:01 | |
| *** bhavikdbavishi1 has joined #zuul | 10:06 | |
| *** bhavikdbavishi has quit IRC | 10:08 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 10:08 | |
| *** sshnaidm is now known as sshnaidm|afk | 10:24 | |
| *** bhagyashris|lunc is now known as bhagyashris | 10:37 | |
| *** harrymichal has quit IRC | 10:55 | |
| *** harrymichal has joined #zuul | 10:56 | |
| *** tosky has quit IRC | 11:05 | |
| *** bhavikdbavishi has quit IRC | 11:07 | |
| *** jcapitao is now known as jcapitao_lunch | 11:09 | |
| *** tosky has joined #zuul | 11:10 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 11:11 |
| openstackgerrit | Benjamin Schanzel proposed zuul/zuul master: GitHub Reporter: Fix User Email in Merge Commit Message https://review.opendev.org/741157 | 11:13 |
| *** saneax has quit IRC | 11:13 | |
| *** saneax has joined #zuul | 11:14 | |
| *** wuchunyang has joined #zuul | 11:22 | |
| *** bhavikdbavishi has joined #zuul | 11:24 | |
| *** wuchunyang has quit IRC | 11:44 | |
| *** bhavikdbavishi has quit IRC | 11:56 | |
| *** rfolco has joined #zuul | 11:56 | |
| *** rlandy has joined #zuul | 11:57 | |
| *** rlandy is now known as rlandy|ruck | 11:58 | |
| *** saneax has quit IRC | 12:00 | |
| *** saneax has joined #zuul | 12:01 | |
| *** bhavikdbavishi has joined #zuul | 12:10 | |
| *** marios has quit IRC | 12:14 | |
| *** jcapitao_lunch is now known as jcapitao | 12:27 | |
| openstackgerrit | Merged zuul/zuul-registry master: Prioritize returning manifest lists https://review.opendev.org/741062 | 12:27 |
| mnaser | avass: thanks for the warning. | 12:29 |
| mnaser | Well check | 12:29 |
| openstackgerrit | Simon Westphahl proposed zuul/nodepool master: Remove default qcow2 format in diskimage config https://review.opendev.org/741166 | 12:30 |
| openstackgerrit | Simon Westphahl proposed zuul/nodepool master: Remove default qcow2 format in diskimage config https://review.opendev.org/741166 | 12:31 |
| bschanzel | bschanzel | 12:32 |
| *** newbie2020 has joined #zuul | 12:45 | |
| newbie2020 | Hi,I am using Zuul with GitHub.As suggested by the documentation and by you in the past,exclude-unprotected-branches is set to true to exclude"feature branches" used for the typical GitHub PR scenario.That works very well.However the Zuul jobs get triggered for any "target" branchregardless of the GitHub protection settings.Is that expected?E.g. 1. | 12:49 |
| newbie2020 | I have a branch 'stable-branch' (not protected in the GitHub settings)2. I create a PR from a branch 'pr-branch' against 'stable-branch'3. The Zuul jobs for that project are triggeredThank you for any help or clarification you may provide | 12:49 |
| newbie2020 | sorry for the indentation | 12:49 |
| newbie2020 | Hi,I am using Zuul with GitHub.As suggested by the documentation and by you in the past,exclude-unprotected-branches is set to true to exclude"feature branches" used for the typical GitHub PR scenario. | 12:49 |
| newbie2020 | That works very well.However the Zuul jobs get triggered for any "target" branchregardless of the GitHub protection settings. | 12:50 |
| newbie2020 | Is that expected? | 12:50 |
| newbie2020 | E.g. 1. I have a branch 'stable-branch' (not protected in the GitHub settings) | 12:50 |
| newbie2020 | 2. I create a PR from a branch 'pr-branch' against 'stable-branch' | 12:50 |
| newbie2020 | 3. The Zuul jobs for that project are triggered | 12:50 |
| newbie2020 | Thank you for any help or clarification you may provide | 12:50 |
| *** sshnaidm|afk is now known as sshnaidm | 12:53 | |
| tobiash | newbie2020: exclude-unprotected-branches only excludes loading config from there, if you attach jobs from a config project you might still be able to run jobs on arbitrary branches | 12:54 |
| *** marios has joined #zuul | 12:56 | |
| newbie2020 | thanks! That matches the observed behaviour | 12:57 |
| *** saneax has quit IRC | 12:59 | |
| *** wuchunyang has joined #zuul | 13:02 | |
| *** bhavikdbavishi has quit IRC | 13:03 | |
| *** wuchunyang has quit IRC | 13:06 | |
| guilhermesp | avass: we have found the issue with NODE_FAILURE issues. I will let you know when we have a fix asap | 13:09 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Fix executor stats with zoned executors https://review.opendev.org/740448 | 13:15 |
| *** rlandy|ruck is now known as rlandy|ruck|mtg | 13:17 | |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Remove shebang for base/library/command.py|zuul_console.py https://review.opendev.org/728955 | 13:17 |
| guilhermesp | avass: just rechecked https://review.opendev.org/#/c/726830/26 | 13:22 |
| *** bhavikdbavishi has joined #zuul | 13:24 | |
| *** piotrowskim has joined #zuul | 13:28 | |
| *** wuchunyang has joined #zuul | 13:41 | |
| *** bhavikdbavishi has quit IRC | 13:54 | |
| *** bhavikdbavishi has joined #zuul | 13:54 | |
| *** bhavikdbavishi has quit IRC | 14:06 | |
| *** Goneri has joined #zuul | 14:11 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Join command thread on exit https://review.opendev.org/739838 | 15:17 |
| *** rlandy|ruck|mtg is now known as rlandy|ruck | 15:26 | |
| *** hamalq has joined #zuul | 15:31 | |
| *** hamalq_ has joined #zuul | 15:34 | |
| corvus | clarkb: ^ i'm going to infer a +2 from you on 739838 (join command thread) and +3 it now | 15:36 |
| *** hamalq has quit IRC | 15:38 | |
| openstackgerrit | Gonéri Le Bouder proposed zuul/zuul master: zuul_stream: avoid exception in _log_streamline https://review.opendev.org/741257 | 15:44 |
| clarkb | corvus: I've +2'd it now too | 15:48 |
| AJaeger | corvus: ianw updated the upload-afs description, want to review that one? https://review.opendev.org/#/c/741051/ | 15:53 |
| *** jcapitao has quit IRC | 15:54 | |
| corvus | AJaeger: done thx | 15:54 |
| *** newbie2020 has quit IRC | 15:54 | |
| avass | guilhermesp: thanks! | 16:00 |
| *** marios is now known as marios|out | 16:00 | |
| *** marios|out has quit IRC | 16:03 | |
| openstackgerrit | Merged zuul/zuul-jobs master: upload-afs-synchronize: expand documentation https://review.opendev.org/741051 | 16:07 |
| *** bhavikdbavishi has joined #zuul | 16:16 | |
| mordred | corvus: unrelated to anything (other than I just noticed the patches and keep forgetting to mention them) ... | 16:16 |
| mordred | corvus: a while ago I wrote https://review.opendev.org/#/c/729066/ and https://review.opendev.org/#/c/729428/ | 16:16 |
| mordred | you may or may not enjoy them | 16:16 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 16:18 |
| corvus | mordred: cool | 16:19 |
| corvus | mordred: re 726477 podmad build -- do you have any idea if that would work in k8s? (ie, the binfmt thing seems maybe problematic, but i haven't looked into it, have you?) | 16:22 |
| *** vblando has joined #zuul | 16:23 | |
| mordred | corvus: it should work in k8s in general - but the binfmt thing would need to be run on each k8s node | 16:23 |
| mordred | (it doesn't have to be run via container - that's just a convenient way to do it) | 16:23 |
| mordred | the binfmt thing is basically just registering handlers with binfmt_misc on the host | 16:24 |
| corvus | yeah, so it's probably not going to be practical for most folks :/ | 16:24 |
| mordred | corvus: yeah. unless there's a way to tell k8s to run a Task on every node | 16:25 |
| mordred | mnaser: ^^ you know crazy k8s tricks - any thoughts? | 16:25 |
| corvus | what's a Task? | 16:25 |
| mordred | corvus: oh - well, you know what you could do ... | 16:25 |
| mnaser | do you have to execute something on the host, or copy some files? | 16:26 |
| mordred | (sorry, Imeant Job I think) | 16:26 |
| corvus | (i know you can run a pod on every node) | 16:26 |
| mordred | corvus: but - actually - you don't need to do it on all the nodes | 16:26 |
| mnaser | if you're already running a pod on every node (i.e. DaemonSet) then you can use `initContainers` on that same daemonset to copy/run/do whatever you want on the host for example | 16:26 |
| mordred | you only need to do it on the same host as nodepool-builder | 16:26 |
| mordred | so you could make the binfmt thing an init container for the nodepool-builder pod | 16:26 |
| mnaser | ^^^ | 16:26 |
| mordred | mnaser: yeah. that | 16:27 |
| mnaser | or that, so it will always run for that specific hosts | 16:27 |
| mordred | and I'm pretty sure dib already means nodepool-builder has to be run as a privileged pod anyway | 16:27 |
| mnaser | initContainer is largely the mechanism of 'do things on host' in k8s | 16:27 |
| corvus | cool, that sounds plausible :) | 16:27 |
| mordred | so if you're running dib in k8s in a nodepool-builder pod, the init container should be fairly easy | 16:27 |
| corvus | mordred: i left a minor comment about a comment | 16:27 |
| mnaser | we have a zuul-helm to test that out ;p | 16:28 |
| mordred | speaking of zuul-helm ... I keep thinking we need to get that updated to use tls | 16:28 |
| corvus | mordred: (mostly just thinking i don't want folks seeing that file and thinking they need to go install it or something) | 16:28 |
| mordred | corvus: ++ | 16:28 |
| mnaser | yeah, we should.. i think zuul-helm doesn't actually deploy zookeeper, relies on an externally deployed one, but i dont think there's option to feed in the certs and what not | 16:29 |
| corvus | speaking of which: woo! new kazoo is out! https://github.com/python-zk/kazoo/issues/621 cc tobiash | 16:29 |
| mordred | corvus: what do you think about: | 16:30 |
| mordred | # This file exists in support of using nested-podman in | 16:30 |
| mordred | # the nodepool-builder container image | 16:30 |
| corvus | so next up for us is: upgrade opendev with that, try switching opendev to tls again, when that works, issue a new 3.x release with it | 16:30 |
| *** wuchunyang has quit IRC | 16:30 | |
| corvus | mordred: yeah, and you know, it might be good to add something to the docs about this, and maybe link there in the comment? | 16:31 |
| corvus | mordred: cause right now, the only doc is a comment in the dockerfile | 16:31 |
| mordred | hrm. that would require coherent thinking | 16:31 |
| corvus | mordred: we have high standards :) | 16:32 |
| openstackgerrit | Merged zuul/zuul master: Join command thread on exit https://review.opendev.org/739838 | 16:32 |
| mordred | hah. the matrix client interprets markdown - so those lines with leading # were rendered as H1 for me :) | 16:32 |
| corvus | # I'm going to use that. | 16:32 |
| mordred | corvus: too bad - it doesn't seem to interpret the plaintext coming from the IRC bridge | 16:33 |
| corvus | > Sure | 16:33 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Require kazoo 2.8.0 https://review.opendev.org/741270 | 16:34 |
| corvus | clarkb, tobiash: ^ | 16:35 |
| tobiash | :) | 16:57 |
| *** bhavikdbavishi1 has joined #zuul | 17:00 | |
| mordred | corvus: oh fascinating. something has changed with that zuul-preview change since I wrote it | 17:00 |
| *** bhavikdbavishi has quit IRC | 17:01 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 17:01 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul-preview master: Simplify build https://review.opendev.org/729066 | 17:03 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-preview master: Bump to c++17 and switch boost::optional to std::optional https://review.opendev.org/729428 | 17:03 |
| mordred | corvus, tristanC: ^^ had to bump boost version | 17:03 |
| openstackgerrit | Gonéri Le Bouder proposed zuul/zuul master: zuul_stream: avoid exception in _log_streamline https://review.opendev.org/741257 | 17:05 |
| *** armstrongs has joined #zuul | 17:09 | |
| openstackgerrit | Merged zuul/zuul master: Require kazoo 2.8.0 https://review.opendev.org/741270 | 17:29 |
| *** jamesmcarthur has joined #zuul | 17:36 | |
| *** jamesmcarthur has quit IRC | 18:02 | |
| *** jamesmcarthur has joined #zuul | 18:03 | |
| *** nils has quit IRC | 18:04 | |
| clarkb | mordred: I've always found it funny that -Wall isn't all | 18:04 |
| openstackgerrit | Merged zuul/zuul master: Round width of change progress bar to 2 decimals https://review.opendev.org/741073 | 18:07 |
| *** jamesmcarthur has quit IRC | 18:07 | |
| clarkb | mordred: see comment on https://review.opendev.org/#/c/729428/ | 18:10 |
| *** jamesmcarthur has joined #zuul | 18:17 | |
| *** vishalmanchanda has quit IRC | 18:20 | |
| openstackgerrit | Merged zuul/zuul-preview master: Simplify build https://review.opendev.org/729066 | 18:22 |
| *** tosky has quit IRC | 18:25 | |
| *** tosky has joined #zuul | 18:25 | |
| mordred | clarkb: I think we can't - I think they're deps of libcpprest - but now that I say that I think the debian packages should take care of the transitive deps - lemme double check | 18:26 |
| mordred | (like, I remember trying and it failing but I forget why) | 18:26 |
| *** harrymichal has quit IRC | 18:27 | |
| *** harrymichal has joined #zuul | 18:27 | |
| mordred | clarkb: hrm. removing it from runtime seemed to work. lemme see if I can remove the build dep too | 18:30 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-preview master: Remove libboost-system depends https://review.opendev.org/741302 | 18:34 |
| mordred | clarkb: ^^ that works | 18:35 |
| clarkb | cool +2 on that one and +3 on the parent | 18:35 |
| mordred | yay for simplifying | 18:36 |
| openstackgerrit | Merged zuul/zuul-preview master: Bump to c++17 and switch boost::optional to std::optional https://review.opendev.org/729428 | 18:48 |
| *** bhavikdbavishi has quit IRC | 19:01 | |
| *** bhavikdbavishi1 has joined #zuul | 19:01 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 19:03 | |
| openstackgerrit | Merged zuul/zuul-preview master: Remove libboost-system depends https://review.opendev.org/741302 | 19:11 |
| *** harrymichal has quit IRC | 19:20 | |
| *** wuchunyang has joined #zuul | 19:20 | |
| *** wuchunyang has quit IRC | 19:45 | |
| *** wuchunyang has joined #zuul | 19:51 | |
| *** bhavikdbavishi has quit IRC | 19:58 | |
| tobiash | corvus: do you want to gather more feedback on the buildset result page (738011) or should we merge it? | 20:12 |
| tobiash | zuul-maint: it would be great to get reviews on some fixes around job pause and skipping: https://review.opendev.org/#/q/status:open+project:zuul/zuul+branch:master+topic:buildset-fixes | 20:18 |
| clarkb | tobiash: I'll take a look | 20:29 |
| tobiash | thanks :) | 20:29 |
| clarkb | tobiash: I guess the issue with pausing on a failed playbook is you want to fail early rather than have subsequent jobs start and fail too? | 20:32 |
| tobiash | clarkb: normally child jobs only run after a successful parent. In case of a paused job that is already failing I think we should stick to the same behavior | 20:33 |
| clarkb | ya I'm currently trying to brainstorm if I can come up with a valid reason to pause and start jobs after a failure and so far have no good examples | 20:34 |
| clarkb | which makes me think you are right | 20:34 |
| tobiash | further many child jobs depend on results of the parent and fail in weird and hard to debug ways (which is how we found that) | 20:34 |
| clarkb | yup this is a good optimization for those cases | 20:35 |
| clarkb | makes the error clear and fails more quickly | 20:35 |
| *** wuchunyang has quit IRC | 20:37 | |
| corvus | tobiash: i think we can merge that and iterate in-tree; i doubt there are significant usability issues we need to collect more feedback on | 20:42 |
| clarkb | I've already approved it fwiw | 20:42 |
| clarkb | the next chagne in the stack has my brain melting a bit | 20:43 |
| corvus | oh sorry, i was talking about the buildset result page | 20:43 |
| *** wuchunyang has joined #zuul | 20:44 | |
| clarkb | ah | 20:44 |
| *** jamesmcarthur_ has joined #zuul | 20:45 | |
| *** hamalq_ has quit IRC | 20:46 | |
| *** jamesmcarthur has quit IRC | 20:48 | |
| *** hamalq has joined #zuul | 20:48 | |
| openstackgerrit | James E. Blair proposed zuul/nodepool master: Require kazoo 2.8.0 https://review.opendev.org/741315 | 20:49 |
| clarkb | corvus: tobiash what I don't undersatnd in https://review.opendev.org/#/c/739511/2/zuul/manager/__init__.py is we should only update the status if we cancel the job directly and if we do that the build isn't in the buildset which means there won;t be anything to reset later? | 20:50 |
| clarkb | I feel like I'm missing something fundamental there | 20:50 |
| corvus | clarkb: i don't think 739511 deals with canceled builds, but rather skipped ones | 20:51 |
| *** hamalq has quit IRC | 20:52 | |
| *** hamalq has joined #zuul | 20:52 | |
| clarkb | but the only state change in _resetDependentBuilds is to cancel it (in the old code) | 20:52 |
| clarkb | I think the magic is happenign in setResult now that i look closer | 20:52 |
| clarkb | setResult makes its own job graph so it isn't dependnet on the data that is in build_set which may have had entries removed | 20:53 |
| tobiash | it also set the result to none | 20:53 |
| clarkb | it will create fake builds in setResult if necessary | 20:53 |
| corvus | (the cancel code path isn't going to hit here because of the previous skip) | 20:53 |
| tobiash | And this is the problem in case there were skipped builds in a multi parent scenario | 20:53 |
| corvus | (the cancel will noop) | 20:53 |
| clarkb | tobiash: where does the result get set to None? | 20:54 |
| clarkb | also the check is if build.result which would fail if it is None? | 20:54 |
| corvus | maybe that's 1004 with removebuild? | 20:54 |
| tobiash | Thats what this function is supposed to do (so they can run again) | 20:54 |
| tobiash | yes it's removebuild | 20:55 |
| clarkb | reading removeBuild it just removes the build from the dict | 20:55 |
| clarkb | I think that is why I am confused as it won't be there to iterate over (and if it is a None result we won't reset the result anyway?) | 20:56 |
| clarkb | I probably need to trace this out more completely to understand it | 20:56 |
| tobiash | We set the result on all completed builds that didn't get reset | 20:56 |
| corvus | clarkb: i think setResult will recurse internally | 20:57 |
| tobiash | And they skip their child jobs if needed which fixes the issue | 20:57 |
| corvus | clarkb: so even though we remove the child build, we call setresult on its parent which then recreates the skipped child | 20:57 |
| tobiash | yepp | 20:57 |
| clarkb | ya thats the fake build creation it does | 20:58 |
| corvus | (setResult walks the job graph, so all the jobs are there) | 20:58 |
| clarkb | ok so what we are doing is starting form builds we can reach then calling setResult from all of those to walk the graph and add in any missing skips if necessary | 20:58 |
| clarkb | and we only bother with those that have a result because something that doesn't have ar esult yet can't modify its children | 20:59 |
| tobiash | yes | 20:59 |
| corvus | tobiash: while you're around, i forgot https://review.opendev.org/741315 earlier :) | 20:59 |
| tobiash | ah the nodepool change, I first thougbt I have andeja vue :) | 21:00 |
| corvus | clarkb: ^ when you have a sec | 21:01 |
| tobiash | you see from my spelling that I'm on mobile... | 21:01 |
| corvus | my french is too bad to notice | 21:01 |
| clarkb | done and done. Now to the last of tobiash's changes | 21:02 |
| tobiash | the last one should be easier :) | 21:04 |
| tobiash | the skip issue was quite a dwbug challenge :) | 21:04 |
| clarkb | yup the last one was easier. I got sniped by the changes to the test suite to handle testing of multiple schedulers but the chagne itself was fine | 21:10 |
| openstackgerrit | Merged zuul/zuul master: Fix bug that allowed failing jobs to pause https://review.opendev.org/739975 | 21:29 |
| openstackgerrit | Merged zuul/nodepool master: Require kazoo 2.8.0 https://review.opendev.org/741315 | 21:51 |
| openstackgerrit | Merged zuul/zuul master: Correctly handle skipped jobs on retries https://review.opendev.org/739511 | 22:09 |
| openstackgerrit | Merged zuul/zuul master: Resume jobs after reenqueue of an item https://review.opendev.org/739709 | 22:09 |
| *** fdegir has quit IRC | 22:16 | |
| *** fdegir has joined #zuul | 22:17 | |
| *** logan- has quit IRC | 22:17 | |
| *** logan- has joined #zuul | 22:19 | |
| *** rlandy|ruck is now known as rlandy|ruck|bbl | 22:34 | |
| *** hamalq has quit IRC | 22:35 | |
| *** tosky has quit IRC | 22:48 | |
| *** jamesmcarthur has joined #zuul | 23:00 | |
| *** jamesmcarthur_ has quit IRC | 23:04 | |
| *** piotrowskim has quit IRC | 23:15 | |
| *** rlandy|ruck|bbl is now known as rlandy|ruck | 23:55 | |
| *** jamesmcarthur has quit IRC | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!