Tuesday, 2020-07-14

*** ysandeep|away is now known as ysandeep|rover00:11
*** rlandy|bbl is now known as rlandy00:34
*** ysandeep|rover is now known as ysandeep|afk01:42
openstackgerritIan Wienand proposed zuul/zuul-jobs master: add-build-sshkey: Generate PEM format key  https://review.opendev.org/74084101:52
*** cloudnull has quit IRC02:13
*** cloudnull has joined #zuul02:13
*** sgw1 has quit IRC02:21
*** ysandeep|afk is now known as ysandeep|rover02:22
openstackgerritIan Wienand proposed zuul/zuul-jobs master: add-build-sshkey: Generate PEM format key  https://review.opendev.org/74084102:25
*** Goneri has quit IRC02:29
*** rlandy has quit IRC02:32
*** cloudnull6 has joined #zuul02:34
*** cloudnull has quit IRC02:35
*** cloudnull6 is now known as cloudnull02:35
*** rfolco has quit IRC02:59
*** sgw1 has joined #zuul03:07
*** ysandeep|rover is now known as ysandeep|afk03:10
*** bhavikdbavishi has joined #zuul03:33
*** bhavikdbavishi1 has joined #zuul03:36
*** bhavikdbavishi has quit IRC03:38
*** bhavikdbavishi1 is now known as bhavikdbavishi03:38
*** iurygregory has quit IRC03:54
*** saneax has joined #zuul03:55
*** bhavikdbavishi has quit IRC04:14
*** sgw1 has quit IRC04:25
*** bhavikdbavishi has joined #zuul04:28
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** wuchunyang has joined #zuul04:37
*** wuchunyang has quit IRC04:50
*** marios has joined #zuul04:53
*** saneax has quit IRC04:53
*** ysandeep|afk is now known as ysandeep04:57
*** saneax has joined #zuul04:57
*** sanjayu_ has joined #zuul05:01
*** saneax has quit IRC05:03
openstackgerritSimon Westphahl proposed zuul/zuul master: Revert "GitHub Reporter: Fix User Email in Merge Commit Message"  https://review.opendev.org/74086805:18
*** sanjayu__ has joined #zuul05:23
*** sanjayu_ has quit IRC05:26
*** vishalmanchanda has joined #zuul05:41
*** bhavikdbavishi1 has joined #zuul06:00
*** bhavikdbavishi has quit IRC06:01
*** bhavikdbavishi1 is now known as bhavikdbavishi06:01
*** bhavikdbavishi has quit IRC06:22
*** bhavikdbavishi has joined #zuul06:25
*** bhavikdbavishi has quit IRC06:35
*** SotK has quit IRC06:54
*** SotK has joined #zuul06:55
*** iurygregory_ has joined #zuul07:10
*** bhavikdbavishi has joined #zuul07:12
tobiashzuul-maint: I went ahead and single-core approved that revert since this broke all pull_request events on github with app authentication ^07:12
*** bhavikdbavishi has quit IRC07:22
*** bhavikdbavishi has joined #zuul07:22
tobiashroot cause is actually still unknown but reverting this fixed our deploymebt07:22
*** iurygregory_ is now known as iurygregory07:31
*** ysandeep is now known as ysandeep|brb07:34
*** tosky has joined #zuul07:37
zbrfelixedel: ping me when online, i want to check few things re pf4 work07:43
*** bhagyashris|afk is now known as bhagyashris07:44
openstackgerritMerged zuul/zuul master: Revert "GitHub Reporter: Fix User Email in Merge Commit Message"  https://review.opendev.org/74086808:04
zbrtobiash: i missed to add my vote to ^ by one second. Anyway, seems like a decent reason for a fast-tracked revert.08:05
*** ysandeep|brb is now known as ysandeep|rover08:10
*** bhavikdbavishi has quit IRC08:14
*** bhavikdbavishi has joined #zuul08:19
openstackgerritFelix Edel proposed zuul/zuul master: Fix brand logo link for dashboards deployed on a sub-url  https://review.opendev.org/74091408:21
felixedelzuul-maint: Another small PF4 fix: https://review.opendev.org/#/c/740914/108:25
*** sanjayu__ has quit IRC08:25
*** sanjayu__ has joined #zuul08:27
*** sanjayu__ has quit IRC08:27
*** sanjayu__ has joined #zuul08:28
openstackgerritJan Kubovy proposed zuul/zuul master: Improve typings in context of 630472  https://review.opendev.org/71524708:34
openstackgerritJan Kubovy proposed zuul/zuul master: Required SQL reporters  https://review.opendev.org/63047208:34
openstackgerritJan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality  https://review.opendev.org/70973508:41
openstackgerritJan Kubovy proposed zuul/zuul master: Separate connection registries in tests  https://review.opendev.org/71295808:41
openstackgerritJan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler  https://review.opendev.org/71726908:41
openstackgerritJan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests  https://review.opendev.org/72125408:41
openstackgerritJan Kubovy proposed zuul/zuul master: Driver event ingestion  https://review.opendev.org/71729908:41
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Store unparsed branch config in Zookeeper  https://review.opendev.org/70571608:41
*** nils has joined #zuul08:42
openstackgerritJan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper  https://review.opendev.org/71622108:43
openstackgerritJan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper  https://review.opendev.org/71687508:43
openstackgerritJan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper  https://review.opendev.org/71626208:43
*** donnyd has quit IRC08:53
*** donnyd has joined #zuul08:54
*** piotrowskim has joined #zuul09:03
openstackgerritFelix Edel proposed zuul/zuul master: Keep active nav links highlighted while browsing the page  https://review.opendev.org/74092309:17
*** frickler is now known as frickler_pto09:44
*** frickler_pto is now known as frickler09:47
*** avass has joined #zuul10:09
zbrfelixedel: tobiash: can you please help with https://review.opendev.org/#/c/740733/ ?10:21
*** gouthamr has quit IRC10:22
*** gouthamr has joined #zuul10:23
*** sanjayu__ has quit IRC10:33
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kuberenetes with kind  https://review.opendev.org/74093510:50
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kuberenetes with kind  https://review.opendev.org/74093510:51
*** ysandeep|rover is now known as ysandeep|afk10:53
*** harrymichal has joined #zuul10:54
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kuberenetes with kind  https://review.opendev.org/74093510:58
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kuberenetes with kind  https://review.opendev.org/74093511:05
*** wuchunyang has joined #zuul11:20
*** wuchunyang has quit IRC11:36
*** rlandy has joined #zuul11:43
*** rlandy is now known as rlandy|ruck11:45
*** iurygregory has quit IRC11:46
*** ysandeep|afk is now known as ysandeep11:47
felixedelzbr: Sry, I saw your message but didn't came to that yet. What do you need?11:54
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kuberenetes with kind  https://review.opendev.org/74093511:54
zbrfelixedel: take a look at https://review.opendev.org/#/c/739482/ -- and tell me how to avoid conflict with your patches. maybe you know best candidate to rebase my on?11:55
zbri will fix the current comments, but i am more worried about conflicts with you pf4 changes,11:55
zbri really want to find a way to merge it because I need a config screen for other work I done, where I was asked to make the feature configurable :p11:56
felixedelzbr: I think you can just rebase this one on the latest master. Might be that the two fixes https://review.opendev.org/#/c/740914/ and https://review.opendev.org/#/c/740923/ also cause merge conflicts since they change the App.jsx. But this depends on which changes comes in first11:58
felixedelThe other changes I have in the pipeline should not conflict with yours11:58
zbrthat is good to know. not sure about the "redux" comment, no idea how to use it yet.12:00
*** iurygregory has joined #zuul12:00
zbrif you can keep an eye on these changes it would be great, especially as you know pf4 much better than me12:01
zbri also have https://review.opendev.org/#/c/740733/ which is safe to merge, but i need reviews.12:02
*** rfolco has joined #zuul12:03
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093512:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093512:14
*** bhavikdbavishi has quit IRC12:14
*** bhavikdbavishi has joined #zuul12:33
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093512:36
*** holser has quit IRC12:58
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093512:59
*** bhavikdbavishi has quit IRC12:59
*** rlandy|ruck is now known as rlandy|ruck|mtg13:00
*** ysandeep is now known as ysandeep|rover13:03
tobiashzuul-maint: I've seen increased job failure rates due to flaky tests. I have two fixes in review that need a few eyes: https://review.opendev.org/#/q/project:zuul/zuul+topic:test-fixes+status:open13:04
*** Goneri has joined #zuul13:14
*** sgw1 has joined #zuul13:14
openstackgerritFelix Edel proposed zuul/zuul master: PF4: Update buildset result page (new layout and styling)  https://review.opendev.org/73801113:19
openstackgerritFelix Edel proposed zuul/zuul master: Consolidate summary, logs and console on a single build page  https://review.opendev.org/74062913:19
openstackgerritFelix Edel proposed zuul/zuul master: PF4: Update build result page layout  https://review.opendev.org/73997213:19
*** bhavikdbavishi has joined #zuul13:25
*** bhavikdbavishi1 has joined #zuul13:28
*** bhavikdbavishi has quit IRC13:30
*** bhavikdbavishi1 is now known as bhavikdbavishi13:30
*** bhavikdbavishi has quit IRC13:36
*** frickler is now known as frickler_pto13:50
openstackgerritMerged zuul/zuul master: Update cherrypy and cheroot requirement pinning  https://review.opendev.org/74071713:50
*** holser has joined #zuul13:55
*** rlandy|ruck|mtg is now known as rlandy|ruck14:00
*** ysandeep|rover is now known as ysandeep|food14:47
*** bhavikdbavishi has joined #zuul14:54
corvuszbr: the redux stuff is mostly in store.js and reducers/*14:57
corvuszbr: the really short version is that it keeps a global state variable, and you write little functions (reducers) that mutate the variable when events (represented by string constants) are received.  the events are sent by the dispatch() method.14:58
corvuszbr: https://redux.js.org/introduction/core-concepts has more14:58
*** rlandy|ruck is now known as rlandy|ruck|mtg15:06
zbrcorvus: do we have any example in zuul or not?15:07
zbrlocalStorage allows only strings, so i need to be sure I serialize data correctly for our persistent user-config15:09
zbrprobably you seen the ugly trick used to evaluate it as a bool15:09
corvuszbr: yes, examples in store.js and reducers/*15:10
corvuszbr: it's how the dashboard stores its global state15:10
corvuszbr: you can initialize the state variable by loading it from local storage, and you can have the reducer write the value out to local storage when it changes15:10
zbrok, i will into it bit later today, i need to finish two other things15:11
zbrthis means that conversion from cookie to localStorage was not really the best approach15:12
corvuszbr: no localstorage is great15:12
corvuszbr: the redux state store is just in-memory15:12
corvuszbr: we still need localstorage for long-term storage15:12
corvuszbr: anyway, take a look at it, and if you have questions, let me know, i can help out15:13
*** hamalq has joined #zuul15:23
avassDid anyone ever check how ansible sets ansible_architecture? I believe someone mentioned that ansible checks localhost instead of the remote or something like that15:23
clarkbavass: ya you have to look at a fact set as a hostvar to get the remote15:24
clarkbiirc15:24
clarkbavass: where this gets weird is when you do loading of files for vars or tasks because that is evaluated on the localhost context15:25
avassclarkb: so something like ansible_facts[<inventory_hostname>].architecture?15:25
clarkbif its used in a task running on the remote then I think it does the right thing. Using the fact var for the host makes it explicit15:26
clarkbya15:26
avassoh, so it's only the 'wrong' architecture if it's delegated to localhost?15:27
clarkbor if it runs within the context of ansible evaluating the tasks themselves15:27
clarkbinclude_* is always done that way or is special somehow as an example15:28
avassdoes that mean it affects any tasks inside an include_*, or only the include itself?15:28
avassI guess only the include task itself15:28
clarkbonly the include itself I think15:28
*** hamalq has quit IRC15:29
*** hamalq has joined #zuul15:35
*** ysandeep|food is now known as ysandeep15:38
avassclarkb: oh could it be that any ansible_* variables act like that but since zuul sets a lot of them explicitly, like ansible_host, it hasn't affected anything else yet.15:39
avasssince ansible_host is set to localhost if you use delegate_to: localhost unless it's explicitly set in the inventory15:40
*** ysandeep is now known as ysandeep|away15:43
*** cloudnull6 has joined #zuul15:44
*** cloudnull has quit IRC15:46
*** cloudnull6 is now known as cloudnull15:46
*** bhavikdbavishi has quit IRC15:46
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093515:47
*** bhavikdbavishi has joined #zuul15:50
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093515:51
avass^ should be ready if anyone is interested. I've been messing around a bit with kind lately so I thought I might as well add support for it in the ensure-kubernetes role :)15:53
*** marios is now known as marios|out16:01
*** rlandy|ruck|mtg is now known as rlandy|ruck16:02
*** sshnaidm is now known as sshnaidm|afk16:08
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093516:09
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/74093516:25
corvusclarkb: i +2d tobiash's test fixes; maybe you can +3 https://review.opendev.org/739835 and child ?16:39
*** sshnaidm|afk is now known as sshnaidm16:48
*** holser has quit IRC17:16
*** marios|out has quit IRC17:35
*** piotrowskim has quit IRC17:56
*** bhavikdbavishi has quit IRC18:06
clarkbcorvus: question on https://review.opendev.org/#/c/739838/18:18
zbrclarkb: corvus: simple improvement around display of cmd content in zuul: https://review.opendev.org/#/c/740733/18:37
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Improve rendering of cmd  https://review.opendev.org/74073318:38
*** nils has quit IRC18:52
*** armstrongs has joined #zuul18:53
*** armstrongs has quit IRC18:57
felixedelcorvus: I've replied to your comments on https://review.opendev.org/#/c/738011/12. The follow-up changes that improve the routing on the builds page https://review.opendev.org/#/c/740629/2 and its layout https://review.opendev.org/#/c/739972/7 are also ready (with tabs now ;-) ). I'm glad that you like the overall layout changes :)18:57
felixedelThere is still one todo in the build result layout change to always show the tabs (Results, Logs, Console) which should improve how the page is loaded. Currently the tabs are building up one after another when the data is there. But I assume that most of the Zuul deployments are utilizing the manifest and output functionality and thus the major part of the builds (except for noop builds) should provide all three so we19:01
felixedelcould always show the tabs. In case some part is missing we could show an empty state as tab content. Would you agree with that?19:01
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Add user preferences dialog  https://review.opendev.org/73948219:05
zbrfelixedel: what are the implications on that regarding page navigation? it would be key to be able to share links that send user to specific tab, specific section.19:07
felixedelzbr: I'm not sure I understand the question correctly, but the navigation wouldn't be affected by this.19:09
zbr|ruckfelixedel: i was trying to understand implications regarding tabs changes.19:11
zbr|rucki am also curious how hard it would be to expose a html report produced by the build as a tab.19:12
zbr|ruckNow that is listed as an artifact, but that does not make it easy to find.19:12
zbr|ruckimagine unitest results, they could fix very well as a tab19:13
zbr|ruckpractical example: https://zuul.opendev.org/t/zuul/build/965bb139ed9b4711882139c2e6966b4019:13
zbr|ruck"Unit Test Report" is an artifact, but it would much better be a tab with iframe19:14
openstackgerritMerged zuul/zuul master: Make test_playbook more stable  https://review.opendev.org/73983519:17
*** holser has joined #zuul19:18
zbrcorvus: is too late for me now and i failed to identify how to use the redux part. if you could alter my preference dialog patch to add it it would really be great.20:04
corvusfelixedel: sure, if it's easier, we could always show the tabs, and have them be empty (or have an explanatory message) if the async fetch doesn't work20:11
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-afs-synchronize: expand documentation  https://review.opendev.org/74105120:52
openstackgerritMerged zuul/zuul-jobs master: write-inventory: add per-host variables  https://review.opendev.org/73989221:26
corvusianw, clarkb, mordred: it looks like the issue with the multi-arch build is that docker buildx is sending the registry an Accept header like:21:53
corvusapplication/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, */*21:53
corvusnote that the manifest list is *after* the manifest; zuul-registry sends the first thing that matches, so it always returns the single manifest rather than the list21:54
mordredcorvus: wow21:54
corvusi'm going to look into what docker registry does (maybe it has a priority order for what to do with accept)21:55
corvusi'll also hack the zuul-registry i have running to ignore accept and return the list, just to confirm that fixes it21:55
mordredcorvus: then I guess an answer might be to special case the accept header processing to treat it like a set rather than a list21:55
clarkbI think the http specs allow the server to choose what is best21:56
mordredassuming that's the behavior observed between docker buildx and docker21:56
clarkbusually thats "best because I know gzip"21:56
clarkbbut I guess that wouldn't be out of spec here21:56
corvusclarkb: ah, makes sense21:57
mordrednod21:57
mordredcorvus: I don't think I was expecting this behavior was going to be realted to accept headers ... but that's probably only because I've stopped expecting things21:57
corvusmordred: expect the unexpected?21:58
mordredcorvus: unexpect the expected21:59
corvusyes, munging the accept header order produced a build22:00
funginobody expects the content-type inquisition22:03
smcginnisfungi: Was just reading the python md5 security patch yesterday. Did you see that?22:07
smcginnishttps://github.com/python/cpython/pull/1952022:07
smcginnisLoved the title.22:07
fungibwahahaha22:08
fungii hadn't see that yet, no22:08
smcginnisI'd be tempted to merge a patch with a title like that, just to have it in the git history. :)22:08
fungialso i've been adoring the names of all their bots22:09
smcginnisTheir bot naming game is much better than ours for sure.22:09
fungiunfortunately for that patch, i saw the usedforsecurity parameter is being ripped back out of openssl22:11
funginot sure what the cpython side is going to do to compensate when that comes to pass22:11
smcginnis:(22:12
smcginnisI was happy to see that added.22:12
smcginnisWe've had a bunch of patches moving off of md5 for trivial little internal things just because security scanners flag it.22:12
mordredyah22:13
mordredI've -2'd some of those22:14
mordredI'm getting tired of having to write the explanation that there is nothing fundamentally wrong with md522:14
mordredlike - do we need to stop using it in sdk as a checksum to tell whether or not we should re-upload bytes for an image or not? NOPE22:16
corvusclarkb, mordred: https://github.com/docker/distribution/blob/244d5246c2f193d50b2f8fd220784958a5e1318b/registry/handlers/manifests.go#L10022:16
smcginnisEspecially when it's just being used to get a key value or something.22:16
corvusso yeah, looks like 'special handling' is the way22:16
mordredcorvus: yeah22:16
corvusi probably won't implement all that logic, i'll just do a priority list filtered by what's in accept22:17
mordred++22:18
clarkbya that seems like it would be sufficient22:18
clarkbbasically give the most verbose option available and set in the accept header22:18
fungismcginnis: more specifically, openssl 3.0 will no longer include a "fips mode" at all, changes will be needed regardless. there will be a separate fips module for it, which presumably cpython can add support for22:18
smcginnisAh, interesting.22:19
fungihttps://bugs.python.org/issue4047922:20
fungito be honest i wish i didn't even know about "fips mode" but years of trauma are not easy to undo22:21
openstackgerritJames E. Blair proposed zuul/zuul-registry master: Prioritize returning manifest lists  https://review.opendev.org/74106222:29
corvusclarkb, mordred, ianw: ^ i think with that we should be gtg22:30
clarkbcorvus: any idea why your test node reproduces it reliably but other jobs don't?22:30
clarkbmaybe the ordering from buildx is influenced by external factors?22:30
*** jamesmcarthur has joined #zuul22:32
jamesmcarthurmordred: corvus: If you have a chance, could y'all have a look at my email re: marketing/press around Zuul 4 & 5 releases?22:33
jamesmcarthurEveryone else :)  If you have a chance to check the Zuul ml re: the Zuul, wiki - we could really use some help.22:35
jamesmcarthurhttp://lists.zuul-ci.org/pipermail/zuul-discuss/2020-July/001300.html22:35
*** vishalmanchanda has quit IRC22:39
corvusclarkb: no, and that's a fascinating question :)22:43
*** tosky has quit IRC22:50
*** hamalq has quit IRC22:58
*** holser has quit IRC23:10
*** saneax has joined #zuul23:27
*** jamesmcarthur has quit IRC23:36
*** jamesmcarthur has joined #zuul23:48

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!