Monday, 2019-09-16

*** jamesmcarthur has joined #zuul00:05
*** jamesmcarthur has quit IRC00:09
*** jamesmcarthur has joined #zuul00:15
*** jamesmcarthur has quit IRC00:25
mnaserhmm00:34
mnaserzuul is complaining "paramiko.ssh_exception.SSHException: No authentication methods available"00:34
clarkbin what context?00:35
mnaserbut i can run successfully: ssh -i /path/to/sshkey.pem user@host -p29418 stream-events00:35
clarkbansible should use openssh by default00:35
mnaserthis is inside the scheduler00:35
clarkbah for gerrit rvents00:35
clarkbis it possible that gerrit is rejecting the zuul auth and that is how it ends up at no remaining methods? counld be the username or other setting (host port etc) if so00:37
mnaserah ffs00:38
mnaser<gerrit connection>.sshkey00:38
mnaser"ssh_key = /etc/zuul/opendev.pem"00:38
mnaserand thats why you dont write things on a friday i guess00:39
mnasererr sunday.00:39
mnaserand that was it lol00:40
*** jamesmcarthur has joined #zuul00:59
*** jamesmcarthur has quit IRC01:10
*** jamesmcarthur has joined #zuul03:10
*** jhesketh has joined #zuul03:50
*** jamesmcarthur has quit IRC04:01
*** jamesmcarthur has joined #zuul04:04
*** jamesmcarthur has quit IRC04:17
*** bhavikdbavishi has joined #zuul05:10
*** pcaruana has joined #zuul05:11
*** roman_g has joined #zuul05:47
openstackgerritIan Wienand proposed zuul/zuul master: Support nodes setting 'auto' python path  https://review.opendev.org/68227505:53
*** jamesmcarthur has joined #zuul06:18
*** badboy has joined #zuul06:21
*** jamesmcarthur has quit IRC06:23
*** logan- has quit IRC06:23
*** logan- has joined #zuul06:26
sshnaidm_is there an option to set irrelevant_files for whole project-template?06:37
*** sshnaidm_ is now known as sshnaidm|rover06:37
openstackgerritIan Wienand proposed zuul/zuul master: Support nodes setting 'auto' python path  https://review.opendev.org/68227506:40
*** gtema_ has joined #zuul06:56
AJaegersshnaidm|rover: no.06:58
*** fbo has joined #zuul07:08
*** tosky has joined #zuul07:08
*** bolg has joined #zuul07:25
*** jangutter has joined #zuul07:34
*** jpena|off is now known as jpena07:34
*** hashar has joined #zuul07:38
*** sshnaidm|rover is now known as sshnaidm|afk07:39
*** gtema_ has quit IRC07:46
*** panda has quit IRC07:56
*** panda has joined #zuul07:58
*** themroc has joined #zuul08:22
*** saneax has joined #zuul08:30
*** sshnaidm|afk is now known as sshnaidm|rover08:43
*** hashar has quit IRC08:47
*** panda is now known as panda|ruck08:59
*** hashar has joined #zuul09:11
*** mgoddard has quit IRC09:26
*** mgoddard has joined #zuul09:28
*** themroc has quit IRC10:03
*** gtema_ has joined #zuul10:22
sshnaidm|rovercan I figure out when the buildset was queued?10:39
*** jpena is now known as jpena|lunch11:30
openstackgerritMerged zuul/zuul master: Better error handling for the PagureAPIClient  https://review.opendev.org/67974611:35
openstackgerritMerged zuul/zuul master: Remove auto-add of localhost from unit test inventory  https://review.opendev.org/68164111:45
openstackgerritMerged zuul/zuul-jobs master: Add tests for manifest generation for missing files  https://review.opendev.org/67857311:56
*** gtema_ has quit IRC11:57
openstackgerritMerged zuul/zuul master: Discuss executor-only jobs, add unit-test  https://review.opendev.org/67918412:08
*** sanjayu_ has joined #zuul12:17
*** saneax has quit IRC12:18
*** rfolco has joined #zuul12:23
*** rlandy has joined #zuul12:25
*** jpena|lunch is now known as jpena12:33
*** themroc has joined #zuul12:35
*** badboy has quit IRC12:39
*** jamesmcarthur has joined #zuul12:48
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Store autohold requests in zookeeper  https://review.opendev.org/66111412:48
*** Goneri has joined #zuul13:11
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly starting at 14:00 UTC (that's roughly 30 minutes from now) for maintenance: http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009064.html13:30
*** bhavikdbavishi has quit IRC13:30
*** bhavikdbavishi has joined #zuul13:32
*** bolg has quit IRC13:35
*** jangutter has quit IRC13:40
*** jangutter has joined #zuul13:42
*** pcaruana has quit IRC13:45
*** jangutter has quit IRC13:53
openstackgerritTristan Cacqueray proposed zuul/zuul-sphinx master: Switch to zuul-release-python  https://review.opendev.org/68236613:58
*** pcaruana has joined #zuul14:07
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org is offline briefly for maintenance: http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009064.html14:08
*** ChanServ changes topic to "The Gerrit service on review.opendev.org is offline briefly for maintenance: http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009064.html"14:08
*** jamesmcarthur has quit IRC14:31
*** sanjayu_ has quit IRC14:32
*** sanjayu_ has joined #zuul14:32
*** jamesmcarthur has joined #zuul14:33
*** jamesmcarthur has quit IRC14:39
*** ChanServ changes topic to "Discussion of the project gating system Zuul | Website: https://zuul-ci.org/ | Docs: https://zuul-ci.org/docs/ | Source: https://git.zuul-ci.org/ | Channel logs: http://eavesdrop.openstack.org/irclogs/%23zuul/ | Weekly updates: https://etherpad.openstack.org/p/zuul-update-email"14:39
-openstackstatus- NOTICE: The Gerrit outage portion of the current maintenance is complete and the service is back on line, however reindexing for renamed repositories is still underway and some Zuul job fixes are in the process of being applied14:39
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add caching of autohold requests  https://review.opendev.org/66341214:47
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add autohold-info CLI command  https://review.opendev.org/66248714:47
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Record held node IDs with autohold request  https://review.opendev.org/66249814:48
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Auto-delete expired autohold requests  https://review.opendev.org/66376214:50
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Mark nodes as USED when deleting autohold  https://review.opendev.org/66406014:50
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add autohold delete/info commands to web API  https://review.opendev.org/67905714:50
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Auto-delete expired autohold requests  https://review.opendev.org/66376214:52
*** sanjayu_ has quit IRC14:54
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Auto-delete expired autohold requests  https://review.opendev.org/66376215:00
*** jamesmcarthur has joined #zuul15:02
*** hashar has quit IRC15:03
fungizuul-maint: there's another osf newsletter being drafted this week, so if there's anything anyone would like to see included i'm happy to pass it along to the newsletter editors15:05
fungijust let me know15:05
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Mark nodes as USED when deleting autohold  https://review.opendev.org/66406015:07
*** jamesmcarthur has quit IRC15:07
*** openstackgerrit has quit IRC15:08
*** openstackgerrit has joined #zuul15:08
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add autohold delete/info commands to web API  https://review.opendev.org/67905715:08
ShrewsSorry for the rebase noise15:10
* mordred hands Shrews a rebase15:16
Shrewsi still feel like i did something wrong with that rebase15:19
Shrewsespecially since none of those show up on the status page15:20
Shrewsoh, wrong status page  :/15:21
*** mattw4 has joined #zuul15:21
mordredShrews: have you tried turning if off and back on again?15:23
*** themroc has quit IRC15:39
*** jamesmcarthur has joined #zuul15:42
*** jamesmcarthur has quit IRC15:45
*** jamesmcarthur has joined #zuul15:45
*** bhavikdbavishi has quit IRC15:54
*** mattw4 has quit IRC15:58
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Auto-delete expired autohold requests  https://review.opendev.org/66376216:16
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Mark nodes as USED when deleting autohold  https://review.opendev.org/66406016:18
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Add autohold delete/info commands to web API  https://review.opendev.org/67905716:18
*** brendangalloway has joined #zuul16:19
*** rlandy is now known as rlandy|brb16:44
*** sshnaidm|rover is now known as sshnaidm|afk16:49
corvusShrews: comment on https://review.opendev.org/661114 -- that's my only comment on the entire stack.16:55
*** jpena is now known as jpena|off16:58
Shrewscorvus: oops, you are correct about that16:59
corvusShrews: cool, i *thought* it felt like an omission, but wanted to check that there weren't grander plans i didn't see :)16:59
Shrewscorvus: oh, you know what... i think that's done by the zk.deleteHoldRequest() method17:00
Shrewscorvus: here: https://review.opendev.org/#/c/664060/14/zuul/zk.py17:01
Shrewsso the comment is just outdated17:01
Shrewshad to scratch my head on that one... a pretty fundamental thing to miss if i did that!  :)17:02
*** jamesmcarthur has quit IRC17:03
*** brendangalloway has quit IRC17:04
corvusShrews: aha, you're right.  I'll +2 the stack, you want to push one more patch that removes the TODO? :)17:06
Shrewscorvus: yeah, i'll tack it on the end of the stack17:07
corvustristanC: i'll leave the +3 of the autohold-revamp stack to you ^17:07
tristanCgreat, i'll pick the new stack on my test setup and validate it again17:08
openstackgerritMerged zuul/zuul-jobs master: Retry container gets in upload-logs-swift  https://review.opendev.org/68209117:09
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Remove outdated TODO  https://review.opendev.org/68242117:10
ShrewstristanC: i *think* i addressed all of your comments from Friday17:11
*** mattw4 has joined #zuul17:14
Shrewswe could be cruel and force mordred to review that stack since it originated from his random thoughts   :)17:18
AJaegerhe's just back from vacation and full of energy ;)17:18
Shrewsa nice "welcome back" present17:18
*** Goneri has quit IRC17:21
*** jamesmcarthur has joined #zuul17:27
*** rlandy|brb is now known as rlandy17:29
fungihome is where the reviews are17:39
*** themroc has joined #zuul17:58
*** Goneri has joined #zuul18:02
*** jamesmcarthur has quit IRC18:08
openstackgerritTristan Cacqueray proposed zuul/zuul master: zk: use pathlib.Path to define ZooKeeper paths  https://review.opendev.org/68245018:25
*** jamesmcarthur has joined #zuul18:25
*** jamesmcarthur has quit IRC18:25
mordredShrews: yay?18:30
*** hashar has joined #zuul18:42
tristanCShrews: i can't figure out how to make autohold request expired based on nodepool max-hold-age18:49
tristanCShrews: the zuul autohold cli help says that (default: nodepool's max-hold-age if set, or indefinitely), but it's always either infinit, or the value given on the cli18:50
*** hashar has quit IRC18:51
ShrewstristanC: default (which is infinite) is set in nodepool config: https://zuul-ci.org/docs/nodepool/configuration.html#attr-max-hold-age18:51
*** hashar has joined #zuul18:51
*** openstackgerrit has quit IRC18:52
ShrewstristanC: if you change the nodepool default to something else, and it doesn't default to that, that's a bug somewhere (maybe even nodepool)18:52
tristanCShrews: then there may be an issue in zuul.Scheduler.autohold method, because by default it write "0" to node_expiration and the request never expires, even when the nodes have been deleted by nodepool because of max-age18:52
tristanCthus I'm not sure how zuul is supposed to know the nodepool max-hold-age to properly expire its hold request18:53
tristanCperhaps this auto expiration logic should be based on the last held node to transition from "hold" to "deleted"?18:54
ShrewstristanC: i forget off hand how the node expiration logic works (perhaps ask mhu if he's around?)   I have to run off to a doctor appointment, but if you can supply an example of what's not working, I can help dig when I get back.18:56
tristanCShrews: alright, perhaps the issue is not introduced by autohold-revamp and it could be fixed in a follow-up18:57
*** rlandy is now known as rlandy|biab18:59
tristanCShrews: I commented an example in https://review.opendev.org/66376219:01
*** openstackgerrit has joined #zuul19:18
openstackgerritTristan Cacqueray proposed zuul/zuul master: zk: use pathlib.Path to define ZooKeeper paths  https://review.opendev.org/68245019:18
openstackgerritTristan Cacqueray proposed zuul/zuul master: Store a list of held node per held build in hold request  https://review.opendev.org/68246619:18
*** hashar has quit IRC19:20
corvustristanC, Shrews: yeah that's a good point -- it seems like we may want to move the default expiration from nodepool into zuul.  otherwise, there's no way for zuul to have a default value for the *request* expiration.19:29
corvus(it'll just have nodes disappear out from under it, which is fine, but the request list will get cluttered since nothing is ever removed)19:30
*** jamesmcarthur has joined #zuul19:33
*** themroc has quit IRC19:39
*** igordc has joined #zuul19:51
*** mhu has quit IRC19:51
openstackgerritTristan Cacqueray proposed zuul/zuul-sphinx master: Switch to zuul-release-python  https://review.opendev.org/68236619:52
*** rlandy|biab is now known as rlandy19:57
tristanCI didn't +3 the base change of the request-revamp to give another zuul-maint a chance to have a look, otherwise the stack lgtm beside an issue with autohold rest endpoint route which i think should be tenant scoped19:58
tristanCautohold*-revamp19:59
corvustristanC: good catch; i removed my +2 on that.  let's see what Shrews wants to do about the autoexpire before we +w that first one20:00
openstackgerritJames E. Blair proposed zuul/zuul master: Add autogenerated tag to Gerrit reviews  https://review.opendev.org/68247320:02
corvusmordred: ^ another on that stack; we'll probably want to have that in before we start commenting on gerrit gerrit changes or we'll look uncouth.20:03
*** jamesmcarthur has quit IRC20:15
*** jamesmcarthur has joined #zuul20:16
*** hashar has joined #zuul20:17
*** hashar has quit IRC20:17
*** jamesmcarthur has quit IRC20:21
Shrewscorvus: perhaps we should consult with mhu on the node expiration issue since i believe that was his feature. should that prevent the revamp from going in?20:22
tristanCShrews: the revamp doesn't seems to be introducing the issue, it seems like something to be fixed in a follow-up20:23
ShrewstristanC: *nod*... i can see how this effects the auto-expire of the hold request though... i'm not sure how to deal with that right now, tbh20:24
corvusShrews, tristanC: yeah, i'd argue it does introduce the issue and we should resolve it before we merge the stack.20:28
tristanCShrews: iiuc corvus suggested we move the max-hold-age nodepool setting into zuul20:28
corvusbasically, i see the stack as moving the UI for dealing with holds more or less entirely into zuul, which is fine, but we should move the expiration along with it20:28
tristanCunless we make nodepool store the max-hold-age in zookeeper20:29
corvusright, that's an option too, but that's a little weird; i'm not sure if we want to pass configuration info *up*20:29
Shrewsyeah, not sure i like the reverse config dependency either20:30
corvusi think it'd be okay to add a default autohold expiration option to zuul, and then deprecate the one in nodepool  (we don't have to remove it from nodepool immediately -- it was only a default anyway)20:30
Shrewscorvus: So, a new change to add the hold expiration config setting to zuul, and then parent https://review.opendev.org/663762 and its sibilings to that?20:33
Shrewsthen the nodepool deprecation can be handled independently, i suppose20:34
tristanCone the other hand, the current autohold-info output may lists nodes' id that are no longer available. Thus when listing or checking for request-hold expiry, we could check if the actual node still exists, and when they are all gone, then we start the expired_hold_request_ttl timer20:34
tristanCthough, since you can't use autohold feature without zuul, it makes sense that everything autohold related is managed by zuul20:36
ShrewstristanC: that would be too expensive20:38
*** pcaruana has quit IRC20:38
Shrewsright now, we validate hold requests after every build completed event. to add node querying for each of those might be a bit much20:39
tristanCShrews: shouldn't we do that only once current_count >= max_count ?20:41
*** jamesmcarthur has joined #zuul20:45
clarkbjamesmcarthur reminds us that shanghai forum session proposals are open now and end on the 20th. Not sure if we want to do any for zuul? Off the top of my head recent emails and thinking back to denver it might be worth having a zuulv2 -> v3 upgrade session?20:47
fungii'd hoped we wouldn't still be talking about zuul v2 two years later, but...20:55
clarkbya I mean its a thing people keep bringing up... having a semi official "here talk about how to upgrade" might help people?20:56
corvusi'd be happy to participate in that in some way; not sure i should run it.20:57
clarkbya I feel like our move is likely unrepresentative, but I'm also not sure there are any groups that represent typical v2 usage that have done an upgrade yet20:58
fungiyou could have stopped at "'m also20:59
funginot sure there are any groups that represent typical v2 usage"20:59
clarkbfungi: well in my head its people still using Jenkins21:00
corvusit's a range; i've certainly talked to folks who feel they can't live with jenkins plugins.  i've also talked to folks who ran into exactly the same issues we did and as a result of restructuring their jobs in the obvious way, are a stones throw away from being able to just flip the switch.21:00
clarkbwhich we had stopped doing long before upgrading21:00
corvuser, "can't live without jenkins plugins"21:00
corvus(obviously, the second case are the folks who can't live with them)21:00
fungilike, maybe there's some cross-section of folks who all followed the exact same blog and are running essentially the same classes of jobs? that's about as far as "typical" is likely to go21:01
fungiyeah, i guess if you're locked into something like sonotype source code analysis via jenkins plugin or something like that where there's unlikely to be an ansible plugin21:02
fungijavaish stuff21:02
fungithen again, i can't think of any reason ansible couldn't push data into something like that21:04
fungijust would need someone willing to write it21:04
clarkbfungi: likely the biggest barrier is ya that21:04
clarkbanyway thought I would throw the idea out there. I also don't know how many zuulv2 or v3 operators we'll have in shanghai21:05
clarkbI think pabelanger said he won't be there. tristanC ^ would that interest you?21:05
corvusi think the most productive way to look at the summit/forum (is forum summit or ptg now? i can't recall) is in reaching new audiences; this idea seems right on point for that.21:08
tristanCclarkb: I won't be attending in person, but i'd be happy to join remotely if possible21:09
*** panda|ruck has quit IRC21:10
jlkbringing this up again from the weekend. IF we have a night free in ATL to grab dinner, anybody interested in grabbing dinner at  http://theoptimistrestaurant.com/ one of the nights (sunday through tuesday)?21:11
fungii think forum is technically still summit, but some more ptg-ish forum/summit things (like project updates) may have been pushed to the afternoon prior to the ptg. i've not been following the scheduling choices super closely21:12
jlk( fungi already said yes )21:12
fungii am always in the mood to hit up a fish restaurant21:12
clarkbI'd be interested too and have no plans yet21:12
openstackgerritJames E. Blair proposed zuul/zuul master: Use robot_comments in Gerrit  https://review.opendev.org/68248721:13
clarkbre optimist restaurant21:13
clarkblet me try put together and etherpad idea for a zuul forum session and see if others think we should go ahead and propose it21:13
jlkrad21:13
corvusjlk: ++ yes please, and i currently have no social obligations :)21:13
jlkthis is for ansiblefest fwiw21:14
jlkI see there is some talk about ptg/forum21:14
corvuswe will have different fish in shanghai :)21:14
clarkbya my response to jlk was re ansiblefest. I land sunday afternoon21:14
jlkkk21:14
corvussame here21:14
jlksadly I will not be making shanghai. I'd love to go but ...21:15
corvuswell, i arrive atl at 7:15pm, so sunday dinner might be sketchy.21:16
*** panda has joined #zuul21:16
jlksadly I will not be making shanghai. I'd love to go but ...21:17
fungicorvus: just fill up on those delta peanuts21:17
jlkI get in somewhat late on Sunday too, I should have said Monday night through21:17
corvusfungi: i'm on united; i'm hoping for a stroopwafel!21:18
fungioh, heh21:18
fungii didn't realize atl let anyone but delta land there ;)21:18
jlkah I land at 18:30~21:18
* fungi jokes21:18
corvus(though, i think they decided that's a "morning" snack)21:18
paladoxThat's going to be a long flight!21:19
fungiit does take a while to cross the continental usa21:19
clarkbhttps://etherpad.openstack.org/p/zuul-shanghai-forum is a short version of something we might do?21:19
corvusone of the folks at the gerrit hackathon brought stroopwafels.  must have had a suitcase full because we ate a lot and they never ran out.21:20
paladoxyup, around 6-7 hours i think?21:20
fungii can be in paris from here faster than i can get to the west coast21:20
corvus(they were way better than united's)21:20
clarkbpaladox: ya about 5.5 one direction and 6 the other21:20
clarkbpaladox: if direct21:20
paladoxyup21:20
paladox5.5 i think is going back to the US.21:20
fungigranted it takes about the same time to fly across australia too21:21
corvusasia and europe are similar flight times from the western us.  it basically means i never fly less than 10 hours.  :(21:22
clarkbcorvus: tokyo is "only" 9 hours from pdx21:22
paladoxclarkb those times are also for london heathrow term 5 :)21:23
clarkband delta is switching us to haneda from narita in the near future21:23
corvusclarkb: that seems like a good omnibus session.21:23
paladoxcorvus do you get premium econ? Since in economy that would be horrible sitting on that length of flight :(21:27
* fungi is built for basic economy. short legs for the win21:30
paladoxheh21:30
corvuspaladox: i haven't yet :(21:30
paladoxoh :(21:31
corvusfungi: no one is built to sit that long...21:31
fungifair21:31
fungibut business class doesn't really solve that problem either21:31
corvuswell, if you can lie down you're a little less likely to suffer from dvt21:32
paladoxAn hour flight to ireland in august was nice, because it wasen't long :)21:32
jlklying down is good. Getting up to pee due to all the free drinks is good too21:32
fungioh, well yes, lie-flat business class is a thing now i guess21:33
paladoxBA seem to charge for food/drinks depending on ticket. They use M&S simple food.21:33
corvuswow did the image build in https://zuul.opendev.org/t/zuul/build/73068fdb14fa43de8eb864799646bbee/log/job-output.txt#11390  just barely time out?21:36
clarkblooks like it was doing something for another 25 seconds? but ya looks like it21:36
openstackgerritJames E. Blair proposed zuul/zuul master: Use robot_comments in Gerrit  https://review.opendev.org/68248721:37
corvuspaladox: i checked that https://review.opendev.org/682473  will cause the "comments only" switch in polygerrit to hide zuul comments21:38
corvusnow, in openstack, we ran into this thing where people kept asking us why the CI system wasn't doing anything on their changes, and it's because the config was wrong, and zuul reported the error to gerrit, but hideCI was masking that, so we made it so zuul comments weren't hidden...21:39
paladoxawesome!21:39
corvuswe may want to do something more sophisticated there, now that we have options.  like maybe report normal success/failure with "autogenerated:" but report config errors as normal comments...21:40
corvusor, maybe the checks plugin obviates the problem21:40
corvus(since a config error will show up as a big failed check, rather than the absence of anything)21:41
fungithat seems like a reasonable solution to the problem21:41
corvusmy inclination is to go with the intended use of autogenerated to start with and see how it works, and if we find places it doesn't, then change it21:42
corvusmaybe not overthink it to start :)21:42
fungiof course21:42
paladoxI also shared https://review.opendev.org/#/c/682487/1 in #wikimedia-releng21:42
paladoxCome to think of, that patch is all about file comments, not actual comments you leave?21:46
corvuspaladox: 682487 is file/line comments; 682473 is review messages21:47
paladoxah21:47
clarkbcorvus: I'll go ahead and propose the forum session idea tomorrow then. Give people to provide any feedback between now and then21:47
paladoxthanks!21:47
* paladox shares https://review.opendev.org/#/c/682473/21:47
corvuspaladox: i think they are not exclusive, so even a plain line comment that was submitted with an "autogenerated:" tag would still have that.  mostly robot_comments additionally allows you to supply a url and suggested fixes (i think both of those may currently be unused, but folks have plans)21:49
paladoxah, yeh.21:49
paladoxI haven't used the robot comments feature yet.21:49
corvusfrom what i gather (i'm not 100% sure about this) there was also some initial confusion about the intended use of tags; i think that's also how we ended up with 2 potential ways of identifying a CI system line comment (does it have an autogenerated: tag?  does it have a robot_id?).  seems like the best thing to do is both.  :)21:50
paladoxheh21:50
corvusi should make sure that robot comments actually show up in polygerrit.... lemme do that real quick :)21:51
corvuspaladox: yep, this is what they look like: https://imgur.com/a/pOetBlE21:55
corvusit has a little picture of a robot21:55
paladoxAwesome! :)21:55
paladoxi think that's from gr-icon21:55
paladoxor from iron-icon21:55
corvuswe should totally do the same in gertty with https://emojipedia.org/robot-face/21:55
paladox:D21:56
clarkbcorvus: my fontactually has that glyph21:56
corvusso the really big idea with robot comments is that they can supply suggested fixes, and then the gerrit ui would have a button next to each and you can say "apply this one" and it will21:56
clarkbthough hrm screen/weechat seem unhappy with it21:56
clarkb🤖21:57
clarkbweird21:57
fungiyeah, i don't seem to have it for my terminal21:57
corvusaiui that isn't implemented yet, but maybe if we start supplying those with zuul, it would be an impetus for folks to finish that in the ui21:57
clarkbcorvus: that is a neat idea. I guess they would be batched up to cut down on patchsets?21:58
corvusclarkb: yeah, i think it works like editing, so you open an edit session with the first, then close it out after you're done clicking 'fix'21:58
corvusor rather, it *will* work like editing21:58
openstackgerritJames E. Blair proposed zuul/zuul master: Use robot_comments in Gerrit  https://review.opendev.org/68248721:59
*** tosky has quit IRC22:35
*** jamesmcarthur has quit IRC23:37
*** rlandy has quit IRC23:43

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!