Tuesday, 2019-04-09

*** jamesmcarthur has quit IRC01:09
*** bhavikdbavishi has joined #zuul02:56
*** bhavikdbavishi has quit IRC03:21
*** bhavikdbavishi1 has joined #zuul03:21
*** bhavikdbavishi1 is now known as bhavikdbavishi03:23
tobiashSpamapS: I've done only a proof of concept so far with aws but probably will get back to it later this year03:46
tobiashWe'll need real quota handling for aws which will be totally different and challenging because of quota per instane type03:47
tobiashThe static driver is a similar challenge innthis regard because of multi label support03:49
SpamapStobiash: I have some half-done code that will use reservations for quota management.04:10
SpamapStobiash: the idea being that at least we catch instance quotas up front, and not-zuul can't take what we need.04:12
SpamapSAlso, wtf AWS for not having an API for limits.04:13
SpamapSAlso kind of want to add spot price capability04:28
SpamapSseems like it could save a lot of money since most of the time jobs will be entirely interruptible.04:28
*** bjackman_ has joined #zuul04:30
*** bjackman__ has joined #zuul04:35
*** bjackman_ has quit IRC04:37
*** bjackman_ has joined #zuul04:39
*** bjackman__ has quit IRC04:41
*** quiquell|off is now known as quiquell|rover05:43
*** pcaruana has joined #zuul06:30
*** snapiri has quit IRC06:33
*** quiquell|rover is now known as quique|rover|brb06:41
*** quique|rover|brb is now known as quiquell|rover07:13
*** jangutter has quit IRC07:15
*** jangutter_ has joined #zuul07:15
*** SpamapS has quit IRC07:15
*** shanemcd has quit IRC07:16
*** shanemcd has joined #zuul07:16
*** SpamapS has joined #zuul07:17
*** sshnaidm|off is now known as sshnaidm|pto07:23
*** gtema has joined #zuul07:23
*** themroc has joined #zuul07:46
*** jpena|off is now known as jpena07:47
*** frickler has quit IRC07:58
*** frickler has joined #zuul07:59
mhuHello08:09
*** johanssone has quit IRC08:18
*** johanssone has joined #zuul08:24
*** zbr has quit IRC08:28
*** hashar has joined #zuul08:54
*** bhavikdbavishi1 has joined #zuul09:28
*** bhavikdbavishi has quit IRC09:29
*** bhavikdbavishi1 is now known as bhavikdbavishi09:29
*** electrofelix has joined #zuul09:41
bjackman_mordred, Any chance you could take a look at https://review.openstack.org/#/c/649900/ ?09:42
bjackman_It's the fix for the gerrit<->Zuul trigger bug I was looking into last week09:43
*** yolanda_ has quit IRC09:47
*** bhavikdbavishi has quit IRC10:35
*** zbr has joined #zuul11:08
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] admin REST API: docker-compose PoC, frontend  https://review.openstack.org/64353611:12
*** jpena is now known as jpena|lunch11:37
*** quiquell|rover is now known as quique|rover|eat12:07
*** hashar has quit IRC12:07
*** hashar has joined #zuul12:08
*** bhavikdbavishi has joined #zuul12:09
*** jamesmcarthur has joined #zuul12:17
*** hashar has quit IRC12:24
*** jpena|lunch is now known as jpena12:29
*** rlandy has joined #zuul12:32
*** rlandy is now known as rlandy|ruck12:32
*** jamesmcarthur has quit IRC12:34
*** openstackgerrit has quit IRC12:44
*** quique|rover|eat is now known as quiquell|rover12:44
*** bjackman_ has quit IRC12:48
*** jamesmcarthur has joined #zuul12:50
*** openstackgerrit has joined #zuul12:58
openstackgerritMerged openstack-infra/zuul-jobs master: Allow user to set ara_report_executable  https://review.openstack.org/64877312:58
*** jamesmcarthur has quit IRC13:04
*** hashar has joined #zuul13:19
*** quiquell|rover is now known as quiquell|off14:38
*** jamesmcarthur has joined #zuul14:47
*** hashar has quit IRC15:09
*** bjackman has joined #zuul15:21
*** bjackman_ has joined #zuul15:22
*** gtema has quit IRC15:23
*** bjackman has quit IRC15:26
*** jamesmcarthur has quit IRC15:42
*** bjackman_ has quit IRC15:48
ShrewsSpamapS: omg https://review.openstack.org/642964 is giving me a headache trying to merge that16:01
Shrewsall the faulty/racey tests are finding you  :(16:03
*** jamesmcarthur has joined #zuul16:05
clarkbzuulians, I'd like to approve https://review.openstack.org/#/c/650968/ now. If we see that that breaks the jobs on ipv4 I am 100% ok with a revert16:07
clarkbmostly pointing that out here so that people know they can revert it immediately without hurting any feelings if we see that it breaks16:08
clarkbwith that out of the way /me +A's16:08
Shrewsclarkb: which repos could that impact? just zuul and nodepool?16:09
clarkbShrews: and some opendev stuff for gitea16:09
clarkbI am not aware of anyone else using it yet16:10
Shrewsah right16:10
clarkbunfortunately there isn't a good way to test it and its relatively new and its broken anyway16:10
clarkbjust not 100% broken16:10
Shrewsyup16:10
*** themroc has quit IRC16:14
*** jamesmcarthur has quit IRC16:23
openstackgerritMerged openstack-infra/zuul-jobs master: Use /etc/hosts with docker registries to handle ipv6  https://review.openstack.org/65096816:23
*** bjackman_ has joined #zuul16:26
openstackgerritClark Boylan proposed openstack-infra/zuul master: Don't cache wheels in dockerfile  https://review.openstack.org/65132216:29
clarkbShrews: ^ I don't know if that is something we actualyl want to merge, but it seemed like it was possibly such a thing and should cause us to run through the docker image build system16:30
*** bjackman_ has quit IRC16:34
clarkbhrm we may have to approve that change (then immediately unapprove it) so that it goes into the gate?16:34
clarkbI don't think the check job pushes the image16:34
electrofelixbattling with centos 7 and proxy settings is enough to basically make me go, this is not a sensible approach to be messing around with when it requires learning how someone elses deployment approach works16:40
electrofelixoops, sorry wrong room16:40
*** jamesmcarthur has joined #zuul16:45
mordredelectrofelix: it's ok - i'm sure we all agree with you anyway :)16:48
electrofelixshould I mention how proxies are the bane of my life...16:49
*** jpena is now known as jpena|away16:50
SpamapSShrews: that whole kubernetes library seems like a fault.16:56
*** electrofelix has quit IRC16:58
clarkbShrews: mordred http://logs.openstack.org/17/650917/1/gate/zuul-upload-image/555d041/job-output.txt.gz#_2019-04-09_16_48_39_33229417:03
clarkbI think that must be an order of operations thing?17:04
clarkbexcept that use-buildset-registry is the previous role17:04
mordredclarkb: oh. well, that's unfortunate17:04
clarkbhttp://logs.openstack.org/17/650917/1/gate/zuul-upload-image/555d041/job-output.txt.gz#_2019-04-09_16_48_24_974566 and the same task worked there?17:04
* Shrews returns from lunch17:05
clarkbok the task that failed ran on localhost17:06
clarkbthe one that succeeded ran on ubuntu-bionic17:06
clarkbI'm guessing that 1) we can't edit /etc/hosts on localhost at all even if that condition didn't break and 2) we don't set buildset_registry on localhost?17:07
clarkbok I see the bug for why it didn't load17:07
clarkbmeaning I know how to fix 2) but I don't have any quick ideas for 1)17:07
clarkbconsidering that I'll push a revert, then propose a change that fixes 2) but leave it WIP until we understand 1)17:08
Shrewslocalhost is going to be the executor there i guess?17:09
Shrewsi need to get a mental map of that entire process in my head first, i think17:09
clarkbyup. Thinking about it more we load these roles from a trusted context so we may be able to edit /etc/hosts17:09
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Revert "Use /etc/hosts with docker registries to handle ipv6"  https://review.openstack.org/65133217:10
clarkbI'll work on a followup that deals with 2)17:10
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Revert "Revert "Use /etc/hosts with docker registries to handle ipv6""  https://review.openstack.org/65133417:13
clarkbif we decide that 651334 will work because the roles run from a trusted context and can edit /etc/hosts I can remove the revert in the middle. But I don't know enough about zuul to be sure about that17:14
* Shrews is a bit uneasy about mucking around with the executor's host file, especially since simultaneous jobs could attempt to edit it at the same time17:19
clarkbShrews: it'll be the hosts file in the container.17:20
clarkbthough if that isn't mounted rw it will fail17:20
Shrewsoh, that's different indeed17:20
* clarkb digs up the zuul bwrap command17:20
clarkbhrm we don't really have that written down in a singple place17:23
clarkbShrews: '--ro-bind', '/etc/hosts', '/etc/hosts',17:26
clarkbwe won't be able to modify that file17:26
clarkbso my change doesn't work as is yet. I'll WIP it with a comment about that ro-bind17:27
clarkbthinking about options here, its possible that we don't need to do the aliasing on the localhost tasks because the localhost tasks run skopeo17:37
clarkband if skopeo accepts the ipv6 address literal those bits may just work as is. It is annoying that we'd have to do different setups in different places though17:38
clarkbOther options include giving each bwrap container its own writeable /etc/hosts file17:38
clarkbFixing docker (whcih I've filed a bug for)17:38
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Fix race with test_provider_removal unit test  https://review.openstack.org/65133917:41
openstackgerritMerged openstack-infra/zuul-jobs master: Revert "Use /etc/hosts with docker registries to handle ipv6"  https://review.openstack.org/65133217:42
clarkbwhere the skopeo stuff gets weird is we appear to use a docker config with the skopeo command17:42
clarkbso to be extra careful we shouldn't write out a docker config that docker itself can't use17:42
*** jpena|away is now known as jpena17:43
*** jpena is now known as jpena|off17:53
*** rlandy|ruck is now known as rlandy|ruck|hw18:19
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Only alias registries on build nodes  https://review.openstack.org/65135318:51
clarkbShrews: mordred ^ thats a cleanup that only runs the /etc/host aliasing where we run docker commands (basically on the test ndoes) and not on localhost where we skopeo18:51
clarkbif skopeo handles ipv6 properly this may work18:51
* mordred worships skopeo18:52
clarkbthat makes the roles slightly less general purpose18:53
clarkband assumes skopeo doesn't also have broken cli parsing18:54
clarkbalso we may want to squash that into the revert revert to ensure we don't merge what we know is broken but I think the diff reads a bit better this way so you can see what I've removed18:54
*** jamesmcarthur has quit IRC18:55
*** hashar has joined #zuul19:15
*** jamesmcarthur has joined #zuul19:21
*** pwhalen has quit IRC19:21
fungianybody had any interaction with the easystack folks scheduled to give this presentation in denver? https://www.openstack.org/summit/denver-2019/summit-schedule/events/23249/best-practice-to-run-zuul-on-kubernetes20:13
fungiseems like they may have been working on a solution in a vacuum, but it's hard to tell just from an abstract20:13
Shrewsclarkb: changes seem sensible, though maybe we should squash after it's been reviewed20:14
clarkbShrews: ya I think it should be squashed20:14
clarkbok really getting lunch now20:14
Shrewsfungi: i seem to recall a similar presentation by them (I at least remember them dev'ing in a vacuum part) at the last summit. I thought corvus was going to speak with them at that time, but maybe that didn't happen... or I'm misremebering20:16
*** jamesmcarthur has quit IRC20:17
mordredShrews, fungi: yeah - corvus and I chatted with them a bit at the end of their talk20:17
mordredin vancouver20:17
*** jamesmcarthur has joined #zuul20:18
fungineat. looks like track chairs enjoyed it so much they've approved a rerun20:18
Shrewsmordred: and did that chat go something like "hey, we seem to be working on the same things. let's cooperate kplzthx?"  :)20:19
mordredShrews: dude. that was a year ago20:21
mordredShrews: you have so much more faith in my powers of memory20:22
Shrewsmordred: apologies. i'll do my best to exhibit less faith in you going forward   :)20:25
*** rlandy|ruck|hw is now known as rlandy|ruck20:27
*** pcaruana has quit IRC20:31
*** pcaruana has joined #zuul20:33
*** pcaruana has quit IRC20:36
*** pcaruana has joined #zuul20:39
*** jamesmcarthur has quit IRC20:44
*** jamesmcarthur has joined #zuul20:45
*** pcaruana has quit IRC20:47
*** SpamapS has quit IRC21:10
*** SpamapS has joined #zuul21:11
*** jamesmcarthur has quit IRC21:11
SpamapSI kind of have a crazy idea for a zuul feature to help with github. People like it when zuul comments on PR's because it provides them with an email notification. But the comments are super noisy. I wonder if we could make Zuul hide its own comments (there's a way to do it in the GH UI, I assume it has an API)21:17
funginot that crazy i suppose. we do something similar on our gerrit to hide comments from our zuul (and other ci systems)21:20
fungithough not implemented from the zuul end21:20
clarkbI think as long as you can toggle them open like our gerrit shim does21:20
clarkbwould be a great feature21:20
clarkbShrews: mordred should I got ahead and squash the two changes together or are you still needing to review them in the slightly nicer diff setup?21:21
fungiyeah, i like being able to view those comments under certain circumstances, but hiding them by default helps to pick out discussion with actual humans21:21
SpamapSBasically I think we could just add an action to take on success/fail/start that is "hide my comments" or "show my comments"21:22
SpamapSBecause ideally what would happen is when checks pass, it hides all the old fails.21:23
clarkbI know what I can do, push a third change that is the squash of the other two then WIP those other two for reviewing21:44
* clarkb does this21:44
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Only alias registries on build nodes  https://review.openstack.org/65139321:45
clarkbShrews: mordred ^ there is the squash. I'll link the other two changes there and wip them21:45
*** jamesmcarthur has joined #zuul22:03
*** hashar has quit IRC22:08
*** jamesmcarthur has quit IRC22:42
*** jamesmcarthur has joined #zuul22:52
*** jamesmcarthur has quit IRC23:03
*** jamesmcarthur has joined #zuul23:06
*** rlandy|ruck is now known as rlandy23:06
*** rlandy has quit IRC23:09
*** jamesmcarthur has quit IRC23:14
*** jamesmcarthur has joined #zuul23:30
*** jamesmcarthur has quit IRC23:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!