Monday, 2019-04-08

*** jamesmcarthur has joined #zuul00:03
*** jamesmcarthur has quit IRC00:08
*** jamesmcarthur has joined #zuul00:12
*** jamesmcarthur has quit IRC00:16
pabelangerianw: so, how can I have DIB do a noop on an image? for example01:17
pabelangerELEMENTS_PATH=`pwd` /opt/venv/nodepool-3.5.0/bin/disk-image-create -x -n --no-tmpfs -o test.qcow2 vyos01:17
pabelangervyos elements contain operating-system and no-final-image01:17
pabelangerhowever, DIB errors out01:18
pabelangerhttp://paste.openstack.org/show/748979/01:18
ianwpabelanger: ummm, you don't want a complete no-op like the fake builder?01:18
pabelangerright01:18
pabelangerI don't want to do anything with the existing image, just have DIB rename it to the value that nodpeool-builder passes01:18
pabelangerbecause this is a network vendor image01:19
pabelangerI'm using cloud-images now, but really want diskimages, so nodepool can handle the uploads for me01:19
ianwahh, yeah i was going to say that sounds like a case for a pre-existing image01:19
ianwcan you run that with -x ?  but i don't think this case has ever been considered at all from dib's pov01:20
pabelangeryah, 1 sec01:20
pabelangerhttps://pastebin.com/raw/sVXjSKqx01:21
pabelangerSo, I'm thinking 2 options, 1 is to expose builder command into diskimages section, so I can replace diskimage-builder with a fake sh script, this is how our testing works.01:21
pabelangerOr maybe we add a cloudimages section, along side diskimages, which just does the upload part01:22
ianwyeah, you're into https://git.openstack.org/cgit/openstack/diskimage-builder/tree/diskimage_builder/lib/common-functions#n340 which is assuming we've mounted and are in a chroot01:24
ianwi feel like the cloudimages idea sounds very reasonable.  basically you have a .qcow2 from somewhere else and nodepool manages it from there01:26
pabelangerianw: cool, thanks. I'll bounce the idea off Shrews, otherwise I think adding support for packer is something I am going to do. The vendor image is build using that, then I could have nodepool-builder do it today.01:27
pabelangerhowever, zuul-job, SSH to nodepool-builder is how I am planning on doing it right now01:28
ianwyeah different building backends seems useful ...01:30
SpamapSJust allowing the command and args to be configured would be ideal. most builders aren't as compositional as dib.. so it should all fit into the current abstraction.01:33
pabelangerAgree01:34
pabelangerNice!01:36
pabelangerhttps://logs.zuul.ansible.com/25/25/dc2cad281a0f75068db0db74a956aa5ae92bf81e/check/vyos-test/fcde131/01:37
pabelangerthat is a vyos node!01:37
pabelangermind you, it doesn't have python27, only python2601:37
pabelangerbut nodepool launched it01:37
pabelangerYay01:37
*** irclogbot_3 has quit IRC01:44
pabelangerokay, neat. Using job.host-vars I can set ansible_python_interpreter01:46
pabelangerit would be kinda neat, if I could do that under nodesets directly... but for now, what I got :D01:46
pabelangerI'll deal with rest tomorrow01:47
*** edmondsw_ has quit IRC01:48
*** jamesmcarthur has joined #zuul01:50
clarkbwouldnt it be better to uplosd the image yourself and tell nodepool about it if the image isnt being updated?02:02
clarkbotherwise nodepool will reupload it everyday02:02
clarkband telling nodepool about a new image isnt much different than telling a cloud?02:03
ianwclarkb: yeah, i mean i was kind of assuming you were pulling in an image frequently, and wanted nodepool to manage just keeping the latest versions02:14
clarkbya I guess dib could pull from a known location that updates and act as ashuttle02:15
ianwyeah, that was pabelanger's initial point i guess; but dib has a bunch of checks that are assuming it's got a chroot with the image open02:16
ianwi mean, we could just have a DIB_DO_NOTHING=1 flag and basically turn it into a cp ... but it seems a bit odd02:16
clarkbor justrun no elements and let dib chroot then make a newfile?02:16
clarkbits less efficient but should work?02:17
clarkbkindalike the ubuntu element or centos element? justdont run anything more?02:17
ianwyeah, but if you're opening the incoming qcow2, making it into a chroot and the repacking it, and outputting what you hope is the same .qcow2 it seems ... a little crazy.02:19
clarkbya you may end up with a different filesystem or other unexpected changes too02:22
*** bhavikdbavishi has joined #zuul02:23
*** jamesmcarthur has quit IRC03:03
*** raukadah is now known as chandankumar03:14
*** bhavikdbavishi has quit IRC03:47
*** bhavikdbavishi has joined #zuul03:47
*** bjackman has joined #zuul03:56
*** bhavikdbavishi has quit IRC04:13
*** pcaruana has joined #zuul04:49
*** pcaruana has quit IRC04:55
*** bhavikdbavishi has joined #zuul04:58
*** bhavikdbavishi1 has joined #zuul04:58
*** bhavikdbavishi has quit IRC05:02
*** bhavikdbavishi1 is now known as bhavikdbavishi05:02
*** jamesmcarthur has joined #zuul05:05
*** jamesmcarthur has quit IRC05:06
*** jamesmcarthur has joined #zuul05:06
*** jamesmcarthur has quit IRC05:10
*** snapiri has joined #zuul05:14
*** quiquell|off is now known as quiquell|rover06:05
*** AJaeger has quit IRC06:06
bjackmanWhen Zuul runs ansible, ~/.ansible/tmp gets created in the zuul user's home directory on the test node (i.e. not on the executor itself but on the remote host of the ansible run). Anyone know why that might be?06:10
*** AJaeger has joined #zuul06:10
bjackmanThe only reference I can find to that path is that it's the default for the local_tmp ansible param. But that is a path on the local host (executor) not the test node IIUC. Also it is always overridden by the ansible.cfg created by the executor server.06:11
bjackmanAh, sorry, scratch that, there's "remote_tmp" as well06:15
*** quiquell|rover is now known as quique|rover|brb06:22
*** snapiri has quit IRC06:28
*** snapiri has joined #zuul06:29
*** pcaruana has joined #zuul06:30
*** sshnaidm|off is now known as sshnaidm06:53
*** themroc has joined #zuul06:59
*** quique|rover|brb is now known as quiquell|rover07:01
*** gtema has joined #zuul07:09
*** gtema has quit IRC07:33
*** gtema has joined #zuul07:44
*** jangutter has joined #zuul07:49
*** yolanda_ has joined #zuul07:52
*** jpena|off is now known as jpena07:54
*** bjackman_ has joined #zuul08:11
*** yolanda_ has quit IRC08:11
*** yolanda_ has joined #zuul08:11
*** bjackman has quit IRC08:14
sshnaidmI have an error: "Unexpected templating type error occurred on ({{ zuul.items|list }}): 'builtin_function_or_method' object is not iterable"  - is zuul.items a list? How do I get its "items"?08:27
*** badboy has quit IRC08:30
*** hashar has joined #zuul08:49
*** yolanda_ has quit IRC09:09
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine  https://review.openstack.org/64088409:19
*** tobberydberg has joined #zuul09:29
sshnaidmtristanC, mhu any ideas? ^^09:31
tristanCsshnaidm: iiuc, zuul.items is already a list, so you don't have to use the |list filter09:35
mhusshnaidm, is that what you're looking for? https://zuul-ci.org/docs/zuul/user/jobs.html?highlight=variables#var-zuul09:35
mhuyep, more precisely: https://zuul-ci.org/docs/zuul/user/jobs.html?highlight=variables#var-zuul.items09:35
mhutristanC is right09:36
sshnaidmmhu, tristanC when I do "debug: var=zuul.items " it shows me "<built-in method items of dict object at 0x7f68ed28da08>"09:42
tristanCsshnaidm: that's odd, where is that happening?09:50
sshnaidmtristanC, http://logs.rdoproject.org/09/20009/8/check/tripleo-ci-reproducer-fedora-28-libvirt-standalone-dryrun/396111c/job-output.txt.gz09:55
tristanCsshnaidm: it seems like rejectattr produces a generator10:06
*** yolanda_ has joined #zuul10:11
tristanCsshnaidm: it seems like you could use json_query instead to filter zuul.items10:12
tristanCsshnaidm: oh I know, zuul.items get's interpreted as the "items" function of zuul, you should try zuul["items"] instead10:16
sshnaidmtristanC, ack10:16
*** yolanda_ has quit IRC10:38
*** electrofelix has joined #zuul10:48
*** yolanda_ has joined #zuul10:48
quiquell|rovertristanC: A Depends-On to Depends-On: gnocchixyz/gnocchi/pull/995 is correct ?10:54
quiquell|rovertristanC: it's a configured github project10:54
quiquell|rovertristanC: or do I have to preprend github.com ?10:54
tristanCquiquell|rover: the new Depends-On syntax needs complete url10:54
quiquell|rovertristanC: ack so https://github.com/gnocchixyz/gnocchi/pull/99510:55
tristanCquiquell|rover: yes10:55
quiquell|rovertristanC: thanks10:55
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine  https://review.openstack.org/64088411:02
*** bhavikdbavishi has quit IRC11:02
*** hashar has quit IRC11:18
*** hashar has joined #zuul11:19
*** jpena is now known as jpena|lunch11:27
*** rfolco has joined #zuul11:33
*** bhavikdbavishi has joined #zuul11:43
*** pcaruana has quit IRC11:47
pabelangerianw: clarkb: Yah, I wouldn't want DIB to modify the qcow2 image, until I had something in the actually install.d phase11:56
*** rlandy has joined #zuul11:57
ianwpabelanger: oh, are you likely to *have* something in the install phase?11:57
*** quiquell|rover is now known as quique|rover|eat11:57
ianwi was really imaging a situation where the image came from a remote daily build or similar, which would bake in any modifications there11:58
*** rlandy is now known as rlandy|ruck12:02
*** edmondsw has joined #zuul12:04
*** jamesmcarthur has joined #zuul12:17
*** jpena|lunch is now known as jpena12:22
pabelangerianw: no, I don't expect install phase for this image12:29
*** jamesmcarthur has quit IRC12:30
*** pcaruana has joined #zuul12:38
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine  https://review.openstack.org/64088412:39
*** quique|rover|eat is now known as quiquell|rover12:40
*** jamesmcarthur has joined #zuul12:48
*** gtema has quit IRC12:49
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Add zuul_debug_info_enabled role setting  https://review.openstack.org/65088012:53
*** Shrews has quit IRC12:56
*** quiquell|rover is now known as quique|rover|bbl12:57
*** gtema has joined #zuul12:57
*** Shrews has joined #zuul12:58
*** bjackman_ has quit IRC13:01
*** pwhalen has joined #zuul13:03
pabelangerzuul-jobs-core: I'd love a review on https://review.openstack.org/650880/13:21
pabelangeradds a toggle to zuul_debug_info task13:21
tristanCpabelanger: speaking of toggle, could you please re-review https://review.openstack.org/63262013:28
AJaegerpabelanger: left a suggestion for the README file13:28
*** gtema has quit IRC13:29
*** bhavikdbavishi has quit IRC13:30
*** pcaruana has quit IRC13:31
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint  https://review.openstack.org/64109913:34
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry  https://review.openstack.org/64240813:34
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Add zuul_debug_info_enabled role setting  https://review.openstack.org/65088013:35
pabelangerAJaeger: fixed13:36
*** pcaruana has joined #zuul13:36
pabelangertristanC: looking13:36
pabelangertristanC: +1, left comment about adding a warning13:40
pabelangerI'll defer to others to approve13:40
*** quique|rover|bbl is now known as quiquell|rover13:51
fungiosf board of directors meeting is underway: https://wiki.openstack.org/wiki/Governance/Foundation/8April2019BoardMeeting14:12
fungikata containers presentation for potential oip confirmation is going on now, zuul's should be starting shortly14:13
pabelangerfungi: do you happen to know dialin info?14:13
clarkbpabelanger: let me find a link for you14:14
pabelangerlink to zoom doesn't seem to show it14:14
pabelanger(without downloading something first)14:14
pabelangerclarkb: thanks14:14
fungidial in numbers are available: https://zoom.us/zoomconference14:14
clarkbhttps://wiki.openstack.org/wiki/Governance/Foundation/8April2019BoardMeeting has the zoom "room" number and ^ has the POTS numbers14:14
pabelangerthanks14:15
clarkb(we should really put the POTS contact info on the wiki)14:15
fungithe conference id is the string of numbers at the end of the zoom url, so 957498070514:15
*** themroc has quit IRC14:15
* fungi is dialled in by phone, for the record, doesn't trust the zoom client/browser plug-in14:15
clarkbfungi: worried another excavator will find that fiber line?14:16
pabelangerokay, connected. Thanks14:16
fungiyou never kjnow14:16
fungibut no, by "trust" i mean i am unwilling to let it execute on my computers14:17
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint  https://review.openstack.org/64109914:19
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry  https://review.openstack.org/64240814:19
pabelangerzuul-jobs-core: I'd also like a review on https://review.openstack.org/648773/ to expose ara_executable path, which is an additional change on top of our recent zuul-executor venv path fixes14:30
clarkbpabelanger: do we still need that if the venv is exposed?14:32
clarkb(maybe we need a doc update that says 'you can put python tools into the virtualenv and they will be available to the executor')14:32
dmsimardpabelanger: I'm curious about the use case14:32
dmsimardis ara not installed in the expected location ?14:33
pabelangerclarkb: right, once we release zuul, it will be fixed. However, I'm currently blocked on a zuul release, which I am unsure when the next one will be. This is my way to get it working now14:33
pabelangerdmsimard: see https://review.openstack.org/64942714:34
pabelangerclarkb: dmsimard: however, that doesn't seem to fix ara getting loaded by zuul-executor, as not in path. So that won't 100% fix my issue, since databae isn't created14:37
dmsimardpabelanger: I guess this doesn't work: https://opendev.org/openstack-infra/zuul/src/branch/master/zuul/executor/server.py#L40-L4314:41
dmsimardif ara is installed in the venv and not for the zuul executor proper14:42
dmsimardI guess you should be able to tell if the executor is able to find the callback by looking at the generated ansible.cfg file https://opendev.org/openstack-infra/zuul/src/branch/master/zuul/executor/server.py#L1748-L176614:43
pabelangerdmsimard: right, doing a test now14:45
pabelangeron 3.7.1, I don't have ara loaded as callback14:45
pabelangerwant to make sure 3.8.0 has is14:46
*** dkehn has joined #zuul14:52
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Assert ara database is loaded from ansible venv  https://review.openstack.org/65091714:58
pabelangerdmsimard: ^confirmed to be working14:59
pabelangertobiash_: ^15:00
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint  https://review.openstack.org/64109915:07
ShrewsI need someone to merge this nodepool change plz  https://review.openstack.org/65038515:13
clarkbShrews: I can look when monty is done talking15:14
Shrewsk, thx15:15
*** bhavikdbavishi has joined #zuul15:15
openstackgerritPaul Belanger proposed openstack-infra/zuul master: [WIP] Set focus on xtem.js to terminal  https://review.openstack.org/65027515:20
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry  https://review.openstack.org/64240815:28
*** rfolco is now known as rfolco|lunch15:29
fungimonty holds a semaphore lock on our conscious thought processes15:32
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Set focus on xtem.js to terminal  https://review.openstack.org/65027515:32
pabelangertobiash_: ^should set focus() properly now15:32
* mordred releases the lock15:44
*** quiquell|rover is now known as quiquell|off15:50
*** rfolco|lunch is now known as rfolco15:58
*** rlandy|ruck is now known as rlandy16:03
Shrewshim, i don't think our new registry jobs are very ipv6 friendly: http://logs.openstack.org/85/650385/3/gate/nodepool-upload-image/c7a0c31/job-output.txt.gz#_2019-04-08_15_54_03_02254916:06
Shrewss/him/hrm/    curse autocorrect16:06
mordredShrews: yes - there is an ipv6 issue with the registry jobs on the ipv6-only clouds - there is a patch up from corvus but he didn't want to land it and then go on vacation16:12
clarkbwe should land that now and watch it16:13
mordredoh - it landed16:13
mordredhttps://review.openstack.org/#/c/650473/16:13
clarkbok cool so we may have more debugging to do16:13
clarkbthat actually looks like a docker bug16:13
mordredare the nodepool jobs using the roles? ah - awesome16:13
clarkbwe may be the first people to try and ipv6 with docker16:13
mordredheh16:13
clarkbif you look at the rror it escaped the ipv6 addr so that it could :5000 and have a proper "url"16:14
clarkbexcept docker doesn't do real urls and I'm sure that means they aren't parsing the ipv6 properly16:14
clarkbis there some other method of escpae?16:14
clarkbfungi: ^ you may know16:14
fungi[]16:15
clarkbfungi: ya that is what we've done "[2607:ff68:100:54:f816:3eff:fe7c:e98a]:5000/zuul/nodepool:latest" is not a valid repository/tag: invalid reference format16:15
fungiahh, that's the traditional method of escaping for an address+port url16:16
clarkbyup16:16
mordredstellar16:16
clarkbmakes me think docker is broken16:16
fungiwhere "broken" might mean they were unaware of convention and invented their own syntax16:17
mordredor quite simply haven't had anyone attempt to push an image to a local ipv6-only registry that doesn't  have a hostname16:17
fungiyes, also entirely possible16:18
logan- /etc/hosts to the rescue16:18
clarkblogan-: ya that may be our best option16:18
clarkbas well as filing a bug with docker16:18
fungithe technical term is an "address literal"16:19
fungiietf rfc 273216:21
*** manjeets has joined #zuul16:22
*** bhavikdbavishi has quit IRC16:25
pabelangerwith PTL out this week, is it safe to say no zuul release this week?16:25
mhupabelanger, when does it start?16:26
fungiprobably better to defer, though if there's something which needs an urgent release to fix then i wouldn't say it's definite16:26
pabelangermhu: PTL out? IIRC, vacation started Saturday16:27
fungiremember, our project leader has no additional rights over other zuul maintainers, only additional responsibilities. if we need a release we can make one happen even when he's taking a much-needed break16:27
mhuthx16:27
mhuoh, I misread, I thought you meant the Denver Summit16:28
pabelangerfungi: not right now, as I have to run to appointment, but maybe we could discuss the idea of beta / RC releases, up to pypi. Most of the tooling today for us depends on getting zuul from pypi, not that it could be changed to consume from git, but really trying to run the released versions of zuul / nodepool.16:29
fungithe denver summit starts monday april 2916:29
fungipabelanger: cool, that sounds like a less urgent thing which we shouldn't decide to start doing on very little notice anyway16:30
pabelangerfungi: agree, not this week for sure16:30
pabelangerokay, afk for a bit16:31
fungii would advise starting an ml thread about it16:31
pabelanger+116:31
fungiwhen you have time16:31
clarkbfungi: pabelanger note that the general process has been to update openstack-infra/opendev's zuul to the current commit and run it for a day or two to check there aren't any major issues16:37
clarkbopenstack-infra/opendev is currently running 3.7.016:38
clarkb(says zuul status page)16:38
clarkband with the openstack release this week we probably don't want to update zuul today through thursday16:38
clarkbso ya I don't expect a release this week if we want to stick to that burn in process16:38
fungiwell, at least through wednesday16:43
fungithursday is probably fair game but would be nice to keep things reasonably stable in case of any day-after emergencies16:43
clarkbya iirc even after the move to wednesday for the bulk of the work we've tried to keep thursday sane for stragglers16:44
*** jpena is now known as jpena|off16:45
*** bhavikdbavishi has joined #zuul16:47
openstackgerritMerged openstack-infra/nodepool master: Fix race in test_handler_poll_session_expired  https://review.openstack.org/65038517:21
*** jamesmcarthur_ has joined #zuul17:46
*** jamesmcarthur has quit IRC17:49
*** electrofelix has quit IRC17:54
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Use /etc/hosts with docker registries to handle ipv6  https://review.openstack.org/65096818:16
clarkbShrews: fungi mordred logan- ^ that takes the use /etc/hosts idea and runs with it18:16
clarkbI may be overapplying the /etc/hosts edits (like multiple times in a single role as an example. I haven't looekd closely enough to see if it is safe to do it less often)18:17
fungiyeah, that is a lot of duplication, but can be simplified once proven to work18:19
clarkbthe use of regex there should mean it is idempotent if over eager18:19
*** Shrews has quit IRC18:20
*** Shrews has joined #zuul18:20
pabelangerclarkb: yah, I wouldn't want to change that process of opendev update to zuul commit for actually release. But, my brain is thinking, with a beta / rc, that might also provide additional info to our release process too, since opendev can't catch all the use cases.18:20
*** gundalow has quit IRC18:20
*** dcastellani has quit IRC18:20
*** PrinzElvis has quit IRC18:20
*** dcastellani has joined #zuul18:21
*** PrinzElvis has joined #zuul18:21
*** gundalow has joined #zuul18:21
pabelangerI'm trying real hard not to get into the process of backporting patches to some packaging tool , and right now pypi is my source of truth for zuul18:21
clarkbpabelanger: why not use git?18:22
pabelangerand, for the most part, this isn't an issue. We've generally been good a doing zuul releases when asked for one18:22
pabelangerclarkb: I'd need to have build tools on servers to build the wheel, right now I don't have everything installed on the server18:23
*** AJaeger has quit IRC18:27
*** sshnaidm is now known as sshnaidm|off18:38
*** AJaeger has joined #zuul18:40
*** jamesmcarthur_ has quit IRC19:04
*** bhavikdbavishi has quit IRC19:11
*** hashar has quit IRC19:12
*** hashar has joined #zuul19:13
fungiwe could start publishing prebuilt wheels too i suppose, if that's desired19:22
fungi(for branch tip)19:22
*** jamesmcarthur has joined #zuul19:34
*** jamesmcarthur_ has joined #zuul19:35
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Use /etc/hosts with docker registries to handle ipv6  https://review.openstack.org/65096819:37
clarkbhopefully that passes linting now19:38
*** jamesmcarthur has quit IRC19:39
*** jamesmcarthur_ has quit IRC19:45
Shrewsclarkb: looks pretty good to me. maybe we should have a zuul or nodepool review depend on it and recheck until it hits an ipv6 enabled host?19:50
clarkbShrews: I don't think that will work because the jobs that use the role are in a trusted repo20:02
clarkbotherwise that would be ++ good20:02
Shrewsclarkb: oh right20:02
*** jamesmcarthur has joined #zuul20:11
Shrewsclarkb: testing the ipaddr filter you use there... i cannot get that to ever be 'true'.  http://paste.openstack.org/show/749024/20:18
Shrewsmaybe i'm testing that wrong?20:19
clarkbshrews according to the docs if you give it an ipv4 or ipv6 address you get it back out the other sidr anything else results in false20:21
logan-good catch Shrews20:22
clarkbmaybe it is broken or the bool filter isnt what we want to get string to true20:22
Shrewsthat second line of the paste doesn't show that   :(20:22
logan-{{ true if '127.0.0.1' | ipaddr else false }} works20:22
clarkbcould compare the input to itself instead of |bool == trye20:23
clarkbaddr | ipaddr == addr20:23
logan-that would probably break with v6 depending on address compression20:24
logan-when: "{{ (true if '127.0.0.1' | ipaddr else false) | bool }}"20:24
Shrewswe could use the ipv6() alias and just modify hosts for those values20:24
logan-(strike the {{ }} since it is a conditional)20:25
*** pcaruana has quit IRC20:25
clarkbI dont want ipv6 to be different20:26
clarkbwill make testing the general case harder20:26
Shrews*nod*20:26
clarkbdoes when: addr | ipaddr work?20:29
mordredwhen the moon is full?20:29
mordredclarkb: https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters_ipaddr.html20:30
mordredclarkb: it says when used by itself it's true if it's an ipaddr, false if not20:30
clarkbit says it returns the input value if true20:33
mordredoh.yeah - fair20:34
mordredalso - we can use jinja filters in when: conditions?20:34
mordredclarkb: oh - but a value is going to evaluate to true ina  when20:35
mordredand it'll be false if it's not one20:35
clarkbmordred: ok that was what I wasn't sure on20:35
mordredso when: foo | ipaddr _should_ work20:35
clarkbso when: addr | ipaddr should be fine then20:35
mordredyeah20:35
mordredother than verifying that we can use jinja on when lines20:36
clarkband when: not ( addr | ipaddr ) ?20:36
clarkbI'm pretty sure you can it is implicit jinja in when20:36
mordredyeah. one would assume20:36
mordredcool20:36
logan-not ('google.com' | ipaddr) lgtm20:36
logan-and '127.0.0.1'20:37
Shrewsah 'when' is the magic there, then20:37
logan-even without the when, it seems like $ ansible localhost -m debug -a msg="{{ not ('127.0.0.1' | ipaddr) }}" evaluates differently than with the bool filter20:38
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Use /etc/hosts with docker registries to handle ipv6  https://review.openstack.org/65096820:41
clarkbI think ^ should address it now20:41
Shrewsyeah, that makes sense to me20:47
Shrewsclarkb: ^^20:47
Shrewsthx20:48
clarkband thank you for reviewing it :)20:49
mordredclarkb: +2 from me too - but I'm not going to +3 it because I'm AFK in a few minutes21:01
mordred+3 at will21:01
clarkbok that might be a tomorrow item for me as I've buiilt up quite the backlog of things to do already today21:01
pabelangerif people are doing reviews, https://review.openstack.org/650275 is a minor improvement to xterm.js for non-mouse users.  Sets focus so our pgup/pgdn keys work, otherwise need to clicked xterm.js first21:02
* mordred wishes he had pgup/pgdn keys still21:10
mordredpabelanger: +2 from me21:11
pabelangerthanks!21:12
pabelangerSo, not directly a zuul question, but does anybody know why ansible process would be killed with signal? specifically SIGPIPE?21:13
clarkbpabelanger: with the current code if I click in the xterm window and then pgup/pgdown it doesn't page for me21:13
clarkbnow to test your chnage21:13
pabelangerever so often I get the following failures: https://logs.zuul.ansible.com/periodic-1hr/github.com/ansible-network/windmill-config/master/windmill-config-deploy/8715067/bastion/ara-report/result/49493489-9d84-4637-9375-ad44cba0ad17/21:13
pabelangerclarkb: shift+pgup?21:13
clarkboh do I need shift?21:13
clarkbheh I guess it really is an xterm21:14
pabelangeryah, I need that for chrome21:14
clarkbya its because that is the xterm behavior :)21:14
pabelanger+121:14
clarkbhttps://github.com/docker/distribution/blob/749f6afb4572201e3c37325d0ffedb6f32be8950/reference/regexp.go#L18 is why docker push fails on that ipv6 addr fwiw21:35
clarkbI'm working on filing a bug now so that we don't forget and hopefully in the future we can drop the /etc/hosts hack21:35
openstackgerritMerged openstack-infra/zuul-jobs master: Add retries to promote-docker-image  https://review.openstack.org/64491121:41
SpamapStobiash_: wondering if you've done much with the AWS driver. The lack of respect for max-servers means every time we get busy, we get NODE_FAILURE storms.22:06
* SpamapS struggling to get back to the update to the driver22:07
SpamapSAlso wondering if there's a way to make those failures more retryable.22:07
openstackgerritMerged openstack-infra/zuul master: Set focus on xtem.js to terminal  https://review.openstack.org/65027522:09
clarkbSpamapS: by default they should be retried 3 times per provider22:10
clarkbthough maybe that is provider specific? I know that is what the openstack driver does22:10
SpamapSclarkb: yes, they are retried 3 times, fairly rapidly (1s pause) and then fail.22:14
SpamapSI'd prefer that they just give back the request.22:14
SpamapSBut guessing there's some problem with that.22:14
SpamapSThe problem I have is that there's a per-region max-instances, and when we hit it.. #FAIL22:14
clarkbwhy not implement max-servers in the aws driver?22:15
clarkbseems like that would be the best thing22:15
SpamapSthat's what I have to do22:15
SpamapSwith all the time I don't have, it should be simple. ;)22:15
SpamapSAlso it will have other problems I'd like to figure out. I have a provider-per-AZ, but there's a regional max. Sometimes AZ's run out of instance types, so I'd prefer a single provider, with a single max-servers, and some kind of retry-on-another-az logic.22:16
*** tobiash_ has quit IRC22:17
clarkbhttps://github.com/moby/moby/issues/39033 is the docker bug22:19
clarkbthere is a chance that a minor update to the regex would fix this, but I don't really feel like being responsible for sorting that out. I guess I could write the regex update and ask them to shepherd from there22:19
*** tobiash has joined #zuul22:21
clarkbmordred: Shrews logan- on my change one thing we should keep in mind is it may affect the ipv4 jobs22:28
clarkbwhich is why i didn't just merge it considering "its already broken"22:28
clarkbbut I'll try to approve that tomorrow morning and watch it from there22:28
*** persia has quit IRC22:30
*** persia has joined #zuul22:31
*** hashar has quit IRC23:02
*** mgoddard has quit IRC23:14
*** mgoddard has joined #zuul23:15
*** jamesmcarthur has quit IRC23:22
*** rlandy has quit IRC23:52
*** jamesmcarthur has joined #zuul23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!