| *** lhcheng has quit IRC | 00:06 | |
| *** uck has quit IRC | 00:17 | |
| *** sripriya has quit IRC | 00:20 | |
| *** sripriya has joined #tacker | 00:39 | |
| *** sripriya_ has joined #tacker | 00:40 | |
| *** bobh has quit IRC | 00:43 | |
| *** sripriya has quit IRC | 00:43 | |
| *** bobh has joined #tacker | 00:50 | |
| *** bobh has quit IRC | 01:00 | |
| *** sripriya_ has quit IRC | 01:04 | |
| *** sripriya has joined #tacker | 01:06 | |
| *** prashantD_ has quit IRC | 01:13 | |
| *** sripriya_ has joined #tacker | 01:23 | |
| *** sripriya__ has joined #tacker | 01:25 | |
| *** sripriya has quit IRC | 01:27 | |
| *** sripriya_ has quit IRC | 01:28 | |
| *** sripriya__ has quit IRC | 01:30 | |
| *** santoshk has quit IRC | 01:30 | |
| *** bobh has joined #tacker | 02:15 | |
| *** bobh has quit IRC | 02:33 | |
| *** bobh has joined #tacker | 02:37 | |
| *** bobh has quit IRC | 02:38 | |
| *** bobh has joined #tacker | 02:40 | |
| openstackgerrit | caoyue proposed openstack/tacker: Replace string format arguments with function parameters https://review.openstack.org/312340 | 02:46 |
|---|---|---|
| *** bobh has quit IRC | 02:59 | |
| *** lhcheng has joined #tacker | 03:04 | |
| *** gongysh has joined #tacker | 03:30 | |
| *** sripriya has joined #tacker | 04:14 | |
| *** vishnoianil has quit IRC | 04:52 | |
| *** lhcheng has quit IRC | 05:28 | |
| *** manikanta_tadi has joined #tacker | 05:28 | |
| *** sripriya has quit IRC | 05:36 | |
| *** tbh has joined #tacker | 05:45 | |
| *** sbalakri has joined #tacker | 05:45 | |
| *** openstackgerrit has quit IRC | 06:03 | |
| *** openstackgerrit has joined #tacker | 06:03 | |
| *** janki has joined #tacker | 06:06 | |
| *** tbh has quit IRC | 06:34 | |
| *** vishnoianil has joined #tacker | 07:20 | |
| *** janki has quit IRC | 07:25 | |
| *** dmk0202 has joined #tacker | 07:57 | |
| *** dmk0202 has quit IRC | 08:03 | |
| *** tbh has joined #tacker | 08:04 | |
| *** mbound has joined #tacker | 08:10 | |
| *** dmk0202 has joined #tacker | 08:11 | |
| *** vishnoianil has quit IRC | 08:15 | |
| *** tbh_ has joined #tacker | 08:26 | |
| *** tbh has quit IRC | 08:27 | |
| *** gongysh has quit IRC | 08:27 | |
| *** tbh_ has quit IRC | 08:31 | |
| *** tbh has joined #tacker | 08:35 | |
| *** tbh_ has joined #tacker | 08:39 | |
| *** tbh has quit IRC | 08:40 | |
| *** tbh_ has quit IRC | 08:44 | |
| *** tbh has joined #tacker | 09:10 | |
| *** manikanta_tadi has quit IRC | 09:33 | |
| *** vishnoianil has joined #tacker | 09:39 | |
| *** manikanta_tadi has joined #tacker | 09:46 | |
| *** amotoki has quit IRC | 10:10 | |
| *** amotoki has joined #tacker | 10:11 | |
| *** tbh has quit IRC | 10:36 | |
| *** manikanta_tadi has quit IRC | 10:47 | |
| *** manikanta_tadi has joined #tacker | 10:59 | |
| *** tbh has joined #tacker | 11:03 | |
| *** tbh has quit IRC | 11:37 | |
| *** brucet has quit IRC | 11:41 | |
| *** brucet has joined #tacker | 12:07 | |
| *** brucet has quit IRC | 12:19 | |
| *** sbalakri has quit IRC | 12:32 | |
| *** sbalakri has joined #tacker | 12:33 | |
| *** manikanta_tadi has quit IRC | 12:50 | |
| *** sbalakri has quit IRC | 12:56 | |
| *** mbound has quit IRC | 12:59 | |
| *** sbalakri has joined #tacker | 13:16 | |
| *** bobh has joined #tacker | 13:18 | |
| *** srwilkers has joined #tacker | 13:21 | |
| *** mbound has joined #tacker | 13:28 | |
| *** openstackgerrit has quit IRC | 13:47 | |
| *** openstackgerrit has joined #tacker | 13:48 | |
| *** sbalakri has quit IRC | 14:17 | |
| *** mageshgv has joined #tacker | 14:38 | |
| *** srwilkers has quit IRC | 14:42 | |
| *** mbound has quit IRC | 15:03 | |
| *** lhcheng has joined #tacker | 15:06 | |
| *** mbound has joined #tacker | 15:09 | |
| *** srwilkers has joined #tacker | 15:16 | |
| *** sbalakri has joined #tacker | 15:18 | |
| *** dmk0202 has quit IRC | 15:38 | |
| *** sridhar_ram has joined #tacker | 15:48 | |
| *** tbh has joined #tacker | 15:51 | |
| *** uck has joined #tacker | 15:54 | |
| *** sbalakri has quit IRC | 15:55 | |
| *** lhcheng has quit IRC | 15:56 | |
| *** lhcheng has joined #tacker | 15:56 | |
| *** janki91 has joined #tacker | 16:24 | |
| *** srwilkers has quit IRC | 16:31 | |
| *** sridhar_ram1 has joined #tacker | 16:31 | |
| *** sridhar_ram has quit IRC | 16:33 | |
| *** sbalakri has joined #tacker | 16:34 | |
| *** twm2016 has joined #tacker | 16:36 | |
| *** tbh has quit IRC | 16:37 | |
| *** tbh has joined #tacker | 16:37 | |
| *** sbalakri has quit IRC | 16:40 | |
| *** uck has quit IRC | 16:45 | |
| *** uck has joined #tacker | 16:46 | |
| twm2016 | Hey guys, I'm doing a mox to mock refactor. Any idea on why I would be getting this error? http://paste.openstack.org/show/496158/ | 16:53 |
| twm2016 | - The error is unrelated to the MyUrlComparer and mox.ContainsKeyValue | 16:53 |
| twm2016 | because I've already replaced those and have the same error. It seems to be tacker specific, my idea is that it is not returning the client I want. | 16:54 |
| *** igordcar1 has quit IRC | 16:56 | |
| *** igordcard has joined #tacker | 16:57 | |
| twm2016 | would it be better if I upload a patch set and label it as WIP? | 17:01 |
| *** janki91 has quit IRC | 17:01 | |
| *** mbound has quit IRC | 17:01 | |
| *** janki91 has joined #tacker | 17:02 | |
| *** mbound has joined #tacker | 17:02 | |
| *** srwilkers has joined #tacker | 17:11 | |
| *** prashantD has joined #tacker | 17:12 | |
| *** sripriya has joined #tacker | 17:13 | |
| *** zeih has joined #tacker | 17:18 | |
| *** srwilkers has quit IRC | 17:24 | |
| *** srwilkers has joined #tacker | 17:26 | |
| *** mbound has quit IRC | 17:27 | |
| *** mbound has joined #tacker | 17:28 | |
| *** mbound has quit IRC | 17:28 | |
| *** lhcheng has quit IRC | 17:31 | |
| *** lhcheng has joined #tacker | 17:31 | |
| *** zeih has quit IRC | 17:37 | |
| *** srwilkers has quit IRC | 17:46 | |
| *** vishwanathj has joined #tacker | 17:48 | |
| *** janki91 has quit IRC | 17:51 | |
| sripriya | bobh: ping | 17:54 |
| bobh | sripriya: pong | 17:54 |
| sripriya | bobh: for vdu key injection, i see that heat translator already supports that, can we add that parameter directly into tosca template? | 17:56 |
| sripriya | bobh: i'm referring to the parameter key_name | 17:57 |
| sripriya | bobh: any clue if tosca interprets it the same way or does it have its own name for the property? | 17:57 |
| bobh | sripriya: so TOSCA has no concept of a key_name property on Compute, but tosca-parser and heat-translator will support it either as a parameter passed into the template or as a property | 17:58 |
| bobh | sripriya: so if we updated the VDU.Tacker definition with a key_name property, it would work | 17:59 |
| bobh | sripriya: I think the same holds true for user_data - if we define it as a property of VDU.Tacker it should get passed into the Heat Server defintion | 17:59 |
| *** sbalakri has joined #tacker | 17:59 | |
| *** srwilkers has joined #tacker | 18:00 | |
| sripriya | bobh: what do you mean by parameter vs property? what is the difference? | 18:00 |
| bobh | a property is defined in the TOSCA data model, where a parameter is passed in at instantiation - generally a parameter will map to a property using get_param, but key_name is a special case in heat-translator where it will add the property to Compute even though the data model does not have a key_name property defined | 18:03 |
| *** lhcheng has quit IRC | 18:04 | |
| *** lhcheng has joined #tacker | 18:04 | |
| *** vishnoianil has quit IRC | 18:05 | |
| bobh | sripriya: the TOSCA data model - obvously the HOT data model has a key_name | 18:05 |
| sripriya | bobh: thanks for clarifying! | 18:06 |
| bobh | sripriya: np | 18:06 |
| sripriya | bobh: so we just go ahead and add this property to VDU.Tacker and not worry if TOSCA data model supports it or not.. | 18:07 |
| bobh | sripriya: right - it will pass through - by adding it to VDU.TAcker we are adding it to the TOSCA data model via inheritance | 18:08 |
| bobh | sripriya: or whatever the opposite of inheritance is | 18:10 |
| *** lhcheng has quit IRC | 18:11 | |
| *** lhcheng has joined #tacker | 18:11 | |
| sridhar_ram1 | bobh: sripriya: I'm glad we have this option of implementing TOSCA that is practical to deploy using Tacker by overlaying on top on "normative" tosca-nfv node_types... | 18:18 |
| sridhar_ram1 | bobh: sripriya: ... the concern I've, we are missing minor version in tacker tosca template to track these "enhancements" .. any thoughts ? | 18:19 |
| *** sridhar_ram1 is now known as sridhar_ram | 18:20 | |
| *** sbalakri has quit IRC | 18:24 | |
| *** tbh has quit IRC | 18:24 | |
| *** manikanta_tadi has joined #tacker | 18:27 | |
| bobh | sripriya: good question | 18:28 |
| bobh | sripriya: I was thinking we might need a point release on the version at some point | 18:28 |
| sridhar_ram | bobh: I'm going to assume that's the reply to my question :) | 18:33 |
| sridhar_ram | bobh: tosca template has this "tosca_definitions _version: tosca_simple_profile_for_nfv_1_0" | 18:33 |
| bobh | sridhar_ram: oops | 18:33 |
| sridhar_ram | bobh: beyond that .. it supports "metadata:" where a version is typically captured.. mostly for the template itself (say 2.0 of CSR1000V VPN network service descriptor) | 18:34 |
| sridhar_ram | bobh: I'm wondering we need a bit more authoritative version identifier that Tacker can "enforce" | 18:35 |
| manikanta_tadi | sridhar_ram bobh sripriya : Hi All, Please review the patch https://review.openstack.org/#/c/295207/ | 18:36 |
| sridhar_ram | for e.g. (thinking out aloud here): within metadata introduce "tacker_tosca_version: 0.4.0" and have a version burnt in the tacker server so that we can do some validation and say software with tacker_tacker_version 0.4.0 will reject a template with tacker_tosca_version: 0.5.0 | 18:37 |
| sridhar_ram | manikanta_tadi: sure, will add it to my queue | 18:38 |
| manikanta_tadi | sridhar_ram : Thanks ! | 18:38 |
| bobh | sridhar_ram: that's adding another level of complexity and validation - your call if you think it's necessary | 18:40 |
| sridhar_ram | bobh: I know it is an order of complexity.. wondering if there are simpler solutions to enforce. | 18:40 |
| bobh | sridhar_ram: I guess it depends on how often it would change - once per cycle would be ok, more than that might be problematic | 18:41 |
| sridhar_ram | bobh: I'm okay to take what is reasonable.. even once per cycle... | 18:42 |
| sridhar_ram | this is the scenario I'd like to avoid (for the user community)... | 18:43 |
| sridhar_ram | .. they install mitaka tacker and throw a Newton template with ffg / nsd and tacker fails with some cryptic traceback and error mesg... | 18:43 |
| sridhar_ram | .. instead would prefer to error out telling the tosca template version is unsupported | 18:44 |
| bobh | sridhar_ram: it would fail to load the vnfd because tosca-parser would fail - we could clean up that exception handling to make it more clear what the exact problem is, if we don't already | 18:45 |
| sridhar_ram | bobh: would be able to differentiate between malformed TOSCA template vs a template with unsupported node-types ? | 18:47 |
| bobh | sridhar_ram: I think so - tosca-parser is pretty good about specifying the problem, at least in most cases - we would have to try it and see | 18:47 |
| sridhar_ram | bobh: okay.. in general, I like this idea of solving this by better exception handling... cost is low.. will go ahead and write an RFE after some more homework | 18:48 |
| bobh | sridhar_ram: I think the data model is going to be changing a lot so I'm a little reluctant to add another layer of validation to it, though I can see the benefits | 18:49 |
| sridhar_ram | bobh: in fact that frequent change in the data model is what bothers me ... it is support nightmare. | 18:51 |
| bobh | sridhar_ram: welcome to NFV... | 18:51 |
| sridhar_ram | bobh: :) | 18:53 |
| bobh | sridhar_ram: if it is mostly additions versus changes (like IP_address to address) we should be OK - it's the updates to existing data structures that hurt | 18:54 |
| sridhar_ram | bobh: yep | 18:55 |
| *** srwilkers has quit IRC | 19:06 | |
| *** srwilkers has joined #tacker | 19:08 | |
| openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Developers guide for functional tests https://review.openstack.org/246183 | 19:10 |
| openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Developers guide for functional tests https://review.openstack.org/246183 | 19:12 |
| *** vishnoianil has joined #tacker | 19:15 | |
| *** srwilkers has quit IRC | 19:28 | |
| *** zeih has joined #tacker | 19:30 | |
| *** srwilkers has joined #tacker | 19:34 | |
| *** manikanta_tadi has quit IRC | 19:36 | |
| *** srwilkers has quit IRC | 19:44 | |
| *** srwilkers has joined #tacker | 19:50 | |
| *** zeih has quit IRC | 19:56 | |
| *** srwilkers has quit IRC | 19:59 | |
| *** uck has quit IRC | 20:06 | |
| *** srwilkers has joined #tacker | 20:14 | |
| *** srwilkers has quit IRC | 20:17 | |
| *** dmk0202 has joined #tacker | 20:29 | |
| sridhar_ram | trozet: ping | 20:51 |
| *** srwilkers has joined #tacker | 20:56 | |
| *** srwilkers has quit IRC | 20:57 | |
| *** amotoki has quit IRC | 20:58 | |
| *** mbound has joined #tacker | 21:01 | |
| *** uck has joined #tacker | 21:06 | |
| *** uck has quit IRC | 21:11 | |
| *** mbound has quit IRC | 21:24 | |
| openstackgerrit | Trevor McCasland proposed openstack/python-tackerclient: WIP: mox to mock refactor https://review.openstack.org/313165 | 21:35 |
| twm2016 | ^ just uploaded a patch I had a few questions about | 21:36 |
| twm2016 | actually just one question | 21:36 |
| sripriya | twm2016: hello | 21:43 |
| openstackgerrit | Merged openstack/tacker: Replace string format arguments with function parameters https://review.openstack.org/312340 | 21:48 |
| twm2016 | sripriya: Hi! So test_cli10.MyUrlComparator in vm/test_cli10_vim.py inherits from mox but I was told I only need refactor the tests inside the vm folder. Do you think I should refactor test_cli10.py too or create a separate file to replace the mox functions? | 21:52 |
| twm2016 | - I'm worried the other files that use it may suffer from the changes. That's why I suggested the latter option. | 21:54 |
| sripriya | twm2016: IMO, it is better we do it in the main file test_cli10.py, let us not make it complex by introducing new files for handling mox functons | 21:58 |
| *** bobh has quit IRC | 21:58 | |
| sripriya | twm2016: i understand that test_cli10 is used by several files, but they should be fine to use the refactored method | 21:59 |
| twm2016 | sripriya: Okay, I'll work on that. My idea of refactoring was to paste the source code of the mox classes into the file. The classes are pretty small to begin with. | 22:01 |
| sripriya | twm2016: what do you mean by 'pasting source code of mox classes'? | 22:02 |
| sripriya | twm2016: BTW to clarify your question on running tests within vm folder, yes right now tests inside vm dir. are the only ones that are executed, however that should not stop us from refactoring the common code base from which they inherit | 22:06 |
| sripriya | twm2016: that is also a reminder we need to refactor our unit tests code base to remove unused files/tests, i will go ahead and create a RFE for this | 22:10 |
| twm2016 | sripriya: The classes I was talking about were small classes that aren't really mox specific, they implement simple operators like and __ne__ __eq__, but I'll work around them. Thanks for creating a RFE I'll be working on this more. | 22:12 |
| *** mageshgv has quit IRC | 22:15 | |
| sripriya | twm2016: thank you. appreciate your contribution, i will assign the RFE to you, feel free to ping if you need any help | 22:17 |
| *** twm2016 has quit IRC | 22:17 | |
| *** sripriya has quit IRC | 22:52 | |
| *** zeih has joined #tacker | 22:57 | |
| *** zeih has quit IRC | 23:01 | |
| *** uck has joined #tacker | 23:08 | |
| *** vishnoianil has quit IRC | 23:08 | |
| *** uck has quit IRC | 23:13 | |
| *** santoshk has joined #tacker | 23:25 | |
| *** sripriya has joined #tacker | 23:29 | |
| *** sridhar_ram has quit IRC | 23:37 | |
| *** lhcheng has quit IRC | 23:41 | |
| *** dmk0202 has quit IRC | 23:42 | |
| *** bobh has joined #tacker | 23:51 | |
| *** santoshk has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!