*** prashantD_ has quit IRC | 00:21 | |
*** mageshgv has joined #tacker | 00:40 | |
*** mageshgv has quit IRC | 00:54 | |
*** uck has quit IRC | 01:07 | |
openstackgerrit | Sripriya Seetharam proposed openstack/tacker: Add multisite VIM usage guide https://review.openstack.org/312297 | 01:41 |
---|---|---|
*** sripriya has quit IRC | 01:46 | |
*** vishwanathj has quit IRC | 01:48 | |
*** lhcheng has joined #tacker | 03:01 | |
*** mageshgv has joined #tacker | 04:26 | |
openstackgerrit | Merged openstack/tacker: Fix mutable default arguments https://review.openstack.org/310178 | 04:44 |
*** mageshgv has quit IRC | 04:56 | |
*** janki has joined #tacker | 05:01 | |
openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Adding vnf testcase with monitoring with new tosca template https://review.openstack.org/300248 | 05:08 |
*** mageshgv has joined #tacker | 05:17 | |
*** mageshgv has quit IRC | 05:23 | |
*** tbh_ has joined #tacker | 05:44 | |
*** vishnoianil has quit IRC | 05:58 | |
*** vishnoianil has joined #tacker | 05:58 | |
*** tbh_ has quit IRC | 06:10 | |
*** openstackgerrit has quit IRC | 06:17 | |
*** openstackgerrit has joined #tacker | 06:18 | |
*** vishnoianil has quit IRC | 06:26 | |
*** lhcheng has quit IRC | 06:35 | |
openstackgerrit | caoyue proposed openstack/tacker: Replace string format arguments with function parameters https://review.openstack.org/312340 | 07:00 |
*** vishnoianil has joined #tacker | 07:13 | |
*** zeih has joined #tacker | 07:21 | |
openstackgerrit | caoyue proposed openstack/tacker: Clean redundant argument to dict.get https://review.openstack.org/312352 | 07:49 |
*** tbh has joined #tacker | 07:49 | |
openstackgerrit | caoyue proposed openstack/tacker: Replace string format arguments with function parameters https://review.openstack.org/312340 | 07:54 |
*** dmk0202 has joined #tacker | 07:54 | |
*** mbound has joined #tacker | 08:11 | |
*** thatsdone has joined #tacker | 08:15 | |
*** thatsdone has quit IRC | 08:26 | |
*** zeih has quit IRC | 08:43 | |
*** tbh has quit IRC | 08:45 | |
*** zeih has joined #tacker | 08:55 | |
*** thatsdone has joined #tacker | 08:56 | |
openstackgerrit | caoyue proposed openstack/tacker: Correcting net-mgmt to net_mgmt in sample template files https://review.openstack.org/312390 | 08:57 |
*** thatsdone has quit IRC | 08:59 | |
*** zeih has quit IRC | 09:12 | |
*** tbh has joined #tacker | 09:20 | |
*** zeih has joined #tacker | 09:25 | |
*** tbh_ has joined #tacker | 09:27 | |
*** tbh has quit IRC | 09:28 | |
*** mbound has quit IRC | 09:35 | |
*** zeih has quit IRC | 09:35 | |
*** fxpester has quit IRC | 09:43 | |
*** mbound has joined #tacker | 09:51 | |
*** tbh_ has quit IRC | 09:57 | |
*** dmk0202 has quit IRC | 09:59 | |
*** tbh has joined #tacker | 10:01 | |
*** tbh has quit IRC | 10:04 | |
*** tbh has joined #tacker | 10:05 | |
*** zeih has joined #tacker | 10:20 | |
*** janki has quit IRC | 10:33 | |
*** tbh has quit IRC | 10:50 | |
*** tbh has joined #tacker | 11:18 | |
*** tbh has quit IRC | 11:30 | |
*** tbh has joined #tacker | 11:37 | |
*** mbound has quit IRC | 11:42 | |
*** tbh has quit IRC | 11:44 | |
*** fxpester has joined #tacker | 11:49 | |
*** bobh has joined #tacker | 12:12 | |
*** mbound has joined #tacker | 12:16 | |
*** bobh has quit IRC | 12:25 | |
*** trozet has quit IRC | 12:46 | |
*** trozet has joined #tacker | 13:03 | |
*** mageshgv has joined #tacker | 13:16 | |
*** sbalakri has joined #tacker | 13:24 | |
*** tbh has joined #tacker | 13:25 | |
*** bobh has joined #tacker | 13:26 | |
*** tbh has quit IRC | 13:28 | |
*** trozet_ has joined #tacker | 13:28 | |
*** trozet has quit IRC | 13:30 | |
*** trozet_ is now known as trozet | 13:30 | |
*** mbound has quit IRC | 13:54 | |
*** mbound has joined #tacker | 13:55 | |
*** sbalakri has quit IRC | 13:57 | |
*** trozet has quit IRC | 13:57 | |
*** trozet has joined #tacker | 13:58 | |
*** mbound has quit IRC | 14:08 | |
*** vishnoianil has quit IRC | 14:12 | |
*** dmk0202 has joined #tacker | 14:14 | |
*** zeih has quit IRC | 14:14 | |
*** vishnoianil has joined #tacker | 14:24 | |
*** Ravikiran_K has joined #tacker | 14:27 | |
*** mbound has joined #tacker | 14:29 | |
*** dmk0202 has quit IRC | 14:33 | |
*** zeih has joined #tacker | 14:33 | |
*** mbound has quit IRC | 14:34 | |
*** zeih has quit IRC | 14:36 | |
*** zeih has joined #tacker | 14:36 | |
*** mbound has joined #tacker | 14:53 | |
*** zeih has quit IRC | 15:00 | |
*** manikanta_tadi has joined #tacker | 15:34 | |
*** amotoki has joined #tacker | 16:02 | |
*** prashantD has joined #tacker | 16:10 | |
*** uck has joined #tacker | 16:11 | |
*** manikanta_tadi has quit IRC | 16:22 | |
*** mbound has quit IRC | 16:23 | |
*** sridhar_ram has joined #tacker | 16:24 | |
*** bobh has quit IRC | 16:48 | |
*** bobh has joined #tacker | 16:49 | |
*** Ravikiran_K has quit IRC | 16:49 | |
*** tbh has joined #tacker | 16:57 | |
*** sripriya has joined #tacker | 17:10 | |
*** vishnoianil has quit IRC | 17:11 | |
sridhar_ram | trozet: sripriya: just caught up to your chat yesterday.. my 2c, I think it is a good idea to show the chains & classifiers realized in the underlying layers to the Tacker users (using the show-vnffg api, perhaps using a --details flag). | 17:20 |
sridhar_ram | trozet: sripriya: this is similar to how we want to show all the underlying resources created beneath the heat stack - VDU -> VMs, ports, etc | 17:21 |
*** tbh has quit IRC | 17:22 | |
sripriya | sridhar_ram: sure, my concern is do we want to have a separate API to show chain and classifiers or can they be part of vnffg resource? | 17:25 |
sridhar_ram | sripriya: it should be against the vnffg resource and the response might list chains / classifiers | 17:26 |
sripriya | sridhar_ram: right now there are separate APIs show_chain, show_classifier and show_nfp, out of those nfp is the only resource that is associated with vnffg_id | 17:29 |
sridhar_ram | sripriya: IMO they need to wrap around under vnffg .. | 17:31 |
sripriya | sridhar_ram: hmmm ok | 17:33 |
*** manikanta_tadi has joined #tacker | 17:44 | |
manikanta_tadi | Hi All, Please review the patch https://review.openstack.org/#/c/295207/ | 17:46 |
bobh | sripriya: Are the chains and classifiers "sub-resources" of the vnffg? i.e. GET /vnffg/123456/chain or GET /vnffg/13456/classifier ? | 17:57 |
sripriya | bobh: yes, but with current spec we would be doing GET /chain/123456 and GET /classifier/123456 | 18:00 |
sripriya | here 123456 refers to chain id/ classifier id | 18:00 |
bobh | sripriya: ok - is the vnffg endpoint included in that or are they separate resources? | 18:01 |
sripriya | bobh: AFAIK they are separate resource with their own APIs | 18:01 |
sripriya | bobh: i implied that from this method call show_chain | 18:02 |
bobh | sripriya: ok - just wondering if they should be modeled separately or if they are dependent on a vnffg | 18:02 |
bobh | sripriya: if the chains/classifiers can exist without a vnffg, or if they can be shared across vnffgs, then keeping them separate is appropriate | 18:03 |
*** twm2016 has joined #tacker | 18:03 | |
bobh | sripriya: if they can't exist without a vnffg and are unique to a vnffg, then maybe they should be modeled as sub-resources of vnffg | 18:03 |
sripriya | bobh: even though they are modelled separately in the backend vnffg_id are foreign keys in their respective tables, so they are part of vnffg | 18:03 |
sripriya | bobh: this was the thought i had yesterday and discussed with trozet | 18:04 |
twm2016 | sripriya, I have a quick question | 18:04 |
* bobh scrolling back to find the conversation.... | 18:05 | |
sripriya | bobh: with current spec, the chain and classifier resources on the API are independent resources and not associated with vnffg_id, so i left a comment on the spec if it needs to be included as EOD they are part of vnffg | 18:05 |
bobh | sripriya: thanks - I'll look at the spec again and comment if needed | 18:06 |
twm2016 | or maybe someone else can answer - when refactoring unit tests from mox to mock, are we only concerned with the vm unit tests? | 18:06 |
twm2016 | I'm referring to this bug, https://bugs.launchpad.net/tacker/+bug/1572706 | 18:07 |
openstack | Launchpad bug 1572706 in tacker "refactor mox references to use the mock library in pythontackerclient" [Low,New] - Assigned to Tin Lam (tl3438) | 18:07 |
sripriya | bobh: sure. thanks | 18:07 |
sripriya | manikanta_tadi: hi!, i see tox failures for all jobs on the patch, did you happen to run tox locally and fix the errors? | 18:09 |
*** vishnoianil has joined #tacker | 18:10 | |
sripriya | twm2016: isn't unit tests the only place where mox is used? did i understand your question right? | 18:10 |
twm2016 | Take a look here http://paste.openstack.org/show/496126/ | 18:11 |
manikanta_tadi | sripriya, Hi! I am working to fix those errors | 18:11 |
twm2016 | All the tests that tox runs are in that output. I tried running a test_shell unit test and it failed. | 18:11 |
twm2016 | So does that mean the refactoring should be done with those in the paste? | 18:12 |
sripriya | twm2016: right now, unit tests under the vm dir. are the only ones that are tested as you pointed. to answer to your question, yes, those are the ones that needs to be refactored | 18:14 |
twm2016 | thank you! | 18:14 |
sripriya | twm2016: sure np | 18:15 |
sripriya | manikanta_tadi: cool, feel free to ping us if you need any help with fixing those errors | 18:16 |
*** uck has quit IRC | 18:17 | |
manikanta_tadi | sripriya: Sure, Thanks ! | 18:17 |
*** tbh has joined #tacker | 18:26 | |
openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker-horizon: Display VNF instance details in Tacker Horizon GUI https://review.openstack.org/295207 | 18:47 |
*** vishwanathj has joined #tacker | 18:50 | |
*** manikanta_tadi has quit IRC | 19:15 | |
*** uck has joined #tacker | 19:17 | |
*** lhcheng has joined #tacker | 19:22 | |
*** tbh has quit IRC | 19:23 | |
*** uck has quit IRC | 19:23 | |
*** mbound has joined #tacker | 19:29 | |
openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Developers guide for functional tests https://review.openstack.org/246183 | 19:40 |
*** openstackgerrit has quit IRC | 19:48 | |
*** openstackgerrit has joined #tacker | 19:48 | |
*** dmk0202 has joined #tacker | 20:14 | |
*** brucet has joined #tacker | 20:32 | |
*** santoshk has joined #tacker | 21:07 | |
*** uck has joined #tacker | 21:12 | |
*** brucet has quit IRC | 21:13 | |
*** mbound has quit IRC | 21:13 | |
openstackgerrit | Merged openstack/tacker: Clean redundant argument to dict.get https://review.openstack.org/312352 | 21:19 |
sripriya | santoshk: ping | 21:19 |
santoshk | sripriya: pong | 21:20 |
sripriya | santohsk: https://review.openstack.org/#/c/311932/ can use the same bug to fix net-mgmt in all places so we are changing it in all places in one patch, that way we can have it consistent everywhere | 21:21 |
sripriya | santoshk : ^^ | 21:23 |
santoshk | ok got a similar comment from someone | 21:25 |
*** brucet has joined #tacker | 21:25 | |
santoshk | will make the change | 21:25 |
sripriya | santoshk: thank you | 21:25 |
*** bobh has quit IRC | 21:28 | |
edigleison | manual installation error: /usr/local/bin/tacker-db-manage --config-file /etc/tacker/tacker.conf upgrade head | 21:31 |
edigleison | helpe me | 21:31 |
sripriya | ediglieson: whats the error? | 21:32 |
edigleison | it worked | 21:37 |
sripriya | edigleison: :-) | 21:41 |
vishwanathj | sripriya santosh the change needs to be done just in the devstack/samples location and not in the data files | 21:41 |
sripriya | vishwanathj: agree, but no harm in keeping it consistent as well, my concern is more on the stable/mitaka patch itself which needs to be cherry picked from master and no direct commits to stable branches | 21:43 |
vishwanathj | sripriya the sample files need to be consistent and the data files in the test data directory have no relation to the sample files | 21:45 |
vishwanathj | if santoshk can take care of just the sample files it should be good....some new author could decide to change the test/data file to be mgmt from net-mgmt tomorrow and it would not impact anything in the samples files | 21:46 |
vishwanathj | they should not be constrained to keep the variables in the sample file to be consistent with the test/data files | 21:47 |
santoshk | vishwanathj: np, i can take care of other files in data dir as well..trying to figureout how to use same commit id to commit into master | 21:47 |
vishwanathj | santoshk the point is data directory values can change the next time around, so there is no value added by keeping them consistent | 21:48 |
santoshk | ok | 21:48 |
sripriya | vishwanathj: the only other place where it is used is in data dir. under unit tests then we can leave it, the bug itself is a low priority IMO | 21:49 |
sripriya | santoshk: provide your fix on master branch, once it is merged you can later cherry-pick it to mitaka by using the cherry-pick button in gerrit | 21:50 |
vishwanathj | the only reason to change the files in samples directory is for a better user experience.....tacker devstack creates network with name net_mgmt whereas the sample files have it as net-mgmt...this uploads the TOSCA template fine but fails at VNF creation due to net-mgmt not being present | 21:51 |
*** mageshgv has quit IRC | 21:57 | |
*** twm2016 has quit IRC | 21:58 | |
*** dmk0202 has quit IRC | 22:01 | |
*** vishwanathj has quit IRC | 22:10 | |
*** vishnoianil has quit IRC | 22:33 | |
*** mbound has joined #tacker | 22:46 | |
*** vishnoianil has joined #tacker | 22:58 | |
*** prashantD_ has joined #tacker | 23:43 | |
*** sridhar_ram has quit IRC | 23:47 | |
*** prashantD has quit IRC | 23:47 | |
*** bobh has joined #tacker | 23:47 | |
*** mbound has quit IRC | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!