| *** jtomasek|afk is now known as jtomasek | 07:51 | |
| pedroalvarez | betherly: hm... weird. Chaging $brand-primary in theme.scss does nothing :/ | 08:58 |
|---|---|---|
| * pedroalvarez cleans the git repository and tries again | 08:59 | |
| Zara | good luck! | 09:04 |
| pedroalvarez | nope | 09:10 |
| Zara | :( | 09:10 |
| pedroalvarez | so, there is another $brand-primary in "src/theme/storyboard/custom_bootstrap_variables.scss" | 09:16 |
| Zara | ah, I thought that was overwritten by whatever was in the custom theme? | 09:24 |
| pedroalvarez | I have no idea, tried to modify that one as well to see what happens | 09:25 |
| pedroalvarez | also asked some questions in the patch | 09:25 |
| pedroalvarez | that does the trick, indeed | 09:25 |
| Zara | heh | 09:26 |
| Zara | I'm sad to say I haven't looked at it yet; it took longer than expected to set up a vm last night | 09:26 |
| Zara | so hoping to get to it tonight instead | 09:27 |
| pedroalvarez | Everything seems to be behaving as usual | 09:27 |
| pedroalvarez | so I believe the patch itself is ok | 09:28 |
| Zara | \o/ | 09:28 |
| pedroalvarez | and she says that it will improve the development experiece, which is good :) | 09:29 |
| pedroalvarez | (she will help us a bit more :) | 09:29 |
| Zara | :D yep, I think anything that helps web developers to contribute can only be a good thing... web developers seem pretty rare in openstack in general | 09:30 |
| Zara | maybe we should announce it on the ml once it's up and running | 09:32 |
| pedroalvarez | heh | 09:34 |
| pedroalvarez | joiinnnn usssss | 09:34 |
| *** alexismonville has joined #storyboard | 10:00 | |
| *** zigo has quit IRC | 10:01 | |
| *** zigo has joined #storyboard | 10:04 | |
| *** alexismonville has quit IRC | 10:04 | |
| *** zigo is now known as Guest84780 | 10:05 | |
| Zara | aaaargh there is a crumb under my 'd' key | 10:14 |
| *** Guest84780 has quit IRC | 10:14 | |
| *** zigo_ has joined #storyboard | 10:16 | |
| Zara | ah, misc ui fixes still await reviews | 10:34 |
| Zara | https://review.openstack.org/#/c/379398/ fixes the one that's probably the most disruptive | 10:35 |
| Zara | then there's https://review.openstack.org/#/c/379417/ | 10:35 |
| Zara | and finally, this one https://review.openstack.org/#/c/373212/ means that buttons will be nicely aligned | 10:35 |
| Zara | (as well as separating task notes from their surroundings a bit) | 10:35 |
| Zara | that last one conflicts with less/sass changes since I made some custom css for it | 10:36 |
| Zara | so I'll rework it if that goes in first | 10:36 |
| Zara | (which would be my preference, since I don't want to make extra work for betherly, but people can preview the patch via the js draft build to see what I have in mind) | 10:38 |
| betherly | Zara: pedroalvarez: ye its a bit funny how less works re overriding styles. almost like it does it in reverse | 10:48 |
| betherly | but basically i had to create another stylesheet to override bootstrap styles before theyre called but then the theme.scss file still has to stay after the bootstrap stylesheet because of some variables not having been declared yet. scss works with dependencies in much the same way as javascript so its easier to understand once its set up | 10:49 |
| betherly | im off today with the flu so might be a little incoherent but will be back soon and sort it all out | 10:50 |
| * Zara has a read of http://stackoverflow.com/questions/33674272/overriding-css-class-variables-with-less | 10:50 | |
| Zara | also, shoo and get well! :) | 10:51 |
| pedroalvarez | yeah, get well! :) | 11:00 |
| *** zigo_ is now known as zigo | 11:23 | |
| *** alexismonville has joined #storyboard | 11:23 | |
| Zara | thanks for the review, pedroalvarez! | 11:46 |
| pedroalvarez | np! :) | 11:46 |
| Zara | I have a horrible feeling that bug was pointed out to me about six months ago and I only remembered it when I found it again the other week | 11:47 |
| pedroalvarez | I wonder if this story in sb-dev is for real: https://storyboard-dev.openstack.org/#!/story/46 | 11:49 |
| Zara | yeah, I wondered the same and asked about it infra | 11:49 |
| Zara | nobody replied so I get the impression nobody knows, or knows how to contact the author | 11:50 |
| Zara | and (unfortunately?) dev doesn't do notifications | 11:50 |
| Zara | I guess it's been long enough with no info that I should put a comment on it | 11:50 |
| Zara | I didn't want to if it was a test story | 11:50 |
| * Zara will comment now | 11:51 | |
| Zara | another review! thanks! | 12:09 |
| *** faybrocklebank has quit IRC | 13:07 | |
| *** faybrocklebank has joined #storyboard | 13:22 | |
| Zara | gah, that logout error | 13:51 |
| * Zara pokes around in storyboard auth some | 13:51 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted to address performance degradation and should return momentarily | 14:02 | |
| *** openstackgerrit has quit IRC | 16:26 | |
| *** openstackgerrit has joined #storyboard | 16:27 | |
| *** openstackgerrit has quit IRC | 16:28 | |
| *** openstackgerrit has joined #storyboard | 16:29 | |
| *** openstackgerrit has quit IRC | 16:30 | |
| *** openstackgerrit has joined #storyboard | 16:30 | |
| *** faybrocklebank has quit IRC | 16:59 | |
| *** alexismonville has quit IRC | 18:25 | |
| *** alexismonville has joined #storyboard | 21:28 | |
| *** alexismonville has quit IRC | 22:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!