Wednesday, 2016-09-14

*** aswadr_ has joined #storyboard06:34
*** wendar has quit IRC07:15
*** wendar has joined #storyboard07:15
*** fay_ has joined #storyboard07:23
*** jtomasek has joined #storyboard07:25
Zarapossibly of interest for custom dashboards (at a glance, would be worth checkign licensing things): http://packery.metafizzy.co/09:52
Zara*checking09:52
SotKshiny09:53
Zaraseems to be jquery and I can never remember off the top of my head which gpl license the apache license is compatible with09:54
Zara(because I can never remember off the top of my head which gpl is which)09:54
Zaralooks like it is compatible09:55
SotKwrong way around aiui09:56
SotK(apache v2 is compatible with gplv3, but gplv3 things shouldn't be linked into apache v2 things)09:57
SotKthough IANAL09:57
Zarahm, I didn't realise the way round made a difference, I thought it just worked both ways (I ain't no expert either)09:58
SotKhttp://www.apache.org/licenses/GPL-compatibility.html09:59
Zarahah, and then the third paragraph goes 'but wait!'10:00
persiaI always imagine the way-ness in similar terms to a food chain:  GPL eats Apache eats BSD eats MIT eats ISC, and so forth.10:00
Zara'This licensing incompatibility applies only when some Apache project software becomes a derivative work of some GPLv3 software, because then the Apache software would have to be distributed under GPLv3. This would be incompatible with ASF's requirement that all Apache software must be distributed under the Apache License 2.0.'10:01
Zarabut then no definition of what they consider 'a derivative work'10:01
Zaraprobaly don't want to commit there.10:01
Zara*probably10:01
persiaA predatory license will eat almost anything, but if you want your non-predatory licensed code to survive, you have to be careful about putting it in the same software with other things.10:01
SotKZara: the 4th paragraph explains the derivative work thing10:03
persiaAh, and that indicates I'm wrong: GPL can't eat Apache without indigestion (software that cannot be distributed)10:03
Zaraheh, it looks like they completely disagree on what constitutes a derivative work but don't trust themselves to win a court battle10:03
persiahttps://www.gnu.org/licenses/license-list.en.html#apache2 is the other side of the discussion10:06
Zarahaha10:06
Zarayeah, the first place I looked just said they were compatible10:07
Zaraof *course* everyone would disagree on it.10:07
persiaIt depends on what you want to do with the software.  If you don't need to distribute, they are.  This isn't true for all the code one might have on one's computer.10:08
persiaWell, also I suppose it depends on what infrastructure you want to use.  Software including Apache2 and GPLv3 sources is GPLv3, which means the ASF won't accept hosting of it, but github might.10:09
*** alexismonville has joined #storyboard11:27
*** alexismonville has quit IRC11:31
*** openstackgerrit has quit IRC11:34
*** openstackgerrit has joined #storyboard11:34
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories  https://review.openstack.org/36891712:10
Zara\o/12:10
SotKnow with all the weird behaviour I could find made less weird12:11
Zarahehe12:11
SotK(and it also now doesn't allow you to accidentally remove all permissions from a story)12:11
Zarahahaha12:11
Zarathat looks like the sort of patch which inevitably does something odd, will test now12:11
* Zara crosses fingers12:12
SotKI can't remember if that was a bug in the old version or a bug halfway through reworking12:12
ZaraI remember we talked about avoiding that case ages ago12:12
Zarabut idk whether the code allowed it in the api, just not the ui12:12
ZaraI could hunt for logs but I don't think it's worth it12:12
SotKI'm pretty sure it was a bug when I was reworking tbh12:12
Zara:)12:13
Zaraheh, the placement of the worklists list on a story detail page is a little odd with the private banner. can't see any way to improve it, will mull it over in the background12:18
Zarasearch breaks12:24
Zara 500: GET /api/v1/stories/search: id12:24
Zara500: GET /api/v1/tasks/search: (InternalError) (1054, u"Unknown column 'tasks.title' in 'where clause'")12:24
Zarahttp://paste.openstack.org/show/576126/12:24
Zarait works on master, so definitely that patch12:25
Zarawill paste full traceback12:27
Zarahttp://paste.openstack.org/show/576129/12:27
* Zara gives a thumbs-up and backflips away B)12:28
Zarathose are issues in revision 4, anyway, so it's not the most recent changes that have caused it12:38
Zaraoh, the first thing is similar to the thing from before so guessing that just needs to change to the same thing for search12:39
Zarawell that's a great sentence but I know what I mean, will check12:40
Zarayeah, that fixes one of them12:41
Zarathough the other makes me wonder if it doesn't like a query like this12:42
Zaraanyway, I changed line 74 in api/v1/search/sqlalchemy_impl.py12:44
Zarafrom models.StorySummary.id == subquery.c.id) to models.StorySummary.id == subquery.c.stories_id)12:44
Zarawhich got rid of the error that looked like the ones from earlier.12:44
Zarabut that still leaves the big one12:45
*** jtomasek has quit IRC12:46
Zara(and I'm mostly pattern matching since I don't properly understand the python-sqlalchemy-mysql conversation)12:46
Zarait says it wants a stories_id, I'll give it a stories_id...12:47
*** dabukalam_ is now known as dabukalam12:48
*** bethwhite_ has quit IRC12:55
*** bethwhite_ has joined #storyboard12:56
SotKwhat a hideous query13:07
ZaraI thought it was almost beautiful in its hideousness13:09
Zaramaybe I'll search repeatedly just so I get lots of them13:09
Zarasorry I found this!13:09
Zaraand all the tests pass happily... :/13:11
Zaraa test for 'did search report a 400, 401 or 500 error when matching a string' would be a good one, tbh; that often uncovers odd api things and so it's something I always check13:13
Zarathough it won't pick up the same thing I check at the same time, ie: did search find any results at all [for something I know is in the instance]13:14
Zara*the same thing -> on something13:14
Zarareminder that the storyboard meeting is at 15:00 UTC-- and the infra bugsquash after that!13:23
Zara(I'm writing up a mini explanation of complex priorities right now)13:36
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories  https://review.openstack.org/36891713:43
Zarayay, will take a look13:44
Zaraugh, can never remember-- am I right in thinking owners and users can add items to a worklist?13:45
Zarafairly sure users just can't change the direct attributes13:45
SotKcorrect13:46
Zara\o/13:46
Zarayay I remembered something.13:46
SotKowners can change the permissions, title, archivedness, as well as moving/adding/removing cards like users can13:47
SotKoh, and automaticness and filters13:47
Zaraokay, that matches my understanding.13:47
Zarahm, I'm still getting the same error (or a very similar one)13:59
* Zara actually looks at the code13:59
Zaraoh I guess it's just the id bit so far13:59
Zarahttp://paste.openstack.org/show/576184/14:01
SotKoh, tasks too, oops14:02
Zarai am the bugfinder, i eat all the bugs, munch munch munch14:03
Zaraadd teams, they said, it'll be fun, they said14:05
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories  https://review.openstack.org/36891714:11
Zara7 iterations already14:32
SotK:)14:32
*** bethwhite_ has quit IRC14:37
Zarastoryboard meeting in 8  minutes!14:52
SotKwoo :D14:52
Zarawow, that's the most enthusiastic anyone has ever been!14:54
Zarayou win a prize!14:54
pleia2hehe14:55
ZaraSotK: your prize is this post: https://www.thedodo.com/dapper-donkeys-guaranteed-to-m-727854881.html14:58
SotKdonkeys are the best :D14:59
persiaOn the screen-size variation for complex priority display: for me, it is at the top right when the screen is wide, between the description and the tasks when the screen is medium-sized, and completely absent when the screen is narrow (and the sidebar moves to the right).15:37
Zaraoh, pep8 was unhappy with the teams patch15:48
*** bethwhite_ has joined #storyboard15:53
*** alexismonville has joined #storyboard16:02
*** fay_ has quit IRC16:11
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Allow teams to be added to the permission list for private stories  https://review.openstack.org/37028716:37
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Allow teams to be added to the permission list for private stories  https://review.openstack.org/37028716:38
persiaWhen one lists the stories for a project, does that show stories that are active in general, or stories that have active tasks against that project?16:42
pedroalvareziirc they appear in different tabs16:43
pedroalvarezactive, merged, and invalid16:43
Zarayep16:43
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories  https://review.openstack.org/36891716:44
pedroalvarezbut persia's question is still valid16:44
persiaI think it might be the former, which could be irritating for cross-project efforts, because it means that folk end up seeing lots of things to do against their project where they can't do anything.16:44
persiaOn the other hand, this might be a feature, to encourage folk to be more engaged in cross-project development to make those stories drop off the list.16:44
SotKit is the former16:45
Zaraiirc it's stories with active tasks but where the task might not be against that project16:45
Zaraso yeah16:45
Zarathere will be a task somewhere in the story against that project16:45
Zarabut it doesn't have to be the active one16:45
Zaraand yeah, I thought it was a planned thing for cross-project efforts16:45
persiapedroalvarez: The thing that made me look is https://storyboard.openstack.org/#!/project/708, where there is an "Active" story, but all the tasks for project 708 are "merged".16:46
persiaIf it's intentional, to encourage cross-project work, then it makes sense to leave it alone, but it may also be good to start training folk to look at lists of stories for multiple projects, rather than lists of projects and stories in each project, to reduce duplication.16:48
pedroalvarezchanging it makes sense to me16:49
ZaraI think the reason people are working by project is to avoid duplicating work16:50
Zaraso there'd need to be another way to group lists of stories for triage16:50
persiaRight, but with this cross-project optimisation, working by project increases duplication of work.16:50
persiapedroalvarez: Doesn't that discourage cross-project work?16:52
* SotK wonders when the page size changing control disappeared16:53
Zaraoh dear16:53
pedroalvareznot sure, if you can see the story there, means that your project has finished with it16:53
persiapedroalvarez: Yes, but it doesn't mean the problem is solved/requirement is met.  I'm being convinced that it makes for a better world if nobody is encouraged to do things like set to "invalid" as "not-my-problem": it stays one's problem until the issue is resolved.16:56
persia(but this does mean that a lot of workflows need to be reconsidered...)16:57
Zarawe still have a thing in a result-set-pager class; maybe pushed off the page?16:58
Zaras/class/tags16:58
SotKnope, its not rendering at all for some reason afaict16:59
persiagit-bisect?17:00
Zaraand we still have the arrows17:00
Zara<span ng-if="!!onPageSize" class="btn-group" dropdown>17:00
Zara    <div>17:00
Zara        <button class="btn btn-xs btn-default"17:00
Zara                dropdown-toggle>17:00
Zara            <i class="fa fa-gear"></i>17:00
Zara        </button>17:00
Zara    </div>17:00
Zara    <ul class="dropdown-menu dropdown-menu-right" role="menu">17:00
Zara        <li class="dropdown-header"># of results</li>17:00
Zara        <li ng-repeat="size in [10,25,50,100]"17:00
Zara            ng-class="{'active': size == limit}">17:00
Zara            <a ng-click="pageSize({'type':listType, 'pageSize':size})">{{size}}</a>17:00
Zara        </li>17:00
Zara    </ul>17:00
Zara</span>17:01
Zarais the bit that seems to not be rendering17:01
SotKit was complex priorities :)17:01
Zarawas about to say maybe it's !onPageSize for some reason?17:01
Zarayay17:01
SotKnow to remember why17:01
SotKpretty sure it got left in from a previous implementation of the UI17:06
SotK18:06:45 < openstackgerrit> Adam Coldrick proposed openstack-infra/storyboard-webclient: Reinstate the page size modification control in17:06
SotK                            result-set-pager  https://review.openstack.org/37031017:06
Zarahaha17:07
Zarawait what how is it already 6:0617:07
Zarahuh, I just tried removing onpagesize in my instance and it didn't seem to make a difference17:08
Zarabut I can test anyway17:08
SotK(that fix will also fix clarkb's issue, since that page uses a different preference (some people expressed desire for different lists to have different lengths without clicking all the time))17:11
Zaraokay17:11
*** bethwhite_ has quit IRC17:26
*** aswadr_ has quit IRC19:32
*** alexismonville has quit IRC19:52
*** alexismonville has joined #storyboard19:52
*** alexismonville has quit IRC20:12
*** alexismonville has joined #storyboard20:16
*** alexismonville has quit IRC20:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!