| *** openstack has joined #storyboard | 01:43 | |
| *** fay has joined #storyboard | 06:44 | |
| *** fay is now known as faybrocklebank | 06:45 | |
| *** ttx has quit IRC | 06:54 | |
| *** ttx has joined #storyboard | 06:54 | |
| *** ttx has quit IRC | 06:54 | |
| *** ttx has joined #storyboard | 06:55 | |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #storyboard | 07:34 | |
| *** matthewbodkin has joined #storyboard | 07:37 | |
| Zara | morning, storyboard! | 09:33 |
|---|---|---|
| Zara | matthewbodkin: these are docs for the commit message syntax for gerrit btw https://review.openstack.org/#/c/360668/3/doc/source/developers.rst@256 , they need more reviews if folks feel like reviewing... | 09:36 |
| matthewbodkin | ahh okay great thanks Zara :d | 09:38 |
| matthewbodkin | :D* | 09:38 |
| Zara | the main advantage of using it is it means someone in the future can find the story from the patch, and the patch from the story. not having to update the task status manually means it's less likely to get out of date. | 09:39 |
| matthewbodkin | I was aware of that, that's handy | 09:40 |
| matthewbodkin | wasn't* | 09:40 |
| matthewbodkin | wow I really can't function today | 09:40 |
| Zara | I can' t type on any day :) | 09:41 |
| Zara | ^ evidence | 09:41 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: Make tags reusable https://review.openstack.org/366188 | 10:12 |
| matthewbodkin | this may sound stupid/obvious but... if I find errors in storyboard, do you want me to create stories for them? | 10:24 |
| pedroalvarez | I would share them here before, just in case there is an story already for them | 10:26 |
| pedroalvarez | or if there is an story where the new task could go | 10:27 |
| matthewbodkin | okay thanks pedroalvarez | 10:29 |
| Zara | anyone free to review https://review.openstack.org/#/c/366188 ? it's only been this late going in because I wanted to promote the gerrit plugin, so my responsibility to ring around for reviews.... | 11:21 |
| pedroalvarez | oh, patch sounds promising | 11:22 |
| *** alexismonville has joined #storyboard | 11:25 | |
| pedroalvarez | it's just great | 11:25 |
| pedroalvarez | good work matthewbodkin | 11:30 |
| matthewbodkin | thanks :D | 11:30 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make tags reusable https://review.openstack.org/366188 | 11:48 |
| Zara | listening to death note soundtrack, such nostalgia~ | 12:16 |
| Zara | task list rework is in merge conflict | 12:18 |
| Zara | so no movement on that until stok's feeling better | 12:19 |
| * pedroalvarez updates his storyboard instance to latest version | 13:54 | |
| Zara | \o/ | 13:54 |
| * pedroalvarez <- happy | 13:54 | |
| persia | pedroalvarez: Do you have the gerrit plugin installed as well? | 13:57 |
| pedroalvarez | no | 13:58 |
| pedroalvarez | I want to do that though | 13:58 |
| *** matthewbodkin has quit IRC | 16:00 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a notice when worklists or boards are private or archived https://review.openstack.org/357354 | 16:04 |
| zaro | url for story references in emails seem to be broken? | 16:12 |
| pedroalvarez | 'URL: None#!/story/2000012 ' | 16:14 |
| Zara | yeah, we're not sure how to fix it yet | 16:15 |
| Zara | it's because the comment is being sent to storyboard from elsewhere, so it's not getting the api url of that storyboard instance | 16:15 |
| Zara | that's a rubbish explanation... | 16:16 |
| * Zara looks for code | 16:16 | |
| Zara | so, there, the template constructs the email with the url https://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/plugin/email/templates/story/POST.txt | 16:21 |
| Zara | but the url comes from the request | 16:21 |
| Zara | https://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/plugin/email/workers.py#n62 | 16:21 |
| Zara | so possibly there's a way to add a referer header to requests sent by the plugin. | 16:23 |
| Zara | though I'm not sure where that would go, since the plugin itself should stay generic... | 16:24 |
| pedroalvarez | oh, but the plugin may use info from the configuration to create these headers | 16:25 |
| zaro | Zara: looks like url in the worker so maybe it's not put on the event queue? | 16:25 |
| Zara | pedroalvarez: I figure there might be some puppety configuration for it but not sure where it would live, if that's what you're thinking of. | 16:29 |
| Zara | zaro: sorry, could you rephrase that? I don't understand. | 16:31 |
| pedroalvarez | what I'm thinking is that the pluging already knows the address of storyboard to make the request. It can use that to add the information needed into the headers of the request | 16:33 |
| pedroalvarez | but | 16:33 |
| pedroalvarez | I think should be fixed server-side | 16:33 |
| pedroalvarez | in storyboard itself | 16:33 |
| Zara | iirc it gets complicated because the api and webclient can live in different places, so the api url can be different to the url you'd visit in the browser | 16:37 |
| pedroalvarez | My suggestion would be to: Add an extra configuration option to the plugin_email section in storyboard.conf. and use that for the templates | 16:37 |
| Zara | (I'd remember the details of this better were my webclient test instance hosted on a different machine to my api...) | 16:38 |
| Zara | anyway, I can take a look at it, I'm not sure I can test it. | 16:58 |
| SotK | so, my idea for a quick fix to that was going to be "try to use the right thing, otherwise fall back to the fqdn of the place the api is" | 17:17 |
| SotK | since in practice I don't think any of our current users are planning to run the api and the webclient at different fqdns | 17:17 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Rework the task list layout https://review.openstack.org/357306 | 17:22 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a way to add tasks to worklists from the story view https://review.openstack.org/366899 | 17:22 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 17:22 |
| Zara | a wild sotk appears! | 17:22 |
| Zara | how are you? | 17:22 |
| SotK | better than I was this morning | 17:22 |
| * Zara interprets that as ':S' | 17:25 | |
| Zara | (my native language is emoticons; I just translate them for irc; might explain a lot) | 17:25 |
| *** bethwhite_ has quit IRC | 18:03 | |
| *** alexismonville has quit IRC | 21:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!