| *** alexismonville has joined #storyboard | 01:59 | |
| *** alexismonville has quit IRC | 02:40 | |
| *** sparkycollier has quit IRC | 04:38 | |
| *** betherly has quit IRC | 04:38 | |
| *** sparkycollier has joined #storyboard | 04:40 | |
| *** betherly has joined #storyboard | 04:40 | |
| *** jjardon has quit IRC | 05:13 | |
| *** jjardon has joined #storyboard | 05:14 | |
| *** matthewbodkin has joined #storyboard | 07:50 | |
| *** bethwhite_ has joined #storyboard | 08:44 | |
| *** SotK has quit IRC | 08:58 | |
| *** anteaya has quit IRC | 08:58 | |
| *** gary_perkins has quit IRC | 08:58 | |
| *** pedroalvarez has quit IRC | 08:58 | |
| *** gary_perkins has joined #storyboard | 08:59 | |
| *** SotK has joined #storyboard | 09:03 | |
| *** anteaya has joined #storyboard | 09:03 | |
| *** pedroalvarez has joined #storyboard | 09:03 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 09:09 |
|---|---|---|
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Make it possible to get worklist/board timeline events via the API https://review.openstack.org/354729 | 09:09 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Don't allow users to subscribe to private worklists they can't see https://review.openstack.org/363776 | 09:09 |
| *** matthewbodkin has quit IRC | 09:55 | |
| *** matthewbodkin has joined #storyboard | 10:12 | |
| Zara | so... sleepy | 11:20 |
| *** alexismonville has joined #storyboard | 11:29 | |
| Zara | btw is it actually helpful when I note the pep8 fails in the gerrit comments? I figure it saves some scrolling through logs for the relevant bits | 11:31 |
| Zara | but if it's spammy I'll stop | 11:31 |
| * SotK doesn't mind either way | 11:38 | |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Add basic docs for python client https://review.openstack.org/362878 | 11:47 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 11:50 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Make it possible to get worklist/board timeline events via the API https://review.openstack.org/354729 | 11:50 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Don't allow users to subscribe to private worklists they can't see https://review.openstack.org/363776 | 11:50 |
| Zara | that groups together some of the example commands more sensibly, and updates the readme to refer to an example script added to 'usage' | 11:50 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Limit PyMySQL to < 0.7.7 https://review.openstack.org/364250 | 11:50 |
| Zara | oops, posted 'uh oh, another limit' in infra | 11:52 |
| SotK | oh well | 11:53 |
| Zara | guess we'll see what the tests do there | 11:53 |
| SotK | probably pretty easy to work around, but I'm failing to run the tests here again | 11:53 |
| Zara | it should help us narrow it down | 11:54 |
| SotK | s/work around/fix our code so that we can remove the limit/ :) | 11:54 |
| Zara | :) | 11:55 |
| Zara | well, jenkins hasn't commented on that change but the ones that depend on it are passing | 12:17 |
| persia | Is it possible to cause an issue in production without the limit? I'm not sure it makes sense to add it if things are only breaking with new code. | 12:19 |
| SotK | I suspect that the tests will fail for any new patches without the limit (or a fix for the changed behaviour) | 12:27 |
| SotK | (the actual functionality is only minimally affected, the two failing tests check for things that it expects to fail with a 400 error that would only happen from incorrect use of the API) | 12:30 |
| persia | So, is it the tests that do not work with new PyMySQL, or the underlying code? Are there other ways to exercise the API that could trigger the same behaviour? | 12:33 |
| persia | My concern is that this sort of limit is essentially saying "There is a problem that is not being addressed now", which is the sort of thing that means a lot of work later with little progress. | 12:34 |
| persia | So if the issue is one that has been around for a long time, this makes sense if some things need to land within timeframes, but if the issue is being introduced by new code, then that code becomes suspect. | 12:35 |
| SotK | it seemed to me that the issue was being caused by trying to update a foreign key field to point at a thing that didn't exist (the failures in question were modifying a task to point at a non-existent story and creating a task to do the same) | 12:37 |
| SotK | I intend to investigate further to confirm my suspicions when I'm in a place that makes it easy for me to run the test suite | 12:38 |
| persia | And I don't see anything in https://review.openstack.org/363776 that changes the model, making me think this is a pre-existing issue. | 12:39 |
| persia | Thank you for the details. | 12:39 |
| SotK | yep, that was my thinking too | 12:40 |
| *** openstackgerrit has quit IRC | 13:49 | |
| *** openstackgerrit has joined #storyboard | 13:49 | |
| *** matthewbodkin has quit IRC | 14:06 | |
| *** matthewbodkin has joined #storyboard | 14:06 | |
| Zara | matthewbodkin: how did database things and whatnot go? | 14:28 |
| matthewbodkin | everything's good now thanks, I have a load of stories/projects etc to see what effect the changes I make have | 14:29 |
| Zara | \o/ | 14:29 |
| matthewbodkin | so now it's much easier and quicker than waiting for the js draft | 14:30 |
| Zara | brilliant | 14:30 |
| *** ivyyy has quit IRC | 14:35 | |
| *** matthewbodkin has quit IRC | 16:00 | |
| Zara | yayyy just noticed the limit passed. | 16:30 |
| Zara | am considering working later tonight and leaving earlier tomorrow, so we don't merge stuff fri afternoon but so we actually can get some things merged this week... though depends what I find. | 16:35 |
| Zara | *some more things | 16:35 |
| persia | Looking at the set of things that might merge, I'm not sure I can help any (as I still don't have a good idea for https://review.openstack.org/356441) | 17:15 |
| persia | but while looking, I noticed https://review.openstack.org/325292 : is that covered by https://review.openstack.org/357306 (so should be abandoned with a note to see the update), or is there something from there worth rescuing? | 17:16 |
| Zara | yeah, that's covered by 357306 imo | 17:16 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Add due_dates https://review.openstack.org/345995 | 17:37 |
| Zara | I thought that went in ages ago, oops | 17:39 |
| *** jtomasek is now known as jtomasek|afk | 17:45 | |
| persia | Is https://review.openstack.org/264770 still meaningful? The series that superceded it seems to have been abandoned, but it isn't clear to me whether this should be done independently, or also abandoned. | 17:46 |
| Zara | ah, It was going to be abandoned anyway so I guess it's ready for abandoning | 17:47 |
| openstackgerrit | Merged openstack-infra/storyboard: Don't allow users to subscribe to private worklists they can't see https://review.openstack.org/363776 | 17:59 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Add basic docs for python client https://review.openstack.org/362878 | 18:00 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Add basic docs for python client https://review.openstack.org/362878 | 18:18 |
| *** openstackgerrit has quit IRC | 18:18 | |
| *** openstackgerrit has joined #storyboard | 18:19 | |
| Zara | hm, maybe this worklist is in a public board again | 18:31 |
| Zara | nope | 18:32 |
| Zara | okay, events for private worklists seem to leak with the patch in review atm, along with events for private things in public worklists. | 18:33 |
| Zara | :/ | 18:33 |
| Zara | I'm heading off, 'night | 18:33 |
| *** alexismonville has quit IRC | 18:52 | |
| *** krotscheck has quit IRC | 22:15 | |
| *** krotscheck has joined #storyboard | 22:15 | |
| *** alexismonville has joined #storyboard | 23:15 | |
| *** alexismonville has quit IRC | 23:24 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!