Wednesday, 2016-08-24

*** alexismonville has joined #storyboard00:41
*** alexismonville has quit IRC01:44
*** aswadr_ has joined #storyboard03:17
*** fay has joined #storyboard07:10
*** fay is now known as faybrocklebank07:10
*** bethwhite_ has joined #storyboard07:50
*** matthewbodkin has joined #storyboard07:55
Zaramorning, storyboard!10:15
SotKmorning!10:16
matthewbodkinmorning10:16
Zarayesterday I discovered that 'men furry hats' is the best image search10:18
ZaraI pass this wisdom on to all in this channel, that ye may use it as ye see fit10:18
*** jtomasek_ is now known as jtomasek11:13
Zaracan't seem to break worklist notifications11:56
persiaIs that a call for help?11:57
persia:)11:57
Zara:) I'm gonna +2. will hold off +A until I've double-checked the endpoint patch11:58
*** bethwhite_ has quit IRC12:15
*** bethwhite_ has joined #storyboard12:15
ZaraI think https://storyboard.openstack.org/#!/board/14 is due a spring clean13:00
*** openstackgerrit has quit IRC13:26
*** openstackgerrit has joined #storyboard13:27
SotKopenstackgerrit is asleep again I see13:37
Zaraaw13:37
* SotK sent https://review.openstack.org/#/c/359894/13:37
SotKand more importantly but dependent on that first one: https://review.openstack.org/#/c/359895/13:37
SotKswift reviews would be much appreciated13:38
* Zara will get on it13:38
* SotK rebases https://review.openstack.org/354729 and https://review.openstack.org/354730 on top of those13:47
* SotK smiles at https://storyboard.openstack.org/#!/story/2000644#comment-754113:48
Zara:)13:50
openstackgerritMerged openstack-infra/storyboard-webclient: Add a margin to the bottom of all pages  https://review.openstack.org/35911914:04
Zara\o/14:05
Zaraheh, looks like tasks are the only thing that aren't cached14:07
SotKin what context?14:09
Zarajust checked logging out and accessing a private story14:14
Zaragot a bit freaked out because it was still displayed, then realised it was just the cache14:14
Zarabut the task list said 'no tasks'14:14
Zaraso that bit was checking14:14
SotKheh14:14
Zarahaven't succeded in breaking the first14:23
SotKgood14:26
ZaraI mainly checked that things expected to be private were private everywhere14:27
Zaradid create a story jic there was anything odd when things moved around but I didn't go extra14:27
* SotK notes that it is the meeting in #openstack-meeting in 10 minutes time14:50
SotKagenda is here, feel free to modify it: https://wiki.openstack.org/wiki/Meetings/StoryBoard#Agenda_for_next_meeting14:51
Zarathanks14:54
Zarahah, that looks about right, I've been reviewing non-stop this week14:59
* SotK tries to figure out this test failure15:53
pleia2Zara: great email \o/15:56
Zarapleia2: aw, thank you! :D15:58
ZaraI'm so happy about gerrit things, tralalala~15:59
pleia2me too16:04
Zara:) I'll probably just spend the entire summit running around barcelona telling strangers who have nothing to do with openstack that gerrit now talks to storyboard.16:07
*** matthewbodkin has quit IRC16:15
*** faybrocklebank has quit IRC16:22
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Hide timeline events and comments of private stories  https://review.openstack.org/35989516:23
* SotK doubts that will actually fix the tests, but they keep timing out when I attempt to run them locally16:24
Zara:(16:25
zaroZara: any wacko problems crept up yet?16:33
zarowith its-storyboard i mean16:33
Zaranot seen anything strange yet! but that has reminded me that we've realised it can't update private stories as it needs to supply auth in the GET to do that (so if we add openstack-gerrit to the story users, it'll be on the ACL)16:34
Zarawe think it should be a small change16:35
Zaraie: just a case of adding a header like it does for POST and PUT16:36
Zarabut right now the way it's behaving is the way we'd expect it to behave, so \o/16:37
zarocoolio, you plan on updating openstack-infra docs to let people know about 'task:xxx' and how it works?16:38
Zarasure, I wasn't sure of the best place to put it but I made a task for it in the story as a start...16:39
Zarawhere are users most likely to look for commit message syntax things? I guess wherever lp things are documented...16:39
Zaraah okay http://docs.openstack.org/infra/manual/developers.html#working-on-bugs looks like the place16:40
ZaraI'll have to restrain myself from just writing 'STORYBOARD STORYBOARD STORYBOARD STORYBOARD' over that section16:40
Zaraeep, I always get panicked when I misspell a git command without realising and then get a dramatic error message17:04
openstackgerritMerged openstack-infra/storyboard: Put the logic for hiding private things in storyboard/db/api/base.py  https://review.openstack.org/35989417:11
*** bethwhite_ has quit IRC17:18
*** aswadr_ has quit IRC17:51
Zaragah, comments are hidden from owners too17:59
Zaraonly when browsing to api though17:59
Zaraoh huh, all api browses to private things18:00
Zarathe ui seems to behave18:00
Zara???????????????????????18:00
persiaMaybe trace the API calls made by the UI?18:01
Zara(this is on https://review.openstack.org/#/c/359895/2 )18:01
SotKbrowsing in browser or with curl?18:03
Zara127.0.0.1 - - [24/Aug/2016 18:02:36] "GET /v1/stories/180 HTTP/1.1" 404 10318:03
Zara127.0.0.1 - - [24/Aug/2016 18:03:06] "GET /v1/systeminfo HTTP/1.1" 200 2018:03
Zara127.0.0.1 - - [24/Aug/2016 18:03:07] "GET /v1/stories/180 HTTP/1.1" 200 74618:03
Zarain browser18:03
Zarafirst is api browse, second is via ui18:03
SotKyou won't have the auth header set in browser unless you've done something special18:04
Zaraohhhh18:04
Zaraokay that's fine then18:04
Zarasuggests it's doing the right thing :P18:04
* SotK was hopeful you'd stumbled on the cause of the test failure18:05
ZaraI'm sorry!18:05
Zarainstead I just rediscovered a behaviour I already knew about but had forgotten about18:05
Zara(since previously I've only hit it when trying to list access tokens, so it didn't jog my memory)18:06
Zarasince the tests aren't displaying the old results in gerrit I also can't look at the logs for ideas over there18:06
zaroZara: that may change with new plugin i'm writing18:08
Zaraooh, exciting18:10
zarosample here: http://138.68.20.113:8080/#/c/2/218:12
Zaraah, the 'show all reports' bit?18:14
zaroZara: that's part of it.  select a different patchset and you'll see a different list of results.  results are saved per patchset18:17
Zaraah, okay18:21
persiazaro: that is *really* cool.18:25
zaroyou think you might use persia?18:26
zarouse/use it18:27
persiazaro: for javascript UIs with docs-draft I will definitely use it, because it lets one see what changed between revisions of a patch.18:27
*** krotscheck has joined #storyboard18:27
zaropersia: javascript UI?  is that a project on openstack's Gerrit?18:28
persiazaro: examples are storyboard-webclient ironic-ui, etc.18:29
* persia suspects krotscheck has a complete list18:29
krotscheckfuel-ui, openstack-health, ironic-webclient, tripleo....18:30
zaropersia: ahh yah, that's openstack's Gerrit.  i was asking whether you guys run some other gerrit where you think that gerrit feature would be useful18:30
persiaI regularly recommend gerrit for other projects, but have more trouble convincing people to use zuul, etc., so I usually see tests not shown properly in gerrit, sadly.18:31
zaropersia: that feature has an accompanying jenkins plugin as well: https://github.com/zaro0508/verify-status-reporter18:33
zarouse it without zuul if you like18:33
persiaI don't like :) but I will try that, and maybe make some recommendations.18:37
zaropersia: soon i will stand up a test jenkins server to work with the above gerrit server to show the entire loop.  you can just look there to see how it all works.18:40
persiaThat makes it easier.  Thanks :)18:42
*** alexismonville has joined #storyboard19:55
*** alexismonville has quit IRC20:16
*** alexismonville has joined #storyboard22:25
zaropersia: try again, reply on a change with 'recheck' and see it go. http://138.68.20.113:808022:31
*** alexismonville has quit IRC22:39
*** zigo has quit IRC22:56
*** zigo has joined #storyboard22:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!