| *** matthewbodkin has joined #storyboard | 07:43 | |
| Zara | yay, latest change seems to have fixed the errors when moving cards | 11:23 |
|---|---|---|
| Zara | so far everything looks normal with that patch | 11:31 |
| Zara | argh the new worklists + boards page needs subscriptions for worklists | 11:32 |
| Zara | oh, and now title searches work, they should be included in header search, I guess | 11:49 |
| SotK | we really need to give boards and worklists their own icons for that to not be really confusing I think | 11:49 |
| SotK | (if we're including both there) | 11:49 |
| Zara | yep. I don't think it operates on tasks atm, but that'll just make people think it does | 11:51 |
| Zara | hm, tried to update it so there could at least be a mostly-copy-pasted wip up there as a guide, got a 400 and a message about missing the id. doesn't really matter. | 12:19 |
| Zara | assume I just missed some js somewhere | 12:19 |
| *** matthewbodkin has quit IRC | 12:24 | |
| *** jtomasek has quit IRC | 12:57 | |
| *** matthewbodkin has joined #storyboard | 13:06 | |
| Zara | hm, I wonder if recent events task status updates should have same little button templates that they do in the timeline | 13:14 |
| Zara | they currently just look like ' status: inprogress ==> review' | 13:14 |
| SotK | they probably should | 13:14 |
| *** alexismonville has joined #storyboard | 14:17 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Prettify Task-Status-Changes in Recent Events https://review.openstack.org/357257 | 14:34 |
| *** alexismonville has quit IRC | 14:57 | |
| Zara | so far haven't been able to break the events api endpoint patch. it takes ages to get (unsurprisingly) so we should be careful with it in general. | 15:01 |
| * SotK doesn't see much point in ever using it without some filters set on it | 15:06 | |
| Zara | yeah, I'm noting it in case someone unwary tries to get it first and then filter later | 15:08 |
| Zara | I partly type stuff out so it lodges in my memory as something I might need to warn people about | 15:09 |
| persia | A fair amount of these notes would do well in the API docs: are those autogenerated in a way that makes it easy to add such comments? | 15:09 |
| SotK | yeah, we could just add a note to the relevant docstring | 15:11 |
| Zara | I can mention it in review notes for the patch. | 15:11 |
| Zara | I haven't found any bugs in it yet. I feel depressed. | 15:12 |
| persia | Could you add the relevant docstring to the patch? | 15:12 |
| persia | Err, nevermind. | 15:12 |
| persia | Yeah, asking for docs in the comment so the author does it is better :) | 15:13 |
| Zara | oh, changes in users for private stories don't yet have an email template. | 15:18 |
| Zara | it's just the generic 'story was updated' with a link atm | 15:18 |
| Zara | well, it says who updated it, just not what the update consisted in or the state before or after the update | 15:19 |
| SotK | that information probably isn't in the timeline event either actually | 15:19 |
| Zara | yeah, it isn't | 15:19 |
| Zara | sorry, I didn't mean it was a bug in the patch | 15:19 |
| Zara | just something I just noticed | 15:19 |
| Zara | while paying special attention to eventsy things | 15:20 |
| SotK | I know :) | 15:20 |
| SotK | I guess when I get round to the team-permissions stuff I should fix it | 15:20 |
| Zara | yeah, there's not much point making a template now since it'll change | 15:21 |
| Zara | also should be something I can take on once other steps are done if necessary | 15:22 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: WIP: Rework the task list layout https://review.openstack.org/357306 | 15:30 |
| * SotK would appreciate if folk could leave comments on that patch at some point | 15:33 | |
| Zara | have commented. I think it'd be worth discussing in-channel sometime when people are more awake and it's not boiling; I don't think it's the right approach and I think it's the kind of thing we might find an interesting/elegant solution for if we discuss it. | 15:54 |
| persia | So, what is the universe of things we want for tasks? Notes, Patch Tracker Links, Status, Assignee, Add-to-Worklist, project, branch? | 15:54 |
| persia | Oh, and description? | 15:55 |
| Zara | branch isn't on there at the moment. | 15:55 |
| persia | Yes, but I think it's part of the set of things to consider, before we decide not to include most things because UI. | 15:55 |
| persia | Personally, I think that without branch, people will put the branch name in the description if needed, but that's just a guess. | 15:57 |
| persia | But is there anything else that is associated with a task that I missed? | 15:57 |
| persia | Oh, ID. | 15:58 |
| Zara | (right now the set of things included in that wip is 'title(edit), notes, link(edit), status, assignee, add to worklist, project(edit), task-id, remove-task-from-story'. link(edit) and add-to-worklist are the additions to the existing things. I'm using 'edit' in brackets to note places where there's an 'edit' icon following the field, since it takes up room compared with the button itself being used to ed | 15:58 |
| Zara | it) | 15:59 |
| Zara | *add an (edit) after assignee | 15:59 |
| persia | Right. Remove-task-from-story. | 15:59 |
| persia | And are there any other ones that aren't currently in the WIP? Branch comes to mind, but I'm not sure I have a complete list. | 16:00 |
| Zara | milestone, board, worklist | 16:00 |
| Zara | maybe others | 16:00 |
| Zara | if nobody's missed them so far, I don't care too much. | 16:01 |
| persia | Worklist? | 16:01 |
| Zara | well a task can be in a worklist | 16:01 |
| persia | I was wondering if milestone was present, although I'm not sure I have a good understanding of what milestone means here. | 16:01 |
| persia | Can't a task be in N worklists, so that would become list-of-worklists? | 16:02 |
| persia | (which doesn't fit there, hence the new UI in 312666) | 16:02 |
| Zara | yep, mentioned for completeness, depending on what you decide counts as 'associated', you could probably say everything in storyboard could be on that line | 16:03 |
| persia | I suppose, although I'm hoping to get a starting point to "whittle down things that absolutely *have* to be displayed at-a-glance from" | 16:04 |
| Zara | :) okay. I've been using the list of things that are there as a starting point. | 16:05 |
| persia | Right now, I have "title*, notes*, link*, status*, assignee*, add-to-worklist, project*, ID, remove-from-story, milestone*, branch*", where * indicates it may be edited. | 16:05 |
| SotK | that seems sensible to me | 16:06 |
| persia | Although maybe it should be "title*, notes*, link*, status, assignee, add-to-worklist, project*, ID, remove-from-story, milestone, branch", where * indicates a secondary control is needed to edit. | 16:06 |
| Zara | for the title, one isn't technically needed, imo | 16:07 |
| Zara | since a title can't act as a link to anything else | 16:07 |
| SotK | it definitely is | 16:07 |
| Zara | why? | 16:07 |
| SotK | because things that aren't links should not be highlighted as such | 16:07 |
| persia | Zara: You're suggesting all work to be performed should be described in such detail in the Story description that individual tasks do not have titles? How does this affect cards? | 16:08 |
| * SotK goes to the project page every single time he wants to edit a task's project because of this | 16:08 | |
| Zara | then maybe it shouldn't need to be highlighted | 16:08 |
| SotK | but then you need a thing to indicate it is editable | 16:09 |
| persia | Oh, right. For the first pass, let's set aside whether a display field is a hyperlink, or needs a separate edit control. | 16:09 |
| persia | I think there is a sensible discussion for each item, but I think there are likely some items on the list we can strike before we get into those. | 16:09 |
| persia | So, My first candidate for removal is "milestone": I'm not sure what this achieves that isn't better done with a worklist managed by the release team for the relevant project (or set of projects). | 16:10 |
| SotK | +1 | 16:10 |
| Zara | (SotK: hahaha, that's a fun user-difference, then; I used to get driven mad expecting the project to operate as a link before we made the link linky and haven't had a problem with task titles. xD) | 16:11 |
| Zara | I've never had any input from anyone on milestones, so happy to leave them out | 16:12 |
| Zara | if someone needs them displayed on every task, they can let us know. :D | 16:12 |
| Zara | hasn't happened yet | 16:12 |
| SotK | (Zara: That used to drive me mad too. The problem is that both look exactly the same and yet have different behaviour.) | 16:12 |
| persia | As a follow-on, would a patchset removing support for milestones entirely be received well, or are there reasons to keep it despite agreeing not to display it. | 16:13 |
| Zara | people have asked after them before, but just a vague 'does storyboard have these?' | 16:13 |
| Zara | so personally I'd rather keep it in the api so nobody ends up redoing that work | 16:13 |
| persia | How do we imagine anyone will use it if we agree never to display it? | 16:14 |
| persia | (or provide UI to edit it) | 16:14 |
| Zara | we don't agree never to display it. we agree we're not going to include it in the task list for now. | 16:14 |
| Zara | if someone later wants it, they can decide what to do then. | 16:14 |
| persia | Are you suggesting that we'll need to revisit what goes in the task list again soon? | 16:15 |
| Zara | why 'soon'? well, actually I suggested we first visit it tomorrow, so I suppose that's true. :P | 16:15 |
| persia | Oh, I missed the "tomorrow" bit: I can wait until then if today is bad :) | 16:16 |
| Zara | I'm just sleepy and irritable so I don't think it'll be as useful today | 16:16 |
| Zara | + nearly end of day for me | 16:16 |
| persia | Then tomorrow it is :) | 16:16 |
| Zara | \o/ thanks | 16:16 |
| * SotK hopes we can have the discussion early on tomorrow :) | 16:17 | |
| Zara | wfm. | 16:17 |
| persia | I just don't like lots of loose ends (like half-implemented features), where if someone asks "Does this work", the answer is "yes", and when the followup "How?" is asked, the answer is "There's no UI, so you can figure out what you what and write API scripts". | 16:17 |
| Zara | agreed. I've assumed it's because it was requested by someone whose wishes were deemed important, but the details of what they wanted from the ui were lost (or it was a case of 'we'll work that out after the api') | 16:18 |
| Zara | so there's a chance it's still waiting rather than no longer relevant, and so really we should take a look around before we remove things. | 16:19 |
| Zara | otherwise some lucky person gets to put everything back in because of a communication fail. | 16:19 |
| persia | Yep. | 16:20 |
| *** matthewbodkin has quit IRC | 16:31 | |
| Zara | oh, argh, before I forget, I was pointed at https://review.openstack.org/#/c/356616/ | 16:45 |
| Zara | so I guess that's one to add to the pile of 'js update things on the horizon' | 16:45 |
| Zara | I have only skimmed thus far | 16:45 |
| openstackgerrit | Merged openstack-infra/storyboard: Create timeline events for boards and worklists https://review.openstack.org/350146 | 16:50 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a notice when worklists or boards are private or archived https://review.openstack.org/357354 | 16:58 |
| *** bethwhite__ has quit IRC | 16:58 | |
| Zara | 'night! | 17:19 |
| *** jtomasek has joined #storyboard | 18:08 | |
| *** persia has quit IRC | 18:30 | |
| *** persia has joined #storyboard | 18:32 | |
| *** jtomasek has quit IRC | 18:59 | |
| *** ctgriffiths has quit IRC | 20:00 | |
| *** ctgriffiths has joined #storyboard | 20:01 | |
| *** dmsimard has left #storyboard | 20:05 | |
| *** ctgriffiths has left #storyboard | 21:26 | |
| *** alexismonville has joined #storyboard | 21:41 | |
| *** alexismonville has quit IRC | 22:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!