| *** davidlenwell has quit IRC | 04:42 | |
| *** davidlenwell has joined #storyboard | 04:55 | |
| *** matthewbodkin has joined #storyboard | 08:00 | |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard: Fix docs so it is easy to understand https://review.openstack.org/355886 | 08:14 |
|---|---|---|
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard: Fix docs so it is easy to understand https://review.openstack.org/355886 | 09:04 |
| *** matthewbodkin has quit IRC | 09:26 | |
| *** matthewbodkin has joined #storyboard | 09:31 | |
| *** openstack has joined #storyboard | 10:17 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 10:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Create timeline events for boards and worklists https://review.openstack.org/350146 | 10:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Make it possible to get worklist/board timeline events via the API https://review.openstack.org/354729 | 10:26 |
| SotK | morning :) | 10:26 |
| Zara | ¬_¬ | 10:29 |
| Zara | the sun is really hot today :0 | 11:26 |
| SotK | heh, its surprisingly cool here | 11:31 |
| matthewbodkin | For now... | 11:33 |
| Zara | 'tis my fault for sitting outside. may be burning. hm. | 11:34 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: Make sidebar submenu the same length as sidebar https://review.openstack.org/355554 | 11:40 |
| *** alexismonville has joined #storyboard | 11:49 | |
| *** alexismonville has quit IRC | 11:53 | |
| matthewbodkin | Argh there's still one thing I want to do with the docs, sorry for the constant reviewing | 11:54 |
| Zara | hahah | 11:54 |
| Zara | np, let us know when you feel it's ready | 11:55 |
| Zara | we could always just merge that and you send a followup patch later | 11:55 |
| matthewbodkin | It's nothing major it literally takes 2 minutes to fix it's just annoying haha | 11:56 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard: Fix docs so it is easy to understand https://review.openstack.org/355886 | 11:57 |
| Zara | testing first of events timeline patches now. hm, my events worker is reporting errors when I move cards, that I don't seem to get with other actions | 12:17 |
| Zara | http://paste.openstack.org/show/559005/ | 12:17 |
| Zara | it seems to be expecting a subscription to the board and then panicking when there isn't one | 12:20 |
| Zara | oh, actually, no, i think it's expecting a story to which the user is subscribed | 12:20 |
| Zara | and then panicking when *that's* missing | 12:20 |
| Zara | (same thing happens with subscribed worklists) | 12:21 |
| Zara | the PUT itself works fine and it doesn't seem to have any bigger consequences | 12:21 |
| Zara | yeah, seems to be the case for any actions on boards, including adding cards and changing description. probably same for worklists | 12:23 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 12:27 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Create timeline events for boards and worklists https://review.openstack.org/350146 | 12:27 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Make it possible to get worklist/board timeline events via the API https://review.openstack.org/354729 | 12:28 |
| SotK | should be fixed now | 12:29 |
| Zara | hahaha | 12:29 |
| Zara | I wasn't even sure if it was expected behaviour that was fixed elsehwere in the series. thank you! | 12:30 |
| Zara | *elsewhere | 12:30 |
| SotK | well, it didn't actually cause any issues since the workers handle errors being raised gracefully | 12:31 |
| *** alexismonville has joined #storyboard | 12:31 | |
| SotK | and there can't be any notifications to be sent for those things until later patches | 12:31 |
| SotK | but, its the kind of thing that would be confusing to see in your logs | 12:32 |
| Zara | yeah | 12:32 |
| Zara | I wasn't expecting to see any notifications | 12:32 |
| Zara | just thought it might suggest something was broken | 12:32 |
| Zara | I'll give the new version a test-drive now | 12:33 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add recent events templates for worklist notifications https://review.openstack.org/356441 | 12:46 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: StoryBoard 'about' page tweak https://review.openstack.org/354570 | 13:01 |
| Zara | reminder that we have the storyboard meeting at 15:00 UTC | 13:19 |
| Zara | hm, seem to still be getting the same error, just checking | 13:23 |
| Zara | http://paste.openstack.org/show/559026/ | 13:24 |
| Zara | when moving a card into a new lane | 13:24 |
| Zara | s/new/different | 13:24 |
| Zara | and moving cards' position in worklists | 13:25 |
| Zara | aaand changing board descriptions. suggests it's everywhere | 13:26 |
| * persia reads patches and mumbles about using nine, rather than six, for backwards, rather than forwards, compatibility | 13:27 | |
| persia | (although I also hear good things about eight, but haven't seen anyone use it much) | 13:28 |
| Zara | I imagine that'll involve changing a lot of existing code | 13:29 |
| persia | The patch which inspired the thought was one that newly imported six because some new construct required code that wasn't both python2 and python3 compatible, so was introducing the python2 semantics, which means more code changes later, if it lands. | 13:29 |
| persia | Any code that doesn't invoke six that passes both the 2.7 and 3.3 tests is fine. | 13:30 |
| persia | Code that doesn't pass both suites needs to have a compat library. | 13:30 |
| persia | I believe that six is no longer the right choice for a compat library for new code. | 13:30 |
| persia | (but not enough to block things) | 13:30 |
| matthewbodkin | In the new sidebar patch when you go into mobile view, there is an option to scroll sideways in the sidebar as well as up, when you scroll it changes very minimally if anything and without scrolling nothing is cut off like it was last time. Is this option to scroll sideways still a problem? | 13:39 |
| persia | For verification, with how many different resolutions have you validated that response? | 13:43 |
| persia | Without digging, it looks to me like it might be true for some chosen resolution, but that it might not all fit at some other resolution. | 13:44 |
| * persia also doesn't understand how Storyboard decides "mobile", which confuses any commentary on this | 13:44 | |
| * SotK used six because its already used in many other places in storyboard and I didn't want to add a new dependency | 13:45 | |
| persia | I figured as much :) | 13:46 |
| SotK | I'm happy to switch to using nine at some point, but would rather not be using both at the same time | 13:46 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix docs so it is easy to understand https://review.openstack.org/355886 | 13:46 |
| SotK | it decides "mobile" based on the window width | 13:46 |
| persia | I can understand how that would make code hard to read. | 13:46 |
| persia | SotK: WIth some threshold? | 13:47 |
| * persia happens to particularly dislike that way of measuring things, as using a half-width browser + half-width terminal is a nice way to split the screen for many webpage-involved development workflows | 13:47 | |
| SotK | persia: yes | 13:48 |
| * SotK goes to find the actual values | 13:48 | |
| persia | So, while there are plenty of "mobile" devices that handle 720px, or even 1080px width in portrait view, there are also many that still only handle 400x or 640x in portrait view. | 13:48 |
| persia | s/0x/0px/g | 13:49 |
| persia | Which makes me worry about assuming that no scrollbar is OK, unless one can be confident that it is true at very low widths. | 13:49 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: Make sidebar submenu the same length as sidebar https://review.openstack.org/355554 | 13:52 |
| matthewbodkin | If it turns out to be a problem then let me know and I'll see what I can do I just wanted to know your opinions on it :) | 13:53 |
| persia | Looking at theme/storyboard/theme.less, I'm guessing that the minimum supported is 400, 401-719 is "mobile", 720-939 is "tablet", 940-1139 is "desktop" and 1140+ is "large desktop" | 13:53 |
| persia | If those are the right numbers, that means that it needs to work at 401 pixels wide without a scrollbar to not need one. | 13:54 |
| SotK | the actual breakpoints are at 0, 750, 970, and 1170 (bootstrap defaults) | 13:55 |
| persia | Do the values for @container-foo in theme.less override those? | 13:56 |
| matthewbodkin | I think its okay :/ | 13:56 |
| persia | Oh, nevermind, I'm missing the math. The potentially overriding values get changed by calculation anyway, so mine are wrong. | 13:56 |
| SotK | nope, they are `@screen-{xs,sm,md,lg}-min` AIUI | 13:57 |
| matthewbodkin | The option for 'Mobile S' is 302 pixels wide and it's fine on that | 13:57 |
| SotK | the @container-foo things don't seem to be used (anymore?) | 13:57 |
| persia | Oh, heh. Thanks for the correction. | 13:57 |
| persia | matthewbodkin: If it works with no scrollbar at 302 pixels, that's probably safe. Most folk with 240px-wide devices don't tend to use the browser very much. | 13:58 |
| * persia , personally, doesn't like to use a browser with less than 480px horizontal | 13:58 | |
| Zara | I'll wait for the draft build and take a look then. concerned it'll give users the impression there are other hidden options. I don't think changing the length should affect the width, so that seems strange. | 14:00 |
| matthewbodkin | Now that I've tried it again the scrollbar is there no matter what the width is | 14:01 |
| * matthewbodkin hmmm's | 14:02 | |
| matthewbodkin | I think that might mean it needs some work but I'll let you all have a look at it first to give your opinion | 14:02 |
| Zara | yeah, it sounds like it does but I also don't know how to fix it so I won't have anything useful to add yet. | 14:03 |
| * Zara today: https://67.media.tumblr.com/1ce2a8db6f085bcdcd0cf9c01025eed9/tumblr_n3w9bq1xha1ruc976o1_500.jpg | 14:04 | |
| matthewbodkin | I'm sure I can do something about it, but at least it fits on now so yay? | 14:06 |
| bethwhite__ | Zara: it's a shame fay isn't here to enjoy that | 14:06 |
| persia | Yes, yay. Next: striving for Hurrah! | 14:07 |
| Zara | bethwhite__: print it out and stick it on her monitor. :D | 14:07 |
| bethwhite__ | Plan. | 14:07 |
| SotK | I can't seem to cause it to have a horizontal scrollbar with Chromium's mobile emulation | 14:13 |
| SotK | however I am now seeing the submenu not reach the bottom of the screen when the main nav menu doesn't require a scrollbar | 14:14 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: StoryBoard 'about' page tweak https://review.openstack.org/354570 | 14:20 |
| Zara | storyboard meeting in 20 mins | 14:39 |
| Zara | in #openstack-meeting | 14:39 |
| Zara | have updated agenda, feel free to add anything | 14:46 |
| *** openstackgerrit has quit IRC | 15:03 | |
| *** openstackgerrit has joined #storyboard | 15:04 | |
| SotK | I sent https://review.openstack.org/#/c/356542/ | 15:58 |
| Zara | oh, hah | 15:58 |
| * SotK is openstackgerrit again | 15:58 | |
| Zara | thanks | 15:58 |
| Zara | well openstackgerrit isn't openstackgerrit today, so I guess you have to be :P | 15:58 |
| Zara | though I picture openstackgerrit as being small and wearing glasses | 15:59 |
| * SotK is apparently the anti-openstackgerrit then | 15:59 | |
| matthewbodkin | The link in Jenkins' check for the sidebar patch is strange... | 16:01 |
| matthewbodkin | Ignore me nevermind it's fine :) | 16:03 |
| Zara | :) | 16:03 |
| Zara | having looked at that boards patch, heehee | 16:04 |
| Zara | double-checking in case it reveals any broken things | 16:05 |
| *** matthewbodkin has quit IRC | 16:07 | |
| persia | Looking at older patches, what is happening with https://review.openstack.org/325294 ? | 16:08 |
| SotK | I think it wants rebasing in order to pass the lint gate | 16:09 |
| persia | Also 355912 and 354570 conflict: which is best rebased over the other? | 16:09 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make task notes read-only by default https://review.openstack.org/325294 | 16:09 |
| Zara | have finally +A'd that, thanks for noticing | 16:11 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make task notes read-only by default https://review.openstack.org/325294 | 16:35 |
| Zara | \o/ | 16:38 |
| persia | 26 minutes from submission to merge indicates the queues are nice and light today :) | 16:39 |
| persia | Although I don't understand why 356542 is still waiting for the initial +V: I would have thought that would happen first. | 16:40 |
| Zara | I figured if it hates it, it'll block it anyway | 16:41 |
| Zara | otherwise it can go in slightly faster. and I try to prioritize glaring bugfixes above other things. | 16:42 |
| persia | That the engine has preferences might be part of it, but I think the preferences are more likely to be "ready to merge" or "old submission" than about the content/ | 16:44 |
| persia | s|/| :)| | 16:44 |
| Zara | yeah, it just takes a while | 16:45 |
| Zara | just explaining why it got a +A so fast (+ we've known about it for some time, and it's something that can stand alone, and requires no detailed input from me, so it's easy to review.) | 16:45 |
| Zara | a patch that requires more input tends to get seen later when I have more time/energy to devote, especially if I have to learn a bunch of stuff to review it. | 16:46 |
| *** alexismonville has quit IRC | 17:14 | |
| *** alexismonville has joined #storyboard | 17:47 | |
| *** alexismonville has quit IRC | 18:23 | |
| *** alexismonville has joined #storyboard | 19:01 | |
| *** alexismonville has quit IRC | 19:06 | |
| *** alexismonville has joined #storyboard | 19:06 | |
| *** alexismonville has quit IRC | 19:44 | |
| *** alexismonville has joined #storyboard | 19:44 | |
| -openstackstatus- NOTICE: The volume for logs.openstack.org filled up rather suddenly, causing a number of jobs to fail with a POST_FAILURE result and no logs; we're manually expiring some logs now to buy breathing room, but any changes which hit that in the past few minutes will need to be rechecked and/or approved again | 19:46 | |
| *** alexismonville has quit IRC | 19:56 | |
| *** alexismonville has joined #storyboard | 20:23 | |
| *** alexismonville has quit IRC | 20:39 | |
| *** alexismonville has joined #storyboard | 21:02 | |
| *** alexismonville has quit IRC | 21:11 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
