| *** alexismonville has joined #storyboard | 00:21 | |
| *** alexismonville has quit IRC | 02:19 | |
| *** jtomasek_ has joined #storyboard | 05:26 | |
| *** jtomasek has quit IRC | 05:26 | |
| *** jtomasek_ is now known as jtomasek | 05:37 | |
| *** ttx has quit IRC | 06:27 | |
| *** ttx has joined #storyboard | 06:28 | |
| *** matthewbodkin has joined #storyboard | 07:46 | |
| *** pedroalvarez has quit IRC | 09:33 | |
| *** pedroalvarez has joined #storyboard | 09:36 | |
| Zara | matthewbodkin: so we have 4 git repos as part of storyboard. https://review.openstack.org/#/q/project:openstack-infra/storyboard is the place to find storyboard itself on gerrit | 09:59 |
|---|---|---|
| Zara | https://review.openstack.org/#/q/project:openstack-infra/storyboard-webclient is the web ui , and https://review.openstack.org/#/q/project:openstack-infra/python-storyboardclient is a tool for talking to storyboard via the commandline | 10:00 |
| matthewbodkin | Okay thanks for the help, I'll investigate | 10:00 |
| Zara | (and then these are some deployment scripts but they shouldn't matter right now, just including them for completeness: https://review.openstack.org/#/q/project:openstack-infra/puppet-storyboard ) | 10:01 |
| Zara | so, our docs for installing currently live in the first one | 10:01 |
| matthewbodkin | Okay great | 10:01 |
| Zara | :) I'm not sure how handy the sandbox is for getting a feel for how patches to the code relate to the actual repo and to the gerrit interface, but hopefully looking at the things in review for storyboard will cover that. when you're ready, here's the list of things missing from the docs that we found earlier: https://storyboard.openstack.org/#!/story/2000684 | 10:05 |
| Zara | and if you're unsure about *anything*, please ask! | 10:07 |
| matthewbodkin | Okay I have a lot of stuff to go over now which is good :) | 10:15 |
| *** mrmartin has joined #storyboard | 10:25 | |
| Zara | \o/ | 10:26 |
| Zara | yeah, I think a good thing to focus on at this point would be how things in the codebase relate to things on the screen, and how the different bits of code are connected. I learn that sort of thing best by trying to patch things and looking at the existing examples; some folks prefer to start with the theory. so wandering around and seeing what works sounds good. :) | 10:42 |
| *** alexismonville has joined #storyboard | 11:27 | |
| Zara | was going to look at boards/worklists-events-timeline patches today. just wondering if everything's still current since they're different topics and one has a merge conflict | 11:42 |
| Zara | hm, all-boards is doing weird pagination things on js draft, earlier version didn't do that | 11:51 |
| SotK | they are both current, I'm just bad at using the same topic apparently | 11:52 |
| SotK | I have no idea why there is a merge conflict | 11:53 |
| Zara | it'd be real handy if gerrit would say what it conflicted with xD | 11:53 |
| *** mrmartin has quit IRC | 12:14 | |
| Zara | hm, pagination for the all-boards patch works on my test instance, just not on the js draft | 12:21 |
| Zara | perhaps it's a problem when one list has <10 items? | 12:21 |
| Zara | that is, https://review.openstack.org/#/c/279753/ | 12:22 |
| Zara | paging to 11-20 of worklists doesn't seem to work | 12:22 |
| Zara | well, it displays those results but then calls them 1-10, and there's no way to get back to the first 10 | 12:23 |
| SotK | hmm | 12:24 |
| Zara | that's really weird. it works on my test instance | 12:26 |
| SotK | it could be the js-draft being weird | 12:27 |
| SotK | istr it was weird about pagination in the events timeline too | 12:28 |
| Zara | yeah, maybe. in the past it's caught errors that haven't been local but have affected prod | 12:28 |
| Zara | (it caught the editing comments thing) | 12:28 |
| Zara | which I thought was just js-draft being weird | 12:28 |
| Zara | then... yeah | 12:28 |
| Zara | but I remember it being weird about other pagination | 12:28 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: 'All Boards and Worklists' Page https://review.openstack.org/279753 | 12:30 |
| SotK | ah, its the same in the other places with pagination | 12:32 |
| Zara | ah, okay. I'll assume it's just the draft, then. | 12:32 |
| Zara | oh well, the thing I just submitted should fix the linting error | 12:33 |
| Zara | it soft-depends on boards search, in that it can be merged without but the search is useless so it just acts as a list of all boards/worklists | 12:34 |
| Zara | which is itself not very useful | 12:34 |
| Zara | thanks for the reviews, persia! :D | 13:45 |
| Zara | I realised that I was delaying looking at notifications patches because I'm scared to turn my email worker on again, will do that tonight | 13:47 |
| *** mrmartin has joined #storyboard | 13:56 | |
| *** mrmartin has quit IRC | 14:11 | |
| *** mrmartin has joined #storyboard | 14:21 | |
| *** mrmartin has quit IRC | 14:27 | |
| *** mrmartin has joined #storyboard | 14:35 | |
| Zara | aw, linting, why | 14:52 |
| Zara | huh, for some reason it's only showing one linting error at a time. so that's probably why it didn't flag this up last time. | 14:54 |
| Zara | (last time it said 'Preference' was defined but never used, in the boards list controller; now it's saying the same thing about 'Board'. but I think it should also be saying that about 'Worklist'... | 14:55 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: 'All Boards and Worklists' Page https://review.openstack.org/279753 | 15:04 |
| Zara | erm, *that* should fix the linting... :/ | 15:04 |
| *** mrmartin has quit IRC | 15:05 | |
| Zara | matthewbodkin: how are you doing? | 15:25 |
| matthewbodkin | Fine thanks I've been learning more about everything using sandbox so I'm going to be able to do the docs tomorrow morning first thing I think :) | 15:27 |
| matthewbodkin | It's all really helped to give me a better understanding of git which is pleasing | 15:27 |
| matthewbodkin | I'm slowly but surely starting to get my head around the whole process of how everything works I think | 15:28 |
| Zara | \o/ glad it's helped! | 15:32 |
| *** ivyyy has joined #storyboard | 16:03 | |
| *** matthewbodkin has quit IRC | 16:05 | |
| *** bethwhite has joined #storyboard | 16:08 | |
| *** bethwhite_ has joined #storyboard | 16:08 | |
| *** bethwhite has quit IRC | 16:09 | |
| *** faybrocklebank has quit IRC | 16:17 | |
| Zara | oh, I just noticed ivyyy joined, welcome, ivyyy! :D | 16:31 |
| Zara | I promise it's not just me in this channel. | 16:32 |
| ivyyy | hiya! :D | 16:32 |
| Zara | most of the team are based in the uk so our day tends to lie on the earlier side, but even if we've vanished for the evening, we'll see things eventually (and we're normally around fairly late on Tuesdays since it's infra-meeting day) | 16:33 |
| Zara | the list of storyboard projects and tasks is over here: https://storyboard.openstack.org/#!/project_group/57 . those projects each correspond to a git repo... and hm, those repos should probably be linked | 16:36 |
| Zara | well I found something to fix, yay! | 16:36 |
| Zara | the python bits are the api and the python client, https://git.openstack.org/cgit/openstack-infra/storyboard and https://git.openstack.org/cgit/openstack-infra/python-storyboardclient/ . at this point I feel like I've sent a million links everywhere, so I'll link to gerrit things if asked but otherwise I'll leave it. :) | 16:38 |
| ivyyy | are you in the UK Zara!? | 16:39 |
| Zara | yup! | 16:39 |
| ivyyy | Zara: london!? | 16:39 |
| Zara | ah, no, Manchester | 16:39 |
| ivyyy | aah still - i'm from london! | 16:39 |
| ivyyy | nice to have people in a similar TZ! | 16:39 |
| Zara | cool! we have a contributor from bristol, so that's sliiightly nearer, haha | 16:40 |
| Zara | yay I have another person to moan to about meetings happening when I want to have tea | 16:40 |
| Zara | other folks should be around in a bit; I think SotK is on a tram right now (he's the other storyboad core, also manchester) | 16:41 |
| ivyyy | cool! its so good to have some new welcoming communities to be in! :3 | 16:44 |
| ivyyy | my main goal at the moment is (maybe a touch unrealistically) to try and get a technical commit to openstack before barcelona | 16:45 |
| ivyyy | is storyboard tied closely to gerrit? | 16:45 |
| zaro | ivyyy: not yet, but getting very close. | 16:45 |
| Zara | ivyyy: we use gerrit for reviews, so a commit in storyboard would work for that | 16:46 |
| zaro | we need to land one more change to make it happen | 16:46 |
| Zara | ah, it depends if you mean 'does storyboard update task-statuses via gerrit?' or if you mean 'does storyboard have the same review process as other openstack projects?' | 16:46 |
| Zara | the answers would be 'not yet' and 'yes' respectively :) | 16:46 |
| Zara | so we get ATC status from commits in storyboard. | 16:48 |
| ivyyy | gotcha | 16:48 |
| Zara | and it should be totally possible to get commits in before barcelona; we have no shortage of bugs. :P | 16:51 |
| *** alexismonville has quit IRC | 16:59 | |
| zaro | Zara: gerrit-dev and sb-dev seems to be integrated now. please give it a run thru when you get a chance | 17:00 |
| Zara | yay! okay, should be able to look at it now, thanks. :) | 17:01 |
| Zara | which reminds me... | 17:01 |
| Zara | ivyyy: if you'd like to play around in storyboard itself and see what it's like to use, we have a dev instance here: https://storyboard-dev.openstack.org/#!/dashboard/stories . feel free to make some strange stories etc. | 17:02 |
| Zara | zaro: hm, it seems that when a patch is abandoned and then restored again, it doesn't say the patch is in review. I wonder if that was covered on an earlier iteration and then not the latest | 17:09 |
| zaro | let me check | 17:10 |
| Zara | I'd be fine with adding it later if it is missing, since it's a bit of an edge case and I'd rather it not block anything. + I think the comments are much nicer now. :) | 17:14 |
| zaro | i see the problem. for some reason it-storyboard isn't updating sb on the change-restored event. will look into it now | 17:16 |
| *** mrmartin has joined #storyboard | 17:16 | |
| Zara | I might have forgotten all about that one when reviewing, if so, sorry! | 17:17 |
| Zara | everything else seems fine so far | 17:17 |
| Zara | I'm not in a position to test what happens when things are merged | 17:18 |
| zaro | merge looks good, here's a test for it https://review-dev.openstack.org/#/c/5460/ | 17:20 |
| zaro | do you get to set all those votes when you reply? | 17:20 |
| Zara | not on review-dev; I only have +1 -1 (for the project I've been using as a test, anyway, which ended up being gtest-org/gtest) | 17:21 |
| Zara | but that test looks good! \o/ | 17:22 |
| zaro | could you please reply again? | 17:23 |
| zaro | try reply on gerrit | 17:23 |
| Zara | aha, ace | 17:23 |
| Zara | thank you | 17:23 |
| Zara | oh, hm, the link to the related patchset didn't work for me just then (for https://storyboard-dev.openstack.org/#!/story/18 ) | 17:25 |
| Zara | well, the gerrit patch set one works, but not the git url | 17:26 |
| Zara | ah, okay, now I have option to +2 but no option to +workflow | 17:27 |
| zaro | yeah, that won't work because it points to git.o.o. we don't have that setup for review-dev. it's only setup for review.o.o | 17:27 |
| Zara | ah, right, cool | 17:27 |
| Zara | trying to make sure I check everything :) | 17:27 |
| Zara | well, I'm fine with it working like this in production | 17:28 |
| zaro | ohh, i think workflow isn't setup right. it should be -1..0 | 17:29 |
| Zara | atm I have the options to pick -1 or 0; not sure if that's the same or if I've misinterpreted. | 17:31 |
| zaro | Zara: please try again | 17:32 |
| Zara | aha | 17:32 |
| Zara | yeah, I have the option to +workflow now! :D | 17:33 |
| Zara | and now it says 'ready to submit' | 17:33 |
| zaro | you need to press submit button to actually submit | 17:35 |
| zaro | i mean to actually merge it | 17:35 |
| Zara | oh! I didn't see that button | 17:36 |
| Zara | found it now | 17:36 |
| Zara | I guess it's there to stop people clicking it by accident | 17:36 |
| Zara | yay, that worked | 17:36 |
| Zara | the task now has a nice green 'merged' status | 17:36 |
| Zara | thank you so much for this! | 17:37 |
| zaro | well still need to fix the restore :( | 17:38 |
| Zara | still, that's the only one! :D and I doubt it would effect that many folks even if it didn't work, but yeah, it'll be nice to have it all shiny. | 17:40 |
| *** ivyyy is now known as ivyyyy-brb | 17:40 | |
| Zara | effect? affect | 17:40 |
| persia | affect as a verb and effect as a noun have similar meanings, being the one you intend. | 18:10 |
| persia | Effect as a verb and affect as a noun are more about social engineering and personality disorders. | 18:11 |
| Zara | or you can put them all together for an exciting political drama blurb, 'now the heroes must affect a shallow affect to effect a plan with affecting effects. This will affect everyone!' | 18:30 |
| *** mrmartin has quit IRC | 18:47 | |
| Zara | ARGH just remembered I meant to turn on my email worker now | 20:02 |
| Zara | seeeems okay... | 20:07 |
| Zara | hm, well the worker itself is erroring and not sending me emails | 20:10 |
| Zara | http://paste.openstack.org/show/552664/ I'll try restarting it, just in case, then I'm off for the night | 20:11 |
| Zara | 'night! | 20:18 |
| bethwhite_ | Night Zara :) | 20:19 |
| *** bethwhite_ has quit IRC | 20:24 | |
| *** zigo has quit IRC | 21:32 | |
| *** zigo has joined #storyboard | 21:35 | |
| *** davidlenwell has quit IRC | 22:25 | |
| *** davidlenwell has joined #storyboard | 22:38 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!