Wednesday, 2016-07-13

*** alexismonville has joined #storyboard01:24
*** jamesmcarthur has joined #storyboard01:55
*** jamesmcarthur has quit IRC01:59
*** alexismonville has quit IRC02:08
*** alexismonville has joined #storyboard02:09
*** alexismonville has quit IRC02:38
*** mrmartin has joined #storyboard04:50
*** mrmartin has quit IRC05:31
*** mrmartin has joined #storyboard05:59
*** mrmartin has quit IRC06:31
*** openstackgerrit has quit IRC06:48
*** openstackgerrit has joined #storyboard06:48
*** mrmartin has joined #storyboard06:55
*** fay_ has joined #storyboard07:21
*** jtomasek__ has joined #storyboard08:21
*** alexismonville has joined #storyboard10:30
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Add a subscribe button to worklists  https://review.openstack.org/32455010:32
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories  https://review.openstack.org/31266610:32
Zaraooh10:34
ZaraSotK: you okay for me to merge https://review.openstack.org/#/c/338532/ ? forgot to do it last night, sorry.10:51
Zaralinting failed for complex priorities ui patch: 2016-07-13 10:53:01.310860 | src/app/stories/controller/story_detail_controller.js11:01
Zara2016-07-13 10:53:01.310886 |   88:54  error  worklist is already declared in the upper scope  no-shadow11:01
Zara2016-07-13 10:53:01.310911 |   92:31  error  item is already declared in the upper scope      no-shadow11:01
Zarahm... something odd going on on my test instance... perhaps more details shortly11:12
Zarayeah, found a bug in editing comments patch. trying to narrow down the version.11:17
Zarastill going... suspect it's to do with the way currentUser is resolved for stories11:20
*** alexismonville has quit IRC11:22
Zaraokay, issue persists in earliest version of the patch, but not on master11:29
Zarareminder that it's the storyboard meeting at 15:00 utc!11:34
Zaraalso hm, my instance no longer displays a favicon. why is that?11:40
*** alexismonville has joined #storyboard11:43
*** alexismonville has quit IRC11:48
Zarathe current theory is that zaro's gerrit patches are blocked by the need for this one, if anyone wants to review: https://review.openstack.org/#/c/340529/11:59
Zaraand the its-storyboard patches are here: https://review.openstack.org/#/q/topic:its-storyboard12:01
*** alexismonville has joined #storyboard12:03
*** alexismonville has quit IRC12:05
*** alexismonville has joined #storyboard12:05
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Add a subscribe button to worklists  https://review.openstack.org/32455012:07
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories  https://review.openstack.org/31266612:07
Zaraooh, again12:07
ZaraI'm glad I have lots of review today; testing is easier than coding to do on no sleep12:07
*** alexismonville has quit IRC12:10
Zaracomplex priorities ui giving same linting errors12:21
* Zara is a gerritbot12:22
SotKoh yeah, I forgot to fix them12:22
Zaranp :)12:22
Zaraah, I think the bug from before may be todo with currentUser in module.js specifically, since I'm getting the same issue in the complex priorities ui patch12:29
Zaraand that was changed in both12:29
Zaraso my guess would be that currentUser.resolve() isn't doing quite what we expect for logged-out users12:30
openstackgerritMerged openstack-infra/storyboard: Add example commands for the Tags api  https://review.openstack.org/33853212:35
*** mrmartin has quit IRC12:46
*** mrmartin has joined #storyboard12:52
SotKhm, so Session.isLoggedIn() doesn't seem to actually work13:01
Zara\o/13:01
Zaragoing to look at all-boards patch again...13:14
ZaraI never find time to code13:14
Zaraoh yeah, I remember  how I'd made this hard for myself now \o/13:25
*** kashyap has joined #storyboard13:26
kashyapWhat markup does StoryBoard stories use?13:35
kashyapA small note: It seems like if you accidentally hit 'escape' while drafting a 'story', all the content is gone :-(13:35
SotKkashyap: StoryBoard uses markdown13:38
SotKalso, the same thing happens if you accidentally click outside the story creation modal, its something we intend to fix at some point13:40
kashyapSotK: Noted.  That bug sounds fairly egregious, as anyone who forgot to save the content locally while drafting a long description, will end up in an unhappy place :-)13:41
openstackgerritZara proposed openstack-infra/storyboard-webclient: Fix project group sidebar-search description  https://review.openstack.org/34153313:49
*** kashyap has left #storyboard13:51
pedroalvarez:)13:52
*** alexismonville has joined #storyboard14:09
openstackgerritZara proposed openstack-infra/storyboard-webclient: WIP search for boards and worklists  https://review.openstack.org/34156214:16
Zarastoryboard meeting in 40 mins!14:22
*** jamesmcarthur has joined #storyboard14:28
ZaraI am missing something for this typeahead...14:38
openstackgerritMerged openstack-infra/storyboard-webclient: Fix project group sidebar-search description  https://review.openstack.org/34153314:42
ZaraI changed the template for typeahead_criteria_item, and added boards and worklists to the list in the search controller. nothing is showing up in the typeahead14:43
Zaraalso, yay, thanks for merging that highly important patch xD14:43
* SotK doesn't remember clearly how it works14:44
Zaraheh. I know the search is working because it works for the index page, but the typeahead...14:45
ZaraI think typeahead troubles were the reason I never got round to adding suggested tags for the header search14:45
*** jamesmcarthur has quit IRC14:48
*** jamesmcarthur has joined #storyboard14:49
Zaraoh I think worklists and boards need {text:q} in the resource...14:51
ZaraWHATEVER THAT MEANS14:51
Zarabut that's what the comments suggest14:51
Zaracomments + difference between projects resource and worklists resource14:51
Zarayay that causes errors14:54
Zaraoh well, meeting in 614:55
ZaraI haven't updated the agenda yet14:55
*** jamesmcarthur has quit IRC14:55
*** jamesmca_ has joined #storyboard14:55
Zararestarted my webclient, now the typeahead is completely broken \o/14:58
*** jamesmca_ has quit IRC15:01
*** jamesmcarthur has joined #storyboard15:04
*** jamesmcarthur has quit IRC15:08
*** matthewbodkin has joined #storyboard15:16
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Allow comments to be edited by their owner  https://review.openstack.org/33341815:22
*** bethwhite- has joined #storyboard15:33
pedroalvarez\o/15:34
dmsimardoh hey that's a cool feature :p15:35
*** jamesmcarthur has joined #storyboard15:36
anteayadmsimard: what is a cool feature?15:38
dmsimardcomment editing ^15:38
anteayaopenstack's storyboard instances will not be allowing comment editing15:39
dmsimardoh ?15:39
dmsimardwhy not15:39
*** jtomasek__ has quit IRC15:39
dmsimardfor history preservation ?15:39
anteayadmsimard: AGREED: OpenStack should not need the ability for task tracker users15:40
anteaya    to edit and delete comments, but would like the ability to disable15:40
anteaya    that if it becomes a feature  (fungi, 19:57:21)15:40
anteayahttp://eavesdrop.openstack.org/meetings/infra/2016/infra.2016-07-05-19.02.txt15:40
SotKI think its partly that and partly concerns that people will think that editing makes things go away permanently15:40
anteayayes for the ability to actually be able to consume things and rely on them15:40
SotK(when in fact things are sent out in emails, and we store history of edited comments that is visible to anyone)15:40
dmsimardhm, but it looks like the history is preserved and is available on demand, there could also be an integration like (launchpad I think?) where comments are editable for like 5 minutes and then afterwards they're not15:41
*** jtomasek__ has joined #storyboard15:41
dmsimardI'm not willing to fight for it, but I think the feature has value as someone who finds typos in his comments even after re-reading 5 times15:42
anteayadmsimard: well the fight happened15:42
anteayait is in the infra meeting logs15:42
anteayaand the agreement was the outcome and the one I posted15:42
anteayaI do hope that this doesn't continue to be a large game of whack a mole15:42
anteayathis could create a bikeshed in storyboard adoption where there really doesn't need to be one15:43
dmsimardwhat do you mean by game of whack a mole ?15:43
ZaraI think it only blocks adoption if there's a preferable alternative for users.15:44
anteayaif would be a really shame of the only obstacle to storyboard adoption was a situation we created ourselves15:44
dmsimardfeatures in storyboard that we don't want in the OpenStack context ?15:44
anteayayes15:44
fungidmsimard: why would that inhibit adoption? lp doesn't let you edit comments, so it's not a regression in functionality for projects moving from lp to sb15:44
anteayawe have a workflow of having history preserved of discussions15:44
anteayalike the infra meeting where the discussion and agreement took place15:45
anteayaso you don't have to take my word for anything, you can read it yourself15:45
anteayawith the confidence that the history is intact15:45
* fungi promises he didn't edit his irc comments in that meeting ;)15:45
*** jtomasek__ has quit IRC15:45
dmsimardfungi: I didn't mention adoption inhibition anywhere, don't get me wrong -- I just mentioned the feature implementation was thoughtful (in the sense that history was preserved) and it looked nice. I wasn't aware it was going to be disabled right out of the gate, that's all.15:46
*** mrmartin has quit IRC15:46
anteayafungi: :)15:47
anteayaI would really like to not have to keep having this conversation, personally15:48
anteayaI would like to focus on the api and its documentation15:48
dmsimardsorry :(15:50
fungidmsimard: to summarize the concern, people who read a lengthy discussion in sb prior to comments getting edited and those who read it after comments got edited can end up with completely contradictory understandings, so at a minimum you need some active mechanism for people to follow edits as they happen (perhaps via e-mail notification) before that becomes remotely sane15:50
fungiand even then it's a risk15:51
dmsimardfungi: it's okay, I can see both sides of the coin15:51
fungiwhereas the "benefits" mentioned for being able to edit comments are that people can correct their typos, or can self-censor after a heavy night of binge drinking15:51
fungibut in those cases, for people using e-mail notification on sb your typos or rants have already landed in their inboxes and you can't undo that15:52
Zaradmsimard: as background, it was implemented as we personally found it irritating not being able to edit, were used to the feature in other software, and had had requests from other users. so those feelings clash with the concerns of those who want to operate something at scale, and this was the compromise.15:56
dmsimardyeah, having the feature and being able to toggle it on and off is fine15:56
dmsimardput toggles on all the things15:57
dmsimardusers have preferences and that's life15:57
anteayano it is configured for the instance15:57
anteayanot on the user level15:57
anteayaif you write something and I take the time to reply to it, I'm not interested in your comment changing whilst I compose my reply15:58
anteayathat erodes trust15:58
dmsimardanteaya: yes, I know the setting is instance-wide15:58
anteayagreat15:59
dmsimardby user I referred to both end users and the operators15:59
fungia "community preference" perhaps15:59
Zara:) in practice once the patches are a bit older, people on storyboard.openstack.org will only stumble across the feature if they actively go hunting through the code, so I doubt it'll continue to have a lot of discussion.15:59
Zarawell, sotk and I will no doubt continue to get requests15:59
SotKcommunity preference is a good way of putting it15:59
Zarayeah :)16:00
dmsimardmy apologies for reviving a debate, I didn't know at all it was a hot topic.16:01
fungithat's the benefit i bring to openstack. i don't do any real work but i'm adept at making up terms16:01
anteayadmsimard: if you have some time to review some api doc examples, I'm grateful: https://review.openstack.org/#/q/topic:expand-api-docs+status:open16:03
*** openstackgerrit has quit IRC16:03
anteayaI will respin the user tokens patch after I finish my lunch to incorporate SotK's most recent review16:03
*** openstackgerrit has joined #storyboard16:03
*** alexismonville has quit IRC16:07
Zara\o/16:11
anteayayay thank you16:13
*** fay_ has quit IRC16:39
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Add example commands for the User Tokens api  https://review.openstack.org/33929716:39
anteayasomehow I ended up with an .eggs/ dir on my last run of tox in storyboard16:40
anteayaan objection to me updating .gitignore to ignore that dir?16:41
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Update .gitignore to ignore all .egg things  https://review.openstack.org/34167016:46
Zaranone from me, sounds like it shouldn't be there :)16:48
anteayathanks16:49
anteayaI didn't want to look at it16:49
anteayanot sure what changed that it appeared16:49
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Remove the delete_all funciton from the user_tokens api  https://review.openstack.org/34167616:54
anteayaZara: SotK do we like the user tokens patch yet? https://review.openstack.org/#/c/339297/216:55
anteayaSotK: thanks for the commands16:55
*** matthewbodkin has quit IRC16:56
anteayaZara: thanks for the worklist commands, I will work on that next16:57
anteayaZara: feel like merging the .gitignore since it has 2 +2's on it now?16:57
anteayawill save me the trouble of having this .eggs/ dir follow me around16:58
Zarasure16:58
anteayathanks16:59
*** jamesmcarthur has quit IRC17:05
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Add example commands for the Worklists api  https://review.openstack.org/34050617:07
anteayathanks Zara!17:07
*** jamesmcarthur has joined #storyboard17:12
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Add example commands for the Users api  https://review.openstack.org/33857017:17
Zaranp! :) I'd add POSTs and PUTs, but I don't have time to check the syntax for curl for those rn17:18
ZaraI'll get to it at some point if nobody does first17:18
anteayaunderstood, thank you for the commands thus far!17:18
anteayathank you17:18
anteayaSotK: how are you feeling about the user_tokens patch at present? https://review.openstack.org/#/c/339297/217:19
Zarayw :) for GETs I generally work them out by browsing to https://storyboard.openstack.org/api/v1/ and then doing a bit of trial and error in the addressbar with the things listed as parameters (or things listed in the xml)17:20
anteayaI don't know what you mean by browsing https://storyboard.openstack.org/api/v1/17:21
anteayawhen I open that in a browser I get a 40417:21
anteayado you mean using that as a base url for the curl command?17:21
Zarayeah, it'll be a 404 until you stick something after it, so eg: https://storyboard.openstack.org/api/v1/worklists/ where you substitute 'worklists' for whatever you're hunting for17:22
Zarasometimes it's not that guessable but it works for me a fair amount of the time17:23
*** mrmartin has joined #storyboard17:27
Zaraso you get the same data as you would using curl, the xml is just a bit easier on the eyes imo17:28
anteayaah cool17:28
anteayathank you, I didn't know I could to that, this is most helpful17:28
Zaraglad to help! :D17:29
Zararight I'm off home, 'night!17:29
anteayagood night, thank you17:32
*** jamesmcarthur has quit IRC17:36
*** alexismonville has joined #storyboard18:17
*** mrmartin has quit IRC18:19
*** alexismonville has quit IRC18:20
*** jamesmcarthur has joined #storyboard18:25
*** alexismonville has joined #storyboard18:27
*** jamesmcarthur has quit IRC18:30
*** alexismonville has quit IRC18:52
*** mrmartin has joined #storyboard19:01
*** mrmartin has quit IRC19:15
*** mrmartin has joined #storyboard19:18
*** mrmartin has quit IRC19:25
*** jamesmcarthur has joined #storyboard19:34
*** jamesmcarthur has quit IRC19:36
*** jamesmcarthur has joined #storyboard19:36
anteayaokay so our db tests are currently failing: https://review.openstack.org/#/q/project:openstack-infra/storyboard19:53
anteayaand it appears that the error: AttributeError: 'ExceptionContextImpl' object has no attribute 'engine' is only affecting storyboard, at least according to logstash19:54
anteayaso it appears that for some of our db tests a server either isn't created or is not responding to the wsme.api calls19:57
anteayaI wonder if Running upgrade 058 -> 059, Add a table for comment history is playing a role here20:05
anteayamy patches that still have passing jenkins tests last ran on July 7th20:06
anteayahttps://review.openstack.org/#/c/339123/20:06
*** jamesmcarthur has quit IRC20:09
Zaraapi patches have passed tests today and yesterday. (https://review.openstack.org/#/q/project:openstack-infra/storyboard) I don't think a change in storyboard has triggered it.20:14
* Zara vanishes again20:14
*** alexismonville has joined #storyboard20:25
anteayathis passed on July 11th: https://review.openstack.org/#/c/339557/ that is the most recent I can find20:29
anteayaI am not seeing api patches that passed tests today20:29
anteayaokay the tags api patch merged today: https://review.openstack.org/#/c/338532/20:30
anteayaokay, well I am at a loss then as to what is creating this error20:30
*** jamesmcarthur has joined #storyboard20:39
*** alexismonville has quit IRC20:50
SotKa random sample of the failed and successful tests suggests to me that APScheduler 3.0.6 doesn't work, but APScheduler 3.2.0 does21:01
SotKidk why its started using the older version sometimes21:01
*** jamesmcarthur has quit IRC21:13
anteayaoh my21:14
anteayathank you21:14
anteayacan you show me in the logs where you see the apscheduler version?21:14
anteayaSotK: I'll offer a patcht to adjust that version in requirements.txt21:15
SotKhttp://logs.openstack.org/97/339297/2/check/gate-storyboard-python34-db/c165765/console.html#_2016-07-13_16_59_54_928020 for a broken one21:16
SotKhttp://logs.openstack.org/22/338522/1/check/gate-storyboard-python34-db/b87dda8/console.html.gz#_2016-07-06_19_59_06_258514 for a working one21:16
SotKanteaya: thanks :)21:17
anteayado you want to just pin to 3.2.0?21:17
anteayacurrently it sits at apscheduler>=3.0.1,<3.1.021:17
anteayaI'll pin to 3.2.0 and go from there21:18
SotKthat works for me21:19
anteayathank you21:21
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Change apscheduler>=3.0.1,<3.1.0 to apscheduler>=3.2.0  https://review.openstack.org/34181021:21
anteayaSotK: I will ping when jenkins passes on it21:22
SotKhmm, I wonder why the gate has been using 3.2.0 when we've had < 3.1.0 set since April21:23
pleia2anteaya: is there anything holding up https://review.openstack.org/#/c/325474 process-wise, or does it just need reviews?21:31
anteayapleia2: well it needs reviews, also Zara thought that it would conflict with betherly's interactive tutorial she wanted to do21:32
anteayamy problem is I have seen no interactive tutorial patches21:32
anteayaand I think our users would benefit from some form of overview21:33
anteayaI don't care if betherly creates it or not21:33
anteayajust that something exist21:33
anteayapleia2: thanks for asking21:33
pleia2anteaya: I don't know what form the interactive tutorial will come in, but I do find a lot of value in searchable, text-based documentation that explains things with words21:34
betherlyanteaya: pleia2: sorry for the delay getting stuff up. can i suggest we look at it and merge it as a start and then as my one gets into review and looked at we can swap it out21:34
pleia2so I would like to see something like this, even if it's part of an interactive tutorial, and with interest growing we should have *something*21:34
anteayabetherly: or have both, either way but thank you yes, I would like something21:35
betherlyif work on something already exists in review it seems to make sense to me to get it in there and then see if we need either/or/both moving forward21:35
anteayapleia2: great thanks, could you add your thoughts in a comment?21:35
betherlyfrom the sounds of it though i think both side by side could be really useful21:35
pleia2anteaya: will do21:35
anteayabetherly: oh thank you, do you have time to add your thoughts to https://review.openstack.org/#/c/32547421:35
anteayapleia2: thanks21:35
betherlyanteaya: absolutely21:35
anteayabetherly: and I agree21:35
anteayabetherly: thank you21:35
betherlywill take a look :)21:35
anteaya:)21:36
anteayaSotK: that is a good question, I do not know the answer21:41
*** alexismonville has joined #storyboard21:41
anteayabut on the other hand, 3.2.0 works21:41
anteayabut I dont' know what is over-riding requirements.txt21:41
anteayaoh also SotK Zara pedroalvarez congratulations on the new government, I hope they treat you better than the prior government21:42
anteayaSotK: nope that isn't the fix, this one installed 3.2.0 and failed: http://logs.openstack.org/10/341810/1/check/gate-storyboard-python34-db/00fb6b3/console.html#_2016-07-13_21_38_16_34186821:43
*** alexismonville has quit IRC21:43
anteayaAttributeError: 'ExceptionContextImpl' object has no attribute 'engine'"21:43
anteaya:(21:43
anteayabetherly: thanks for the review21:45
SotK:(21:52
* SotK has no more ideas21:52
SotKre the government: I don't hold out much hope21:53
anteaya:(21:53
anteayalet's look at the test failures tomorrow, thanks for your time tonight21:54
*** jamesmcarthur has joined #storyboard21:56
*** jamesmcarthur has quit IRC22:01
betherlyanteaya: np22:01
*** alexismonville has joined #storyboard22:02
*** alexismonville has quit IRC22:06
*** jamesmcarthur has joined #storyboard22:25
*** jamesmcarthur has quit IRC22:33
*** jamesmcarthur has joined #storyboard22:36
*** jamesmcarthur has quit IRC22:40
*** jamesmcarthur has joined #storyboard22:44
*** jamesmcarthur has quit IRC22:51
*** jamesmcarthur has joined #storyboard22:54
*** jamesmcarthur has quit IRC22:56
*** jamesmcarthur has joined #storyboard22:58
*** jamesmcarthur has quit IRC23:00
*** jamesmcarthur has joined #storyboard23:01
*** jamesmcarthur has quit IRC23:06
*** jamesmcarthur has joined #storyboard23:06
*** jamesmcarthur has quit IRC23:08
*** jamesmcarthur has joined #storyboard23:19
*** jamesmcarthur has quit IRC23:21
*** jamesmcarthur has joined #storyboard23:23
*** jamesmcarthur has quit IRC23:32
*** jamesmcarthur has joined #storyboard23:43
*** jamesmcarthur has quit IRC23:46
*** jamesmcarthur has joined #storyboard23:47

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!