| *** alexismonville has joined #storyboard | 01:39 | |
| *** alexismonville has quit IRC | 02:10 | |
| *** davidlenwell has quit IRC | 04:28 | |
| *** davidlenwell has joined #storyboard | 04:38 | |
| *** bilaltariq has quit IRC | 06:18 | |
| *** bilaltariq has joined #storyboard | 06:21 | |
| SotK | anteaya: you need to use [ and ] rather than { and } for it to be a list :) | 07:35 |
|---|---|---|
| *** mrmartin has joined #storyboard | 07:58 | |
| *** jtomasek_ has joined #storyboard | 08:13 | |
| pedroalvarez | oh, openstack P naming poll | 08:45 |
| pedroalvarez | obviously, it has to be OpenStack Pedro | 08:46 |
| SotK | only sensible choice | 09:00 |
| Zara | the mascot can also be pedro | 09:25 |
| pedroalvarez | hah | 09:25 |
| *** alexismonville has joined #storyboard | 10:32 | |
| *** mrmartin has quit IRC | 11:15 | |
| *** mrmartin has joined #storyboard | 11:59 | |
| Zara | btw, zaro has been working on gerrit integration things over here: https://review.openstack.org/#/q/topic:its-storyboard | 12:12 |
| Zara | I mentioned in infra, but may as well repeat here-- I think one is failing because it's not finding a cert. the other may be related to the as-yet-unmerged refactor for java_home patch (https://review.openstack.org/#/c/331523/). otherwise I have no idea. | 13:25 |
| Zara | most of the patches are passing tests and just need more reviews | 13:26 |
| Zara | s/most/all/ | 13:27 |
| Zara | fdsfd wrong java_home patch... https://review.openstack.org/#/c/331523/ | 13:28 |
| Zara | dfdsfdsfds | 13:28 |
| *** jtomasek__ has joined #storyboard | 13:29 | |
| Zara | I thought I had linked an old version but I hadn't | 13:29 |
| Zara | Idk what's going wrong for the linting test for that patch, either | 13:29 |
| Zara | and now my watch is ended | 13:29 |
| *** jtomasek_ has quit IRC | 13:33 | |
| *** jamesmcarthur has joined #storyboard | 13:43 | |
| *** matthewbodkin has joined #storyboard | 13:44 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add quick non-permanent filter buttons for timeline events https://review.openstack.org/331748 | 13:59 |
| Zara | +A'd | 13:59 |
| SotK | ty :) | 14:03 |
| Zara | yw :) though now I'm going to make you sad having looked at the complex priorities ui | 14:06 |
| Zara | made a coupla points, one is something we could iterate on, the other I'd consider a bug | 14:06 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add quick non-permanent filter buttons for timeline events https://review.openstack.org/331748 | 14:21 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow comments to be edited by their owner https://review.openstack.org/333418 | 14:43 |
| Zara | oooh, didn't notice filter buttons had merged, yay | 14:44 |
| Zara | I merged it but generally assume things'll need a recheck, haha | 14:44 |
| pedroalvarez | hm.. | 14:45 |
| pedroalvarez | my ansible is now broken: | 14:46 |
| pedroalvarez | ValueError: ("Expected ',' or end-of-list in", "email>=4.0.2;python_version<'3.0'", 'at', ";python_version<'3.0'") | 14:46 |
| Zara | hm, how does it expect the end of the list to be shown? | 14:47 |
| Zara | sounds like that was caused by the requirements change for python 3 things | 14:47 |
| pedroalvarez | yes, looks like pip doesn't like that ";python_version" thing | 14:47 |
| pedroalvarez | although, maybe is my pip version | 14:47 |
| Zara | https://review.openstack.org/#/c/339286/ | 14:48 |
| Zara | line 25 here: https://review.openstack.org/#/c/339286/3/requirements.txt | 14:48 |
| Zara | since I can never remember how to link to lines in gerrit | 14:48 |
| pedroalvarez | yup, upgrading pip was needed | 14:49 |
| *** jamesmca_ has joined #storyboard | 15:02 | |
| *** jamesmcarthur has quit IRC | 15:02 | |
| anteaya | SotK: thank you I will try square brackets | 15:38 |
| *** jamesmca_ has quit IRC | 15:42 | |
| anteaya | SotK: thank you, square brackets work, sorry I didn't notice that you had used them earlier | 16:02 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Tags api https://review.openstack.org/338532 | 16:07 |
| anteaya | SotK: thank you, that should work now | 16:08 |
| anteaya | pedroalvarez, Zara: if you feel like reviewing as well ^^ | 16:08 |
| *** fay_ has quit IRC | 16:12 | |
| anteaya | pedroalvarez: thank you | 16:12 |
| pedroalvarez | np :) | 16:13 |
| anteaya | :) | 16:14 |
| Zara | sure, I'll take a look in a min (making a sandwich) | 16:14 |
| anteaya | Zara: mmm, food, good choice | 16:15 |
| anteaya | and thank you | 16:15 |
| *** jamesmcarthur has joined #storyboard | 16:16 | |
| * anteaya considers food | 16:17 | |
| *** jtomasek__ has quit IRC | 16:26 | |
| pedroalvarez | I feel like I have to ask here | 16:29 |
| pedroalvarez | does anybody know why this is failing? https://travis-ci.org/palvarez89/ansible-role-storyboard/builds/144208176 | 16:30 |
| Zara | I don't know. :/ I notice it says (see /opt/storyboard-webclient/.tox/grunt/log/grunt-1.log) ; is there anything useful in there? | 16:35 |
| Zara | otherwise if you know the last time it worked, we can try to narrow down which patch changed things | 16:35 |
| Zara | there have been a few requirementsy changes recently | 16:36 |
| anteaya | Zara: thank you | 16:36 |
| anteaya | is there someone with api skills you would like to review the patch? | 16:36 |
| pedroalvarez | Zara: if you see the last thing the test run, is a `cat` call to show that file | 16:37 |
| pedroalvarez | nothing interesting in there | 16:37 |
| Zara | ohh, sorry :/ | 16:37 |
| Zara | wow, I see it now. that's the most amazing log. | 16:38 |
| *** mrmartin has quit IRC | 16:38 | |
| Zara | anteaya: sotk probably, because he's spotted things I've missed in those patches in the past | 16:39 |
| Zara | but I won't block it, just leaving it a few hours so he has a chance to check | 16:39 |
| anteaya | Zara: ah okay great, yes thank you | 16:40 |
| pedroalvarez | so, as I understand it, when I do `tox -egrunt build`, that will gett all the dependencies in [testenv] | 16:40 |
| pedroalvarez | one of them is the storyboard-master tarball | 16:40 |
| pedroalvarez | and it tries to install it, but fails | 16:40 |
| Zara | hm, that seems weird, since isn't it trying to install the webclient? but that's the api? | 16:42 |
| Zara | (the command I use manually is `tox -egrunt_no_api` to do webclient things, so it's different) | 16:44 |
| Zara | so lines 705-706 seem odd to me but it's all new territory to me, so :S | 16:45 |
| pedroalvarez | aaah, that might help | 16:49 |
| pedroalvarez | "-egrunt_no_api" | 16:49 |
| Zara | hahaha, I checked my own grunt log and apparently it gives more information when it works. how useful... ¬_¬ | 16:51 |
| Zara | I hope that command helps, anyway | 16:51 |
| pedroalvarez | I'm sure it will :) | 16:53 |
| zaro | Zara: you can reference lines in gerrit by adding @<line number> to end of url | 16:55 |
| anteaya | zaro: I didn't know that | 16:58 |
| anteaya | thanks | 16:58 |
| Zara | zaro: aha, thank you! I'm sure someone's told me before. I tried #<line number> , but not quite close enough... | 16:58 |
| anteaya | zaro: also as a heads up, I have an item on today's agenda asking about the current status of the storyboard plugin: https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting#Agenda_for_next_meeting | 17:00 |
| anteaya | zaro: I'll be asking you | 17:00 |
| anteaya | Zara: I have some questions about the User api: https://review.openstack.org/#/c/338570/1 specifically the create and modify functions | 17:02 |
| anteaya | right now storyboard uses openid, for user creation, yes? | 17:02 |
| *** jamesmcarthur has quit IRC | 17:02 | |
| anteaya | in the api user creation is limited to superuser | 17:03 |
| anteaya | could the api user creation feature create a clash with openid user creation? | 17:03 |
| SotK | in what way? | 17:03 |
| anteaya | well that is what I am asking | 17:03 |
| anteaya | right now one of the user details is an openid key | 17:04 |
| *** mrmartin has joined #storyboard | 17:04 | |
| anteaya | if an admin created a user would that user have an openid key? | 17:04 |
| anteaya | because I think the openid key is the unique identifier, is it not? | 17:04 |
| SotK | if the admin gave it one over the api, I imagine so | 17:04 |
| *** matthewbodkin has quit IRC | 17:04 | |
| SotK | the unique identifier is the user id | 17:05 |
| anteaya | ah okay thanks | 17:05 |
| SotK | (the id is autogenerated by mysql) | 17:05 |
| anteaya | so storyboard can handle an admin creating a user without an openid key | 17:05 |
| anteaya | cool, thanks | 17:05 |
| SotK | I imagine so, but I don't know how that user would be able to log in to the web ui | 17:05 |
| anteaya | so I guess I need a superuser to tell me what the command should be then here, for Create a user: https://review.openstack.org/#/c/338570/1/storyboard/api/v1/users.py | 17:06 |
| anteaya | SotK: yeah, good point | 17:06 |
| SotK | but maybe an admin could generate an access token for the user so it can interact using the api | 17:06 |
| anteaya | I guess? | 17:06 |
| anteaya | can an admin generate access tokens for users that are not themselves? | 17:06 |
| anteaya | if yes, then I think we need an example of that in the token api examples | 17:07 |
| SotK | I'm not sure if they can or not, checking | 17:07 |
| anteaya | thanks | 17:07 |
| anteaya | SotK: any notes you have on your investigation please add comments to the user tokens api patch: https://review.openstack.org/#/c/339297/ | 17:07 |
| anteaya | and thank you | 17:08 |
| SotK | looking at the code I think they can | 17:09 |
| anteaya | I would have no way of creating an example for that | 17:10 |
| * SotK will create an example when he's cooked and made some phone calls | 17:10 | |
| anteaya | have you time to take a try at figuring out an example and then putting something as a comment on the tokens patch? | 17:10 |
| anteaya | ah, thank you | 17:10 |
| anteaya | yes food first | 17:11 |
| anteaya | and life | 17:11 |
| anteaya | life too | 17:11 |
| zaro | i'll be at meeting but thanks for heads up. | 17:13 |
| anteaya | thank you | 17:14 |
| anteaya | zaro: so if there are patches that are stuck or things that need attention or sorting out, do bring urls with you | 17:14 |
| *** jtomasek__ has joined #storyboard | 17:17 | |
| *** jtomasek__ has quit IRC | 17:22 | |
| pedroalvarez | Zara: that fixed the issue (now tested), thanks! :) | 17:24 |
| anteaya | yay! | 17:24 |
| *** mrmartin has quit IRC | 17:28 | |
| Zara | \o/ | 17:28 |
| Zara | glad it worked! | 17:29 |
| Zara | as for users, I haven't looked at user things at all so would only be able to tell you things that are already in the docs. | 17:29 |
| anteaya | okay thanks | 17:29 |
| anteaya | I'm not a superuser so can't use the create command myself | 17:30 |
| Zara | yeah, I think the small pool of superusers means there's less urgency to getting those commands up there, since aiui we want these so the wider community can test out the api | 17:31 |
| anteaya | oh well if we are happy merging patches that have TODO in the spaces for the superuser that makes my job easier and me really happy | 17:32 |
| anteaya | I can un-1 workflow a whole pile of patches | 17:32 |
| anteaya | can we do that? | 17:32 |
| Zara | personally, I'm fine with that, if the patches add at least some non-TODO info (which I think they all do, but I can't remember for sure) | 17:34 |
| anteaya | they do, yes | 17:35 |
| anteaya | thanks I'll unwip some patches | 17:35 |
| Zara | np :) | 17:37 |
| Zara | other people might have different opinions but that's my 2 cents | 17:37 |
| Zara | my approach to merging is generally 'is this better than no change?' | 17:37 |
| Zara | so I tend not to mind if things aren't in the ideal state. | 17:38 |
| anteaya | thank you | 17:38 |
| anteaya | well on the teams patch: https://review.openstack.org/#/c/339123/1 I only have one command on the patch, the rest are TODO, now I do have access to one more command but because neither storyboard nor storyboard-dev have any team objects I don't know how to form the only other command in that api that I can access as a guest | 17:40 |
| anteaya | Zara: I couldn't convinve you to create a team on -dev, could I Zara? a public team? | 17:41 |
| Zara | I *think* teams are only visible to admin users atm (through the ui, anyway). | 17:45 |
| Zara | yeah, there is no setting to make a team 'public' or 'private', and in practice they're navigated-to via the admin menu, though teams stuff is on the todo list | 17:46 |
| Zara | so we should be making them a bit nicer soonish | 17:46 |
| *** mrmartin has joined #storyboard | 17:46 | |
| Zara | hm, the users list on dev is a bit odd | 17:47 |
| Zara | oh, ha, nvm | 17:48 |
| Zara | it was just paginated... | 17:48 |
| anteaya | ah | 17:53 |
| anteaya | um okay then, well so far I only have one command for the teams api: https://review.openstack.org/#/c/339123/1 | 17:53 |
| anteaya | I'll unwip it | 17:53 |
| anteaya | if you don't want it merged with the sole command I can figure out please tell me what commands to add or tell me how I can figure out the commands myself | 17:54 |
| anteaya | right now I have done all I can figure out | 17:54 |
| Zara | okay. I suspect it will be fine like that, and we'll steadily fill out the todos, especially as the teams code may change a bit in the coming weeks | 18:00 |
| Zara | but we'll see if anyone feels strongly about it | 18:00 |
| * Zara disappears for a bit for dinner | 18:06 | |
| *** alexismonville has quit IRC | 18:07 | |
| *** jamesmcarthur has joined #storyboard | 18:11 | |
| anteaya | Zara: enjoy dinner | 18:17 |
| SotK | anteaya: I left some comments on https://review.openstack.org/#/c/339297/ | 18:50 |
| anteaya | SotK: thank you | 18:51 |
| anteaya | SotK: so the Delete command should be removed from documentation? | 18:53 |
| SotK | either we should make it possible to trigger the delete_all function or remove it entirely | 18:56 |
| anteaya | +1 remove it entirely | 18:57 |
| anteaya | since there is already functionality to delete a specific access token, and you can list all your access tokens | 18:58 |
| anteaya | so if you really want to delete all of them, have a loop | 18:58 |
| anteaya | then you aren't doing so by mistake | 18:58 |
| * SotK is fine with that | 18:59 | |
| anteaya | yay, thank you | 19:02 |
| anteaya | SotK: I'll just ignore it in my examples patch then and let you follow up with a patch to remove? | 19:02 |
| SotK | anteaya: is there any chance you could also send the patch to remove it please? :) | 19:04 |
| anteaya | I can do that, just remove the documenation or remove the api code as well? | 19:04 |
| SotK | the code too, since it is currently serving no purpose | 19:05 |
| anteaya | very good I will propose a patch | 19:06 |
| anteaya | thank you | 19:06 |
| SotK | thanks | 19:07 |
| *** jamesmcarthur has quit IRC | 20:04 | |
| *** jamesmcarthur has joined #storyboard | 20:06 | |
| *** mrmartin has quit IRC | 20:19 | |
| *** jamesmcarthur has quit IRC | 21:02 | |
| *** jamesmcarthur has joined #storyboard | 21:02 | |
| *** jamesmcarthur has quit IRC | 21:09 | |
| *** jamesmcarthur has joined #storyboard | 21:09 | |
| *** jamesmcarthur has quit IRC | 21:13 | |
| *** jamesmcarthur has joined #storyboard | 21:13 | |
| *** alexismonville has joined #storyboard | 21:18 | |
| *** jamesmcarthur has quit IRC | 21:31 | |
| *** jamesmcarthur has joined #storyboard | 21:31 | |
| *** jamesmcarthur has quit IRC | 21:36 | |
| *** jamesmcarthur has joined #storyboard | 21:39 | |
| *** jamesmcarthur has quit IRC | 21:39 | |
| *** alexismonville has quit IRC | 23:13 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!