openstackgerrit | Clark Boylan proposed openstack-infra/storyboard: Use a common requirements file https://review.openstack.org/339286 | 00:11 |
---|---|---|
*** jamesmcarthur has joined #storyboard | 00:15 | |
*** jamesmcarthur has quit IRC | 00:19 | |
openstackgerrit | Clark Boylan proposed openstack-infra/storyboard: Use a common requirements file https://review.openstack.org/339286 | 00:27 |
openstackgerrit | Merged openstack-infra/storyboard: Add a py35 textenv to tox.ini https://review.openstack.org/339270 | 00:46 |
*** jamesmcarthur has joined #storyboard | 00:53 | |
*** jamesmcarthur has quit IRC | 00:58 | |
*** jamesmcarthur has joined #storyboard | 01:16 | |
*** jamesmcarthur has quit IRC | 01:20 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the User Tokens api https://review.openstack.org/339297 | 01:21 |
*** AJaeger has joined #storyboard | 07:08 | |
AJaeger | My changes for binary dependencies to support xenial in CI system are ready https://review.openstack.org/#/c/335826 and https://review.openstack.org/#/c/335824. | 07:09 |
*** mrmartin has joined #storyboard | 07:27 | |
*** ttx has quit IRC | 07:55 | |
*** ttx has joined #storyboard | 07:56 | |
*** mrmartin has quit IRC | 08:05 | |
*** pedroalvarez has quit IRC | 08:44 | |
*** pedroalvarez has joined #storyboard | 08:46 | |
*** aswadr_ has joined #storyboard | 09:17 | |
*** alexismonville has joined #storyboard | 10:00 | |
*** alexismonville has quit IRC | 10:05 | |
*** bethwhite has quit IRC | 10:37 | |
*** bethwhite has joined #storyboard | 10:37 | |
*** alexismonville has joined #storyboard | 13:03 | |
*** jamesmcarthur has joined #storyboard | 13:19 | |
*** alexismonville has quit IRC | 13:24 | |
openstackgerrit | Merged openstack-infra/storyboard: Add a paragraph instructing api users how to get a token https://review.openstack.org/339213 | 13:25 |
*** jamesmcarthur has quit IRC | 13:31 | |
*** jamesmcarthur has joined #storyboard | 13:37 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add support for notifications from subscribed worklists https://review.openstack.org/339557 | 13:42 |
*** jamesmcarthur has quit IRC | 13:47 | |
*** jamesmcarthur has joined #storyboard | 13:53 | |
*** mrmartin has joined #storyboard | 13:55 | |
*** jamesmcarthur has quit IRC | 13:56 | |
*** jamesmcarthur has joined #storyboard | 13:57 | |
*** jamesmcarthur has quit IRC | 14:00 | |
*** jamesmcarthur has joined #storyboard | 14:00 | |
*** mrmartin has quit IRC | 14:04 | |
*** jamesmcarthur has quit IRC | 14:21 | |
*** jamesmcarthur has joined #storyboard | 14:24 | |
*** jamesmcarthur has quit IRC | 14:30 | |
*** jamesmcarthur has joined #storyboard | 14:39 | |
anteaya | hey folks | 14:40 |
pedroalvarez | good morning anteaya :) | 14:40 |
anteaya | so https://review.openstack.org/#/c/337730/ the projects and project groups api examples patch is ready for review pedroalvarez SotK | 14:40 |
anteaya | pedroalvarez: how are you today? | 14:41 |
SotK | hey anteaya | 14:41 |
pedroalvarez | good, friday mood :) | 14:41 |
anteaya | SotK: hey there | 14:41 |
anteaya | pedroalvarez: nice | 14:41 |
anteaya | :) | 14:41 |
anteaya | did you see I added a bit in the tox.ini file to get python35 tests passing? | 14:42 |
anteaya | it merged last night | 14:42 |
anteaya | https://review.openstack.org/#/c/339270/ | 14:42 |
anteaya | that gets the python35-db-nv job passing | 14:43 |
pedroalvarez | should we make it that job a "voting" one? | 14:43 |
anteaya | well not yet | 14:43 |
anteaya | as there is another patch up | 14:43 |
anteaya | https://review.openstack.org/#/c/339286/2 | 14:43 |
*** dmsimard is now known as dmsimard|afk | 14:44 | |
anteaya | I talked with clarkb last night and he feels we should have a separate requirements file for py3 | 14:44 |
anteaya | so he offered the above patch | 14:44 |
anteaya | which is failing right now as he also has to increase the hacking version | 14:44 |
anteaya | he said he will fix the patch today | 14:44 |
anteaya | once he does then we can discuss when to merge it | 14:45 |
anteaya | I would be in favour of keeping the py35 jobs non-voting until clarkb's patch merges | 14:45 |
anteaya | then if there is a problem storyboard isnt' blocked | 14:45 |
anteaya | if the test is still working after we exercise it a bit with clark's patch in place, then making it voting | 14:46 |
anteaya | pedroalvarez: what do you think? | 14:46 |
anteaya | sorry, clark feels we should _not_ have a separate requirements file for py3 | 14:46 |
pedroalvarez | that makes sense | 14:47 |
anteaya | thanks | 14:47 |
anteaya | SotK: have you any thoughts? | 14:47 |
pedroalvarez | I didn't know you could set conditionals on the python_verion in the requirements file | 14:47 |
pedroalvarez | that's neat | 14:47 |
anteaya | I didn't know either | 14:48 |
anteaya | I think it might be new | 14:48 |
anteaya | but I don't know what provided that functionality? | 14:48 |
anteaya | pbr maybe? | 14:48 |
pedroalvarez | pip would be my guess | 14:48 |
pedroalvarez | no idea | 14:49 |
anteaya | ah that would make sense | 14:50 |
SotK | I think we should keep it non-voting until we're sure there won't be problems | 14:50 |
* pedroalvarez nods | 14:50 | |
*** jamesmcarthur has quit IRC | 14:51 | |
anteaya | that sounds reasonable to me | 14:51 |
anteaya | SotK: any thoughts on clark's patch? | 14:51 |
anteaya | is his approach okay with you? | 14:52 |
*** jamesmcarthur has joined #storyboard | 14:53 | |
pedroalvarez | i'm curious about the "email" python package, won't be needed in py3? | 14:57 |
anteaya | clark didn't seem to feel it was needed at all | 14:58 |
anteaya | as he felt it was included in standard lib | 14:59 |
SotK | its in the 2.7 standard lib too isn't it? | 15:00 |
SotK | a single requirements.txt seems sensible to me | 15:01 |
anteaya | thanks | 15:01 |
anteaya | yeah if we don't need to call out the email package perhaps we shouldn't | 15:01 |
anteaya | clarkb was asking why it was called out specifically | 15:02 |
anteaya | do you happen to know? | 15:03 |
SotK | I do not | 15:04 |
*** jamesmca_ has joined #storyboard | 15:06 | |
*** jamesmcarthur has quit IRC | 15:06 | |
anteaya | okay thanks | 15:06 |
*** jamesmca_ has quit IRC | 15:11 | |
pedroalvarez | it looks like it was added on the initial work for adding email support, and that we can remove it now | 15:11 |
pedroalvarez | oh no, it's not included in 2.6 | 15:11 |
pedroalvarez | maybe that's why | 15:11 |
*** jamesmcarthur has joined #storyboard | 15:13 | |
anteaya | ah | 15:15 |
*** jamesmcarthur has quit IRC | 15:15 | |
anteaya | well that begs my follow up question | 15:15 |
anteaya | once we get python35 tests in place | 15:15 |
anteaya | is anyone open to the idea of supporting python 3 going forward and dropping support for python 2? | 15:15 |
*** jamesmcarthur has joined #storyboard | 15:17 | |
pedroalvarez | oh, python 2.7 EOL is in 2020 | 15:19 |
pedroalvarez | not soon, but probably going forward is a good idea | 15:19 |
pedroalvarez | btw, regarding the "email" import, it is built-in 2.7, which looks like the only py2 version we support right now | 15:20 |
anteaya | so we can remove the email direct import? | 15:22 |
* SotK is happy for that to happen | 15:24 | |
*** jamesmcarthur has quit IRC | 15:25 | |
anteaya | SotK: okay great | 15:27 |
*** jamesmcarthur has joined #storyboard | 15:29 | |
pedroalvarez | actually, commit 1a924e2 "removed support" for py3 | 15:30 |
pedroalvarez | in setup.cfg | 15:30 |
* pedroalvarez stops digging around | 15:31 | |
anteaya | oh? | 15:31 |
anteaya | no keep digging | 15:31 |
pedroalvarez | hah | 15:31 |
pedroalvarez | I think it will be more useful to just move forward, and stop worrying about the commit history | 15:31 |
anteaya | yeah, you are right | 15:32 |
anteaya | https://review.openstack.org/#/c/154582/1 but to her credit yolanda did ask why, though never got a response | 15:32 |
pedroalvarez | I mean, the history of the project is a bit messy, and sometimes will be difficult to understand the reasons | 15:33 |
anteaya | yes, and in many cases the reasons have changed | 15:33 |
pedroalvarez | yup | 15:33 |
*** jamesmcarthur has quit IRC | 15:44 | |
anteaya | pedroalvarez: have you time to give the projects api patch a review? https://review.openstack.org/#/c/337730/ | 15:51 |
*** jamesmcarthur has joined #storyboard | 15:53 | |
*** AJaeger has left #storyboard | 15:59 | |
*** mrmartin has joined #storyboard | 16:00 | |
pedroalvarez | sure :) | 16:00 |
openstackgerrit | Clark Boylan proposed openstack-infra/storyboard: Use a common requirements file https://review.openstack.org/339286 | 16:06 |
*** jamesmcarthur has quit IRC | 16:10 | |
*** jamesmcarthur has joined #storyboard | 16:12 | |
*** jamesmcarthur has quit IRC | 16:29 | |
*** jamesmcarthur has joined #storyboard | 16:35 | |
*** mrmartin has quit IRC | 16:38 | |
*** mrmartin has joined #storyboard | 16:39 | |
anteaya | pedroalvarez: thank you! | 16:40 |
*** jamesmcarthur has quit IRC | 16:42 | |
*** jamesmcarthur has joined #storyboard | 16:45 | |
*** mrmartin has quit IRC | 16:46 | |
*** mrmartin has joined #storyboard | 16:47 | |
*** jamesmcarthur has quit IRC | 16:51 | |
*** mrmartin has quit IRC | 16:52 | |
*** jamesmcarthur has joined #storyboard | 16:54 | |
*** dmsimard|afk is now known as dmsimard | 16:54 | |
*** jamesmcarthur has quit IRC | 17:00 | |
*** jamesmcarthur has joined #storyboard | 17:02 | |
*** jamesmcarthur has quit IRC | 17:06 | |
*** jamesmcarthur has joined #storyboard | 17:09 | |
*** jamesmcarthur has quit IRC | 17:19 | |
*** jamesmcarthur has joined #storyboard | 17:27 | |
anteaya | SotK: would you have time to revie this today? https://review.openstack.org/#/c/337730/ should be ready to merge | 17:34 |
anteaya | review | 17:34 |
*** jamesmcarthur has quit IRC | 17:34 | |
*** jamesmcarthur has joined #storyboard | 17:38 | |
*** jamesmcarthur has quit IRC | 17:46 | |
*** jamesmcarthur has joined #storyboard | 17:51 | |
*** jamesmcarthur has quit IRC | 18:09 | |
*** jamesmcarthur has joined #storyboard | 18:16 | |
*** jamesmcarthur has quit IRC | 18:27 | |
*** jamesmcarthur has joined #storyboard | 18:36 | |
*** jamesmcarthur has quit IRC | 18:52 | |
*** jamesmcarthur has joined #storyboard | 18:56 | |
*** aswadr_ has quit IRC | 19:01 | |
*** jamesmcarthur has quit IRC | 19:04 | |
*** jamesmcarthur has joined #storyboard | 19:08 | |
*** jamesmcarthur has quit IRC | 19:15 | |
*** jamesmcarthur has joined #storyboard | 19:22 | |
*** jamesmcarthur has quit IRC | 19:36 | |
*** jamesmcarthur has joined #storyboard | 19:39 | |
*** jamesmcarthur has quit IRC | 19:51 | |
*** jamesmcarthur has joined #storyboard | 19:55 | |
*** jamesmcarthur has quit IRC | 20:05 | |
*** jamesmcarthur has joined #storyboard | 20:16 | |
*** jamesmcarthur has quit IRC | 20:26 | |
*** jamesmcarthur has joined #storyboard | 20:27 | |
*** jamesmcarthur has quit IRC | 20:29 | |
*** jamesmcarthur has joined #storyboard | 20:32 | |
*** jamesmcarthur has quit IRC | 20:32 | |
*** jamesmcarthur has joined #storyboard | 20:55 | |
*** jamesmcarthur has quit IRC | 21:05 | |
*** jamesmcarthur has joined #storyboard | 21:14 | |
*** jamesmcarthur has quit IRC | 21:26 | |
*** jamesmcarthur has joined #storyboard | 21:31 | |
*** jamesmcarthur has quit IRC | 21:40 | |
*** jamesmcarthur has joined #storyboard | 21:46 | |
*** jamesmcarthur has quit IRC | 21:55 | |
*** jamesmcarthur has joined #storyboard | 21:56 | |
*** alexismonville has joined #storyboard | 21:57 | |
*** jamesmcarthur has quit IRC | 22:00 | |
*** jamesmcarthur has joined #storyboard | 22:04 | |
*** jamesmcarthur has quit IRC | 22:11 | |
*** davidlenwell has quit IRC | 22:12 | |
*** jamesmcarthur has joined #storyboard | 22:13 | |
*** alexismonville has quit IRC | 22:13 | |
*** alexismonville has joined #storyboard | 22:18 | |
*** jamesmcarthur has quit IRC | 22:19 | |
*** davidlenwell has joined #storyboard | 22:22 | |
*** alexismonville has quit IRC | 22:41 | |
*** alexismonville has joined #storyboard | 22:45 | |
*** alexismonville has quit IRC | 23:04 | |
*** jamesmcarthur has joined #storyboard | 23:10 | |
*** jamesmcarthur has quit IRC | 23:14 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!