*** bethwhite has quit IRC | 00:01 | |
*** bethwhite has joined #storyboard | 00:01 | |
*** dmsimard|afk is now known as dmsimard | 00:18 | |
*** jamesmcarthur has joined #storyboard | 00:19 | |
*** jamesmcarthur has quit IRC | 00:24 | |
*** mrmartin has joined #storyboard | 06:40 | |
*** mrmartin has quit IRC | 06:58 | |
*** fay_ has joined #storyboard | 07:14 | |
*** mrmartin has joined #storyboard | 07:35 | |
*** mrmartin has quit IRC | 07:57 | |
*** mrmartin has joined #storyboard | 08:00 | |
*** mrmartin has quit IRC | 08:17 | |
*** openstackgerrit has quit IRC | 08:18 | |
*** openstackgerrit has joined #storyboard | 08:18 | |
*** mrmartin has joined #storyboard | 08:22 | |
*** mrmartin has quit IRC | 09:07 | |
*** mrmartin has joined #storyboard | 09:10 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 09:58 |
---|---|---|
*** alexismonville has joined #storyboard | 10:08 | |
*** mrmartin has quit IRC | 10:31 | |
*** mrmartin has joined #storyboard | 10:33 | |
*** mrmartin has quit IRC | 11:02 | |
*** mrmartin has joined #storyboard | 11:25 | |
*** mrmartin has quit IRC | 12:37 | |
*** mrmartin has joined #storyboard | 12:51 | |
*** alexismonville has quit IRC | 13:00 | |
anteaya | hey there SotK | 13:05 |
anteaya | I'm wondering if there is anything on this list you are comfortable merging? https://review.openstack.org/#/q/topic:expand-api-docs | 13:06 |
pedroalvarez | wow, various patches over there | 13:10 |
anteaya | various is a very nice word :) | 13:16 |
anteaya | I'd like to get a few merged before the list gets too much longer | 13:17 |
anteaya | long lists feel overwhelming and tend to repel reviewers rather than entice them | 13:17 |
* SotK kinda feels like they should get another +1 before being merged :) | 13:21 | |
pedroalvarez | i can help with that | 13:21 |
SotK | thanks pedroalvarez | 13:32 |
pedroalvarez | np | 13:33 |
anteaya | thank you | 13:34 |
anteaya | SotK: and yes, that is perfectly reasonable, thanks for saying so | 13:34 |
*** alexismonville has joined #storyboard | 13:45 | |
openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the Systeminfo api https://review.openstack.org/337888 | 13:50 |
openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the Timeline api https://review.openstack.org/337854 | 13:50 |
openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the Tasks api https://review.openstack.org/337879 | 13:50 |
anteaya | thank you | 13:51 |
anteaya | pedroalvarez: would you have time to review the Subscriptions api examples as well? https://review.openstack.org/#/c/338561/ | 13:59 |
pedroalvarez | yup | 14:00 |
anteaya | thanks :) | 14:00 |
pedroalvarez | looks good | 14:01 |
pedroalvarez | and also, more docs are always good | 14:01 |
anteaya | pedroalvarez: thanks so much | 14:01 |
*** jamesmcarthur has joined #storyboard | 14:01 | |
anteaya | yes, useful documentation is so helpful | 14:01 |
*** alexismonville has quit IRC | 14:01 | |
pedroalvarez | thanks for that | 14:03 |
anteaya | :) | 14:04 |
anteaya | welcome | 14:04 |
anteaya | glad I can do something useful | 14:04 |
pedroalvarez | I think I'm going to abandon https://review.openstack.org/#/c/303499/ | 14:05 |
pedroalvarez | although I like latest suggestion in https://storyboard.openstack.org/#!/story/2000543 | 14:08 |
* SotK likes that idea too | 14:09 | |
*** mrmartin has quit IRC | 14:09 | |
pedroalvarez | does openstack have something like jsfiddle.net? | 14:15 |
anteaya | pedroalvarez: I don't know what that is | 14:16 |
anteaya | it looks like some form of online editing and evaluation tool | 14:16 |
* persia doesn't understand why something like that would be in project infrastructure, rather than just global public resource | 14:17 | |
anteaya | I have not seen anything like that tool that is specific to openstack | 14:17 |
pedroalvarez | a place where you can put html, js, css, and more, so that you can share it | 14:17 |
anteaya | ah it is for sharing | 14:17 |
anteaya | cool | 14:17 |
persia | Yes, very cool. | 14:17 |
anteaya | yes I have never seen such a thing before | 14:17 |
anteaya | and don't believe openstack has such a tool dedicated to our use | 14:18 |
anteaya | could we use this one for the time being? | 14:18 |
anteaya | is that allowed or does one have to sign in to be able to use and view items | 14:18 |
pedroalvarez | looks free to use, without any account | 14:20 |
pedroalvarez | https://jsfiddle.net/3c19goqj/ | 14:21 |
pedroalvarez | just wanted to share the idea ^ | 14:21 |
anteaya | that is a great idea, pedroalvarez | 14:25 |
anteaya | thanks for sharing | 14:25 |
anteaya | also that little progress bar looks appealing to me | 14:26 |
anteaya | SotK: would you have time for a +A as the Subscriptions examples have pedroalvarez's +1 on them: https://review.openstack.org/#/c/338561/ ? | 14:57 |
anteaya | the patches that have merged already are still in post | 14:57 |
SotK | done :) | 15:05 |
openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the Subscriptions api https://review.openstack.org/338561 | 15:17 |
anteaya | thank you | 15:19 |
anteaya | :) | 15:19 |
*** davidlenwell has quit IRC | 15:20 | |
anteaya | the patch for projects and project groups I need admin assistance with the commands: https://review.openstack.org/#/c/337730/ I think that is the highest priority of the patches that still need work | 15:28 |
*** davidlenwell has joined #storyboard | 15:30 | |
anteaya | SotK: I'm assuming teams is also an admin only function in terms of creation and modification? | 15:41 |
anteaya | given the speed with which the admin only commands are getting addressed I am thinking that what I will do is finish a first pass of all of the sections in the api doc filling it what I can as a registered user and then request admin on the -dev server so that I can address the admin commands myself (or try to) | 15:50 |
anteaya | I'm open to feedback on that proposal | 15:50 |
anteaya | I'm not complaining just noting that everyone with admin access is very very busy | 15:55 |
*** jamesmcarthur has quit IRC | 16:39 | |
*** jamesmcarthur has joined #storyboard | 16:40 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Teams api https://review.openstack.org/339123 | 16:42 |
*** mrmartin has joined #storyboard | 16:44 | |
*** mrmartin has quit IRC | 16:44 | |
*** mrmartin has joined #storyboard | 16:51 | |
*** jamesmcarthur has quit IRC | 16:55 | |
*** mrmartin has quit IRC | 17:03 | |
*** jamesmcarthur has joined #storyboard | 17:10 | |
*** jamesmcarthur has quit IRC | 17:14 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the User Preferences api https://review.openstack.org/339148 | 17:16 |
anteaya | SotK: pedroalvarez this one is just two commands and should be good to go once it passes tests: https://review.openstack.org/#/c/339148/1 | 17:17 |
anteaya | which it has done successfully | 17:49 |
*** jamesmcarthur has joined #storyboard | 18:11 | |
*** jamesmcarthur has quit IRC | 18:11 | |
*** jamesmcarthur has joined #storyboard | 18:11 | |
anteaya | thank you | 18:31 |
SotK | yw :) | 18:32 |
anteaya | :) | 18:39 |
SotK | anteaya: http://paste.openstack.org/show/527030/ is the project commands | 19:19 |
anteaya | yayyyyyy! | 19:20 |
anteaya | thank you thank you thank you | 19:20 |
SotK | I'll do the project group ones when I've eaten :) | 19:21 |
anteaya | thank you so much | 19:22 |
anteaya | yes enjoy food, I'll update the projects file | 19:22 |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Project api https://review.openstack.org/337730 | 19:31 |
anteaya | SotK: I added you as Co-Authored-By on that patch, please check I have your information correct | 19:32 |
* pleia2 does another once over of that patch | 19:32 | |
anteaya | pleia2: thank you | 19:33 |
pleia2 | anteaya: are you planning on filling in the TODOs in this patch, or are these going to continue to be placeholders until another patch? | 19:35 |
pleia2 | also, good work figuring out the \\ syntax for literal backslashes in the examples, I learned something today :) | 19:36 |
anteaya | pleia2: SotK said he will give me the commands for the project groups once he as had something to eat, so hopefully by the end of today 337730 will have all its TODO's filled in with commands | 19:37 |
pleia2 | wonderful | 19:37 |
anteaya | pleia2: thank you, I took a chance and it worked :) | 19:37 |
anteaya | thanks for being here to review | 19:37 |
anteaya | I know Adam appreciates not having to merged things noone else has had a chance to review | 19:38 |
anteaya | s/merged/merge | 19:38 |
anteaya | pleia2: 339148 is all finished if you feel like reviewing that one | 19:39 |
pleia2 | anteaya: will do | 19:40 |
anteaya | thank you :) | 19:41 |
pleia2 | anteaya: I noted in the other change, but is there any reason you're using my.example.org ? | 19:41 |
anteaya | khai suggested it as a neutral domain that was neither storyboard nor storyboard-dev | 19:41 |
anteaya | I have it in all the examples | 19:41 |
pleia2 | example.org (and .net, .com) are standard top-level domains set aside in RFC 2606, and I'm not sure why a subdomain should be used instead | 19:41 |
pleia2 | my issue is just with the my. | 19:41 |
pleia2 | in our other docs we just tend to use example.com | 19:42 |
anteaya | Khai suggested it and I didn't question it | 19:42 |
anteaya | if you want me to change all the patches I can do so | 19:42 |
pleia2 | fair enough | 19:42 |
anteaya | can we live with the my. subdomain? | 19:42 |
pleia2 | it's not a big deal, just not quite in line with what I expect | 19:42 |
anteaya | okay thanks for mentioning it | 19:42 |
anteaya | I honestly hadn't thought about it | 19:43 |
pleia2 | if it was something other than example.com/.net/.org I would request a change because they are reserved, but a using subdomain is just a nitpick :) | 19:43 |
anteaya | okay thanks | 19:43 |
anteaya | after we get the api docs usable if you feel strongly about it, I can change it | 19:44 |
anteaya | pleia2: if you look at the docs: http://docs.openstack.org/infra/storyboard/webapi/v1.html so far stories, timeline, tasks, subscriptions and system info have merged | 19:52 |
anteaya | so that is the sort of template I have been following for the rest of the patches | 19:52 |
pleia2 | anteaya: yeah that's fine, nice work on those, they're really valuable | 19:53 |
anteaya | okay great thanks | 19:53 |
anteaya | I do agree with you on the tokens bit | 19:53 |
anteaya | let me figure out a patch that can go at the top of the file | 19:54 |
pleia2 | anteaya: ok, that will explain it for all the sections that reference MY_ACCESS_TOKEN? (looking to +A 339148 but I can wait if you want to add any text to that patch for this) | 19:56 |
*** mrmartin has joined #storyboard | 19:58 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add a paragraph instructing api users how to get a token https://review.openstack.org/339213 | 20:02 |
anteaya | pleia2: I put it at the very top of the page | 20:03 |
* pleia2 thumbs up | 20:04 | |
anteaya | thank you | 20:06 |
anteaya | I'm glad you said something, I had been feeling the same thing I just hadn't taken the time to do anything about it | 20:06 |
*** jamesmcarthur has quit IRC | 20:08 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Project api https://review.openstack.org/337730 | 20:12 |
anteaya | pep8 was upset with me | 20:13 |
anteaya | line too long | 20:13 |
openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the User Preferences api https://review.openstack.org/339148 | 20:19 |
anteaya | yay! | 20:20 |
*** mrmartin has quit IRC | 20:21 | |
*** mrmartin has joined #storyboard | 20:22 | |
*** jamesmcarthur has joined #storyboard | 20:28 | |
*** alexismonville has joined #storyboard | 20:56 | |
SotK | anteaya: project groups: http://paste.openstack.org/show/527356/ | 21:04 |
anteaya | yay! | 21:04 |
anteaya | thank you | 21:04 |
anteaya | SotK: and are all those project group commands admin only, as I had thought? | 21:04 |
SotK | indeed | 21:06 |
SotK | admin only commands have the `@secure(checks.superuser)` decorator on the relevant function | 21:06 |
SotK | similarly, commands available only to authenticated users have `@secure(checks.authenticated)` | 21:07 |
anteaya | ah, I will look for that decorator thank you | 21:15 |
anteaya | good to know | 21:15 |
anteaya | will submit a new patch after the nova meeting | 21:15 |
*** alexismonville has quit IRC | 21:20 | |
*** mrmartin has quit IRC | 21:55 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Project api https://review.openstack.org/337730 | 21:58 |
anteaya | SotK: thank you | 22:00 |
anteaya | SotK: I think the next highest priority it the Tags api one, I think there are some bugs in it: https://review.openstack.org/#/c/338532/ | 22:00 |
anteaya | I left notes in the comments | 22:00 |
anteaya | s/it/is | 22:00 |
*** jamesmcarthur has quit IRC | 22:06 | |
*** jamesmcarthur has joined #storyboard | 22:46 | |
*** jamesmcarthur has quit IRC | 22:51 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add a py35 textenv to tox.ini https://review.openstack.org/339270 | 23:18 |
*** jamesmcarthur has joined #storyboard | 23:49 | |
*** jamesmcarthur has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!