| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 00:04 |
|---|---|---|
| *** jamesmcarthur has joined #storyboard | 00:24 | |
| *** jamesmcarthur has quit IRC | 00:29 | |
| openstackgerrit | Merged openstack-infra/storyboard: Allow users to be filtered by openid and email https://review.openstack.org/333567 | 00:37 |
| *** zara_the_gloomy_ has joined #storyboard | 01:30 | |
| zara_the_gloomy_ | can't sleep. also, conwy, bury, wat. you've got some explaining to do. | 01:31 |
| *** zara_the_gloomy_ has quit IRC | 01:31 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 01:34 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 02:56 |
| *** alexismonville has joined #storyboard | 07:00 | |
| * SotK expected nothing different from Bury | 07:09 | |
| *** alexismonville has quit IRC | 07:19 | |
| *** zara_the_gloomy has joined #storyboard | 08:06 | |
| zara_the_gloomy | ;_; looks like my sample of the population was unrepresentative. | 08:09 |
| SotK | yes | 08:11 |
| betherly | Shocked | 08:15 |
| zara_the_gloomy | (I actually suspect they won't go through with it, but the damage is done. the far-right fringe is now perceived as a legitimate contender for leading the country, and they're getting the platform to match, along with a chain-reaction across europe. :( ) | 08:20 |
| zara_the_gloomy | well this isn't the channel for that, anyway... | 08:21 |
| zara_the_gloomy | *sigh* | 08:21 |
| *** jamesmcarthur has joined #storyboard | 08:29 | |
| *** jamesmcarthur has quit IRC | 08:33 | |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333810 | 08:34 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333810 | 08:36 |
| zara_the_gloomy | \o/ | 08:43 |
| zara_the_gloomy | I'll be in in a bit. though I promised at around 11 last night to review various things, so might take me a while to get to it. | 08:44 |
| zara_the_gloomy | also we're all terribly demotivated FOR SOME REASON | 08:45 |
| zara_the_gloomy | but glad to see you were fine submitting the change! | 08:46 |
| *** zara_the_gloomy has quit IRC | 08:46 | |
| SotK | woo, thanks for the patch bilaltariq | 08:47 |
| bilaltariq | SotK, :) I tried to squash another change with that previous commit that I pushed, but I don't see it on the review site | 08:49 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333820 | 08:55 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333828 | 09:00 |
| SotK | bilaltariq: btw, when squashing commits like that you can remove all the change-id lines that aren't from the base commit, they're only used by gerrit to keep track of different versions of a change | 09:02 |
| bilaltariq | alright. If I add --amend to git commit, and then do git review again, will it change the last patch that I made? because I think I just created 4 different patches | 09:05 |
| bilaltariq | I've abandoned all but the latest one | 09:05 |
| SotK | yeah, it will | 09:05 |
| SotK | thanks :) | 09:05 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333828 | 09:09 |
| bilaltariq | I was just testing the change-id and signature bit there, no code was changed. | 09:09 |
| *** faybrocklebank has quit IRC | 10:27 | |
| *** faybrocklebank has joined #storyboard | 10:27 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix alignment of long-running simple events https://review.openstack.org/333225 | 10:49 |
| Zara | ah, pep8 doesn't like the number of blank lines yet for the worklist api update | 11:04 |
| Zara | oh nvm I was on an old one | 11:04 |
| Zara | and that has been covered | 11:04 |
| Zara | ignore me | 11:04 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333828 | 11:09 |
| *** alexismonville has joined #storyboard | 11:27 | |
| Zara | betherly: how's it going? the bugsquash officially ended without me noticing, but every second is a bugsquash second really | 11:27 |
| *** jtomasek_ has joined #storyboard | 12:01 | |
| bilaltariq | For WorklistItems, a string 'item_type' is sent and it can be either "Story or "Task" and then depending on that value, the response has another field with the actual Task/Story object. Would it not be better to request the object from the task/story endpoints instead of sending it with the worklists | 12:09 |
| SotK | perhaps, but this is another place that the API is tied to the webclient a bit | 12:10 |
| SotK | since the webclient worked better when being able to get the entire contents of a board in one go, rather than piecemeal | 12:11 |
| bilaltariq | For these types of responses, would you suggest having the python client use the same data or rerequest it every time it's needed | 12:12 |
| SotK | I'd recommend using the same data | 12:14 |
| SotK | rather than having to send a large number of GETs | 12:14 |
| *** jtomasek_ has quit IRC | 12:40 | |
| *** jtomasek has quit IRC | 12:46 | |
| *** jtomasek has joined #storyboard | 12:47 | |
| *** alexismonville has quit IRC | 13:28 | |
| openstackgerrit | Merged openstack-infra/python-storyboardclient: Updated Worklist API https://review.openstack.org/333828 | 13:29 |
| *** alexismonville has joined #storyboard | 13:30 | |
| Zara | \o/ | 13:35 |
| * Zara gloomily looks at the exchange rate | 13:48 | |
| Zara | er, I mean, any patches people want me to look at? | 13:48 |
| SotK | task notes ones? :D | 13:52 |
| SotK | or maybe write some yourself to distract from the exchange rate :) | 13:52 |
| pedroalvarez | I'm planning on introducing email threading in StoryBoard. Fancy some distracting bikeshedding? | 13:53 |
| Zara | hah, I asked because I knew I had a massive queue so just wondered what people cared about | 13:53 |
| Zara | BUT YES PLEASE | 13:53 |
| Zara | bikeshed requires more thought | 13:54 |
| SotK | yes please | 13:54 |
| Zara | o/ | 13:54 |
| Zara | \o | 13:54 |
| Zara | fine | 13:54 |
| pedroalvarez | hahah, sorry, didn't get it | 13:54 |
| pedroalvarez | \o | 13:54 |
| pedroalvarez | \o | 13:54 |
| pedroalvarez | \o | 13:54 |
| Zara | o/ | 13:54 |
| pedroalvarez | o/ * \o | 13:54 |
| pedroalvarez | o/*\o | 13:54 |
| Zara | *\o/* *\o/* | 13:55 |
| Zara | okay please tell us all about email threading | 13:55 |
| pedroalvarez | so, for now we only send emails for task events, and story events | 13:56 |
| pedroalvarez | but I would say that task-events emails should be in the same thread of the story they belong, right? | 13:56 |
| Zara | yup | 13:56 |
| * SotK agrees | 13:57 | |
| pedroalvarez | there might be other kind of events in the future that send emails | 13:57 |
| pedroalvarez | but my feeling is that for now, we only add threading support for tasks and stories | 13:57 |
| pedroalvarez | .. events | 13:57 |
| Zara | yeah, I think it makes sense to start there | 13:58 |
| pedroalvarez | I've looked at how gerrit does this, and is actually pretty simple. you only need to set the In-Reply-To header when creating the email | 13:58 |
| Zara | (especially as we turned off worklist events since they broke everything) | 13:58 |
| pedroalvarez | that header should contain an ID, which has to be the same for all the emails that you want to be in the same thread | 13:59 |
| pedroalvarez | gerrit generates this ID with $patch_creation_time.$patchID@$gerrit_hostname | 14:00 |
| pedroalvarez | we could do something similar, like: $story_creation_time.$story_id@$hostname.. | 14:00 |
| pedroalvarez | or even prefixing "storyboard.story", just in case in the future we send emails for other events, and ID and creation_time are not enough | 14:01 |
| Zara | how come it needs the creation time? | 14:01 |
| pedroalvarez | Zara: it doesn't need to, but I guess is good to have that, given that a story can be removed, and a new story can be created with previous ID | 14:02 |
| Zara | oh, can it? argh, I thought they were always unique | 14:02 |
| Zara | okay, makes sense | 14:02 |
| pedroalvarez | (it looks like you can specify the ID, looking at anteaya examples of using the API) | 14:03 |
| SotK | I think specified IDs are ignored, but I may be wrong | 14:03 |
| pedroalvarez | This, hopefully, will make emails a bit better | 14:07 |
| pedroalvarez | So, do you like my bike? | 14:09 |
| SotK | I do | 14:09 |
| Zara | yes! | 14:09 |
| Zara | I'd definitely like threading | 14:10 |
| Zara | emails are very spammy atm | 14:10 |
| Zara | (I MEAN I STILL LOVE THEM OF COURSE) | 14:10 |
| *** alexismonville has quit IRC | 14:18 | |
| *** alexismonville has joined #storyboard | 14:18 | |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Add support for WorklistItems https://review.openstack.org/333939 | 14:38 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Removed whitespace for PEP8 test https://review.openstack.org/333939 | 14:41 |
| openstackgerrit | Bilal proposed openstack-infra/python-storyboardclient: Add support for WorklistItems https://review.openstack.org/333939 | 14:42 |
| *** jamesmcarthur has joined #storyboard | 15:04 | |
| *** jamesmcarthur has quit IRC | 15:42 | |
| *** jamesmcarthur has joined #storyboard | 15:43 | |
| *** zara_the_lemur__ has joined #storyboard | 16:28 | |
| *** jamesmcarthur has quit IRC | 16:34 | |
| *** jamesmcarthur has joined #storyboard | 16:38 | |
| *** alexismonville has quit IRC | 16:41 | |
| *** zara_the_lemur__ has quit IRC | 16:50 | |
| *** zara_the_lemur__ has joined #storyboard | 16:50 | |
| anteaya | I'm so sorry | 16:58 |
| anteaya | you all are still a big part of my world | 16:58 |
| anteaya | in case you didn't already know that | 16:58 |
| pedroalvarez | I hope we are not abandoning this planet yet :) | 17:00 |
| zara_the_lemur__ | :) the next few months are going to be great fun... | 17:03 |
| zara_the_lemur__ | on the up-side, next time we want a manchester meetup, the hotel will probably be 2p. | 17:12 |
| zara_the_lemur__ | well, £20000000000, but it'll be equivalent to 2 cents | 17:13 |
| zara_the_lemur__ | *ahem* | 17:13 |
| zara_the_lemur__ | sorry I didn't get through more patches today, anyway | 17:20 |
| *** zara_the_lemur__ has quit IRC | 18:00 | |
| *** openstackgerrit has quit IRC | 18:03 | |
| *** openstackgerrit has joined #storyboard | 18:03 | |
| *** jamesmca_ has joined #storyboard | 18:06 | |
| *** jamesmc__ has joined #storyboard | 18:07 | |
| *** jamesmcarthur has quit IRC | 18:09 | |
| *** jamesmca_ has quit IRC | 18:11 | |
| *** alexismonville has joined #storyboard | 18:17 | |
| anteaya | pedroalvarez: oh good, I'm so releaved | 18:20 |
| anteaya | Zara: no, I totally understand | 18:20 |
| pleia2 | Zara: I am totally not laughing at the collapse of your economy, but I did giggle at your 2 cents comment :) | 18:26 |
| *** openstackstatus has quit IRC | 18:40 | |
| *** openstack has joined #storyboard | 18:42 | |
| *** openstackstatus has joined #storyboard | 18:43 | |
| *** ChanServ sets mode: +v openstackstatus | 18:43 | |
| SotK | :) | 18:47 |
| *** alexismonville has quit IRC | 19:23 | |
| *** jamesmc__ has quit IRC | 20:46 | |
| *** persia has quit IRC | 21:22 | |
| *** alexismonville has joined #storyboard | 21:24 | |
| *** persia has joined #storyboard | 21:24 | |
| *** alexismonville has quit IRC | 21:59 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 22:26 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!