| *** openstackgerrit has quit IRC | 06:02 | |
| *** openstackgerrit has joined #storyboard | 06:03 | |
| betherly | morning all! | 06:11 |
|---|---|---|
| SotK | morning! | 06:36 |
| alexismonville | Hello, in case you did not see that :) there was answers from jroll and tristanC on the Trello for Ironic thread http://lists.openstack.org/pipermail/openstack-dev/2016-June/096592.html | 06:46 |
| SotK | alexismonville: thanks for the link | 07:44 |
| alexismonville | SotK: :) | 07:44 |
| *** bethwhite has joined #storyboard | 08:49 | |
| SotK | krotscheck: thanks for the reviews! | 09:03 |
| SotK | TIL about using $resource response interceptors | 09:04 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a note mentioning markdown is supported under the comment box https://review.openstack.org/325360 | 09:18 |
| *** bethwhite has quit IRC | 11:33 | |
| *** lgreg has joined #storyboard | 11:43 | |
| persia | Looking at old changes: anyone know why 304565 didn't merge? | 11:45 |
| SotK | no idea | 11:45 |
| SotK | I guess maybe we hit merge when there was some zuul issues? | 11:46 |
| persia | Do you think "recheck" will merge it? | 11:46 |
| SotK | I don't see why it wouldn't | 11:47 |
| * persia tries | 11:48 | |
| *** bethwhite has joined #storyboard | 11:57 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow superusers to edit other users successfully https://review.openstack.org/325196 | 12:57 |
| *** lgreg has quit IRC | 13:06 | |
| *** lgreg has joined #storyboard | 13:06 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a cancel button to the Add Tag text box https://review.openstack.org/325904 | 13:16 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow superusers to edit other users successfully https://review.openstack.org/325196 | 13:21 |
| SotK | too hot to remember to run tests today :) | 13:21 |
| *** anteaya has joined #storyboard | 13:37 | |
| krotscheck | SotK: yw | 14:08 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow superusers to edit other users successfully https://review.openstack.org/325196 | 14:21 |
| *** lgreg has left #storyboard | 15:27 | |
| * persia still doesn't understand 304565, and hopes someone else has the relevant gerrit-fu | 16:09 | |
| krotscheck | persia: package.json line 16 in that review invokes bower install. gruntfile also invokes bower install. Since the first must always be done before the second can work, it doesn't make much sense to do both. | 16:11 |
| krotscheck | Especially since making API calls against bower can fail. | 16:11 |
| persia | krotscheck: So, the bit I'm having trouble understanding is what is needed to merge the patch :) | 16:12 |
| pedroalvarez | "why zuul is not merging it" | 16:12 |
| persia | It has +1, +2, +A, +V, dependencies merged. | 16:12 |
| krotscheck | persia: Ah, right. It's based on an outdated revision of the previous patch. | 16:13 |
| krotscheck | Sec. | 16:13 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Removed grunt-bower https://review.openstack.org/304565 | 16:13 |
| krotscheck | There ya go | 16:13 |
| persia | And that should just need +V and +A, and merge? | 16:14 |
| anteaya | yes | 16:15 |
| persia | Cool. | 16:16 |
| anteaya | persia: thanks for keeping things moving along :) | 16:18 |
| persia | anteaya: I'd really like to see all the development-environment patches land before there are too many more developers. Similarly, there are a couple large outstanding features I'd like to see land before there are too many more users. I'm not sure there's much time for either set :) | 16:19 |
| anteaya | I understand the feeling | 16:19 |
| anteaya | persia: I'm not sure if you have seen this yet, my first round of a user's guide: https://review.openstack.org/#/c/325474/4 | 16:20 |
| * persia thinks that wa the last of krotscheck's dev environment cleanups | 16:20 | |
| anteaya | oh nice | 16:20 |
| krotscheck | There's always more cleaning to do. | 16:20 |
| * krotscheck points at the test coverage | 16:21 | |
| persia | krotscheck: Anything else that you have in mind that would be very visible to developers working with the repo? | 16:21 |
| persia | anteaya: I did. I will need to set aside a larger chunk of time to review that properly, and I don't think it would be a bad thing if it landed in advance of that (wherein the change would be a new change, if I take too long). | 16:22 |
| anteaya | right mostly this is a stick in the sand | 16:24 |
| anteaya | and much expansion needed on that | 16:24 |
| *** bethwhite has quit IRC | 16:24 | |
| krotscheck | persia: Can't switch context to answer that question right now, bringing myself up to date on App Ecosystem things. | 16:26 |
| persia | krotscheck: No worries. | 16:27 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Removed grunt-bower https://review.openstack.org/304565 | 16:52 |
| *** jtomasek has quit IRC | 18:39 | |
| *** krotscheck has quit IRC | 18:42 | |
| *** krotscheck_ has joined #storyboard | 18:42 | |
| *** krotscheck_ is now known as krotscheck | 18:44 | |
| *** openstackstatus has quit IRC | 19:55 | |
| *** openstackstatus has joined #storyboard | 19:58 | |
| *** ChanServ sets mode: +v openstackstatus | 19:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!