| *** anteaya has quit IRC | 02:04 | |
| betherly | o/ morning all! | 07:35 |
|---|---|---|
| *** openstackstatus has quit IRC | 07:38 | |
| *** openstackstatus has joined #storyboard | 07:40 | |
| *** ChanServ sets mode: +v openstackstatus | 07:40 | |
| SotK | morning betherley! | 09:05 |
| Zara | morning! | 09:24 |
| *** fay_ has joined #storyboard | 09:37 | |
| betherly | o/ Zara SotK :D | 10:18 |
| betherly | Zara: how are you feeling? | 10:18 |
| Zara | betherly: better than yesterday, still really sleepy. there's building work right next to my flat so I got woken up early. how are you? | 10:21 |
| betherly | Zara: ugh that is super annoying! im ok. still super tired. looking forward to doing as little as physically possible this weekend lol | 10:23 |
| Zara | :) | 10:24 |
| *** jtomasek has quit IRC | 10:59 | |
| francoblanco | Afternoon all! o/ just wanted to say that I've got a bit of free time today before I catch a flight, so if anyone wants to send some urgent but beginner friendly-ish reviews my way I'd be happy to try and do them :) | 11:13 |
| *** fay_ has quit IRC | 11:25 | |
| Zara | hi! :) I'm not sure about 'urgent', but probably best to look at smallish ones here https://review.openstack.org/#/q/project:openstack-infra/storyboard and https://review.openstack.org/#/q/project:openstack-infra/storyboard-webclient | 11:30 |
| francoblanco | OK cool, thanks Zara I'll take a look whilst I'm heading to the airport. Hope you're feeling a bit better today btw | 11:41 |
| Zara | thanks | 11:43 |
| *** jseutter has joined #storyboard | 12:55 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add a table for story permissions https://review.openstack.org/310951 | 13:44 |
| Zara | \o/ | 13:45 |
| Zara | thanks | 13:46 |
| Zara | ahahaha, I'm guessing you just accessed my test instance | 13:48 |
| Zara | since I started it up after the migration and my logs were full of 'adam coldrick' | 13:48 |
| Zara | was a bit unexpected | 13:48 |
| SotK | :D | 13:48 |
| Zara | checking nothing is on fire... | 13:48 |
| Zara | at some point I should really fix the users search stuff in my db | 13:49 |
| * Zara notes that the preferences page should make it more obvious to the user that their preferences have been updated | 13:51 | |
| Zara | (atm it gives them a message, but they have to scroll down so far to save preferences that the message isn't visible when clicking 'save') | 13:51 |
| Zara | so it can seem like the page doesn't react | 13:52 |
| Zara | so probably a shortterm answer is to rearrange things so less scrolling | 13:52 |
| Zara | okay, db migration causes 500 error for me when I make a new story | 13:56 |
| Zara | '500: POST /api/v1/stories: (InternalError) (1364, u"Field 'private' doesn't have a default value") 'INSERT INTO stories (created_at, updated_at, creator_id, story_type_id, title, description, is_bug) VALUES (%s, %s, %s, %s, %s, %s, %s)' (datetime.datetime(2016, 5, 6, 13, 55, 50, 78631), None, 1, 1, 'newstory', 'dskfjldsfds', 1) ' | 13:56 |
| *** jtomasek has joined #storyboard | 13:59 | |
| Zara | SotK ^ | 14:00 |
| Zara | I can paste more context if useful, but it seemed like the sort of thing that might provoke an 'Ohhh, I forgot the thing!' | 14:05 |
| * SotK is fixing it | 14:06 | |
| Zara | \o/ | 14:09 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow the creation of private stories https://review.openstack.org/310952 | 14:14 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add a table for story permissions https://review.openstack.org/310951 | 14:14 |
| Zara | :) | 14:14 |
| Zara | so, given I've already updated my db to version 57 for this, how do I migrate to the newer version of the patch? | 14:15 |
| Zara | I've probably done this before but forgotten :/ | 14:15 |
| -openstackstatus- NOTICE: Zuul is currently recovering from a large number of changes, it will take a few hours until your job is processed. Please have patience and enjoy a great weekend! | 14:16 | |
| Zara | what a friendly status message! \o/ | 14:17 |
| SotK | downgrade to 056 and re-upgrade should be fine | 14:17 |
| Zara | iirc last time my downgrade set on fire, okay | 14:17 |
| SotK | shouldn't be too bad this time, the change is minimal | 14:17 |
| * Zara crosses fingers | 14:19 | |
| Zara | seems fine so far, though I just swapped 'upgrade 057' for 'downgrade 056' in the command I was using, so I hope that's right | 14:19 |
| SotK | sounds right | 14:20 |
| Zara | my page is ful of errors | 14:20 |
| SotK | \o/ | 14:20 |
| * Zara tries restarting all the things | 14:20 | |
| betherly | yay for restarts | 14:21 |
| Zara | :) | 14:21 |
| Zara | okay, seems fine now | 14:21 |
| * Zara prepares to re-upgrade | 14:21 | |
| Zara | seems to work now \o/ | 14:28 |
| SotK | excellent | 14:28 |
| Zara | now I'm so confused, since it looks like I took the wrong patch the second time? but it worked? wah? | 14:31 |
| SotK | o.O | 14:32 |
| Zara | I thought I'd gone from 3 to 4, but then the commands look like I went from 2 to 3 (which is just the commit message so no way was that intended...) | 14:34 |
| * Zara downgrades and upgrades *again* to be careful | 14:35 | |
| Zara | argh | 14:35 |
| Zara | it works, anyway... so yay? | 14:39 |
| Zara | I'm not sure what happened there | 14:39 |
| Zara | but I got an error, then didn't get it, apparently on the same patch, after a later patch was submitted. such mystery. | 14:39 |
| Zara | and now everything seems to work on the new patch anyway | 14:40 |
| Zara | seems it just needed me to restart all the things or something, is my best guess | 14:40 |
| SotK | I guess so | 14:40 |
| SotK | weird | 14:40 |
| Zara | ¯\_(ツ)_/¯ | 14:41 |
| Zara | sorry for asking you to fix something that probably wasn't broken but also was... | 14:42 |
| Zara | were you able to reproduce it for the fix? | 14:42 |
| SotK | I didn't try :) | 14:45 |
| Zara | >_> | 14:45 |
| Zara | mystery forever! | 14:45 |
| -openstackstatus- NOTICE: Zuul has been restarted. As a results, we only preserved patches in the gate queue. Be sure to recheck your patches in gerrit if needed. | 14:47 | |
| betherly | hey so weird question perhaps... | 15:10 |
| betherly | trying to address a more minor ux thing on my long storyboard to do list... | 15:10 |
| betherly | trying to find the code for the form for adding a task to a story | 15:11 |
| Zara | heya | 15:11 |
| betherly | ive found a src link to /inline/task_edit_form.html but as yet i cannot find that actually existing anywhere - mystery | 15:11 |
| Zara | I think it's in the same file | 15:11 |
| betherly | or potentially i am having a friday breakdown. either way...can anyone help :D | 15:12 |
| Zara | since I was confused by that too | 15:12 |
| Zara | the /inline means it should be elsewhere in the file | 15:12 |
| betherly | ah | 15:12 |
| Zara | yeah, line 366 I think | 15:13 |
| betherly | found iiiiit | 15:13 |
| Zara | \o/ | 15:13 |
| betherly | i gave up looking too early. thank you! | 15:14 |
| betherly | :D | 15:14 |
| Zara | np, I got totally baffled by it a while back | 15:14 |
| Zara | you'd think the word 'inline' would be a clue but it just didn't click | 15:14 |
| SotK | `git grep "/inline/task_edit_form.html"` :P | 15:15 |
| Zara | well I just found a bug so no :P for you | 15:15 |
| SotK | what is the bug? :( | 15:16 |
| Zara | not sure which file yet, but 500: PUT /api/v1/worklists/23/items/50: story_get() got an unexpected keyword argument 'current_use' | 15:16 |
| Zara | when moving a card from one lane to another | 15:16 |
| Zara | my guess is maybe a typo somewhere which should be 'current_user' | 15:17 |
| Zara | (in the api patch I'm reviewing now, but guessing you've guessed that..) | 15:18 |
| SotK | wat | 15:18 |
| Zara | aha, line 245 | 15:18 |
| Zara | worklists.py | 15:18 |
| Zara | https://review.openstack.org/#/c/310952/8/storyboard/api/v1/worklists.py | 15:18 |
| Zara | I sent a comment so it was easier to spot | 15:19 |
| SotK | aha, its moving a story not a task, I must have not done that in all my random card moving | 15:20 |
| Zara | ah, it's repeated elsewhere in that file, guessing you pasted your old code | 15:21 |
| * Zara posts it up | 15:22 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow the creation of private stories https://review.openstack.org/310952 | 15:23 |
| Zara | :D couldn't spot 'use=' anywhere else so hopefully we've caught all of those | 15:25 |
| *** jtomasek has quit IRC | 15:33 | |
| betherly | is there any reason that form fields have been appended with things like input-inline ? | 15:34 |
| betherly | currently the only purpose i can see in that is that when '-inline' is removed it adds another class that manages the styling of the form field | 15:34 |
| betherly | same with project-typeahead and user-typeahead fields | 15:34 |
| betherly | the classes can be added manually without the appended field name and that would allow placeholders to work on those fields to make the form clearer for users | 15:35 |
| Zara | I think it's used to apply the input_inline.js directive (in src/app/util/directive). where I've done it, I've done it to be consistent with what was there before. but I think the placeholders used to work, so mysteries abound | 15:37 |
| SotK | project-typeahead and user-typeahead are directives from the same directory too, which exist so that there is a reusable "input box which finds projects/users" | 15:38 |
| SotK | (I think that is why anyhow) | 15:38 |
| Zara | that's my assumption so I hope you're right xD | 15:38 |
| betherly | hmm ok so best to leave those alone | 15:40 |
| betherly | time to find another way around that issue then... | 15:41 |
| * betherly thought she had found an easy friday afternoon quick fix | 15:41 | |
| betherly | facepalm | 15:41 |
| Zara | that may still be the place to look to work out why placeholders don't work in them. | 15:42 |
| Zara | but no idea really =D | 15:42 |
| Zara | anyway, I can't break these privacy patches now | 15:42 |
| Zara | I'm sure there's a way | 15:42 |
| Zara | but I probably won't find it until I test with ui ones too | 15:42 |
| Zara | I've looked at the code, but there's a lot and it's similar-looking, so this is definitely one of those times where I have to rely more on testing behaviour, and then look at the code when things go wrong. :/ | 15:43 |
| betherly | i kinda wish i had storyboard set up locally on my mac rather than my vm at moments like these | 15:45 |
| Zara | oh, jenkins is flagging up an unused var here (idArray) https://review.openstack.org/#/c/312663/ | 15:46 |
| Zara | so that probably needs taking out | 15:46 |
| Zara | how come it's easier if it's set up locally, ooi? (mine's always been on a vm so curious) | 15:54 |
| Zara | ooh, fancy privacy icon | 15:55 |
| Zara | I can't decide whether or not I like it being the same colour as the error messages | 15:56 |
| Zara | the banner, that is | 15:56 |
| SotK | I don't think it should be a different colour | 15:56 |
| Zara | yeah, I don't see a better way, just the first thing I thought when it popped up was that I'd had an error creating the story | 15:57 |
| SotK | and then you read what the red text said, as intended :D | 15:57 |
| Zara | :P I wonder if it'd happen in reverse after a while | 15:58 |
| betherly | Zara: i think just because im used to being on the mac and navigating there. other than storyboard i only use the vms for running devstack and ironic in the background and i do everything front end related on my mac | 15:58 |
| betherly | even all my d3 experimentation has been on the mac just because im used to my tools there | 15:58 |
| betherly | so when i switch over to full dev on my vm its just confusing switching between mac and vm and tools and ugh | 15:58 |
| Zara | SotK: I'm also wondering whether the banner should scroll with the user (in case a story task list or description is long, and a user tabs elsewhere then comes back)-- or whether that would be thoroughly irritating. but I'm happy to try it like this and see what happens. | 15:59 |
| persia | betherly: you should be able to do all the SB front-end stuff locally on the Mac, with only the API server and DB in the VM, but you would have to tweak the test deployment stuff. | 16:00 |
| * SotK decided that would be a pain in the neck on mobile devices | 16:00 | |
| Zara | okay, I can see us having one rule for mobile, one for desktop-- but I'm all for waiting to see if it's actually a problem for anyone | 16:00 |
| betherly | persia: ye i know there is probably a way to do it but with the amount on my to do list i dont want to break things completely in the process and have to take time out to make it work. but then the time wasted getting frustrated on the vm is probably much the same as that i would use to set it up so... | 16:01 |
| persia | Heh | 16:02 |
| SotK | Zara: its also much more work to get a fixed one to play nicely :) | 16:02 |
| Zara | betherly: it'd be cool if you were able to use your regular tools, since something you bring to the project is knowledge of what tools are out there, but I agree you could lose hours fiddling around with it. I wonder how much of the same stuff you could get on your VM? | 16:03 |
| betherly | Zara: to be honest i just have to switch between and thats fine, its just a bit of getting used to it and i need to suck it up and use my vm more rather than avoid it lol | 16:05 |
| Zara | SotK: yeah, great fun :D. I just know a buncha people hilighted the banner as important, and most people tend to have a task-tracker open in the background while they do other stuff, so won't be giving it their full attention, plus stories can get long. so it's on my 'possible future fix' list rather than my 'lol no way are we fixing that, YOU'RE WRONG' list. | 16:06 |
| Zara | and I'm now glad to be aware of the mobile worry-- even if I forget it almost immediately, which seems to happen to me ;_' | 16:07 |
| Zara | ;_; | 16:07 |
| Zara | see I can't even remember how to type semicolons | 16:08 |
| Zara | betherly: as long as you're comfortable-ish, then sounds fine! :D | 16:08 |
| Zara | okay, so something I notice about the banner is that it seems to be a feature of the story detail page, rather than something that comes up for any private resource | 16:10 |
| Zara | so the code will have to be duplicated | 16:10 |
| Zara | that seems a bit strange to me (obviously the text will change but the 'red thing at top of the screen' seems pretty constant) | 16:11 |
| SotK | I don't see any value in generalizing it more, its just a single <div> that contains text | 16:12 |
| *** dabukalam has quit IRC | 16:25 | |
| *** dabukalam has joined #storyboard | 16:25 | |
| *** SotK has quit IRC | 16:28 | |
| *** SotK has joined #storyboard | 16:28 | |
| Zara | SotK: my thought is that if the style changes in the future, we'll have to change it in multiple places. but also okay with leaving that for later if we come back to it. | 16:34 |
| Zara | and have noticed the caching has the same effect on the banner as the description (that is, if you edit story, then click 'private', then cancel, the banner will continue to display until the page is refreshed, which could be misleading) | 16:35 |
| Zara | previously it was just a bit confusing but that might actually pose a security risk | 16:35 |
| SotK | its not caching, its that the story object is edited in place in the browser and not refreshed on cancel | 16:36 |
| SotK | We should fix it in a separate patch, it doesn't belong in the same patch as making things private IMO | 16:37 |
| Zara | agree, just mentioning it so I don't forget it (or why it's relevant) | 16:37 |
| Zara | I may still forget it but gotta try :P | 16:37 |
| Zara | (and gotcha re: not-caching.) | 16:38 |
| *** jtomasek has joined #storyboard | 17:21 | |
| Zara | ui patches seem fine. some weirdness with one of my boards, but that persists on master. :/ | 17:49 |
| Zara | (stories aren't showing up in the thing that searches and lists stories automatically. | 17:50 |
| Zara | I think the db and api permissions patches just need +1s since they've been reworked, that is: https://review.openstack.org/#/c/310951/ and https://review.openstack.org/#/c/310952/ | 17:55 |
| *** yarkot1 has quit IRC | 17:57 | |
| *** yarkot1 has joined #storyboard | 18:07 | |
| *** jseutter has quit IRC | 18:32 | |
| *** jjardon_ has joined #storyboard | 19:45 | |
| *** jjardon has quit IRC | 19:48 | |
| *** jjardon_ is now known as jjardon | 19:48 | |
| *** jseutter has joined #storyboard | 20:11 | |
| *** openstackgerrit has quit IRC | 20:32 | |
| *** openstackgerrit has joined #storyboard | 20:33 | |
| *** jseutter has quit IRC | 21:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!