| *** pleia2 has quit IRC | 03:51 | |
| *** openstackgerrit has quit IRC | 06:03 | |
| *** openstackgerrit has joined #storyboard | 06:03 | |
| *** bethwhite has joined #storyboard | 08:09 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for making stories private to a list of people https://review.openstack.org/312663 | 09:16 |
|---|---|---|
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: WIP: Complex priorities UI in stories https://review.openstack.org/312666 | 09:16 |
| Zara | morning, storyboard! I'm still not feeling great and may vanish | 09:49 |
| SotK | :( | 09:51 |
| Zara | I should review patches but my duvet is so comfy... | 11:17 |
| krotscheck | o/ | 11:30 |
| Zara | hey there! :D | 11:32 |
| SotK | hi! | 11:41 |
| * krotscheck doesn't know why he's awake | 11:43 | |
| Zara | join the club =D | 11:44 |
| Zara | how's it going? | 11:45 |
| krotscheck | Not bad? First time bunchkin slept for 8 hours, so now I have no idea waht to do with myself. | 11:47 |
| krotscheck | *munchkin | 11:47 |
| Zara | \o/ | 11:47 |
| krotscheck | Trying to put all my oslo code to rest so I can do ironic things | 11:48 |
| Zara | oh, I was gonna suggest 'wake the child up again and go "SEE, THIS IS HOW IT FEELS!"' but that works, too | 11:49 |
| Zara | reason 1 of 234873589375932 I should never have children. | 11:49 |
| krotscheck | Zara: I take the Transformers approach to children. | 11:55 |
| krotscheck | Zara: "When you look back on your life 50 years from now, don't you want to be able to say that you had the guts to [have a kid]?" | 11:55 |
| *** fay_ has joined #storyboard | 12:04 | |
| Zara | heh, makes sense if it's something you want to do and you're holding back from fear (plus if you want to, even if you're worried about things, it probably means you're suited to it). :) just not my thing. | 12:06 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Removed grunt test-unit in favor of just running karma https://review.openstack.org/304555 | 12:35 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Updated README https://review.openstack.org/304556 | 12:42 |
| *** openstackgerrit has quit IRC | 13:47 | |
| *** openstackgerrit has joined #storyboard | 13:48 | |
| *** jseutter has joined #storyboard | 14:08 | |
| *** krotscheck has quit IRC | 14:27 | |
| *** jseutter_ has joined #storyboard | 14:30 | |
| *** krotscheck has joined #storyboard | 14:33 | |
| *** jseutter has quit IRC | 14:34 | |
| *** anteaya has joined #storyboard | 14:43 | |
| *** jseutter_ has quit IRC | 15:07 | |
| *** jseutter has joined #storyboard | 15:08 | |
| *** pleia2 has joined #storyboard | 15:15 | |
| Zara | finally about to test pagination patch for boards and worklists | 15:36 |
| Zara | sorry, taken ages to get to it, still floopy | 15:36 |
| * SotK is looking forward to you testing the permissions patches most of all :D | 15:37 | |
| Zara | ah, I figure those are best-tested when we're in the same place | 15:37 |
| Zara | so I can do the whole 'I can see x can you see x?' | 15:37 |
| Zara | forever | 15:37 |
| anteaya | so thought I would begin here | 15:38 |
| * Zara hates testing permissions patches because it's so longwinded xD | 15:38 | |
| persia | But if you do that on IRC, there is a transcript :) | 15:38 |
| anteaya | the scientific working group has asked if they can use storyboard for their work | 15:38 |
| anteaya | I figure there would be no objection from the storyboard side | 15:38 |
| anteaya | is there any objection? | 15:38 |
| Zara | I can't think of any. | 15:39 |
| SotK | I don't have one | 15:39 |
| anteaya | great thanks | 15:39 |
| anteaya | didn't think there would be | 15:39 |
| anteaya | I also told three folks from the group about the storyboard meetup | 15:40 |
| anteaya | and to sign up and join in if they are able | 15:40 |
| Zara | persia: ah, we would anyway, I just mean we're currently on different networks, and it's fiddly getting our VMs to chat (not impossible, on my side, just means I have to keep changing urls when pasting, and idk about viewing sotk's vm, so yeahhhh) | 15:41 |
| Zara | anteaya: great! :D | 15:41 |
| Zara | btw, we think it may now start at 11am instead of 10am | 15:41 |
| persia | Zara: Oh, heh, now I undertstand. | 15:41 |
| Zara | on account of me booking the meeting room late and people being in there | 15:41 |
| Zara | I might be able to shift people but it depends if anyone really needs it to start at 10am | 15:42 |
| anteaya | Zara: oh thats fine | 15:43 |
| anteaya | no no no, 11am start is fine | 15:43 |
| Zara | I have received top-secret intel that we might be able to shift people to do 10am after all | 15:47 |
| *** bethwhite has quit IRC | 15:49 | |
| anteaya | either way | 15:49 |
| Zara | anteaya: back to 10am :D | 16:04 |
| anteaya | 10am is great | 16:05 |
| anteaya | 11am is great | 16:05 |
| anteaya | there will be cake! | 16:05 |
| Zara | ooh, interesting. so if you make a private board, then uncheck 'private' at the board level, all the lanes will still be checked 'private' until manually unchecked | 16:28 |
| anteaya | ohhhh | 16:29 |
| anteaya | very interesting | 16:29 |
| anteaya | maybe consult with fungi here? | 16:29 |
| anteaya | to see what behaviour is wanted? | 16:29 |
| anteaya | or do you feel you know? | 16:29 |
| Zara | my own feeling is that making a board non-private should make all its lanes non-private, but SotK may have a good reason for doing it this way, so I think we should wait for his input (aand if the behaviour's intentional, it might have already been explained somewhere and I've forgotten). | 16:32 |
| anteaya | sounds good | 16:34 |
| anteaya | plus fungi just left for lunch | 16:34 |
| Zara | :) the current way round, I think it's slightly more secure, since the board owner has to explicitly list each thing they want others to view, but risks confusing users a bit more ('the board's showing up for me now, but I still can't see any lanes') | 16:36 |
| Zara | curiouser and curiouser... seems checkbox for lane permissions doesn't have an effect on the privacy of lanes | 16:38 |
| Zara | board permissions do work, and govern the permissions of lanes | 16:39 |
| Zara | so lanes have a checkbox that doesn't seem to do anything | 16:39 |
| Zara | if a board is private, lanes are private; if not, they're not, and changing their checkbox in the board view doesn't seem to make a difference | 16:40 |
| * Zara tests a little further | 16:40 | |
| persia | I can think of use cases for public boards wherein only a subset of lanes is public. | 16:40 |
| Zara | yeah, just wondering about defaults... but right now, looks like there's a bug! \o/ | 16:42 |
| Zara | right, can confirm, changing lane permissions from the board page doesn't do anything but change the display of the checkbox | 16:44 |
| Zara | changing lane permissions from the worklist page does change the permissions for the lane | 16:44 |
| Zara | although... | 16:45 |
| Zara | setting that worklist to 'private' has now also hidden it from me. | 16:45 |
| Zara | I like to test things right after sotk goes home, just to upset him. | 16:46 |
| persia | It helps promote inclusive thought about timezones :) | 16:47 |
| Zara | :) | 16:49 |
| Zara | it looks like setting board permissions overwrites lane permissions each time | 16:49 |
| persia | So making a board public makes all the lanes public, and making it private makes all the lanes private? | 16:52 |
| Zara | yeah | 16:52 |
| Zara | you can then manually change them on the worklist page for each lane | 16:52 |
| persia | While there is still the bug of having no sensible UI to create a board with lanes that are consumed as worklists in other places, this isn't that important, but it could become very important in frustrating ways. | 16:52 |
| Zara | there is a checkbox that comes up in a modal when a lane is clicked on for privacy of the lane, but that checkbox doesn't seem to work | 16:53 |
| persia | Oh, a checkbox not working is a direct bug, regardless of the utility. | 16:54 |
| Zara | yup. I dislike testing permissions because it feels like doing a big truth-table for combinations, and I have to make sure I knoww where I'm up to. | 16:54 |
| Zara | 'this checked, this unchecked; both checked; both unchecked; this unchecked, this checked' | 16:54 |
| persia | Can any of the tests be usefully automated? | 16:55 |
| Zara | I'm not sure for these ones, I'd've thought so but question is more when we get to it. I'm hoping it's something we can do with a bigger team. | 16:55 |
| Zara | though I still think it's worth a human looking at anything security-related, but we could cut down the frequency. | 16:56 |
| Zara | the tricky thing for the early work on permissions is that it's a case of finding out what leaks | 16:57 |
| Zara | which was a lot of what I was doing at the summit 'what about due dates? stories in projects? stories in project groups?' | 16:58 |
| Zara | so you need the list first before checks against it can be automated | 16:58 |
| Zara | (this was for places where the total number of stories was listed, since if there's a discrepancy between displayed number and number of items visible to user, user can tell there are hidden items) | 16:59 |
| Zara | boards and worklists need automated tests anyway. | 17:00 |
| Zara | roughly, if it generates a red error message in the top right when something goes wrong, I figure it's fairly easily automatable in theory. if it's more 'there's an issue with how this looks', I think it's harder. | 17:02 |
| Zara | in practice, the latter are more common for permissions things 'hey, I can see this?'-- tests are liable to have the same flaws as the code. | 17:07 |
| SotK | i think we discussed that checkbox at the summit, and agreed the solution is for it not to be there | 17:08 |
| Zara | \o/ sorry I forgot, then | 17:09 |
| Zara | I remember us talking about inheritance of permissions but not that the box didn't work | 17:10 |
| Zara | but heh, makes it easier since it's effectively not there anyway | 17:10 |
| Zara | (so I got confused because it looked like they weren't inheriting board permissions, but they were.) | 17:13 |
| SotK | it was the box that got us on to inheritance | 17:29 |
| SotK | to confirm for the others, worklists which are in boards inherit their permissions from the board which contains them | 17:30 |
| SotK | since people didn't want to have the hassle of changing lane permissions individually when they changed the board's | 17:31 |
| SotK | s/when they changed/when they changed or instead of changing/ | 17:31 |
| SotK | on tests, testing of permissions can be fully automated given a dummy database | 17:34 |
| Zara | ah, I forgot that the box sparked it off then. Looked around for a way to remove it from just that view but couldn't find one since it reuses the modal. | 17:36 |
| SotK | check the modal for creating a due date for an example :) | 17:37 |
| Zara | aw, I was hoping I was just confused and looking in the wrong place and didn't have to make one, wahwahwah | 17:38 |
| SotK | you don't, you just need to modify the existing one | 17:40 |
| SotK | (the due date modal is used for both creating and editing, and is different depending on what its doing) | 17:40 |
| Zara | (I think it can be automated once we know what we're testing *for*, I'm less sure we're certain of that yet, and really I should've been noting things as I went along (I did start that a while ago, but it's skeletal)) | 17:43 |
| Zara | re: due date modal, will take a look, thanks | 17:44 |
| * SotK finds a place where stories will leak | 17:45 | |
| Zara | \o/ | 17:45 |
| Zara | gotta catch 'em all! | 17:45 |
| Zara | where this time? | 17:45 |
| SotK | search | 17:46 |
| SotK | because its not browse, because our api is weird | 17:46 |
| Zara | gah, I asked about search! which bit? | 17:46 |
| Zara | ahaha | 17:46 |
| SotK | the bit which is actual search that I never use | 17:47 |
| Zara | :) | 17:51 |
| *** jseutter has quit IRC | 17:51 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow the creation of private stories https://review.openstack.org/310952 | 18:01 |
| Zara | \o/ | 18:03 |
| Zara | for my own part, I'm giving up on today | 18:03 |
| Zara | 'night | 18:03 |
| betherly | ditto Zara! Heading off now! See y'all tomorrow :) | 18:11 |
| SotK | incidentally, you can find the code paths which need testing by doing `git grep "model_query(models.Story"`, `git grep "story_get"`, `git grep "model_query(models.Task"`, and `git grep "task_get"` (with a bit of reading) | 18:18 |
| -openstackstatus- NOTICE: Gerrit is restarting to address performance issues related to a suspected memory leak | 19:22 | |
| *** jseutter has joined #storyboard | 19:45 | |
| *** jseutter has quit IRC | 20:01 | |
| -openstackstatus- NOTICE: Gerrit is restarting to revert incorrect changes to test result displays | 20:30 | |
| *** fay_ has quit IRC | 21:00 | |
| *** jseutter has joined #storyboard | 21:32 | |
| *** jseutter_ has joined #storyboard | 21:50 | |
| *** jseutter has quit IRC | 21:50 | |
| *** jseutter_ has quit IRC | 22:16 | |
| *** krotscheck has quit IRC | 23:31 | |
| *** krotscheck has joined #storyboard | 23:31 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!