| persia | I think you want latest :) | 00:04 |
|---|---|---|
| pedroalvarez | hehe, yes :) | 00:11 |
| pedroalvarez | I was wondering why the UI was totally different | 00:11 |
| SotK | pedroalvarez: I think the recommended approach for production deployment is to use the puppet stuff in http://git.openstack.org/cgit/openstack-infra/puppet-storyboard/tree/README.md | 00:21 |
| SotK | I've not tried to use that yet myself though | 00:23 |
| *** openstackgerrit has quit IRC | 09:46 | |
| *** openstackgerrit has joined #storyboard | 09:47 | |
| *** openstackgerrit has quit IRC | 10:16 | |
| *** openstackgerrit has joined #storyboard | 10:17 | |
| pedroalvarez | never used puppet, but yes, it looks like those scripts install storyboard | 10:58 |
| pedroalvarez | I wonder what zuul does for upgrading to a newer version | 10:58 |
| pedroalvarez | my guess is that it runs those puppet scripts | 10:59 |
| SotK | I guess that is what happens too | 11:24 |
| SotK | the answer is probably somewhere in project-config, but i cant look right now | 11:24 |
| pedroalvarez | no worries :) | 11:26 |
| pedroalvarez | SotK: go away and enjoy the holidays! | 11:26 |
| Zara | DO I SEE A SOTK HERE? | 11:28 |
| Zara | YOU HAVE BEEN WARNED | 11:29 |
| Zara | AWAY WITH YOU | 11:29 |
| Zara | ... I think that worked. | 11:32 |
| Zara | something that puzzles me about 'StoryBoard': why is the B capitalised? is it just so it looks like 'OpenStack'? | 12:13 |
| Zara | doesn't particularly matter, just bothers me whenever I write it down in a setting where I'm meant to capitalise it properly | 12:15 |
| * Zara goes to garden some more stories | 12:29 | |
| *** mrmartin has joined #storyboard | 12:42 | |
| Zara | some of SotK's quick UX fixes from yesterday that could do with some reviews: https://review.openstack.org/#/c/243705/ , https://review.openstack.org/#/c/244099/ and https://review.openstack.org/#/c/244218/ | 13:17 |
| Zara | (there are others here, those are just the ones I've already had a chance to look at. https://review.openstack.org/#/q/owner:adam.coldrick%2540codethink.co.uk+status:open,n,z ) | 13:18 |
| Zara | the 'browsing by creator ID' patch has now been merged, which means this one is no longer blocked: https://review.openstack.org/#/c/212105/ . I think we just need SotK to remove the workflow -1 . | 13:25 |
| pedroalvarez | Zara: have you tested this one: https://review.openstack.org/#/c/244218/ ? | 13:27 |
| pedroalvarez | I wonder how exactly it works | 13:27 |
| Zara | yeah, I tested it | 13:28 |
| Zara | how it works is a bit of a mystery to me, but it's really cool and didn't seem to break anything | 13:28 |
| Zara | I think it just makes a bit of the template display the text after it's been markdownified, but doesn't save the result. | 13:29 |
| pedroalvarez | after looking the code I understand how it should work | 13:31 |
| pedroalvarez | I like the idea | 13:31 |
| Zara | the inner workings of <insert-markdown> are still a bit magical to me, but I get the process in theory :) | 13:31 |
| Zara | the service is in src/app/services/directive/markdown.js ; it gets the function from marked in bower_components | 13:36 |
| Zara | and all the other mysterious things that it needs | 13:36 |
| Zara | I think that the description in this story is being wrongly interpreted as markdown... https://storyboard.openstack.org/#!/story/2000061 | 13:47 |
| Zara | yeah, it's converting a quoted '<a></a>' into formatting for the description itself | 13:49 |
| * Zara wonders how you quote tags in markdown without using them | 13:50 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a preview button when adding a comment https://review.openstack.org/244218 | 13:50 |
| pedroalvarez | Zara: I reviewed this too just in case you missed it: https://review.openstack.org/#/c/244099/ | 13:55 |
| Zara | \o/ | 13:56 |
| Zara | ah, okay, tpollard's story should work if I just indent the <a> tag so it's interpreted as a codeblock | 13:56 |
| * Zara updates it | 13:56 | |
| Zara | thanks, I did miss that | 13:57 |
| Zara | so fast, thank you! :) | 13:58 |
| * pedroalvarez fails to find that story | 13:58 | |
| Zara | oh, it was just this: https://storyboard.openstack.org/#!/story/2000061 | 13:59 |
| Zara | it was displaying a bit strangely | 13:59 |
| Zara | should be fine now | 13:59 |
| Zara | looks a bit odd with the '<a>' as a code block but I didn't know an alternative way to display it | 13:59 |
| Zara | bit messy but it's clear what's going on. if anyone knows markdown better, s'fine to edit the description. :) | 14:00 |
| pedroalvarez | `<a>` ? | 14:00 |
| pedroalvarez | may I? | 14:01 |
| Zara | heh, it works | 14:01 |
| Zara | go for it | 14:01 |
| Zara | :) | 14:02 |
| pedroalvarez | better | 14:02 |
| Zara | \o/ | 14:02 |
| Zara | I suspect there are going to be other stories like that; good to know for the future | 14:02 |
| pedroalvarez | would be good to have the preview feature when creating the story itself, and not only the comments? | 14:04 |
| Zara | yeah, since both use markdown | 14:05 |
| * Zara makes story for it... | 14:05 | |
| Zara | https://storyboard.openstack.org/#!/story/2000410 | 14:07 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make timestamps more readable https://review.openstack.org/244099 | 14:09 |
| Zara | gardening old stories is revealing how important it is that stories update with reviews etc | 14:12 |
| Zara | there are old stories with patches in 'review' that have probably been merged, but there's no link to the story, and sometimes they're titled a little differently, so they can be hard to track down | 14:13 |
| pedroalvarez | yes, I was thinking about that | 14:13 |
| pedroalvarez | would be good to link tasks to patches whenever possible | 14:13 |
| Zara | yeah, I want it to be automated in time; in the meantime I'm just going through manually and changing statuses/adding links in comments where I can :/ | 14:15 |
| SotK | descriptions could use a preview too, I just didn't have time to implement it yesterday | 14:15 |
| Zara | will look into it | 14:20 |
| Zara | should be easier to do now there's a precedent | 14:20 |
| Zara | also shoo :) | 14:20 |
| SotK | indeed, you can probably just do a similar kind of thing | 14:20 |
| Zara | yeah. :) (I guess this shows that working on storyboard is just as fun as going on holiday, yay) | 14:22 |
| Zara | how many projects can make that claim? B) | 14:22 |
| SotK | the insert-markdown directive takes the thing given to its content attribute and renders it as markdown using https://github.com/chjj/marked | 14:22 |
| SotK | it uses https://highlightjs.org/ for syntax highlighting | 14:23 |
| Zara | ah, okay. I'd worked out the first bit after wandering back through the code. probably did that a few weeks ago and then forgot... | 14:24 |
| SotK | it works by setting the insert-markdown element's contained html to the result of the rendering (after passing it through angular's sanitisation function), contained in a div for reasons I forget | 14:25 |
| SotK | it updates that html each time the thing passed in the content attribute changes | 14:26 |
| * SotK goes to do other things | 14:26 | |
| Zara | thanks for the explanation :) | 14:27 |
| SotK | I also removed my workflow -1 on https://review.openstack.org/#/c/212105/ | 14:28 |
| Zara | \o/ | 14:28 |
| Zara | yay :) | 14:30 |
| Zara | oh I thought sam had +1'd but he hadn't | 14:30 |
| Zara | I hadn't merged it yet, luckily | 14:30 |
| pedroalvarez | I'm looking at it right now | 14:30 |
| pedroalvarez | looks good | 14:34 |
| pedroalvarez | gerrit diff is a mess though | 14:34 |
| Zara | how come? maybe I've just got used to it... | 14:35 |
| pedroalvarez | it's comparing "Recent Events" table with the new "Stories created by me" table | 14:39 |
| pedroalvarez | https://review.openstack.org/#/c/212105/1/src/app/dashboard/template/dashboard.html | 14:39 |
| Zara | so it is o.O | 14:41 |
| Zara | my guess is that the file was edited that way | 14:42 |
| Zara | but it's a shame that gerrit can't pick it up | 14:42 |
| Zara | I think sometimes I end up switching the order of things around in files to make sure the right things will be compared, but it's a hassle :( | 14:43 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Change Gruntfile Connect Default Hostname Value to '0.0.0.0' https://review.openstack.org/244706 | 15:24 |
| Zara | I thought we'd done that ages ago | 15:26 |
| Zara | (submitted the patch, though not merged it) oh well | 15:27 |
| *** mrmartin has quit IRC | 15:32 | |
| pedroalvarez | I remember a patch from tpollard for the same | 15:35 |
| pedroalvarez | https://review.openstack.org/#/c/138053/4/Gruntfile.js | 15:35 |
| SotK | oh, I forgot to mention that I'd discovered that! | 15:38 |
| SotK | Zara: doing `tox -e grunt_no_api -- serve --hostname $IP` works I think | 15:39 |
| Zara | ahh, we might want to update the docs then | 15:41 |
| Zara | I was just doing tox -egrunt_no_api serve , so that'd explain it, hahaha | 15:41 |
| Zara | I'll abandon mine, then, since it's a bit too much brute-force.... | 15:42 |
| Zara | ah, yup, that works | 15:47 |
| Zara | hah, it's in the docs already (well, with hostname 0.0.0.0) | 15:48 |
| Zara | I have no idea why my saved command was different, strange. | 15:49 |
| Zara | oh, I know. I was using option 3, not option 4 | 15:50 |
| Zara | from 'installing the webclient' here: http://docs.openstack.org/infra/storyboard/install/development.html | 15:50 |
| Zara | probably didn't understand it at the time of reading, ended up with it saved and worked around it... whereas now I do understand it, so it's just funny. | 15:52 |
| * Zara leaves a not on the old story and marks it merged | 15:54 | |
| Zara | *note | 15:54 |
| Zara | I'm now wondering if that means this story also applies to an old version, since links seem to behave as expected these days: https://storyboard.openstack.org/#!/story/2000061 | 16:02 |
| Zara | the only buttons I can find that don't seem to are 'created', 'updated' and their ilk | 16:03 |
| Zara | ah, no, there's the odd other button, so I think it's still an issue | 16:05 |
| Zara | (eg: adding tags or removing tasks) | 16:05 |
| Zara | currently wondering how many things marked 'invalid' are actually invalid | 16:11 |
| Zara | be helpful if they had been edited to explain before being marked invalid... | 16:11 |
| Zara | how have I spent all today gardening old stories, hooooow | 16:21 |
| Zara | okay, review time. | 16:22 |
| * Zara ended up reviewing something from baserock, had forgotten how much nicer the gerrit interface was around those parts | 16:33 | |
| Zara | there's even an 'up to change' button | 16:34 |
| Zara | oh actualy there's one on the openstack gerrit, it's just away from all the other buttons | 16:34 |
| Zara | TIL! | 16:35 |
| Zara | and you can hilight text for a comment, oh the memories | 16:39 |
| *** mrmartin has joined #storyboard | 16:49 | |
| pedroalvarez | toogle preview button works nicely:) | 16:54 |
| Zara | yeah, it's a majestic patch! | 16:56 |
| Zara | it's a little odd that it's only interactive when something is typed in the box | 16:56 |
| Zara | but I only just noticed that now | 16:56 |
| Zara | if it confuses people I guess we'll see a story and we'll know to patch it. otherwise I won't worry about it | 16:57 |
| *** mrmartin has quit IRC | 16:59 | |
| Zara | hm, for some reason I thought there was also a patch to redirect new users to the about page (as well as the button replace patch) but I think I just imagined it | 17:10 |
| * Zara adjusts story accordingly https://storyboard.openstack.org/#!/story/2000399 | 17:13 | |
| * Zara shakes fist at jenkins https://review.openstack.org/#/c/212105/ | 17:16 | |
| *** mrmartin has joined #storyboard | 17:19 | |
| Zara | I'm not even sure if you're able to recheck someone else's patch | 17:20 |
| Zara | this is the patch to hide all the 'not updated's, since having no text at all conveys the same info, and is prettier + makes other things easier to read: https://review.openstack.org/#/c/243705/ | 17:27 |
| Zara | linking here because I already tested and reviewed that one, so can immediately +1 workflow it once it gets more review | 17:28 |
| *** mrmartin has quit IRC | 17:48 | |
| Zara | 'night, storyboard! | 17:58 |
| *** mrmartin has joined #storyboard | 18:10 | |
| *** mrmartin has quit IRC | 18:37 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Show stories created by the current user on the dashboard https://review.openstack.org/212105 | 19:16 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!