| *** cody-somerville has joined #storyboard | 01:17 | |
| *** cody-somerville has quit IRC | 02:09 | |
| openstackgerrit | Merged openstack-infra/storyboard: Set correct default credentials in the test_backend.sh scripts https://review.openstack.org/213732 | 08:59 |
|---|---|---|
| * SotK apologises for doing to workflow +1 on his own change without thinking :/ | 09:00 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Move project group admin and streamline list page https://review.openstack.org/206108 | 09:04 |
| Zara | at least it had another +1 aside from my +2, but yeah, probably best avoided! | 09:35 |
| Zara | though I'd've workflow +1'd it when I saw it... though I daresay that would've been about an hour later. | 09:35 |
| pedroalvarez | I've been trying to review easy patches | 09:42 |
| pedroalvarez | let me know if there is anything you would like to get reviewed | 09:42 |
| Zara | thanks :) some the worklists and boards things might be a good place to start; they've been waiting around for a while, and going by summit feedback, I don't think we'll get lots of reviews for those from other corners of openstack (people were mostly interested in email notifications and us having a dev branch) | 09:46 |
| Zara | *some of | 09:46 |
| pedroalvarez | yeah, that would be good, but I think those are going to take me a while to review | 09:51 |
| Zara | sure, no problem | 09:52 |
| Zara | I'll see if we have other things hanging around when I'm done splitting up this UI issues story into separate ones :) | 09:53 |
| pedroalvarez | but I guess I can have a look to see if I feel confident reviewing them | 09:53 |
| Zara | there are probably some smaller ones among them. My reviewing style is mainly testing to see if anything breaks, so you might find things in the code that I wouldn't notice. | 09:55 |
| Zara | (I do look at the code! but probably not as thoroughly as some people do) | 09:56 |
| SotK | Zara: yeah, I saw the +1 and was like "MERGE!!!" then realised I'd sent that patch... | 10:09 |
| SotK | pedroalvarez: the reviews are really appreciated, thanks! | 10:09 |
| pedroalvarez | no problem :) | 10:13 |
| Zara | Have tried to split up the UI story here: https://storyboard.openstack.org/#!/project/457 | 10:13 |
| Zara | various familiar things toward the end, plus the odd other thing I noticed as I went along... | 10:13 |
| SotK | the back button thing? | 10:15 |
| SotK | that is not going to be fun I fear | 10:15 |
| Zara | yeah | 10:16 |
| Zara | I just wanted a record of it, really | 10:16 |
| Zara | I'm guessing you'd need an url per page or something? I don't really know. | 10:16 |
| Zara | some way of tracking it, anyway | 10:16 |
| SotK | yeah, you'd need to encode the browse criteria or search string in the url | 10:17 |
| SotK | certainly doable, but the UI implementation of browse/search is still somewhat magical to me | 10:17 |
| Zara | yeah | 10:18 |
| * Zara adds another story | 10:20 | |
| Zara | yay so many | 10:20 |
| Zara | we've got an extra 9 since yesterday :) I'm glad we're getting feedback though. | 10:22 |
| pedroalvarez | there is something really annoying in the storyboard version I'm using, I wonder if that has been fixed | 10:22 |
| Zara | what is it? | 10:22 |
| pedroalvarez | I can't remove someone from a task | 10:22 |
| SotK | pedroalvarez: what is it? | 10:22 |
| SotK | that has indeed been fixed | 10:22 |
| pedroalvarez | good | 10:22 |
| Zara | \o/ | 10:23 |
| pedroalvarez | I need to upgrade :) | 10:23 |
| SotK | you do :) | 10:23 |
| SotK | I think that was a "feature" to encourage people to not drop work without finding someone else to do it | 10:23 |
| Zara | hahaha | 10:24 |
| Zara | sometimes I've been tempted to put in a patch that assigns a bug to the person who files it by default. | 10:24 |
| Zara | but that would be mean :P | 10:25 |
| pedroalvarez | hehe, in my case I don't want pepople believing that I'm doing something that I'm not doing | 10:25 |
| Zara | yeah, it's better to have up to date info really | 10:26 |
| Zara | and up to date storyboards, hint hint | 10:26 |
| Zara | for some reason there was no story up for this https://storyboard.openstack.org/#!/story/2000407 | 10:53 |
| Zara | eep this backlog: https://review.openstack.org/#/q/owner:adam.coldrick%2540codethink.co.uk+status:open,n,z | 11:07 |
| * Zara hides under her desk | 11:07 | |
| Zara | that should work | 11:07 |
| SotK | sounds like the best plan | 11:09 |
| SotK | :D | 11:09 |
| * SotK prepares to add to the backlog | 11:09 | |
| Zara | -_- | 11:10 |
| Zara | so much to update on my vm. that's a good thing, but argh | 11:12 |
| Zara | still getting the odd 500s on my own instance | 11:19 |
| SotK | when editing the description? | 11:19 |
| Zara | yeah, on the oldest stories | 11:20 |
| Zara | the three oldest in the oldest project | 11:20 |
| Zara | idk if any others are affected, but that might be relevant | 11:20 |
| SotK | weird | 11:20 |
| Zara | for now I don't know what's up with it and I haven't seen the behaviour on another instance, so I'm not going to let it hold me up (my branches are up to date with master for the webclient and the api) | 11:21 |
| Zara | but it's odd and I don't like odd things | 11:21 |
| Zara | reviewed. ooi, why *list*Projects but *filter*Stories ? I've assumed it's a legacy thing | 11:38 |
| Zara | (it works so that's the bit I care about :P) | 11:38 |
| SotK | good question | 11:38 |
| Zara | (this was on https://review.openstack.org/#/c/235992/ , for general reference) | 11:39 |
| SotK | aha, I think my logic was that the browse parameters of listProjects aren't configurable, it just gets all the projects in the group, but in filterStories you can change which statuses you search by, thereby "filtering" the list | 11:41 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make project group paging controls work correctly https://review.openstack.org/235992 | 11:42 |
| SotK | \o/ | 11:43 |
| Zara | I see. I'd like it to be consistent; maybe it makes sense for projects to have statuses, idk | 11:44 |
| Zara | atm it hilights that there's a difference, though, so I guess it draws attention to an area for development | 11:45 |
| Zara | maybe it's not an issue; I just think of the listing and filtering as different steps | 11:46 |
| Zara | ahaha, the list project groups changes are showing up | 11:48 |
| Zara | openstack has a lot more projects in the groups | 11:49 |
| Zara | so it looks a bit dramatic | 11:49 |
| Zara | we may want a button to hide projects within a group on that page... | 11:50 |
| Zara | it's also listed in the title as admin, although it isn't actually an admin view | 11:52 |
| Zara | https://storyboard.openstack.org/#!/project_group/list | 11:52 |
| Zara | gah | 11:52 |
| SotK | heh, oops | 11:52 |
| Zara | I like that we can instantly see what projects are in a group, but ack | 11:53 |
| Zara | there's stuff you don't spot until it's scaled up... | 11:53 |
| SotK | yet another reason to set up storyboard-dev.openstack.org I guess | 11:55 |
| Zara | yup | 11:56 |
| * Zara fixes title on her instance | 12:15 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Fix Project Groups title https://review.openstack.org/244068 | 12:21 |
| Zara | should fix the title. no 'hide projects' button as yet, though I'll make a story for it | 12:22 |
| Zara | I really want to get some reviews done today xD | 12:22 |
| Zara | hm, pagination could do with having first/last arrows, too. | 12:28 |
| *** openstackgerrit has quit IRC | 12:31 | |
| Zara | we okay to mark this 'merged'? https://storyboard.openstack.org/#!/story/179 seems the back arrow works for the situation described | 12:32 |
| *** openstackgerrit has joined #storyboard | 12:32 | |
| persia | Looking at https://storyboard.openstack.org/#!/project_group/list, there seems to be a secret project with no name, no link , and no updates. What is this? | 12:33 |
| Zara | I've wondered. | 12:35 |
| Zara | I keep being caught out by the most recent comment not showing up | 12:39 |
| Zara | it makes me think the comment hasn't been left (once there are > 10 comments) | 12:40 |
| * Zara adds a story | 12:41 | |
| Zara | Time to mark this one invalid? https://storyboard.openstack.org/#!/story/151 | 12:47 |
| * Zara is gardening... | 12:47 | |
| * SotK doesn't even know what that story is asking for | 12:48 | |
| Zara | I'm really not sure and wondering if it refers to the way storyboard looked many moons ago | 12:53 |
| Zara | unless 'expanding in the list view' is synonymous with 'going to the detail page' | 12:54 |
| * Zara marks it invalid for now | 12:55 | |
| Zara | since this is in storyboard-webclient, I'm guessing he was thinking of publishing the webclient itself, here: https://storyboard.openstack.org/#!/story/315 | 12:57 |
| SotK | I guess so too | 12:57 |
| Zara | seems everything but the spec was done here; probably time to mark it merged... https://storyboard.openstack.org/#!/story/331 | 13:00 |
| Zara | or to delete the spec from the tasks list | 13:01 |
| Zara | since at this point this story's just getting in the way | 13:01 |
| * SotK is fine with deleting the spec task | 13:01 | |
| Zara | I'm not sure if this has been fixed a bit or not: https://storyboard.openstack.org/#!/story/2000016 | 13:08 |
| Zara | it seems to me like it's okay, but I'm wondering if theyr'e referring to something I haven't noticed. | 13:09 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make timestamps more readable https://review.openstack.org/244099 | 13:23 |
| Zara | oooh | 13:26 |
| Zara | looks good at a glance at the commit message | 13:26 |
| * Zara goes back from gardening stories page to reviewing things | 13:26 | |
| SotK | I think there should be a way to edit comments | 13:28 |
| * SotK wonders what other people think of that | 13:28 | |
| persia | Only if the original remains visible. | 13:29 |
| persia | Conversations get confusing when people can unilaterally retract things to position others arguments as being wildly overreacting, etc. | 13:29 |
| Zara | yeah, some fora have an option where you can edit a comment a certain number of seconds after posting | 13:31 |
| Zara | for if you notice typos etc | 13:31 |
| Zara | might be a lot of effort for not-much-gain here | 13:31 |
| * SotK will settle for a preview button for now | 13:31 | |
| Zara | :) | 13:31 |
| persia | I prefer unlimited time, with a "show original" or "show revisions" button to limited time, because limited time always ends up being frustrating for people on the edge of the window. | 13:32 |
| persia | "preview" is probably enough for a viable product :) | 13:32 |
| SotK | persia: +1 | 13:32 |
| Zara | hm, was going to review 'unlimited' pagination option patch next; seems there's a merge conflict | 13:37 |
| SotK | :( | 13:37 |
| Zara | I can't remember if jenkins says what conflicts | 13:37 |
| * SotK will rebase it once he's sent the thing he's working on | 13:37 | |
| Zara | on gerrit anywhere | 13:37 |
| Zara | ah okay | 13:37 |
| Zara | cool | 13:37 |
| SotK | It became conflicted after we merged the project groups patch I think | 13:38 |
| Zara | probably, I was a bit worried about that :S | 13:38 |
| Zara | it's quite sprawling | 13:38 |
| Zara | better to catch it today, I guess :S | 13:38 |
| * Zara looks at 'replace dashboard button with about button when logged out' instead | 13:39 | |
| Zara | it feels quite nice looking at the code and understanding it way better now than when I started. | 13:40 |
| SotK | :D | 13:42 |
| Zara | hehehe, I like how the 'about' transforms into 'dashboard' when I login | 13:42 |
| * SotK notices that the gate-storyboard-js-integration test is now passing on webclient patches! | 13:45 | |
| SotK | my fix worked! | 13:45 |
| Zara | (I feel like the 'about' page might need to say the user should log in to edit things but 1) that might be overkill and 2) that's for a different patch anyway) | 13:45 |
| Zara | yay! | 13:45 |
| Zara | :D | 13:45 |
| Zara | that was only the second try, too, iirc? | 13:46 |
| SotK | something like that, yeah xD | 13:46 |
| Zara | way better than we dared to hope for | 13:46 |
| SotK | now we just need to figure out how to make it usable for storyboard patches too | 13:47 |
| Zara | hm, it's saying the timestamps-more-readable patch depends on the 'not updated' one | 13:58 |
| SotK | oh, I bet its because I'm just doing `git review` each time I commit to my cleanup branch | 13:58 |
| Zara | that would explain it | 13:58 |
| Zara | I mentioned it because I'm not sure about the 'not updated' patch (left some comments), but I liked the one that 'depended on it'. | 14:01 |
| SotK | I wonder if there is a way to tell Gerrit they are independently submittable without me having to cherry-pick onto master each time I review... | 14:01 |
| Zara | idk :S I've been going back to master and making a new branch based on that every time. :/ | 14:02 |
| persia | I think considered best practice is to have each patch on master. | 14:02 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Replace Dashboard button with About button when logged out https://review.openstack.org/243700 | 14:03 |
| persia | But ask in -infra to confirm :) | 14:03 |
| Zara | oh storyboard meeting in one hour | 14:06 |
| Zara | completely forgot about it | 14:06 |
| SotK | oh yeah, so it is! | 14:07 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix Project Groups title https://review.openstack.org/244068 | 14:11 |
| SotK | we are on fire today! | 14:11 |
| Zara | hehehe | 14:12 |
| Zara | it's the first time I've been reviewing for a while... :S | 14:13 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make timestamps more readable https://review.openstack.org/244099 | 14:19 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Improve comment styling https://review.openstack.org/244125 | 14:20 |
| Zara | argh somebody stop him every time I review something he posts another patch | 14:21 |
| SotK | :D | 14:21 |
| Zara | I think we're encouraging you; this must be stopped | 14:22 |
| SotK | :( , the unlimited option patch seems to be broken | 14:24 |
| Zara | hm, if you update a task in a story, seems the 'updated at' field doesn't get that info | 14:26 |
| Zara | only seems to apply to title and description | 14:26 |
| SotK | yep, because updating the task doesn't update the story's record in the DB | 14:26 |
| Zara | I wonder if anyone finds the current behaviour useful | 14:26 |
| Zara | would email notifications go off the same data? | 14:27 |
| Zara | in their current form, anyway? haven't got round to looking at those yet | 14:28 |
| SotK | nope, they trace down through the contents of things when deciding whether to send emails or not | 14:28 |
| SotK | so when you update a task, it tries to email everyone who is subscribed to the story | 14:28 |
| SotK | and when you update a story, it tries to email everyone who is subscribed to any projects containing the story | 14:28 |
| Zara | ah, I see | 14:28 |
| Zara | maybe 'updated at' needs to work similarly | 14:29 |
| Zara | seems like that'll be great fun to code... | 14:29 |
| * SotK rediscovers the stupid preferences bug | 14:33 | |
| SotK | we can't merge the "Unlimited pagination" patch until after https://review.openstack.org/#/c/235985/ | 14:34 |
| Zara | ahh, well done for tracking the problem down | 14:35 |
| Zara | (just looking at the pretty timestamps one atm; seems fine at a glance and a big improvement) | 14:36 |
| SotK | I must have had a broken copy of the webclient patch locally too, because the version obtained with `git review -d` worked fine when rebased, except for that preferences bug | 14:36 |
| Zara | huh | 14:37 |
| SotK | and that is only noticeable because I accidentally deleted my page_size preference, so it was no longer the first matching result I think | 14:37 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add an "Unlimited" option to the paging controls https://review.openstack.org/235993 | 14:39 |
| Zara | something that's a little odd about the timetamps patch-- when reviewing it in isolation, 'not updated' vanishes for stories but not for projects. suspect it might hint a rebase will be needed, not sure. | 14:39 |
| SotK | hm, where is that? | 14:40 |
| SotK | oh huh, well then | 14:43 |
| * SotK tries to figure out what happened | 14:43 | |
| SotK | oh, its because now it doesn't depend on the patch which removes the "not updated" thing | 14:45 |
| SotK | and there is no "not updated" thing there for stories in master :) | 14:46 |
| Zara | huh | 14:46 |
| Zara | I was missing the last piece of that puzzle. okay, then. | 14:47 |
| SotK | meeting in 13 minutes, anyone got anything to add to the agenda I wonder? | 14:47 |
| SotK | https://wiki.openstack.org/wiki/Meetings/StoryBoard | 14:47 |
| Zara | 'endless catchup' is probably my in progress work atm | 14:49 |
| SotK | :) | 14:49 |
| Zara | that, and 'finding out about specs' | 14:50 |
| Zara | maybe email notifications patches count under urgent items | 14:53 |
| Zara | since afaik, one is -1'd but you've replied and are waiting on a reply to that? | 14:53 |
| SotK | I am indeed | 14:54 |
| * SotK is happy to just talk about them in the in-progress section though | 14:54 | |
| Zara | too late it's in urgent items too hahahahaa | 14:55 |
| SotK | :D | 14:55 |
| * Zara goes for quickest phrasing for all the misc stuff she's doing atm that doesn't fall under 'review' | 14:57 | |
| Zara | 1 minute, eep | 14:59 |
| SotK | -> #openstack-meeting | 15:00 |
| SotK | that was better than my lonely meeting last week :) | 15:27 |
| Zara | hahaha | 15:27 |
| Zara | aw, I should've popped in | 15:28 |
| Zara | though I think I was on a plane... | 15:28 |
| * SotK probably won't be popping in this time next week I'm afraid | 15:28 | |
| Zara | no worries | 15:28 |
| Zara | yeah, I was on a plane and it might have been midnight, though I'm not sure, because I was travelling in the direction of the time difference getting smaller | 15:29 |
| Zara | so maybe by then it was earlier. my head can't make sense of it. | 15:29 |
| *** openstackgerrit has quit IRC | 16:02 | |
| *** openstackgerrit has joined #storyboard | 16:02 | |
| * SotK creates a preview button for comments | 16:05 | |
| Zara | btw re: dev server, there was an old story for it here: https://storyboard.openstack.org/#!/story/2000028 guessing you saw it but jic so we don't have duplicates | 16:08 |
| openstackgerrit | Merged openstack-infra/storyboard: Check that the preference being updated is the right one https://review.openstack.org/235985 | 16:13 |
| *** dabukalam_ has joined #storyboard | 16:15 | |
| SotK | \o/ | 16:15 |
| *** persia_ has quit IRC | 16:17 | |
| *** dabukalam has quit IRC | 16:17 | |
| *** persia_ has joined #storyboard | 16:17 | |
| Zara | oh, hang on, on the email patch he also left a comment about not including [storyboard] in the subject; looks like the patch hasn't been updated there but I don't think you replied about that bit? | 16:25 |
| Zara | sorry if I missed a discussion about it somewhere | 16:26 |
| SotK | You didn't, I had nothing to say about that bit. I was planning to change ot not including [storyboard] when the discussion was concluded | 16:27 |
| SotK | should probably have made that clear... | 16:27 |
| Zara | ahhh, right | 16:27 |
| Zara | cool | 16:27 |
| Zara | I feel like I never give -1s but I think it's more that I give +0s and then chat for ages instead | 16:31 |
| * Zara glances at stackalytics; it doesn't keep track of +0 :( | 16:31 | |
| Zara | maybe openstack is more liberal with -1s than some other places. | 16:32 |
| SotK | seems that way to me | 16:32 |
| Zara | yeah, my page makes me look ridiculously positive, but I'm pretty sure I nitpick a lot. | 16:35 |
| persia | Unless you truly have no opinion, do give a -1 if you want changes. | 16:38 |
| persia | It isn't hard to change a -1 to a +1 if someone provides a convincing argument, but a +0 means nothing. | 16:38 |
| Zara | I read +0 as 'I think this commit is better than no commit, but I'd like some tweaks.' | 16:39 |
| Zara | for me, -1 is a 'this is worse than leaving things as they are' | 16:39 |
| Zara | and a -2 is 'abort abort abort this will break everything abort' | 16:40 |
| Zara | a +0 is just as much a block to something being merged as a -1 afaik, but it shows that you approve that there's progress. | 16:41 |
| persia | Then leave -1 with a positive comment. | 16:45 |
| persia | And, if you might approve anyway, indicate what you seek to approve, and that with a good response you might +1 it (or even +2A it) | 16:45 |
| Zara | I'll switch to that way of doing things when there's a need to be that strict. for now I think it's more forceful than we need to be, and it can just get people down. | 16:51 |
| SotK | hm, openstackgerrit seems to have gone to sleep again | 17:03 |
| Zara | offset error seems to come back with the worklists and boards tables patch | 17:04 |
| Zara | oh, nvm, fine once rebased onto master | 17:07 |
| Zara | "500: PUT /api/v1/stories/1: 'unicode' object has no attribute '_sa_instance_state' " still so mysterious~ | 17:12 |
| Zara | (tried editing my oldest stories again, just on the off-chance :( ) | 17:12 |
| Zara | huh... the preview button wasn't what I was expecting, but I think it's more sensible than what I had pictured | 17:22 |
| SotK | what did you expect? | 17:22 |
| Zara | tbf I hadn't read the commit message, just the title | 17:22 |
| Zara | so I was expecting something like 'click a button after you write the comment and then it renders a preview' | 17:23 |
| Zara | this way is much nicer. | 17:23 |
| Zara | ikiwiki needs it | 17:24 |
| SotK | heh, that's what I had planned at first, then realised the easiest way was just to automatically render it | 17:24 |
| SotK | hahaha, it sure does | 17:24 |
| Zara | the unlimited pagination patch seems to break on the project groups page for me ; | 18:06 |
| Zara | -_ | 18:06 |
| Zara | erm | 18:06 |
| Zara | it seems I'm too tired to type emoticons | 18:06 |
| Zara | that might be a sign... | 18:06 |
| SotK | :( | 18:06 |
| SotK | worked fine on there for me when I tested :/ | 18:07 |
| Zara | I'll look at it again tomorrow in case it's my instance, then | 18:07 |
| Zara | I'm finding it's getting stuck on the 'unlimited' option | 18:07 |
| Zara | and I can't go back from it. | 18:07 |
| Zara | I have >10 project groups, which might be a difference | 18:07 |
| Zara | seems to happen both logged in and logged out | 18:08 |
| Zara | stories and projects are fine | 18:08 |
| SotK | oh, so am I | 18:08 |
| SotK | oops | 18:08 |
| Zara | \o/ | 18:08 |
| Zara | idk if I should be relieved or not | 18:09 |
| Zara | probably should; means this vm is still usable as a test environment | 18:09 |
| SotK | oh, looking in the browser console gives a hint maybe | 18:10 |
| Zara | night, storyboard! | 18:17 |
| Zara | until tomorrow!~ | 18:17 |
| SotK | o/ | 18:17 |
| *** lexholden has joined #storyboard | 19:23 | |
| *** lexholden has quit IRC | 20:19 | |
| * pedroalvarez fails to install storyboard | 22:36 | |
| SotK | :( | 23:26 |
| SotK | what went wrong? | 23:26 |
| pedroalvarez | it's a bit confusing | 23:56 |
| pedroalvarez | I guess I just don't understand how to do it yet | 23:57 |
| pedroalvarez | I can't find docs for production deployments | 23:57 |
| pedroalvarez | and.. I was deploying a version from almost 2 years ago.. | 23:57 |
| pedroalvarez | storyboard-webclient-master != storyboard-webclient-latest here: http://tarballs.openstack.org/storyboard-webclient/?C=M;O=D | 23:58 |
| pedroalvarez | :) | 23:58 |
| pedroalvarez | I'll try to improve docs a bit whenever I manage to do it, I promise | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!