*** openstackgerrit has quit IRC | 00:01 | |
*** openstackgerrit has joined #storyboard | 00:02 | |
lifeless | oh, ok | 00:59 |
---|---|---|
lifeless | persia: ^ | 00:59 |
Zara_ | Just spoke with zaro about the gerrit plugin he wrote for storyboard (it's fallen through the cracks for various reasons , but gerrit upgrade is no longer a blocker.) He thinks it should still work. | 00:59 |
lifeless | so two things. dev.* *must* not be in the same namespace as prod - it permits attacks | 00:59 |
persia | lifeless: Do you remember the rules used for LP? | 00:59 |
lifeless | secondly, as long as the migrations are done with backwards compat, you can run old instance on prod and new on staging | 01:00 |
lifeless | erm | 01:00 |
lifeless | not staging, next. or something | 01:00 |
persia | nomenclature :) | 01:00 |
lifeless | semantics :) | 01:00 |
lifeless | staging in most environments is a separate db | 01:00 |
persia | How do you mean different namespace: as in changes in the dev instance don't affect prod, etc.? But for "next", they do? | 01:00 |
lifeless | LP's staging and db-staging were separate db's | 01:00 |
persia | Or different namespaces in a XSS-way? | 01:01 |
lifeless | dns namespace | 01:01 |
lifeless | yes, xss and cookie pollution concerns are what I was referring to | 01:01 |
persia | Ah, right. Thanks for the clarification. | 01:01 |
Zara_ | So connecting stories with their gerrit statuses might be closer than we think. Needs investigation. | 01:02 |
lifeless | so LP took a db dump every once in a while and restored it to staging | 01:02 |
lifeless | and staging ran master | 01:02 |
lifeless | (There's nuance, but this is a sufficient explanation) | 01:02 |
persia | Thanks. | 01:03 |
persia | SotK: ^^ Is that enough to get you started? | 01:03 |
persia | (when the sun gets to your part of the planet) | 01:04 |
lifeless | personnally, I wouldn't run a next tree, I'd just have staging (separate db, as above) | 01:04 |
Zara_ | Bear in mind that email notifications have *really* been stressed to me, so if both seem similar sized tasks, I think notifications would be the priority . | 01:05 |
Zara_ | The request for a staging branch was framed as a 'nice to have' | 01:05 |
Zara_ | Though I agree that we need it, I've just got the impression it's less important than email notifications. | 01:07 |
Zara_ | Not that it's unimportant. | 01:07 |
persia | I was hoping it was relatively trivial to implement: with a toy DB, it sounds like it might be, but perhaps just a dev environment would be enough for most folk. | 01:08 |
*** davidlenwell has quit IRC | 02:06 | |
*** davidlenwell has joined #storyboard | 02:08 | |
*** mrmartin has joined #storyboard | 06:33 | |
*** persia has quit IRC | 08:24 | |
*** persia has joined #storyboard | 08:27 | |
SotK | persia_, lifeless: that is helpful, thanks | 09:36 |
*** dabukalam has quit IRC | 10:39 | |
*** dabukalam has joined #storyboard | 10:40 | |
* SotK struggles to get notifications working properly | 11:18 | |
*** lifeless has quit IRC | 12:36 | |
*** lifeless has joined #storyboard | 12:37 | |
SotK | I was being dumb... "enable_notifications = False" | 12:39 |
pedroalvarez | :) | 12:40 |
pedroalvarez | time to test it? | 12:40 |
SotK | indeed | 12:43 |
SotK | and it immediately doesn't work | 12:43 |
SotK | \o/ | 12:43 |
* SotK fixes the easy bug and now gets it breaking in interesting ways | 12:52 | |
*** mrmartin has quit IRC | 12:52 | |
SotK | the "recent events" thing on the dashboard isn't working either, though it seems to be for a different reason | 12:58 |
SotK | for some reason things aren't making it into the database after being created | 13:00 |
* SotK recieves mail from storyboard | 13:28 | |
SotK | so does Zara_ I expect | 13:29 |
* SotK still hasn't managed to figure out why recent events aren't working on his test instance though | 14:56 | |
SotK | I managed to fix that, I don't know why it seems to be working on storyboard.openstack.org but not on my test instance though | 15:53 |
*** mrmartin has joined #storyboard | 15:56 | |
* SotK fixes how the email patch looks for preferences | 16:03 | |
Zara_ | \o/ \o/ \o/ | 16:10 |
Zara_ | Can confirm I got that email | 16:13 |
SotK | \o/ | 16:13 |
Zara_ | Brilliant and thank you! I'll let people know since it's affecting them right now... | 16:13 |
SotK | no problem, if I'd known the old abandoned patch was so close to being fully functional I'd have done this a while ago :) | 16:15 |
* pedroalvarez wonders if these emails are going to be as useful as gerrit emails | 16:16 | |
Zara_ | We have more power to configure the settings, I guess | 16:16 |
SotK | the current situation is "any time something changes in a story you are subscribed to, you recieve an email" | 16:17 |
SotK | there seems to be a plan for "recieve a daily digest email of all changes on things you are subscribed to in that day" | 16:18 |
SotK | making it send emails for projects, project_groups, and tasks should be a simple case of adding email templates for those things | 16:19 |
Zara_ | :) | 16:26 |
Zara_ | I'm so happy; I thought this would be so much more time-consuming and prickly. | 16:29 |
SotK | me too | 16:29 |
* SotK tries sending more email | 16:30 | |
SotK | so it appears that the default preference stuff isn't working at all | 17:06 |
* SotK makes it just ignore defaults for now | 17:09 | |
*** mrmartin has quit IRC | 17:19 | |
SotK | everything seems to be in order | 17:24 |
SotK | \o/ | 17:24 |
SotK | I'll update the API patches to make them pass tests and actually work momentarily | 17:25 |
*** zara__ has joined #storyboard | 17:28 | |
*** zara__ has quit IRC | 17:28 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Single event email worker. https://review.openstack.org/179542 | 17:54 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Factory subject is now a template file. https://review.openstack.org/181763 | 17:54 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Revert "Email Outbox" https://review.openstack.org/182043 | 17:54 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix SubscriptionEvents not making it into the database https://review.openstack.org/240301 | 17:54 |
Zara_ | :0 | 17:55 |
SotK | the first three are the ones required for emails, the last one is a weird bug I found that I thought I'd better send a fix for even though it doesn't seem to happen in storyboard.openstack.org | 17:57 |
* SotK might take a look at the plugin documentation tomorrow now that he understands the beautiful magic | 17:59 | |
Zara_ | Sorry, the gerrit plugin? | 18:00 |
SotK | nope, storyboard plugins | 18:00 |
SotK | the bit of the documentation that currently says "To learn how to write a user preference plugin, please contribute to this documentation." | 18:00 |
Zara_ | Ahahahahahaha | 18:00 |
SotK | since I spent most of today trying to figure out how to do that, I figure I should make it easier for the next poor soul who would otherwise have to see that stupid line | 18:01 |
Zara_ | \o/ | 18:02 |
Zara_ | +10000 | 18:02 |
*** jtomasek has quit IRC | 18:36 | |
*** jtomasek has joined #storyboard | 19:09 | |
*** jtomasek has quit IRC | 21:33 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix SubscriptionEvents not making it into the database https://review.openstack.org/240301 | 22:37 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Revert "Email Outbox" https://review.openstack.org/240344 | 22:37 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Factory subject is now a template file. https://review.openstack.org/240345 | 22:37 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Single event email worker. https://review.openstack.org/240346 | 22:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!