| *** coolsvap has joined #storyboard | 00:05 | |
| *** gothicmindfood has joined #storyboard | 00:07 | |
| *** pedroalvarez has joined #storyboard | 00:07 | |
| *** jasondotstar has joined #storyboard | 00:07 | |
| *** ttx has joined #storyboard | 00:07 | |
| *** pleia2 has joined #storyboard | 00:07 | |
| *** persia has joined #storyboard | 00:08 | |
| *** jjardon has joined #storyboard | 00:08 | |
| *** SotK has joined #storyboard | 00:11 | |
| *** openstackgerrit has joined #storyboard | 00:12 | |
| *** cody-somerville- has joined #storyboard | 00:12 | |
| *** dabukalam has joined #storyboard | 00:12 | |
| *** cody-somerville has joined #storyboard | 00:12 | |
| *** Zara has joined #storyboard | 00:12 | |
| *** wendar_ has joined #storyboard | 00:17 | |
| *** jtomasek has joined #storyboard | 00:17 | |
| *** davidlenwell has joined #storyboard | 00:17 | |
| *** NikitaKonovalov has joined #storyboard | 00:17 | |
| *** rainya has joined #storyboard | 00:17 | |
| *** ChanServ has joined #storyboard | 00:30 | |
| *** cameron.freenode.net sets mode: +o ChanServ | 00:30 | |
| *** lifeless has joined #storyboard | 02:51 | |
| *** mrmartin has joined #storyboard | 05:14 | |
| SotK | eek, rogue print statement snuck into my patch | 08:21 |
|---|---|---|
| *** jcoufal has joined #storyboard | 08:26 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Implement complex permissions for worklists and boards https://review.openstack.org/235472 | 08:27 |
| SotK | hmm, the story I saw that weird bug on works fine now | 08:46 |
| Zara | o.O | 09:11 |
| SotK | well, its no wonder the paging on project group projects doesn't work | 09:14 |
| SotK | it refreshes the list of stories instead of projects | 09:14 |
| Zara | argh | 09:14 |
| * Zara hopes it wasn't something she did. | 09:14 | |
| SotK | it was me :) | 09:15 |
| Zara | ahhh, phew | 09:15 |
| * SotK wonders what people would think of the default pagination limit being "unlimited" rather than 10 | 11:31 | |
| * SotK decides it would not be good | 13:19 | |
| Zara | sorry, went off for lunch pretty much the moment you asked that! | 13:20 |
| Zara | is this the default for everything? or for stories in projects? | 13:20 |
| Zara | I'd vaguely prefer the default to be higher than 10, but it's just a prefrence and not a strong one. | 13:21 |
| SotK | everything | 13:21 |
| Zara | ah, cool. now that subscriptions don't do 1 GET per displayed resource, I can't see an issue with having more things on the page | 13:22 |
| Zara | so can't see any big problems and I think it'd be a little improvement. | 13:22 |
| Zara | that is my considered opinion on this. :P | 13:22 |
| SotK | I think its a bad plan for the project_group stuff at least, since that will then be just as bad to read as it was before paging was added | 13:23 |
| SotK | on https://storyboard.openstack.org/#!/project_group/55 for example | 13:23 |
| * Zara gets 401 and weeps | 13:25 | |
| Zara | ahh, good point | 13:25 |
| SotK | we can have different defaults for that though | 13:26 |
| SotK | it mostly comes down to personal preference I feel | 13:26 |
| Zara | maybe the project groups page (and possibly the dashboard) is the outlier | 13:27 |
| Zara | yeah | 13:27 |
| Zara | I'm pretty neutral on it. | 13:27 |
| Zara | (I'm going to test the streamline project groups patch manually now; I think the only difference *should* be the rebase but I want to check I didn't mess anything up in the rebase) | 13:28 |
| Zara | I did a cursory check at the time | 13:28 |
| *** mrmartin has quit IRC | 13:36 | |
| Zara | seems to be fine. | 13:43 |
| SotK | \o/ | 13:43 |
| Zara | I still dread to look at the actual code because I did this before I knew angular anywhere near as well as I know it now. but it looks and behaves as expected for people who are logged in or out. | 13:44 |
| Zara | the same stories are still doing the odd 500 thing | 13:45 |
| * Zara wonders how tricky would it be to hide the dashboard icon for non logged-in users | 14:08 | |
| SotK | probably not very tricky | 14:08 |
| Zara | I think we should do it, then. :) since currently it takes a user to a more useful page (thanks), but I'm concerned that they'd be like 'but I clicked on the dashboard!' | 14:09 |
| SotK | that makes sense | 14:09 |
| Zara | unless boards and worklists will be visible to non-logged in users from there, and we'll change the redirect accordingly? | 14:10 |
| Zara | just occurred to me that that might complicate it | 14:10 |
| SotK | they aren't at the moment, we can always undo the change if that happens though | 14:11 |
| Zara | okay, thinking about it, are they currently accessible for non-logged in users to view at all or does the user have to type in the url? I've started looking at the patches but there are many and my instance is misbehaving anyway. | 14:12 |
| SotK | you need the url if you aren't logged in | 14:12 |
| Zara | ah, I think we should change that, but maybe no rush... | 14:13 |
| SotK | yeah, I'd like to be able to search for them eventually I think | 14:13 |
| *** MarkAtwood has joined #storyboard | 14:37 | |
| *** racle_ has joined #storyboard | 15:05 | |
| *** racle_ has left #storyboard | 15:10 | |
| *** MarkAtwood has quit IRC | 15:15 | |
| *** MarkAtwood has joined #storyboard | 15:16 | |
| Zara | hm, seems the project groups view does a GET for each project group (maybe just the admin view? just noticed it, anyway). might not be too bad if there aren't likely to be many project groups. | 15:19 |
| * SotK checks the admin view | 15:20 | |
| SotK | aha, it does it to get the project titles | 15:21 |
| SotK | we could probably optimise that if we have to | 15:21 |
| Zara | yeah, I'm not sure there's a need right now, or maybe ever... | 15:22 |
| Zara | I'll note it but really not a priority | 15:22 |
| Zara | if something the size of openstack has only 4 project groups. though I suppose storyboard wasn't rolled out to everyone | 15:23 |
| Zara | so that might not be a fair way of putting it. | 15:23 |
| * SotK grumbles about preferences | 15:24 | |
| SotK | they have a "key", which obviously needs to be unique | 15:25 |
| SotK | however, because of the way a query is constructed, it also can't be a substring of any other key | 15:25 |
| Zara | does it ensure they're all the same length? (sorry if I've misunderstood, afaict it can't be a substring if it's the same length and differs by a character?) | 15:28 |
| SotK | nope, they can be anything up to a certain length | 15:28 |
| Zara | argh | 15:28 |
| SotK | so for example, "story_detail_page_size" and "page_size" conflict confusingly | 15:28 |
| Zara | well I guess I'd start by forcing them to be the same length, since it sounds like a timebomb. | 15:29 |
| SotK | because when you try to set "page_size", "story_detail_page_size" gets set instead | 15:29 |
| * SotK is making it so that it checks its actually using the right preference | 15:29 | |
| Zara | (the other option would be to change the way the query is constructed, I guess? sounds more complicated but I don't know for sure.) | 15:30 |
| Zara | hehe | 15:30 |
| * Zara wonders about the origin of the 'setting a property that has only a getter' issue | 15:34 | |
| Zara | the error comes up a lot in the console, though it doesn't seem to cause any visible trouble | 15:35 |
| * SotK doesn't think he's ever noticed that | 15:35 | |
| Zara | I worried that it was my patch at first, but checked it against master (before that was merged) and it was still there | 15:36 |
| *** wendar_ is now known as wendar | 15:37 | |
| Zara | perhaps another one to go on a backburner; if it's tough to get to the bottom of, I could spend some time at some point checking against old webclient versions until I find the culprit. | 15:37 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Check that the preference being updated is the right one https://review.openstack.org/235985 | 15:43 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make project group paging controls work correctly https://review.openstack.org/235992 | 15:59 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add an "Unlimited" option to the paging controls https://review.openstack.org/235993 | 15:59 |
| *** MarkAtwood has quit IRC | 16:50 | |
| *** MarkAtwood has joined #storyboard | 16:56 | |
| *** jcoufal has quit IRC | 17:06 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!